[jira] [Created] (EXTCDI-309) look for phase listeners in parent classloader too

2013-05-23 Thread Romain Manni-Bucau (JIRA)
Romain Manni-Bucau created EXTCDI-309:
-

 Summary: look for phase listeners in parent classloader too
 Key: EXTCDI-309
 URL: https://issues.apache.org/jira/browse/EXTCDI-309
 Project: MyFaces CODI
  Issue Type: Improvement
Reporter: Romain Manni-Bucau


In ear phaselisteners can be in lib part of the ear too so in 
org.apache.myfaces.extensions.cdi.jsf.impl.listener.phase.PhaseListenerExtension#consumePhaseListeners
 the phaselisteners should be looked up from parent loader too (if (classloader 
!= systemLoader) ...)

It is underspecified but it doesn't work in tomee for instance


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (EXTCDI-309) look for phase listeners in parent classloader too

2013-05-23 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/EXTCDI-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664959#comment-13664959
 ] 

Gerhard Petracek commented on EXTCDI-309:
-

imo the only change we should do (since there is no official ear support) is a 
backport of the new approach we use in deltaspike.

 look for phase listeners in parent classloader too
 --

 Key: EXTCDI-309
 URL: https://issues.apache.org/jira/browse/EXTCDI-309
 Project: MyFaces CODI
  Issue Type: Improvement
Reporter: Romain Manni-Bucau

 In ear phaselisteners can be in lib part of the ear too so in 
 org.apache.myfaces.extensions.cdi.jsf.impl.listener.phase.PhaseListenerExtension#consumePhaseListeners
  the phaselisteners should be looked up from parent loader too (if 
 (classloader != systemLoader) ...)
 It is underspecified but it doesn't work in tomee for instance

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (EXTCDI-309) look for phase listeners in parent classloader too

2013-05-23 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/EXTCDI-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665070#comment-13665070
 ] 

Romain Manni-Bucau commented on EXTCDI-309:
---

Well, the issue was mainly to track it down.

Side note: DS should work on ears (even if CDI is not that clear) otherwise it 
is quite limitating IMO.

 look for phase listeners in parent classloader too
 --

 Key: EXTCDI-309
 URL: https://issues.apache.org/jira/browse/EXTCDI-309
 Project: MyFaces CODI
  Issue Type: Improvement
Reporter: Romain Manni-Bucau

 In ear phaselisteners can be in lib part of the ear too so in 
 org.apache.myfaces.extensions.cdi.jsf.impl.listener.phase.PhaseListenerExtension#consumePhaseListeners
  the phaselisteners should be looked up from parent loader too (if 
 (classloader != systemLoader) ...)
 It is underspecified but it doesn't work in tomee for instance

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (EXTCDI-309) look for phase listeners in parent classloader too

2013-05-23 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/EXTCDI-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665072#comment-13665072
 ] 

Gerhard Petracek commented on EXTCDI-309:
-

as you might know there is https://issues.apache.org/jira/browse/DELTASPIKE-335 
for it

 look for phase listeners in parent classloader too
 --

 Key: EXTCDI-309
 URL: https://issues.apache.org/jira/browse/EXTCDI-309
 Project: MyFaces CODI
  Issue Type: Improvement
Reporter: Romain Manni-Bucau

 In ear phaselisteners can be in lib part of the ear too so in 
 org.apache.myfaces.extensions.cdi.jsf.impl.listener.phase.PhaseListenerExtension#consumePhaseListeners
  the phaselisteners should be looked up from parent loader too (if 
 (classloader != systemLoader) ...)
 It is underspecified but it doesn't work in tomee for instance

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (EXTCDI-309) look for phase listeners in parent classloader too

2013-05-23 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/EXTCDI-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665094#comment-13665094
 ] 

Romain Manni-Bucau commented on EXTCDI-309:
---

right,

i thought the hack getParent() was not that bad to be integrable (at least 
through config) but i understand if you prefer to wait for DS (since providing 
it in the webapp make it green)

 look for phase listeners in parent classloader too
 --

 Key: EXTCDI-309
 URL: https://issues.apache.org/jira/browse/EXTCDI-309
 Project: MyFaces CODI
  Issue Type: Improvement
Reporter: Romain Manni-Bucau

 In ear phaselisteners can be in lib part of the ear too so in 
 org.apache.myfaces.extensions.cdi.jsf.impl.listener.phase.PhaseListenerExtension#consumePhaseListeners
  the phaselisteners should be looked up from parent loader too (if 
 (classloader != systemLoader) ...)
 It is underspecified but it doesn't work in tomee for instance

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (MYFACES-3728) javax.faces.partial.execute=@none still process

2013-05-23 Thread Thomas Andraschko (JIRA)
Thomas Andraschko created MYFACES-3728:
--

 Summary: javax.faces.partial.execute=@none still process
 Key: MYFACES-3728
 URL: https://issues.apache.org/jira/browse/MYFACES-3728
 Project: MyFaces Core
  Issue Type: Bug
Reporter: Thomas Andraschko




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (TOBAGO-1270) The textAlign attribute of tc:flowLayout on JSP doesn't work on Tomcat, when using a string literal

2013-05-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/TOBAGO-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665117#comment-13665117
 ] 

Hudson commented on TOBAGO-1270:


Integrated in tobago-1.5.x #160 (See 
[https://builds.apache.org/job/tobago-1.5.x/160/])
TOBAGO-1270: The textAlign attribute of tc:flowLayout on JSP doesn't work 
on Tomcat, when using a string literal
 - test page (Revision 1485610)

 Result = FAILURE
lofwyr : http://svn.apache.org/viewvc/?view=revrev=1485610
Files : 
* 
/myfaces/tobago/branches/tobago-1.5.x/tobago-example/tobago-example-test/src/main/webapp/test/flowLayout
* 
/myfaces/tobago/branches/tobago-1.5.x/tobago-example/tobago-example-test/src/main/webapp/test/flowLayout/flowLayout-textAlign.xhtml


 The textAlign attribute of tc:flowLayout on JSP doesn't work on Tomcat, when 
 using a string literal
 ---

 Key: TOBAGO-1270
 URL: https://issues.apache.org/jira/browse/TOBAGO-1270
 Project: MyFaces Tobago
  Issue Type: Bug
  Components: Core
Affects Versions: 1.6.0-beta-2, 1.5.9
 Environment: Tested with Tomcat 6.0.20 and 6.0.37 (Tobago 1.5.9) and 
 tested with Tomcat 7.0.40 (Tobago 2.0.0-alpha-SNAPSHOT)
 Jetty (from the maven-jetty-plugin) works
Reporter: Udo Schnurpfeil
Assignee: Udo Schnurpfeil
Priority: Minor
 Fix For: 1.5.10, 2.0.0-alpha-1, 2.0.0


 Type problems with strings like center:
 Tomcat: Cannot coerce value (center) to type 
 (org.apache.myfaces.tobago.layout.TextAlign) for attribute textAlign.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (TOBAGO-1251) tc:link is calculated to narrow when using auto, especially when images are used

2013-05-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/TOBAGO-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665118#comment-13665118
 ] 

Hudson commented on TOBAGO-1251:


Integrated in tobago-1.5.x #160 (See 
[https://builds.apache.org/job/tobago-1.5.x/160/])
TOBAGO-1251: tc:link is calculated to narrow when using auto, especially 
when images are used 
 - adding 1 pixel per character (Revision 1485608)

 Result = FAILURE
lofwyr : http://svn.apache.org/viewvc/?view=revrev=1485608
Files : 
* 
/myfaces/tobago/branches/tobago-1.5.x/tobago-theme/tobago-theme-standard/src/main/java/org/apache/myfaces/tobago/renderkit/util/RenderUtils.java


 tc:link is calculated to narrow when using auto, especially when images are 
 used
 --

 Key: TOBAGO-1251
 URL: https://issues.apache.org/jira/browse/TOBAGO-1251
 Project: MyFaces Tobago
  Issue Type: Bug
Affects Versions: 1.6.0-beta-2, 1.5.9
Reporter: Matthias Wronka
Assignee: Udo Schnurpfeil
Priority: Minor
 Fix For: 1.5.10, 2.0.0-alpha-1, 2.0.0


 The width-calculation of links doesn´t work correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (MYFACES-3716) Implement h:inputFile

2013-05-23 Thread Dora Rajappan (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665146#comment-13665146
 ] 

Dora Rajappan commented on MYFACES-3716:


Context ... allowCasualMultipartParsing=true tomcat7 users need to set this 
for file upload.
Chrome is submitting file.

According to spec decode behaviour is

Call getParts() on the httpServletRequest. Iterate over the parts. If the 
name property of the current part is equal to the clientId, pass the 
current part to the setSubmittedValue() method of the component. If an 
exception is thrown during the iteration, log the exception and continue.

So the bean should have a type ApplicationPart and not File type for the 
property.

Encode behaviour is pending.

If ProjectStage is not ProjectStage.Production, verify that the enclosing form 
has an enctype attribute whose value is multipart/form-data. If not, add a 
FacesMessage for this component's clientId to the FacesContext stating that 
file upload requires a form with enctype equal to multipart/form-data. If 
ProjectStage is ProjectStage.Production, do not do this verification.

In order not to break the spec

standard-faces-config add renderer entry  for javax.faces.File 
renderer 
component-familyjavax.faces.Input/component-family 
renderer-typejavax.faces.File/renderer-type 

renderer-classorg.apache.myfaces.renderkit.html.HtmlInputFileRenderer/renderer-class
 
  /renderer 
   




 Implement h:inputFile
 -

 Key: MYFACES-3716
 URL: https://issues.apache.org/jira/browse/MYFACES-3716
 Project: MyFaces Core
  Issue Type: Task
  Components: JSR-344
Reporter: Leonardo Uribe

 Implement h:inputFile as described in the spec

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (TRINIDAD-2389) review and fix values for @platform in skinning documentation

2013-05-23 Thread Jeanne Waldman (JIRA)

[ 
https://issues.apache.org/jira/browse/TRINIDAD-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665434#comment-13665434
 ] 

Jeanne Waldman commented on TRINIDAD-2389:
--

SVN revision 1485788  


 review and fix values for @platform in skinning documentation
 -

 Key: TRINIDAD-2389
 URL: https://issues.apache.org/jira/browse/TRINIDAD-2389
 Project: MyFaces Trinidad
  Issue Type: Bug
  Components: Skinning
Affects Versions: 2.1.0-core
Reporter: Anand V Nath
Priority: Minor
 Fix For: 2.1.0-core

 Attachments: jira-2389.patch


 This bug is for reviewing and fixing the valid values for @platform mentioned 
 in the skinning documentation: 
 http://myfaces.apache.org/trinidad/devguide/skinning.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (MYFACES-3729) Implement resource library contracts specification

2013-05-23 Thread Leonardo Uribe (JIRA)
Leonardo Uribe created MYFACES-3729:
---

 Summary: Implement resource library contracts specification
 Key: MYFACES-3729
 URL: https://issues.apache.org/jira/browse/MYFACES-3729
 Project: MyFaces Core
  Issue Type: Task
  Components: JSR-344
Reporter: Leonardo Uribe
Assignee: Leonardo Uribe


Implement resource library contracts specification is one of the main topics 
part of JSF 2.2

It is necessary to change all ResourceHandler default implementation to 
introduce the contracts on top or everything. Additionally, facelets algorithm 
must be updated to use createViewResource(...), but it is good to remember that 
it is resposibility of the vdl to decide if it uses it or not.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (MYFACES-3729) Implement resource library contracts specification

2013-05-23 Thread Leonardo Uribe (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13665928#comment-13665928
 ] 

Leonardo Uribe commented on MYFACES-3729:
-

Prototype committed. Simple tests done. Pending full test.

 Implement resource library contracts specification
 --

 Key: MYFACES-3729
 URL: https://issues.apache.org/jira/browse/MYFACES-3729
 Project: MyFaces Core
  Issue Type: Task
  Components: JSR-344
Reporter: Leonardo Uribe
Assignee: Leonardo Uribe

 Implement resource library contracts specification is one of the main topics 
 part of JSF 2.2
 It is necessary to change all ResourceHandler default implementation to 
 introduce the contracts on top or everything. Additionally, facelets 
 algorithm must be updated to use createViewResource(...), but it is good to 
 remember that it is resposibility of the vdl to decide if it uses it or not.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (MYFACES-3730) Implement ViewDeclarationLanguageWrapper

2013-05-23 Thread Leonardo Uribe (JIRA)
Leonardo Uribe created MYFACES-3730:
---

 Summary: Implement ViewDeclarationLanguageWrapper
 Key: MYFACES-3730
 URL: https://issues.apache.org/jira/browse/MYFACES-3730
 Project: MyFaces Core
  Issue Type: Task
Reporter: Leonardo Uribe


Implement ViewDeclarationLanguageWrapper

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (MYFACES-3730) Implement ViewDeclarationLanguageWrapper

2013-05-23 Thread Leonardo Uribe (JIRA)

 [ 
https://issues.apache.org/jira/browse/MYFACES-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonardo Uribe resolved MYFACES-3730.
-

   Resolution: Fixed
Fix Version/s: 2.2.0
 Assignee: Leonardo Uribe

 Implement ViewDeclarationLanguageWrapper
 

 Key: MYFACES-3730
 URL: https://issues.apache.org/jira/browse/MYFACES-3730
 Project: MyFaces Core
  Issue Type: Task
Reporter: Leonardo Uribe
Assignee: Leonardo Uribe
 Fix For: 2.2.0


 Implement ViewDeclarationLanguageWrapper

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira