[jira] [Commented] (MYFACES-3728) javax.faces.partial.execute=@none still process javax.faces.source component
[ https://issues.apache.org/jira/browse/MYFACES-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703058#comment-13703058 ] Thomas Andraschko commented on MYFACES-3728: Any plans to fix this? Otherwise i must temporally do a workaround in PrimeFaces. AFAICS the @none handling was removed in PartialViewContext + Impl. javax.faces.partial.execute=@none still process javax.faces.source component Key: MYFACES-3728 URL: https://issues.apache.org/jira/browse/MYFACES-3728 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.1.10 Reporter: Thomas Andraschko i found a weird issue that if i use p:ajax on inputText with process=@none, the InputTextRenderer#decode method will be still invoked. This works fine with f:ajax in myfaces and mojarra. p:ajax only works expected on mojarra. The only difference i found is, that p:ajax sends the javax.faces.partial.execute param and f:ajax not. Here is a list with the post params (without my inputs): PrimeFaces: javax.faces.ViewState=N%2F6uUZMB9%2BPXSBTJVus5p6rncWDWwUAgQ9UIOweKuerVM0Z7 javax.faces.partial.ajax=true javax.faces.source=xxx javax.faces.partial.execute=%40none javax.faces.partial.render=%40none javax.faces.behavior.event=change javax.faces.partial.event=change form_SUBMIT=1 MyFaces: javax.faces.ViewState=EHCQlskNw%2BLXSBTJVus5pyzjdxWpT%2B72t7rvnK11Nffi10%2Bl javax.faces.partial.ajax=true javax.faces.source=xxx javax.faces.behavior.event=change javax.faces.partial.event=change javax.faces.windowId=2cc form_SUBMIT=1 form=form -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3728) javax.faces.partial.execute=@none still process javax.faces.source component
[ https://issues.apache.org/jira/browse/MYFACES-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703380#comment-13703380 ] Leonardo Uribe commented on MYFACES-3728: - Checking the jsdoc spec of jsf.ajax.request it says: ... If the keyword @none is present, do not create and send the post data argument javax.faces.partial.execute. ... later on: ... If the keyword @none is present, do not create and send the post data argument javax.faces.partial.render. ... MyFaces is doing it right. But it also says this: ... If the keyword @all is present, create the post data argument with the name javax.faces.partial.execute and the value @all ... So in theory it is valid to pass the keyword inside javax.faces.partial.execute and javax.faces.partial.render fields. I think it is a topic more related to interpretation. The spec is clear saying that is @none keyword is used, it is responsibility of the client behavior renderer to omit the request parameters. In this case and being strict with the spec, I think the fix should be done at primefaces, but I don't see any reason why don't allow the case in MyFaces. Probably it is a good idea, because in theory developers should be able to invent new keywords, and overriding PartialViewContext make things work. In my opinion, it is not a bug, but it looks more like a clarification over the possible allowed values for these two request parameters. I think we can fix it on the next version. javax.faces.partial.execute=@none still process javax.faces.source component Key: MYFACES-3728 URL: https://issues.apache.org/jira/browse/MYFACES-3728 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.1.10 Reporter: Thomas Andraschko i found a weird issue that if i use p:ajax on inputText with process=@none, the InputTextRenderer#decode method will be still invoked. This works fine with f:ajax in myfaces and mojarra. p:ajax only works expected on mojarra. The only difference i found is, that p:ajax sends the javax.faces.partial.execute param and f:ajax not. Here is a list with the post params (without my inputs): PrimeFaces: javax.faces.ViewState=N%2F6uUZMB9%2BPXSBTJVus5p6rncWDWwUAgQ9UIOweKuerVM0Z7 javax.faces.partial.ajax=true javax.faces.source=xxx javax.faces.partial.execute=%40none javax.faces.partial.render=%40none javax.faces.behavior.event=change javax.faces.partial.event=change form_SUBMIT=1 MyFaces: javax.faces.ViewState=EHCQlskNw%2BLXSBTJVus5pyzjdxWpT%2B72t7rvnK11Nffi10%2Bl javax.faces.partial.ajax=true javax.faces.source=xxx javax.faces.behavior.event=change javax.faces.partial.event=change javax.faces.windowId=2cc form_SUBMIT=1 form=form -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3716) Implement h:inputFile
[ https://issues.apache.org/jira/browse/MYFACES-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703388#comment-13703388 ] Leonardo Uribe commented on MYFACES-3716: - We can't introduce a new public class (javax.faces.component.HttpPartWrapper), otherwise we will break binary compatibility. I prefer rewrite the code in _HtmlInputFile to do not depend on additional imports. It will be longer but it will not require a change over the base template that will be replicated across all classes. I think the content is ok, just we need to work out on the shape. I still think the wrapper can be moved to the decode() method of the renderer. Implement h:inputFile - Key: MYFACES-3716 URL: https://issues.apache.org/jira/browse/MYFACES-3716 Project: MyFaces Core Issue Type: Task Components: JSR-344 Reporter: Leonardo Uribe Attachments: inputFile4Jul.patch Implement h:inputFile as described in the spec -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3728) javax.faces.partial.execute=@none still process javax.faces.source component
[ https://issues.apache.org/jira/browse/MYFACES-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703448#comment-13703448 ] Thomas Andraschko commented on MYFACES-3728: Thanks Leo for checking the specs! I will change the primefaces impl to be compatible with the specs but allow @none in myfaces would be a good enhancement too. javax.faces.partial.execute=@none still process javax.faces.source component Key: MYFACES-3728 URL: https://issues.apache.org/jira/browse/MYFACES-3728 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.1.10 Reporter: Thomas Andraschko i found a weird issue that if i use p:ajax on inputText with process=@none, the InputTextRenderer#decode method will be still invoked. This works fine with f:ajax in myfaces and mojarra. p:ajax only works expected on mojarra. The only difference i found is, that p:ajax sends the javax.faces.partial.execute param and f:ajax not. Here is a list with the post params (without my inputs): PrimeFaces: javax.faces.ViewState=N%2F6uUZMB9%2BPXSBTJVus5p6rncWDWwUAgQ9UIOweKuerVM0Z7 javax.faces.partial.ajax=true javax.faces.source=xxx javax.faces.partial.execute=%40none javax.faces.partial.render=%40none javax.faces.behavior.event=change javax.faces.partial.event=change form_SUBMIT=1 MyFaces: javax.faces.ViewState=EHCQlskNw%2BLXSBTJVus5pyzjdxWpT%2B72t7rvnK11Nffi10%2Bl javax.faces.partial.ajax=true javax.faces.source=xxx javax.faces.behavior.event=change javax.faces.partial.event=change javax.faces.windowId=2cc form_SUBMIT=1 form=form -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira