[jira] [Updated] (TRINIDAD-2428) rtl styles are getting overriden by non rtl styles
[
https://issues.apache.org/jira/browse/TRINIDAD-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anand V Nath updated TRINIDAD-2428:
---
Status: Patch Available (was: Open)
rtl styles are getting overriden by non rtl styles
--
Key: TRINIDAD-2428
URL: https://issues.apache.org/jira/browse/TRINIDAD-2428
Project: MyFaces Trinidad
Issue Type: Bug
Components: Skinning
Affects Versions: 2.1.0-core
Reporter: Anand V Nath
Fix For: 2.1.1-core
Attachments: jira2428.patch
Consider the following selectors in a skin
af|foo:rtl
{
color: red;
}
af|foo
{
color: blue;
}
With trinidad-config containing the right-to-left configuration, the selector
that gets applied is
af|foo
{
color: blue;
}
This is wrong. The rtl specific style should get applied.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[Commit Request] (TRINIDAD-2428) rtl styles are getting overriden by non rtl styles
Hello,
Can some body review and commit the patch for TRINIDAD-2428.
Thanks
Anand
On 11/25/2013 3:05 PM, Anand V Nath (JIRA) wrote:
[
https://issues.apache.org/jira/browse/TRINIDAD-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anand V Nath updated TRINIDAD-2428:
---
Status: Patch Available (was: Open)
rtl styles are getting overriden by non rtl styles
--
Key: TRINIDAD-2428
URL: https://issues.apache.org/jira/browse/TRINIDAD-2428
Project: MyFaces Trinidad
Issue Type: Bug
Components: Skinning
Affects Versions: 2.1.0-core
Reporter: Anand V Nath
Fix For: 2.1.1-core
Attachments: jira2428.patch
Consider the following selectors in a skin
af|foo:rtl
{
color: red;
}
af|foo
{
color: blue;
}
With trinidad-config containing the right-to-left configuration, the selector
that gets applied is
af|foo
{
color: blue;
}
This is wrong. The rtl specific style should get applied.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Resolved] (MYFACES-3817) ajax redirect/navigation loosing state information when changes are executed with redirect/navigation
[ https://issues.apache.org/jira/browse/MYFACES-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dora Rajappan resolved MYFACES-3817. Resolution: Fixed ViewExpiredException is fixed. state change under these conditions is lost due to overwrite and not supported this time for client and server side state saving to remain in sync. ajax redirect/navigation loosing state information when changes are executed with redirect/navigation -- Key: MYFACES-3817 URL: https://issues.apache.org/jira/browse/MYFACES-3817 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 2.2.0-beta Environment: Windows 8 Reporter: Dora Rajappan Original Estimate: 0.8h Remaining Estimate: 0.8h Ajax redirect/navigation loosing state information when changes are executed with redirect. This can be addressed #1 By putting a flag in redirect and write it in response after save state in rendering phase. #2 This behaviour true for redirect via navigation handler. In render phase it goes to response complete and state saving is avoided. When its a redirect not make the response complete true and flag it so that in rendering phase state is saved. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (MYFACES-3737) Remove _Html*.class from myface api.jar
[ https://issues.apache.org/jira/browse/MYFACES-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dora Rajappan resolved MYFACES-3737. Resolution: Fixed Api pom is changed and api.jar not containing the _Html* classes that are only required for myfaces builder plugin. Remove _Html*.class from myface api.jar --- Key: MYFACES-3737 URL: https://issues.apache.org/jira/browse/MYFACES-3737 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 2.1.12 Environment: NA Reporter: Dora Rajappan Priority: Trivial Original Estimate: 168h Remaining Estimate: 168h _Html classes are used by the builder plugin and not required to be there in api.jar to have it lighter. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (TRINIDAD-2430) ForEach looses varStatus data if JSP tags are not executed
Andrew Robinson created TRINIDAD-2430: - Summary: ForEach looses varStatus data if JSP tags are not executed Key: TRINIDAD-2430 URL: https://issues.apache.org/jira/browse/TRINIDAD-2430 Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 2.1.1-core Reporter: Andrew Robinson Assignee: Andrew Robinson the ForEachTag has a phase listener that removes unused iteration data (varStatus data). If a 3rd party JSF library skips JSP tag execution during a request, that code assumes the ForEachTag is no longer used. The result is the data is thrown out when it should not need to be. There should be a way to allow such a library notify Trinidad that the JSP tags are not being executed so that the information is not cleaned up. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (TOBAGO-1228) Setting JSF 2.0 as default version for Tobago
[ https://issues.apache.org/jira/browse/TOBAGO-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831680#comment-13831680 ] Hudson commented on TOBAGO-1228: SUCCESS: Integrated in tobago-trunk #1166 (See [https://builds.apache.org/job/tobago-trunk/1166/]) TOBAGO-1228: JSF 2.0 - using invokeOnComponent form JSF (lofwyr: http://svn.apache.org/viewvc/?view=revrev=1545295) * /myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/compat/InvokeOnComponent.java * /myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/ajax/AjaxResponseRenderer.java * /myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIData.java * /myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIForm.java * /myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIPage.java * /myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/util/ComponentUtils.java * /myfaces/tobago/trunk/tobago-extension/tobago-deprecation/src/main/java/org/apache/myfaces/tobago/compat/InvokeOnComponent.java * /myfaces/tobago/trunk/tobago-extension/tobago-deprecation/src/main/java/org/apache/myfaces/tobago/component/UIViewRoot.java * /myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/generate/ComponentInfo.java * /myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/java/org/apache/myfaces/tobago/apt/processor/ClassesGenerator.java * /myfaces/tobago/trunk/tobago-tool/tobago-tool-apt/src/main/resources/org/apache/myfaces/tobago/apt/component2.0.stg Setting JSF 2.0 as default version for Tobago - Key: TOBAGO-1228 URL: https://issues.apache.org/jira/browse/TOBAGO-1228 Project: MyFaces Tobago Issue Type: Task Affects Versions: 1.6.0-beta-2 Reporter: Udo Schnurpfeil Assignee: Udo Schnurpfeil Fix For: 2.0.0-alpha-1, 2.0.0 It is to be defined, if we longer support JSF 1.2 for Tobago 1.6.x. -- This message was sent by Atlassian JIRA (v6.1#6144)
Re: [core][discuss][proposal] Include View Pooling into MyFaces 2.2.x
Hi, +1 for this feature in core 2.2. Regards, Kocicak 2013/11/24 Thomas Andraschko andraschko.tho...@gmail.com Perfect. Thanks for Info. So +1 from my side. 2013/11/24 Leonardo Uribe lu4...@gmail.com Hi 2013/11/24 Thomas Andraschko andraschko.tho...@gmail.com Hi Leo, By default all the code in UIComponentBase is already in place, so if all components extend from UIComponentBase everything will work just fine cool, perfect! What about Behaviors or ActionListeners like: http://code.google.com/p/primefaces/source/browse/primefaces/trunk/src/main/java/org/primefaces/component/collector/Collector.java http://code.google.com/p/primefaces/source/browse/primefaces/trunk/src/main/java/org/primefaces/behavior/base/AbstractBehavior.java Will they work correctly? Yes, because the related variables are stored into the state, so if they change, saveState(...) will return non null and in the worst case the component will be replaced with a new one. The ideal is the attached objects (Collector) implements PartialStateHolder instead StateHolder. The reason is the hack involves save the state when markInitialState(...) was called and when a hard reset is done, reuse that information and restore the state of the component or attached object like it was when the view was built by first time. But if that is not done, the algorithm just replace the component with a new one and problem solved. The tricky part are those variables that are not part of the state buy plays some role, because there is no way to know they are there. For example the dataModelMap in UIData, but the examples out there are very few. All other components in PrimeFaces just use the StateHelper. So it should be fine. If saveState(...) is overriden, there is a chance that some additional lines are required. Note we still have a lot of work to do, but the evidence we have suggest we should at least give another try and see what happens. regards, Leonardo Uribe Regards, Thomas
[jira] [Created] (MYFACES-3828) [perf] Do not store the namespace into state for dynamic components
Leonardo Uribe created MYFACES-3828: --- Summary: [perf] Do not store the namespace into state for dynamic components Key: MYFACES-3828 URL: https://issues.apache.org/jira/browse/MYFACES-3828 Project: MyFaces Core Issue Type: Improvement Components: JSR-344 Reporter: Leonardo Uribe Assignee: Leonardo Uribe Checking some performance stuff I notice the full namespace of each component added by vdl.createComponent(...) is added into the state to be used later. One option to avoid that effect is calculate a list of all namespaces at startup and use that list to store only an associated identifier into the state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (MYFACES-3828) [perf] Do not store the namespace into state for dynamic components
[ https://issues.apache.org/jira/browse/MYFACES-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3828. - Resolution: Fixed Fix Version/s: 2.2.0 [perf] Do not store the namespace into state for dynamic components --- Key: MYFACES-3828 URL: https://issues.apache.org/jira/browse/MYFACES-3828 Project: MyFaces Core Issue Type: Improvement Components: JSR-344 Reporter: Leonardo Uribe Assignee: Leonardo Uribe Fix For: 2.2.0 Checking some performance stuff I notice the full namespace of each component added by vdl.createComponent(...) is added into the state to be used later. One option to avoid that effect is calculate a list of all namespaces at startup and use that list to store only an associated identifier into the state. -- This message was sent by Atlassian JIRA (v6.1#6144)
