[jira] [Commented] (MYFACES-4002) Regression? - References to external entities not working with WebXmlParser
[
https://issues.apache.org/jira/browse/MYFACES-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718339#comment-14718339
]
Dennis Kieselhorst commented on MYFACES-4002:
-
As far as I can see there were no significant changes in WebXmlParser. I tried
it with latest 2.0.x release and the same error occurred. So I think it's more
a change of dependencies (e.g. XML parser) or environment (servlet container).
I also tried your example with Jetty and Jetty itself was not even able to
parse the file:
{noformat}
java.io.FileNotFoundException
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.init(FileInputStream.java:146)
at java.io.FileInputStream.init(FileInputStream.java:101)
at
sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
at
sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:619)
at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.startEntity(XMLEntityManager.java:1297)
at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.startEntity(XMLEntityManager.java:1234)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanEntityReference(XMLDocumentFragmentScannerImpl.java:1908)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3067)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
at
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:648)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:332)
at org.eclipse.jetty.xml.XmlParser.parse(XmlParser.java:252)
{noformat}
So a hack in MyFaces would just fix a particular setup but not the whole issue.
As I'm also not aware of possible side effects I will not apply your patch but
leaving this issue open for a while to allow comments from other team members.
Regression? - References to external entities not working with WebXmlParser
---
Key: MYFACES-4002
URL: https://issues.apache.org/jira/browse/MYFACES-4002
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 2.2.4
Environment: Myfaces 2.2.4, Tomcat 8.0.23, JDK 1.8_20, Windows 7 64bit
Reporter: Thomas Timbul
Attachments: patch1.txt
I've searched JIRA and there are a few issues related to WebXmlParser, but
this seems almost like a recurrence of MYFACES-1754.
My web.xml is split into multiple files, each declared as an XML entity
relative to the web.xml file itself:
{code:xml}
!ENTITY contextparamsSYSTEM webxml/context-params.xml
{code}
(As a side note I used to use
{{jndi:/localhost/WEB-INF/webxml/context-params.xml}}, but for some reason
Tomcat 8 claims that jndi is an invalid protocol).
Using resource relative system identifiers Tomcat is now happy and the
context starts correctly. However, during its initialization MyFaces
re-parses the web.xml descriptor and resolves the entities incorrectly,
leading to failure with the message:
{code}
2015-06-17 15:48:13.853 [localhost-startStop-1] ERROR
o.a.m.s.w.webxml.WebXmlParser - Unable to parse web.xml
java.lang.IllegalArgumentException: The resource path
[file:///WEB-INF/webxml/context-params.xml] is not valid
{code}
The solution is to remove the file:// prefix before passing to the external
context to resolve, as in this patch:
{code}
Index: org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
===
--- WebXmlParser.java (revision ???)
+++ WebXmlParser.java (working copy)
@@ -138,6 +138,9 @@
private InputSource createContextInputSource(String publicId, String
systemId)
{
+if(systemId.startsWith(file:)) {
+systemId =
[jira] [Commented] (TOBAGO-1484) image in tc:button breaks tc:segmentLayout
[ https://issues.apache.org/jira/browse/TOBAGO-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718556#comment-14718556 ] Hudson commented on TOBAGO-1484: SUCCESS: Integrated in tobago-3.0.x #68 (See [https://builds.apache.org/job/tobago-3.0.x/68/]) TOBAGO-1484: image in tc:button breaks tc:segmentLayout (lofwyr: http://svn.apache.org/viewvc/?view=revrev=1698318) * /myfaces/tobago/branches/tobago-3.0.x/tobago-example/tobago-example-test/src/main/webapp/test/segmentLayout/buttons-with-image.xhtml * /myfaces/tobago/branches/tobago-3.0.x/tobago-theme/tobago-theme-standard/src/main/resources/org/apache/myfaces/tobago/renderkit/html/standard/standard/style/tobago.css image in tc:button breaks tc:segmentLayout -- Key: TOBAGO-1484 URL: https://issues.apache.org/jira/browse/TOBAGO-1484 Project: MyFaces Tobago Issue Type: Bug Components: Themes Affects Versions: 3.0.0-alpha-1 Environment: Firefox 40 and IE 11 (Safari and IE11 are okay) Reporter: Udo Schnurpfeil Assignee: Udo Schnurpfeil Priority: Minor Glyphicons are okay See: http://localhost:8080/faces/test/segmentLayout/buttons-with-image.xhtml -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TRINIDAD-2526) Parent page not getting disable on opening child window using modal dialog.
[ https://issues.apache.org/jira/browse/TRINIDAD-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pooja Parihar updated TRINIDAD-2526: Status: Patch Available (was: Open) Parent page not getting disable on opening child window using modal dialog. --- Key: TRINIDAD-2526 URL: https://issues.apache.org/jira/browse/TRINIDAD-2526 Project: MyFaces Trinidad Issue Type: Bug Components: Components, Facelets Affects Versions: 2.1.0-core Environment: Windows 7 64-Bit Reporter: Pooja Parihar The Core JavaScript file considers IE11 and Chrome39 as a Gecko and Safari browsers respectively. The JavaScript agent initialization (function _agentInit ) uses the userAgent property of the DOM's navigator object to identify the browser and its version number. This function use ‘msie’ to identify IE agent. Below are the userAgent for the browsers involved : IE 11- mozilla/5.0 (windows nt 6.1; wow64; trident/7.0; slcc2; .net clr 2.0.50727; .net clr 3.5.30729; .net clr 3.0.30729; media center pc 6.0; .net4.0c; .net4.0e; rv:11.0) like gecko Chrome 39 - mozilla/5.0 (windows nt 6.1; wow64) applewebkit/537.36 (khtml, like gecko) chrome/41.0.2272.76 safari/537.36 IE8 - mozilla/4.0 (compatible; msie 8.0; windows nt 6.1; wow64; trident/4.0; slcc2; .net clr 2.0.50727; .net clr 3.5.30729; .net clr 3.0.30729; media center pc 6.0; .net4.0c; .net4.0e) As IE11 and Chrome39 userAgent doesn’t Contain “msie”, the 'isIE' attribute is set to 'false' for these browser. On accessing child window using modal dialog, openWindow() function of Window.js under trinidad-impl-2.1.0\META-INF\adf\jsLibs is called. This method executes different blocks depending on the whether the browser is of type – IE, Gecko, etc. - For with IE8 , the block for IE browser executes (which contains code responsible for dimming of parent page). - For IE11 and Chrome 39, IE block doesnot executes (ie, code for dimming parent page is not executed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TRINIDAD-2526) Parent page not getting disable on opening child window using modal dialog.
Pooja Parihar created TRINIDAD-2526: --- Summary: Parent page not getting disable on opening child window using modal dialog. Key: TRINIDAD-2526 URL: https://issues.apache.org/jira/browse/TRINIDAD-2526 Project: MyFaces Trinidad Issue Type: Bug Components: Components, Facelets Affects Versions: 2.1.0-core Environment: Windows 7 64-Bit Reporter: Pooja Parihar The Core JavaScript file considers IE11 and Chrome39 as a Gecko and Safari browsers respectively. The JavaScript agent initialization (function _agentInit ) uses the userAgent property of the DOM's navigator object to identify the browser and its version number. This function use ‘msie’ to identify IE agent. Below are the userAgent for the browsers involved : IE 11- mozilla/5.0 (windows nt 6.1; wow64; trident/7.0; slcc2; .net clr 2.0.50727; .net clr 3.5.30729; .net clr 3.0.30729; media center pc 6.0; .net4.0c; .net4.0e; rv:11.0) like gecko Chrome 39 - mozilla/5.0 (windows nt 6.1; wow64) applewebkit/537.36 (khtml, like gecko) chrome/41.0.2272.76 safari/537.36 IE8 - mozilla/4.0 (compatible; msie 8.0; windows nt 6.1; wow64; trident/4.0; slcc2; .net clr 2.0.50727; .net clr 3.5.30729; .net clr 3.0.30729; media center pc 6.0; .net4.0c; .net4.0e) As IE11 and Chrome39 userAgent doesn’t Contain “msie”, the 'isIE' attribute is set to 'false' for these browser. On accessing child window using modal dialog, openWindow() function of Window.js under trinidad-impl-2.1.0\META-INF\adf\jsLibs is called. This method executes different blocks depending on the whether the browser is of type – IE, Gecko, etc. - For with IE8 , the block for IE browser executes (which contains code responsible for dimming of parent page). - For IE11 and Chrome 39, IE block doesnot executes (ie, code for dimming parent page is not executed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-4002) Regression? - References to external entities not working with WebXmlParser
[
https://issues.apache.org/jira/browse/MYFACES-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718492#comment-14718492
]
Thomas Timbul commented on MYFACES-4002:
I assume you created each of those files for your test in the webxml
subdirectory. Did it say what it couldn't find? Was the file:// prefix added?
I suppose one question is where exactly this {{file://}} scheme is added,
because it's not part of the original web.xml. I'm full time on something else
right now, so unfortunately lack time. Hopefully I'll get another chance at
some point to look into this in more detail again and help figure out the root
source of the issue.
Regression? - References to external entities not working with WebXmlParser
---
Key: MYFACES-4002
URL: https://issues.apache.org/jira/browse/MYFACES-4002
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 2.2.4
Environment: Myfaces 2.2.4, Tomcat 8.0.23, JDK 1.8_20, Windows 7 64bit
Reporter: Thomas Timbul
Attachments: patch1.txt
I've searched JIRA and there are a few issues related to WebXmlParser, but
this seems almost like a recurrence of MYFACES-1754.
My web.xml is split into multiple files, each declared as an XML entity
relative to the web.xml file itself:
{code:xml}
!ENTITY contextparamsSYSTEM webxml/context-params.xml
{code}
(As a side note I used to use
{{jndi:/localhost/WEB-INF/webxml/context-params.xml}}, but for some reason
Tomcat 8 claims that jndi is an invalid protocol).
Using resource relative system identifiers Tomcat is now happy and the
context starts correctly. However, during its initialization MyFaces
re-parses the web.xml descriptor and resolves the entities incorrectly,
leading to failure with the message:
{code}
2015-06-17 15:48:13.853 [localhost-startStop-1] ERROR
o.a.m.s.w.webxml.WebXmlParser - Unable to parse web.xml
java.lang.IllegalArgumentException: The resource path
[file:///WEB-INF/webxml/context-params.xml] is not valid
{code}
The solution is to remove the file:// prefix before passing to the external
context to resolve, as in this patch:
{code}
Index: org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
===
--- WebXmlParser.java (revision ???)
+++ WebXmlParser.java (working copy)
@@ -138,6 +138,9 @@
private InputSource createContextInputSource(String publicId, String
systemId)
{
+if(systemId.startsWith(file:)) {
+systemId = systemId.substring(7); // remove file://
+}
InputStream inStream = _context.getResourceAsStream(systemId);
if (inStream == null)
{
{code}
Those three lines of code are based on other work by the MyFaces team
(org.apache.myfaces.config.impl.FacesConfigEntityResolver) and even if it
weren't is made available free of charge and free from license restrictions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TRINIDAD-2526) Parent page not getting disable on opening child window using modal dialog.
[ https://issues.apache.org/jira/browse/TRINIDAD-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pooja Parihar updated TRINIDAD-2526: Status: Open (was: Patch Available) Parent page not getting disable on opening child window using modal dialog. --- Key: TRINIDAD-2526 URL: https://issues.apache.org/jira/browse/TRINIDAD-2526 Project: MyFaces Trinidad Issue Type: Bug Components: Components, Facelets Affects Versions: 2.1.0-core Environment: Windows 7 64-Bit Reporter: Pooja Parihar The Core JavaScript file considers IE11 and Chrome39 as a Gecko and Safari browsers respectively. The JavaScript agent initialization (function _agentInit ) uses the userAgent property of the DOM's navigator object to identify the browser and its version number. This function use ‘msie’ to identify IE agent. Below are the userAgent for the browsers involved : IE 11- mozilla/5.0 (windows nt 6.1; wow64; trident/7.0; slcc2; .net clr 2.0.50727; .net clr 3.5.30729; .net clr 3.0.30729; media center pc 6.0; .net4.0c; .net4.0e; rv:11.0) like gecko Chrome 39 - mozilla/5.0 (windows nt 6.1; wow64) applewebkit/537.36 (khtml, like gecko) chrome/41.0.2272.76 safari/537.36 IE8 - mozilla/4.0 (compatible; msie 8.0; windows nt 6.1; wow64; trident/4.0; slcc2; .net clr 2.0.50727; .net clr 3.5.30729; .net clr 3.0.30729; media center pc 6.0; .net4.0c; .net4.0e) As IE11 and Chrome39 userAgent doesn’t Contain “msie”, the 'isIE' attribute is set to 'false' for these browser. On accessing child window using modal dialog, openWindow() function of Window.js under trinidad-impl-2.1.0\META-INF\adf\jsLibs is called. This method executes different blocks depending on the whether the browser is of type – IE, Gecko, etc. - For with IE8 , the block for IE browser executes (which contains code responsible for dimming of parent page). - For IE11 and Chrome 39, IE block doesnot executes (ie, code for dimming parent page is not executed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TRINIDAD-2526) Parent page not getting disable on opening child window using modal dialog.
[ https://issues.apache.org/jira/browse/TRINIDAD-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14719284#comment-14719284 ] Mike Kienenberger commented on TRINIDAD-2526: - As far as I can tell, the last commit to the Trinidad project was in October 2014, so I'm guessing we do not currently have any active Trinidad developers. If you provide a patch, I'll apply it for you. Parent page not getting disable on opening child window using modal dialog. --- Key: TRINIDAD-2526 URL: https://issues.apache.org/jira/browse/TRINIDAD-2526 Project: MyFaces Trinidad Issue Type: Bug Components: Components, Facelets Affects Versions: 2.1.0-core Environment: Windows 7 64-Bit Reporter: Pooja Parihar The Core JavaScript file considers IE11 and Chrome39 as a Gecko and Safari browsers respectively. The JavaScript agent initialization (function _agentInit ) uses the userAgent property of the DOM's navigator object to identify the browser and its version number. This function use ‘msie’ to identify IE agent. Below are the userAgent for the browsers involved : IE 11- mozilla/5.0 (windows nt 6.1; wow64; trident/7.0; slcc2; .net clr 2.0.50727; .net clr 3.5.30729; .net clr 3.0.30729; media center pc 6.0; .net4.0c; .net4.0e; rv:11.0) like gecko Chrome 39 - mozilla/5.0 (windows nt 6.1; wow64) applewebkit/537.36 (khtml, like gecko) chrome/41.0.2272.76 safari/537.36 IE8 - mozilla/4.0 (compatible; msie 8.0; windows nt 6.1; wow64; trident/4.0; slcc2; .net clr 2.0.50727; .net clr 3.5.30729; .net clr 3.0.30729; media center pc 6.0; .net4.0c; .net4.0e) As IE11 and Chrome39 userAgent doesn’t Contain “msie”, the 'isIE' attribute is set to 'false' for these browser. On accessing child window using modal dialog, openWindow() function of Window.js under trinidad-impl-2.1.0\META-INF\adf\jsLibs is called. This method executes different blocks depending on the whether the browser is of type – IE, Gecko, etc. - For with IE8 , the block for IE browser executes (which contains code responsible for dimming of parent page). - For IE11 and Chrome 39, IE block doesnot executes (ie, code for dimming parent page is not executed). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MYFACES-1383) FacesContextFactoryImpl issue using trinidad any myfaces core
[ https://issues.apache.org/jira/browse/MYFACES-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko updated MYFACES-1383: --- Status: Open (was: Patch Available) FacesContextFactoryImpl issue using trinidad any myfaces core - Key: MYFACES-1383 URL: https://issues.apache.org/jira/browse/MYFACES-1383 Project: MyFaces Core Issue Type: Bug Components: Portlet_Support Affects Versions: 1.1.5-SNAPSHOT Environment: pluto 1.1-dev, tomcat 5.5.17 running on linux 2.6.17 Reporter: nicolas kalkhof Assignee: Matthias Weßendorf Attachments: bridge.patch trinidad won´t run in a portlet environment. problem is, that FacesContextFactoryImpl does not extend ServletFacesContextImpl. therefore this is an internal myfaces core problem that could hopefully be fixed. stacktrace of the crashing portlet using myfaces and trinidad: javax.portlet.PortletException: org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl$CacheRenderKit at org.apache.myfaces.portlet.MyFacesGenericPortlet.handleExceptionFromLifecycle(MyFacesGenericPortlet.java:253) at org.apache.myfaces.portlet.MyFacesGenericPortlet.facesRender(MyFacesGenericPortlet.java:407) Nested Exception is java.lang.ClassCastException: org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl$CacheRenderKit at org.apache.myfaces.portlet.MyFacesGenericPortlet.facesRender(MyFacesGenericPortlet.java:387) at net.portlets.logon.LogonPortlet.doView(LogonPortlet.java:88) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
