[jira] [Commented] (MYFACES-3170) [perf] use initialCapacity for ArrayList
[ https://issues.apache.org/jira/browse/MYFACES-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011779#comment-15011779 ] Leonardo Uribe commented on MYFACES-3170: - The improvement is minimal. It is not something really required. > [perf] use initialCapacity for ArrayList > > > Key: MYFACES-3170 > URL: https://issues.apache.org/jira/browse/MYFACES-3170 > Project: MyFaces Core > Issue Type: Improvement > Components: General > Environment: myfaces trunk >Reporter: Martin Kočí >Assignee: Martin Kočí >Priority: Minor > > new ArrayList() creates Object [10] and in some situation it is not > necessary. For example, UIInput.addValidator allocates ArrayList of size ten > but in real usage nobody adds 10 validators to one component. > Analyze usage of new ArrayList() and myfaces code and use initialCapacity if > possible. > i -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-3991) New flow-scoped bean is created when passing outbound parameter
[
https://issues.apache.org/jira/browse/MYFACES-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011882#comment-15011882
]
Leonardo Uribe commented on MYFACES-3991:
-
I can't see any bug in the code. The steps done to initialize outbound
parameters are correct, so beyond that there is nothing else I can do. I'll
close this one as cannot reproduce. Please reopen it again if you can provide
an example that shows the problem.
> New flow-scoped bean is created when passing outbound parameter
> ---
>
> Key: MYFACES-3991
> URL: https://issues.apache.org/jira/browse/MYFACES-3991
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.8
>Reporter: Dhana kumar Anem
>Priority: Minor
>
> Hi,
> I am actively using JSF 2.2 flows in my application; I suspect this is bug.
> in my view, I do set in my commandLink action,
> #{memberListBean.setMember(member).
> But the above 'setMember' returns outcome 'callMemberRegisterUpdate' which is
> a node in my flow and invokes the nested flow. (Code is below)
> Here, the outbound parameter refers to new instance of MemberListBean, hence
> I get null for 'memberListBean.member'; I expect the value instead of null as
> it is set before.
> flowBuilder.flowCallNode("callMemberRegisterUpdate")
> .flowReference("", "member") // define the flow to call
> .outboundParameter("member", "#{memberListBean.member}");
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MYFACES-3957) Disabled h:commandLink results in rendering of a span with onclick
[
https://issues.apache.org/jira/browse/MYFACES-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012531#comment-15012531
]
Leonardo Uribe commented on MYFACES-3957:
-
I tested Mojarra 2.2.12 and I can see that only the onclick is removed from the
element, but the patch remove all event listeners. It looks like an
special case not documented, and it has sense just to remove the onclick
javascript. I'll modify the patch to do the same, just remove onclick when the
link is disabled.
> Disabled h:commandLink results in rendering of a span with onclick
> ---
>
> Key: MYFACES-3957
> URL: https://issues.apache.org/jira/browse/MYFACES-3957
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.2
> Environment: Websphere 8.5
>Reporter: Stephan Knitelius
> Attachments: MYFACES-3957.patch
>
>
> {code}
>type="button">link
> AND
>type="button" value="link" />
> {code}
> Result in:
> {code}
> link
> {code}
> I would have expected to find a disabled or a span without the
> onclick action.
> In comparison a disabled h:commandButton:
> {code}
> type="button"/>
> {code}
> Results in:
> {code}
> id="frmContent:j_id499838546_62f34114" onclick="alert('hello')" type="button"
> value="button">
> {code}
> As expected the onclick action is not preformed.
> I would expect similar behaviour from both h:commandButton and h:commandLink.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MYFACES-3957) Disabled h:commandLink results in rendering of a span with onclick
[
https://issues.apache.org/jira/browse/MYFACES-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe updated MYFACES-3957:
Resolution: Fixed
Assignee: Leonardo Uribe
Fix Version/s: 2.2.9
2.1.18
2.0.24
Status: Resolved (was: Patch Available)
Thanks to Thomas Andraschko for provide this patch
> Disabled h:commandLink results in rendering of a span with onclick
> ---
>
> Key: MYFACES-3957
> URL: https://issues.apache.org/jira/browse/MYFACES-3957
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.2
> Environment: Websphere 8.5
>Reporter: Stephan Knitelius
>Assignee: Leonardo Uribe
> Fix For: 2.0.24, 2.1.18, 2.2.9
>
> Attachments: MYFACES-3957.patch
>
>
> {code}
>type="button">link
> AND
>type="button" value="link" />
> {code}
> Result in:
> {code}
> link
> {code}
> I would have expected to find a disabled or a span without the
> onclick action.
> In comparison a disabled h:commandButton:
> {code}
> type="button"/>
> {code}
> Results in:
> {code}
> id="frmContent:j_id499838546_62f34114" onclick="alert('hello')" type="button"
> value="button">
> {code}
> As expected the onclick action is not preformed.
> I would expect similar behaviour from both h:commandButton and h:commandLink.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (MYFACES-3988) An empty tag in a custom tag-lib causes an Exception
[ https://issues.apache.org/jira/browse/MYFACES-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3988. - Resolution: Fixed Assignee: Leonardo Uribe Fix Version/s: 2.2.9 I did a small change, just allow renderer-type and handler-class to receive empty values and interpret them as null. I think that's enough in this case. > An empty tag in a custom tag-lib causes an Exception > > > Key: MYFACES-3988 > URL: https://issues.apache.org/jira/browse/MYFACES-3988 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-344 >Affects Versions: 2.2.8 >Reporter: Christopher Meyer >Assignee: Leonardo Uribe >Priority: Minor > Fix For: 2.2.9 > > > While developing a custom tag library we added an empty renderer-type tag > like this: > > myinput > >my.test.MyInput > > > > This causes the following exception: > Caused by: java.lang.Exception: Value Cannot be Empty > at > org.apache.myfaces.view.facelets.compiler.TagLibraryConfigUnmarshallerImpl$LibraryHandler.endElement(TagLibraryConfigUnmarshallerImpl.java:395) > at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown > Source) > at > org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanEndElement(Unknown Source) > at > org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown > Source) > ... > This appears to be expected based on the code in > TagLibraryConfigUnmarshallerImpl. From what I can see the exception appears > to be thrown on elements which are used in another spot. If any of them are > empty they will throw the above exception. Wildfly/Glassfish does not have > the same behavior, so my assumption is they just ignore it. > Should the MyFaces code be modified to just continue on without the > exception, based on the reference implementation? I can quickly create > something if so, I just wanted to bring this up to the community at large > since I don't know the reasoning behind the difference of the implementations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
