Re: jsf.js post 2.3 plans

2017-10-06 Thread Dora Rajappan
 Thanks for detailing the future of browser and how jsf cope up with it.
I was using mojarra for my application and the commandLink was not working due 
to script problem.So I switched to myfaces and we got some problem with 
repeated ajax calls. (Myfaces 4160).
Are we syncing with mojarra regarding the technology to be used with the 
jsf.js, entire scripting arena.Not sure spec say anything about the technology 
used for scripting.
Thanks & Regards,Dora Rajappan.

On Thursday, October 5, 2017, 11:32:23 PM GMT+5:30, Thomas Andraschko 
 wrote:  
 
 yep. +1 for IE11 in JSF.next

2017-10-05 14:36 GMT+02:00 Werner Punz :

Yeah given the timeframe, I guess IE11 is perfectly fine. We cannot
expect JSF 2.4 to hit the final spec before 2019, by then even
corporate support of Windows 7 will come to an end.

The main problem I see is that we probably will be stuck with supporting
IE11 for many years, since Microsoft still basically packs it in with every 
windows 10 sort of as secondary browser. So IE11 support will die about 10 
years after Microsoft stops doing it.

And believe me even IE11
is currently the bottom barrely quality and speedwise you currently get
in the browser space. Even frameworks like Angular 1 basically drive the IE11 
engine to its limits, the more shims you add it the bigger the browser becomes 
as a problem in day to day development.


I guess we once will hit the point where we will say we cannot support it 
anymore. Not now not in 2 years but sometime in the future.


Werner



Am 05.10.17 um 14:12 schrieb Mike Kienenberger:

I think it's ok for us to say that the baseline is IE11.   If you are
concerned, take a poll on the users list.

On Thu, Oct 5, 2017 at 3:43 AM, Thomas Andraschko
 wrote:

Hi Werner,

big +1 for doing a completely new jsf.js!

Basically it would be really great to use another lang as plain js.
But there is also another downside: most webdevelopers and commiters of
MyFaces are fimilar with plain js but maybe not with TypeScript or else.
But i think we should do it if can we can easily integrate it somehow in our
maven builds.
My personal opinion is that i would prefer plain js if the developers must
install nodejs etc. on their machines. If everything is done by maven in the
background, it's ok for me.

As you already said, we actually must avoid dependencies like kotlin.js and
jquery.js - thats a no go and also not really required.

Regards,
Thomas



2017-10-05 9:19 GMT+02:00 Werner Punz :


Hi guys


I just wanted to start a discussion on how we are going to proceed with
the jsf.js codebase.
The issue is following:

Our codebase which currently is adapted by me for 2.3 is rather old.
It by now is around 9-10 years old and back then most of the stuff I did
made sense
a) The library needed to be self contained
b) There were an awful lot of browsers in use, which did not adhere to any
standards whatsoever
c) There was no real inheritance system available just the prototype
system which is one level below inheritance by allowing to access the
class/object tree and manipulate it on the fly

So what I did was following
Implement my own class system for not having to deal with prototype
inheritance all the time
Since I needed to be self contained integrating a library like JQuery
(which also was it its infancy at that time) was out of the question
due to possible conflicts. There also was no widespread support
for querySelector on node level some browsers had it some browsers
had other workarounds to speed the dom node lookup up.

Also no unified ajax handling, the ajax api was at its infancy and I still
had to support the archaic IE way of doing things.

To the worse there were significant differences in dom and xml handling
between the various browsers out in the wild compared to the already
defined standards (I am speaking of you IE and mobile browsers in use back
then)

So in the end I ended up with a codebase which is about 40-50% there just
to support legacy browsers. While I did some work to isolate the quirks code
and compile it out of the codebase there still is work to be done.

Again all of this made sense back then...


Lots of things have been changed in those 10 years and now most of the
things do not make sense anymore.

a) We have saner meta languages which allow to compile to javascript,
following candidates come to my mind

- Typescript, a language which I amn very familiar with due to my day to
day work
- Coffeescript ... not very familiar with that one
- Kotlin... yes that one also has a javascript target compiler

We definitely should opt for a meta compiler instead of pure js.
The reasons are many, and I can speak here atm only for Typescript

- You can change ecma script levels on build level
- You can change the package management system in build level
- You get additional coding security by having the apis fortified at least
with some types instead of doing constantly your manual asserts
- In the end the Meta language codebase is way cleaner th

[jira] [Comment Edited] (MYFACES-4153) h:selectOneRadio when rendered inside h:panelGroup which is right aligned stands out from the group

2017-10-06 Thread Dora Rajappan (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194450#comment-16194450
 ] 

Dora Rajappan edited comment on MYFACES-4153 at 10/6/17 10:58 AM:
--

Thomas you can run this pom as it is and you will get the login page where you 
can find the alignment of selectOneRadio.


was (Author: dorarajappan):
Thomas you can run this pom as it it and you will get the login page where you 
can find the alignment of selectOneRadio.

> h:selectOneRadio when rendered inside h:panelGroup which is right aligned 
> stands out from the group
> ---
>
> Key: MYFACES-4153
> URL: https://issues.apache.org/jira/browse/MYFACES-4153
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 2.3.0-beta
>Reporter: Dora Rajappan
>Priority: Minor
> Attachments: login.xhtml, mf23test.zip
>
>
> h:selectOneRadio when rendered inside h:panelGroup which is right aligned 
> stands out from the group towards the left since it gets rendered as html 
> table. This is same behaviour for mojarra 2.2 also.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MYFACES-4122) Auto scroll doesn't work anymore for some environment

2017-10-06 Thread Pino (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194693#comment-16194693
 ] 

Pino commented on MYFACES-4122:
---

Hi,

got the same error for 
org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils -> "Error 
getting y offset for autoscroll feature. Bad param value"

> Auto scroll doesn't work anymore for some environment
> -
>
> Key: MYFACES-4122
> URL: https://issues.apache.org/jira/browse/MYFACES-4122
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.2.12
>Reporter: Taro App
> Attachments: HtmlJavaScriptUtils.java.patch
>
>
> Auto Scroll doesn't work anymore for some environment. This is because auto 
> scroll code assumes scroll position to be integer value where some browsers 
> begin to return floating numbers. See 
> org.apache.myfaces.shared.renderkit.html.HtmlJavaScriptUtils.getAutoScrollFunction
>  where it parses scroll positions assuming they are integers, and if not, it 
> ignores those values and prints out error "Error getting y offset for 
> autoscroll feature. Bad param value"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (MYFACES-4058) ProtectedViewException for a protectedview access while checking the OriginHeader for appContextPath

2017-10-06 Thread Bill Lucy (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194833#comment-16194833
 ] 

Bill Lucy commented on MYFACES-4058:


I've been looking into this issue as well; in the scenario I'm investigating, 
protected views are broken in Safari.  Similar to the other posts here, I can 
see an Origin header added by Safari to a non-CORS request.  

I can see that JSF 2.2 section 2.2.1 says we should be checking the Origin 
header in the same way we check the Referer header.. but that doesn't make 
sense: the header is not intended to contain any path info. 
(https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin)  So it looks 
like checking the Origin header in 
RestoreViewExecutor.checkRefererOrOriginHeader() will always fail.

Checking the Origin header against the ExternalContext's host and port makes 
sense, but not the full path.  Changing the default behavior here would make 
sense to me, given my current understanding, but a custom param would work, 
given the language in the spec.  [~lu4242] what are your thoughts?

> ProtectedViewException for a protectedview access while checking the 
> OriginHeader for appContextPath
> 
>
> Key: MYFACES-4058
> URL: https://issues.apache.org/jira/browse/MYFACES-4058
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 2.2.6
> Environment: Windows, JSF 2.2
>Reporter: Dinesh Kumar A S
>
> Getting ProtectedViewException while accessing a protectedview/xhtml, while 
> checking the OriginHeader for appContextPath..
> SO reference : 
> http://stackoverflow.com/questions/38308431/jsf-2-2-protectedviewexception-due-to-origin-header-and-appcontextpath-mismatch
> Any help is much appreciated.
> Does the "Origin" request-header is supposed to have the appContextPath in 
> the path/urlInfo ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)