Re: [VOTE] Release Tobago 4.2.1
Here is my +1 Regards Bernd On Mon, May 7, 2018 at 7:07 PM, Henning Nöth wrote: > +1 > > Am 06.05.18 um 18:29 schrieb Dennis Kieselhorst: > > +1 > > >
Re: Migrate all MyFaces projects to Git
To avoid further confusion I've just done the merge from 2.3.x to master. Please have a look, if everything is fine for you. After that we can delete the 2.3.x branch. Cheers Dennis
Re: Migrate all MyFaces projects to Git
You need to switch to 2.3.x branch. Master still points to 2.2.x because this was trunk before the migration.
Re: Migrate all MyFaces projects to Git
It is 2.2.13-SNAPSHOT On Tuesday, May 8, 2018, 10:07:29 PM GMT+5:30, Dora Rajappan wrote: I could just clone it. Thank you. Hope its 2.3.1.On Tuesday, May 8, 2018, 9:50:58 PM GMT+5:30, Dennis Kieselhorst wrote: So the migration of MyFaces Core is done. Please use https://gitbox.apache.org/repos/asf/myfaces.git or https://github.com/apache/myfaces from now. Any volunteer who merges 2.3.x to master (former 2.2.x trunk)? I think it makes sense to switch now. I'll continue with build-tools, it's more difficult then first thought, so it will take some extra time. I was not aware that we already had mirrors for https://github.com/apache/myfaces-extcdi https://github.com/apache/myfaces-extval https://github.com/apache/myfaces-html5 https://github.com/apache/myfaces-portlet-bridge https://github.com/apache/myfaces-scripting I'll have them transfered to Gitbox.
Re: Migrate all MyFaces projects to Git
I could just clone it. Thank you. Hope its 2.3.1.On Tuesday, May 8, 2018, 9:50:58 PM GMT+5:30, Dennis Kieselhorst wrote: So the migration of MyFaces Core is done. Please use https://gitbox.apache.org/repos/asf/myfaces.git or https://github.com/apache/myfaces from now. Any volunteer who merges 2.3.x to master (former 2.2.x trunk)? I think it makes sense to switch now. I'll continue with build-tools, it's more difficult then first thought, so it will take some extra time. I was not aware that we already had mirrors for https://github.com/apache/myfaces-extcdi https://github.com/apache/myfaces-extval https://github.com/apache/myfaces-html5 https://github.com/apache/myfaces-portlet-bridge https://github.com/apache/myfaces-scripting I'll have them transfered to Gitbox.
Re: Migrate all MyFaces projects to Git
So the migration of MyFaces Core is done. Please use https://gitbox.apache.org/repos/asf/myfaces.git or https://github.com/apache/myfaces from now. Any volunteer who merges 2.3.x to master (former 2.2.x trunk)? I think it makes sense to switch now. I'll continue with build-tools, it's more difficult then first thought, so it will take some extra time. I was not aware that we already had mirrors for https://github.com/apache/myfaces-extcdi https://github.com/apache/myfaces-extval https://github.com/apache/myfaces-html5 https://github.com/apache/myfaces-portlet-bridge https://github.com/apache/myfaces-scripting I'll have them transfered to Gitbox.
Re: [VOTE] Release Tobago 4.2.1
Hi Udo, others! Considering this is the following source zip? https://repository.apache.org/content/repositories/orgapachemyfaces-1134/org/apache/myfaces/tobago/tobago/4.2.1/ with sha1 a57c13ae4aea6270a7efe233a1cb64b12e4cd548 ? In which case I'm +1 * builds * rat ok * LICENSE ok * NOTICE ok * sig ok Please next time also add the link to the source tarball/zip + it's sha1 in the VOTE mail. Otherwise we don't really have a guaranteed way to tell what we did vote on at all ;) txs and LieGrue, strub > Am 06.05.2018 um 16:37 schrieb Udo Schnurpfeil : > > Hello, > > We would like to release Tobago 4.2.1. > > Major changes since last release are: Bugfixes > > This is a PATCH release with backwards-compatible bug fixes. > > For a detail list please consult the release notes at: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273&version=12342849 > > > The version is available at the staging repository (Nexus) at: > > https://repository.apache.org/content/repositories/orgapachemyfaces-1134/ > > Please vote now! (The vote is open for 72h.) > > [ ] +1 > [ ] +0 > [ ] -1 > > Regards, > > Udo > >
[jira] [Comment Edited] (MYFACES-4229) Regression in Spec Issue 790: Cross form submit
[
https://issues.apache.org/jira/browse/MYFACES-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467157#comment-16467157
]
Werner Punz edited comment on MYFACES-4229 at 5/8/18 9:36 AM:
--
Yes I will have a look it indeed it is related. To the other, I have to recheck
the specs, if I missed a case. In the meanwhile simply add following code to
your page, to automatically update the viewstates:
window.myfaces = window.myfaces || {};
myfaces.config = myfaces.config || {};
myfaces.config.no_portlet_env = true;
The no_portlet_env is an internal flag to enforce a update all viewstates in
the entire page no matter
which forms are in execute and render.
was (Author: werpu):
Yes I will have a look it indeed it is related. To the other, I have to recheck
the specs, if I missed a case. In the meanwhile simply add following code to
your page, to automatically update the viewstates:
window.myfaces = window.myfaces || {}; myfaces.config = myfaces.config || {};
myfaces.config.no_portlet_env = true;
The no_portlet_env is an internal flag to enforce a update all viewstates in
the entire page no matter
which forms are in execute and render.
> Regression in Spec Issue 790: Cross form submit
> ---
>
> Key: MYFACES-4229
> URL: https://issues.apache.org/jira/browse/MYFACES-4229
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-372
>Affects Versions: 2.3.1
>Reporter: Eduardo Breijo
>Assignee: Werner Punz
>Priority: Major
> Attachments: JSF23Spec790.war
>
>
> After releasing MyFaces 2.3.1, I noticed a regression in cross form submit
> from Spec Issue 790:
> [https://github.com/javaee/javaserverfaces-spec/issues/790]
> HTML sample code:
> {code:java}
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
>
> The issue is that on MyFaces 2.3.1 the hidden input javax.faces.ViewState is
> being removed from form "b" after we submit form "a" and viceversa. As a
> result, cross form submit is not working as expected, you either have to
> refresh the page before executing submit on the second form or you have to
> execute submit twice so the update is reflected in the other form.
> Rendered page on MyFaces 2.3.0
> {code:java}
> enctype="application/x-www-form-urlencoded"> This is 'form a'
> Enter a new value for input1:
>
> onclick="jsf.util.chain(this, event,'jsf.ajax.request(this,event,{execute:\'a
> b \',render:\'b \',\'javax.faces.behavior.event\':\'action\'})'); return
> false;"/>
>
> id="j_id__v_0:javax.faces.ViewState:1"
> value="RjhDMEFGQUMwNDI4NTUwRDAwMDAwMDAx" autocomplete="off"/>
>
> enctype="application/x-www-form-urlencoded"> This is 'form b'
> Enter a new value for input2:
>
> id="b:commandLink1" name="b:commandLink1"> Click here to execute 'form a' and
> 'form b' but re-render 'form a'
>
> name="javax.faces.ViewState" value="RjhDMEFGQUMwNDI4NTUwRDAwMDAwMDAx"/>
>
> {code}
>
> Rendered page on MyFaces 2.3.1
> {code:java}
> enctype="application/x-www-form-urlencoded"> This is 'form a'
> Enter a new value for input1:
>
> onclick="jsf.util.chain(this, event,'jsf.ajax.request(this,event,{execute:\'a
> b \',render:\'b \',\'javax.faces.behavior.event\':\'action\'})'); return
> false;"/>
>
> id="j_id__v_0:javax.faces.ViewState:1"
> value="RjY3MjAyMTY3N0U2ODE3RDAwMDAwMDAx" autocomplete="off"/>
>
> enctype="application/x-www-form-urlencoded"> This is 'form b'
> Enter a new value for input2:
>
> id="b:commandLink1" name="b:commandLink1"> Click here to execute 'form a' and
> 'form b' but re-render 'form a'
>
>
> {code}
>
> I have provided a sample app that shows the issue when MyFaces 2.3.1 is used.
> # Just deploy the app on Tomcat and drive a request to:
> [http://localhost:8080/JSF23Spec790/test1.xhtml]
> # Enter a text in input1 and click submit button next to the input. Check
> the rendered page.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MYFACES-4229) Regression in Spec Issue 790: Cross form submit
[
https://issues.apache.org/jira/browse/MYFACES-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467157#comment-16467157
]
Werner Punz commented on MYFACES-4229:
--
Yes I will have a look it indeed it is related. To the other, I have to recheck
the specs, if I missed a case. In the meanwhile simply add following code to
your page, to automatically update the viewstates:
window.myfaces = window.myfaces || {}; myfaces.config = myfaces.config || {};
myfaces.config.no_portlet_env = true;
The no_portlet_env is an internal flag to enforce a update all viewstates in
the entire page no matter
which forms are in execute and render.
> Regression in Spec Issue 790: Cross form submit
> ---
>
> Key: MYFACES-4229
> URL: https://issues.apache.org/jira/browse/MYFACES-4229
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-372
>Affects Versions: 2.3.1
>Reporter: Eduardo Breijo
>Priority: Major
> Attachments: JSF23Spec790.war
>
>
> After releasing MyFaces 2.3.1, I noticed a regression in cross form submit
> from Spec Issue 790:
> [https://github.com/javaee/javaserverfaces-spec/issues/790]
> HTML sample code:
> {code:java}
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
>
> The issue is that on MyFaces 2.3.1 the hidden input javax.faces.ViewState is
> being removed from form "b" after we submit form "a" and viceversa. As a
> result, cross form submit is not working as expected, you either have to
> refresh the page before executing submit on the second form or you have to
> execute submit twice so the update is reflected in the other form.
> Rendered page on MyFaces 2.3.0
> {code:java}
> enctype="application/x-www-form-urlencoded"> This is 'form a'
> Enter a new value for input1:
>
> onclick="jsf.util.chain(this, event,'jsf.ajax.request(this,event,{execute:\'a
> b \',render:\'b \',\'javax.faces.behavior.event\':\'action\'})'); return
> false;"/>
>
> id="j_id__v_0:javax.faces.ViewState:1"
> value="RjhDMEFGQUMwNDI4NTUwRDAwMDAwMDAx" autocomplete="off"/>
>
> enctype="application/x-www-form-urlencoded"> This is 'form b'
> Enter a new value for input2:
>
> id="b:commandLink1" name="b:commandLink1"> Click here to execute 'form a' and
> 'form b' but re-render 'form a'
>
> name="javax.faces.ViewState" value="RjhDMEFGQUMwNDI4NTUwRDAwMDAwMDAx"/>
>
> {code}
>
> Rendered page on MyFaces 2.3.1
> {code:java}
> enctype="application/x-www-form-urlencoded"> This is 'form a'
> Enter a new value for input1:
>
> onclick="jsf.util.chain(this, event,'jsf.ajax.request(this,event,{execute:\'a
> b \',render:\'b \',\'javax.faces.behavior.event\':\'action\'})'); return
> false;"/>
>
> id="j_id__v_0:javax.faces.ViewState:1"
> value="RjY3MjAyMTY3N0U2ODE3RDAwMDAwMDAx" autocomplete="off"/>
>
> enctype="application/x-www-form-urlencoded"> This is 'form b'
> Enter a new value for input2:
>
> id="b:commandLink1" name="b:commandLink1"> Click here to execute 'form a' and
> 'form b' but re-render 'form a'
>
>
> {code}
>
> I have provided a sample app that shows the issue when MyFaces 2.3.1 is used.
> # Just deploy the app on Tomcat and drive a request to:
> [http://localhost:8080/JSF23Spec790/test1.xhtml]
> # Enter a text in input1 and click submit button next to the input. Check
> the rendered page.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MYFACES-4230) IE 11 an javascript error occured after rerender part of the page
[ https://issues.apache.org/jira/browse/MYFACES-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467148#comment-16467148 ] Werner Punz edited comment on MYFACES-4230 at 5/8/18 9:31 AM: -- Sure I will to it later this week. Reassigning the task to me. was (Author: werpu): Suew I will to it later this week. Reassigning the task to me. > IE 11 an javascript error occured after rerender part of the page > - > > Key: MYFACES-4230 > URL: https://issues.apache.org/jira/browse/MYFACES-4230 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0, 2.3.1 > Environment: MyFaces 2.3.1 >Reporter: Niels Borman >Priority: Critical > Fix For: 2.3.2 > > Attachments: Screen Shot 2018-05-08 at 09.15.36.png > > > In IE 11 we get an javascript error: > TypeError: Unable to get property 'indexOf' of undefined or null reference > > This error arises on linenumber 7451 of jsf.js. The element is in IE > undefined so the error is thrown. Can you please make the if statement so > that there is a check if name is not undefined. In other browsers the name > property is “” so the error doen’s occure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4230) IE 11 an javascript error occured after rerender part of the page
[ https://issues.apache.org/jira/browse/MYFACES-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467148#comment-16467148 ] Werner Punz commented on MYFACES-4230: -- Suew I will to it later this week. Reassigning the task to me. > IE 11 an javascript error occured after rerender part of the page > - > > Key: MYFACES-4230 > URL: https://issues.apache.org/jira/browse/MYFACES-4230 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0, 2.3.1 > Environment: MyFaces 2.3.1 >Reporter: Niels Borman >Priority: Critical > Fix For: 2.3.2 > > Attachments: Screen Shot 2018-05-08 at 09.15.36.png > > > In IE 11 we get an javascript error: > TypeError: Unable to get property 'indexOf' of undefined or null reference > > This error arises on linenumber 7451 of jsf.js. The element is in IE > undefined so the error is thrown. Can you please make the if statement so > that there is a check if name is not undefined. In other browsers the name > property is “” so the error doen’s occure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MYFACESTEST-72) MockExternalContext20 is missing the key 'httpOnly'
Sven created MYFACESTEST-72: --- Summary: MockExternalContext20 is missing the key 'httpOnly' Key: MYFACESTEST-72 URL: https://issues.apache.org/jira/browse/MYFACESTEST-72 Project: MyFaces Test Issue Type: Bug Components: Mock Objects Affects Versions: 1.0.8 Reporter: Sven The key 'httpOnly' from e.g. [https://github.com/omnifaces/omnifaces/blob/3.1/src/main/java/org/omnifaces/util/FacesLocal.java#L1238] is missing, giving the error message: Unused key when creating Cookie -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4230) IE 11 an javascript error occured after rerender part of the page
[ https://issues.apache.org/jira/browse/MYFACES-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467001#comment-16467001 ] Thomas Andraschko commented on MYFACES-4230: [~werpu] Could you check that? > IE 11 an javascript error occured after rerender part of the page > - > > Key: MYFACES-4230 > URL: https://issues.apache.org/jira/browse/MYFACES-4230 > Project: MyFaces Core > Issue Type: Bug > Environment: MyFaces 2.3.1 >Reporter: Niels Borman >Priority: Critical > Fix For: 2.3.2 > > Attachments: Screen Shot 2018-05-08 at 09.15.36.png > > > In IE 11 we get an javascript error: > TypeError: Unable to get property 'indexOf' of undefined or null reference > > This error arises on linenumber 7451 of jsf.js. The element is in IE > undefined so the error is thrown. Can you please make the if statement so > that there is a check if name is not undefined. In other browsers the name > property is “” so the error doen’s occure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MYFACES-4230) IE 11 an javascript error occured after rerender part of the page
Niels Borman created MYFACES-4230: - Summary: IE 11 an javascript error occured after rerender part of the page Key: MYFACES-4230 URL: https://issues.apache.org/jira/browse/MYFACES-4230 Project: MyFaces Core Issue Type: Bug Environment: MyFaces 2.3.1 Reporter: Niels Borman Attachments: Screen Shot 2018-05-08 at 09.15.36.png In IE 11 we get an javascript error: TypeError: Unable to get property 'indexOf' of undefined or null reference This error arises on linenumber 7451 of jsf.js. The element is in IE undefined so the error is thrown. Can you please make the if statement so that there is a check if name is not undefined. In other browsers the name property is “” so the error doen’s occure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
