[jira] [Commented] (TOBAGO-2016) Tobago2: allow svg resources

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/TOBAGO-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17011938#comment-17011938
 ] 

Hudson commented on TOBAGO-2016:


SUCCESS: Integrated in Jenkins build Tobago 2.x #1553 (See 
[https://builds.apache.org/job/Tobago%202.x/1553/])
TOBAGO-2016 - Tobago2: allow svg resources (v.weber: rev 
13a3011b92a0b8c26c20ca453b9fdf7cadf607ce)
* (edit) 
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/context/ResourceManagerImpl.java


> Tobago2: allow svg resources
> 
>
> Key: TOBAGO-2016
> URL: https://issues.apache.org/jira/browse/TOBAGO-2016
> Project: MyFaces Tobago
>  Issue Type: Improvement
>Affects Versions: 2.4.1
>Reporter: Volker Weber
>Assignee: Volker Weber
>Priority: Major
> Fix For: 2.5.0
>
>
> ResourceManager should allow *.svg Images



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [myfaces] volosied opened a new pull request #77: Myfaces 4311 Unit Tests

[GitBox]

volosied opened a new pull request #77: Myfaces 4311 Unit Tests
URL: https://github.com/apache/myfaces/pull/77
 
 
   Added two unit tests to ensure that the generic converter & validator work 
as expected.
   
   Please ignore EntityBean.java, I removed it in the second commit. 
   
   And let me know if there are any issues. Particularly, I'm not sure if I 
should implement testValidator another way.  I kept it simple with the try 
catch, but I can use some JUnit feature to expect a FacesException if 
recommended. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [myfaces] wtlucy commented on issue #77: Myfaces 4311 Unit Tests

[GitBox]

wtlucy commented on issue #77: Myfaces 4311 Unit Tests
URL: https://github.com/apache/myfaces/pull/77#issuecomment-572703463
 
 
   This looks good @volosied, thanks for circling back to add these tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [myfaces] wtlucy merged pull request #77: Myfaces 4311 Unit Tests

[GitBox]

wtlucy merged pull request #77: Myfaces 4311 Unit Tests
URL: https://github.com/apache/myfaces/pull/77
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [myfaces] wtlucy opened a new pull request #78: Myfaces 4311 unittest

[GitBox]

wtlucy opened a new pull request #78: Myfaces 4311 unittest
URL: https://github.com/apache/myfaces/pull/78
 
 
   Port of https://github.com/apache/myfaces/pull/77 for master


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [myfaces] wtlucy merged pull request #78: Myfaces 4311 unittest

[GitBox]

wtlucy merged pull request #78: Myfaces 4311 unittest
URL: https://github.com/apache/myfaces/pull/78
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Myfaces 2.3-next-M1 question

[Vicente Rossello]

Thanks, I confirm that it works setting org.apache.myfaces.SUPPORT_JSP =
false. I will deploy this build again.

On Tue, Jan 7, 2020 at 2:25 PM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> Should better for M2:
>
> https://github.com/apache/myfaces/commit/d2549787f085d9e58e778c682866bcda34b8f942
>
> https://issues.apache.org/jira/browse/MYFACES-4315
> 
>
> Am Di., 7. Jan. 2020 um 14:14 Uhr schrieb Thomas Andraschko <
> andraschko.tho...@gmail.com>:
>
>> I think setting
>> org.apache.myfaces.SUPPORT_JSP  = false
>> in web.xml
>> should fix it; we should make it the default actually
>>
>> Am Di., 7. Jan. 2020 um 14:09 Uhr schrieb Thomas Andraschko <
>> andraschko.tho...@gmail.com>:
>>
>>> and thanks for testing! every help is welcome :)
>>> i currently try to build the homepage for 2.3-next and after that
>>> publish the release mail and a blog about the changes
>>>
>>> Am Di., 7. Jan. 2020 um 14:03 Uhr schrieb Thomas Andraschko <
>>> andraschko.tho...@gmail.com>:
>>>
 Hi,

 can you post the stacktrace?


 Am Di., 7. Jan. 2020 um 13:59 Uhr schrieb Vicente Rossello <
 cocorosse...@gmail.com>:

> Hi,
>
> I was trying a  bit more myfaces next and I've noticed a behaviour
> change.
>
> If I call the URL http://localhost/somepagenotexists/  I get an error
> "java.lang.NoClassDefFoundError: javax/servlet/jsp/jstl/core/Config".
> With version 2.3.6 I get a 404 error.
>
> (notice the ending slash in the URL)
>
> Is it a bug?
>
> Thanks,
> Vicente.
>