[jira] [Created] (MYFACES-4486) TCK: Spec Issue 4313 failure
Paul Nicolucci created MYFACES-4486:
---
Summary: TCK: Spec Issue 4313 failure
Key: MYFACES-4486
URL: https://issues.apache.org/jira/browse/MYFACES-4486
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 4.0.0-RC1
Reporter: Paul Nicolucci
Assignee: Paul Nicolucci
The following TCK test fails for MyFaces:
[https://github.com/jakartaee/faces/blob/4.0.1/tck/faces23/validateWholeBean/src/test/java/ee/jakarta/tck/faces/test/javaee8/validateWholeBean/Issue4313IT.java#L81]
App:
[https://github.com/jakartaee/faces/blob/4.0.1/tck/faces23/validateWholeBean/src/main/webapp/Issue4313.xhtml]
The test is for the following specification issue:
[https://github.com/eclipse-ee4j/mojarra/issues/4313]
The following exception occurs:
{noformat}
jakarta.servlet.ServletException: jakarta.el.ELException: Cannot convert
[WholeBeanValidator] of type [class java.lang.String] to [class
ee.jakarta.tck.faces.test.javaee8.validateWholeBean.User]
at jakarta.faces.webapp.FacesServlet.service(FacesServlet.java:255)
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: Plan 4.0.0 RC2
Hi, Sorry for the delay. I will get started on a RC2 tomorrow (Oct 20th). Thanks, Volodymyr From: Werner Punz Date: Wednesday, October 19, 2022 at 2:28 AM To: MyFaces Development Subject: [EXTERNAL] Plan 4.0.0 RC2 Hi, I am wondering What are the release plans for 4. 0. 0 RC2? Any specific date already set? Or is it ready, when it´s ready? Werner ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd Hi, I am wondering What are the release plans for 4.0.0 RC2? Any specific date already set? Or is it ready, when it´s ready? Werner
[jira] [Resolved] (MYFACES-4477) TCK: Spec1581IT: Fix Programmatic Views in Faces 4.0 (Views Rendered via Java)
[ https://issues.apache.org/jira/browse/MYFACES-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Siedlecki resolved MYFACES-4477. -- Resolution: Fixed > TCK: Spec1581IT: Fix Programmatic Views in Faces 4.0 (Views Rendered via Java) > -- > > Key: MYFACES-4477 > URL: https://issues.apache.org/jira/browse/MYFACES-4477 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 4.0.0-RC1 >Reporter: Volodymyr Siedlecki >Assignee: Volodymyr Siedlecki >Priority: Major > > Spec Issue: [https://github.com/jakartaee/faces/issues/1581] > When running the TCK app, MyFaces produces a 404. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4477) TCK: Spec1581IT: Fix Programmatic Views in Faces 4.0 (Views Rendered via Java)
[ https://issues.apache.org/jira/browse/MYFACES-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620576#comment-17620576 ] Volodymyr Siedlecki commented on MYFACES-4477: -- I've undone the escaping changes, so it's the same as it was before. I will follow up with the TCK as I believe the tests are _incorrect_ ( default is assumed to not escape, but it should be the opposite. the test code itself should set escape=false on the UIOutput) > TCK: Spec1581IT: Fix Programmatic Views in Faces 4.0 (Views Rendered via Java) > -- > > Key: MYFACES-4477 > URL: https://issues.apache.org/jira/browse/MYFACES-4477 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 4.0.0-RC1 >Reporter: Volodymyr Siedlecki >Assignee: Volodymyr Siedlecki >Priority: Major > > Spec Issue: [https://github.com/jakartaee/faces/issues/1581] > When running the TCK app, MyFaces produces a 404. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [myfaces] volosied merged pull request #338: MYFACES-4477 Fix Programmatic Views
volosied merged PR #338: URL: https://github.com/apache/myfaces/pull/338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #338: MYFACES-4477 Fix Programmatic Views
volosied commented on PR #338: URL: https://github.com/apache/myfaces/pull/338#issuecomment-1284526273 ``` [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.25 s - in org.apache.myfaces.view.facelets.impl.ProgrammaticViewTest``` Addressed Thomas' comments. Merging code in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] volosied commented on a diff in pull request #338: MYFACES-4477 Fix Programmatic Views
volosied commented on code in PR #338:
URL: https://github.com/apache/myfaces/pull/338#discussion_r999894484
##
impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextRendererBase.java:
##
@@ -142,8 +142,8 @@ protected void renderOutput(FacesContext facesContext,
UIComponent component) th
}
else
{
-//default is to escape
-escape = AttributeUtils.getBooleanAttribute(component,
ComponentAttrs.ESCAPE_ATTR, true);
+//default is NOT to escape (Changed true -> false, Myfaces-4477)
+escape = AttributeUtils.getBooleanAttribute(component,
ComponentAttrs.ESCAPE_ATTR, false);
Review Comment:
I've removed the changes and updated the test to not escape the
elements.
I will bring this escaping issue up to the TCK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [myfaces] volosied commented on a diff in pull request #338: MYFACES-4477 Fix Programmatic Views
volosied commented on code in PR #338:
URL: https://github.com/apache/myfaces/pull/338#discussion_r999893060
##
impl/src/test/java/org/apache/myfaces/view/facelets/impl/ProgrammaticViewBean.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.view.facelets.impl;
+
+
+import static jakarta.faces.application.StateManager.IS_BUILDING_INITIAL_STATE;
+
+import java.io.IOException;
+import java.util.List;
+
+import jakarta.el.ELContext;
+import jakarta.el.ExpressionFactory;
+import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.faces.annotation.View;
+import jakarta.faces.component.UIComponent;
+import jakarta.faces.component.UIOutput;
+import jakarta.faces.component.html.HtmlBody;
+import jakarta.faces.component.html.HtmlOutputText;
+import jakarta.faces.context.FacesContext;
+import jakarta.faces.view.facelets.Facelet;
+
+/* Modelled off of corresponding TCK test */
+@View("/test.xhtml")
+@ApplicationScoped
+public class ProgrammaticViewBean extends Facelet {
+
+@Override
+public void apply(FacesContext facesContext, UIComponent root) throws
IOException {
+
+if
(!facesContext.getAttributes().containsKey(IS_BUILDING_INITIAL_STATE)) {
+return;
+}
+
+ComponentBuilder components = new ComponentBuilder(facesContext);
+ELContext elContext = facesContext.getELContext();
+ExpressionFactory expressionFactory =
facesContext.getApplication().getExpressionFactory();
+
+List rootChildren = root.getChildren();
+
+UIOutput output = new UIOutput();
+output.setValue("http://www.w3.org/1999/xhtml\;>");
+output.getAttributes().put("escape", false);
Review Comment:
manually setting escape to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MYFACES-4458) Quarkus Upgrade to 2.12
[ https://issues.apache.org/jira/browse/MYFACES-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620552#comment-17620552 ] Melloware commented on MYFACES-4458: for 2.3-NEXT? i would be ok with that! > Quarkus Upgrade to 2.12 > --- > > Key: MYFACES-4458 > URL: https://issues.apache.org/jira/browse/MYFACES-4458 > Project: MyFaces Core > Issue Type: Improvement > Components: Extension Feature >Affects Versions: 4.0.0-RC1 >Reporter: Melloware >Assignee: Melloware >Priority: Major > Fix For: 4.0.0-RC3 > > > Working on some Quarkus issues realized the whole environment still relied on > Quarkus 1.13 and would like to upgrade to 2.12 and update plugins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4458) Quarkus Upgrade to 2.12
[ https://issues.apache.org/jira/browse/MYFACES-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620505#comment-17620505 ] Thomas Andraschko commented on MYFACES-4458: Should we up to java11? +1 for it > Quarkus Upgrade to 2.12 > --- > > Key: MYFACES-4458 > URL: https://issues.apache.org/jira/browse/MYFACES-4458 > Project: MyFaces Core > Issue Type: Improvement > Components: Extension Feature >Affects Versions: 4.0.0-RC1 >Reporter: Melloware >Assignee: Melloware >Priority: Major > Fix For: 4.0.0-RC3 > > > Working on some Quarkus issues realized the whole environment still relied on > Quarkus 1.13 and would like to upgrade to 2.12 and update plugins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4458) Quarkus Upgrade to 2.12
[ https://issues.apache.org/jira/browse/MYFACES-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620493#comment-17620493 ] Melloware commented on MYFACES-4458: Can't be done for 2.3-NEXT because Quarkus 2.x requires JDK11 > Quarkus Upgrade to 2.12 > --- > > Key: MYFACES-4458 > URL: https://issues.apache.org/jira/browse/MYFACES-4458 > Project: MyFaces Core > Issue Type: Improvement > Components: Extension Feature >Affects Versions: 4.0.0-RC1 >Reporter: Melloware >Assignee: Melloware >Priority: Major > > Working on some Quarkus issues realized the whole environment still relied on > Quarkus 1.13 and would like to upgrade to 2.12 and update plugins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MYFACES-4458) Quarkus Upgrade to 2.12
[ https://issues.apache.org/jira/browse/MYFACES-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melloware resolved MYFACES-4458. Resolution: Fixed > Quarkus Upgrade to 2.12 > --- > > Key: MYFACES-4458 > URL: https://issues.apache.org/jira/browse/MYFACES-4458 > Project: MyFaces Core > Issue Type: Improvement > Components: Extension Feature >Affects Versions: 4.0.0-RC1 >Reporter: Melloware >Assignee: Melloware >Priority: Major > > Working on some Quarkus issues realized the whole environment still relied on > Quarkus 1.13 and would like to upgrade to 2.12 and update plugins. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [myfaces] melloware closed pull request #314: MYFACES-4458 for 2.3 next
melloware closed pull request #314: MYFACES-4458 for 2.3 next URL: https://github.com/apache/myfaces/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #314: MYFACES-4458 for 2.3 next
melloware commented on PR #314: URL: https://github.com/apache/myfaces/pull/314#issuecomment-1284406926 " JDK 11 is the minimal version to use Quarkus 2.0." So for 2.3-NEXT I can't bump to 2.X branch. Closing this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #3352: build(deps): bump dependency-check-maven from 7.2.1 to 7.3.0
dependabot[bot] opened a new pull request, #3352: URL: https://github.com/apache/myfaces-tobago/pull/3352 Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 7.2.1 to 7.3.0. Release notes Sourced from https://github.com/jeremylong/DependencyCheck/releases;>dependency-check-maven's releases. Version 7.3.0 Changes Fixed issue with the Maven plugin that caused concurrent modification exceptions (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935). Migrated from Jackson Afterburner to Blackbird (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4905;>#4905). Added an experimental Dart analyzer (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4869;>#4869). See the full listing of https://github.com/jeremylong/DependencyCheck/milestone/50?closed=1;>changes. Changelog Sourced from https://github.com/jeremylong/DependencyCheck/blob/main/RELEASE_NOTES.md;>dependency-check-maven's changelog. https://github.com/jeremylong/DependencyCheck/releases/tag/v7.3.0;>Version 7.3.0 (2022-10-19) Changes Fixed issue with the Maven plugin that caused concurrent modification exceptions (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935). Migrated from Jackson Afterburner to Blackbird (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4905;>#4905). Added an experimental Dart analyzer (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4869;>#4869). See the full listing of https://github.com/jeremylong/DependencyCheck/milestone/50?closed=1;>changes. Commits https://github.com/jeremylong/DependencyCheck/commit/978800526c25495c253325dd7b8027426751d4da;>9788005 [maven-release-plugin] prepare release v7.3.0 https://github.com/jeremylong/DependencyCheck/commit/5fed581289667f0510887f1aed28579b74fe8114;>5fed581 docs: prepare release https://github.com/jeremylong/DependencyCheck/commit/a4be3beb204246b2d508d730d00e609526fe3613;>a4be3be Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935 from jeremylong/concurrentModification_removeSingleton https://github.com/jeremylong/DependencyCheck/commit/b6e0b2896dfcd01480e3ee9c8aa414eac003d6fa;>b6e0b28 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4936;>#4936 from jeremylong/dependabot/github_actions/pnpm/actio... https://github.com/jeremylong/DependencyCheck/commit/4fcf04602be7cd21affdb09eb918758283e055c1;>4fcf046 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4929;>#4929 from jeremylong/dependabot/github_actions/actions/se... https://github.com/jeremylong/DependencyCheck/commit/909c72672dd5f88b8c7c8bc71bac13422ec65f6e;>909c726 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4928;>#4928 from jeremylong/dependabot/github_actions/actions/gi... https://github.com/jeremylong/DependencyCheck/commit/8868a4f052b93d0f9d4fa6d98726cd518ee979fb;>8868a4f Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4927;>#4927 from jeremylong/dependabot/github_actions/JamesIves/... https://github.com/jeremylong/DependencyCheck/commit/acfc3b041f960fd026377d34f890f8f39ceb4710;>acfc3b0 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4926;>#4926 from jeremylong/dependabot/github_actions/actions/se... https://github.com/jeremylong/DependencyCheck/commit/edaba8f89bc371e3f4c0546cc43ab94fb2b6fb27;>edaba8f fix: refactor to prevent concurrent modification exception https://github.com/jeremylong/DependencyCheck/commit/00ed239a4b52ec492cb8014fd637fc1e386c23c0;>00ed239 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4959;>#4959 from slieschke/fix-retirejs-documentation-404 Additional commits viewable in https://github.com/jeremylong/DependencyCheck/compare/v7.2.1...v7.3.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #3351: build(deps): bump dependency-check-maven from 7.2.1 to 7.3.0
dependabot[bot] opened a new pull request, #3351: URL: https://github.com/apache/myfaces-tobago/pull/3351 Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 7.2.1 to 7.3.0. Release notes Sourced from https://github.com/jeremylong/DependencyCheck/releases;>dependency-check-maven's releases. Version 7.3.0 Changes Fixed issue with the Maven plugin that caused concurrent modification exceptions (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935). Migrated from Jackson Afterburner to Blackbird (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4905;>#4905). Added an experimental Dart analyzer (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4869;>#4869). See the full listing of https://github.com/jeremylong/DependencyCheck/milestone/50?closed=1;>changes. Changelog Sourced from https://github.com/jeremylong/DependencyCheck/blob/main/RELEASE_NOTES.md;>dependency-check-maven's changelog. https://github.com/jeremylong/DependencyCheck/releases/tag/v7.3.0;>Version 7.3.0 (2022-10-19) Changes Fixed issue with the Maven plugin that caused concurrent modification exceptions (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935). Migrated from Jackson Afterburner to Blackbird (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4905;>#4905). Added an experimental Dart analyzer (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4869;>#4869). See the full listing of https://github.com/jeremylong/DependencyCheck/milestone/50?closed=1;>changes. Commits https://github.com/jeremylong/DependencyCheck/commit/978800526c25495c253325dd7b8027426751d4da;>9788005 [maven-release-plugin] prepare release v7.3.0 https://github.com/jeremylong/DependencyCheck/commit/5fed581289667f0510887f1aed28579b74fe8114;>5fed581 docs: prepare release https://github.com/jeremylong/DependencyCheck/commit/a4be3beb204246b2d508d730d00e609526fe3613;>a4be3be Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935 from jeremylong/concurrentModification_removeSingleton https://github.com/jeremylong/DependencyCheck/commit/b6e0b2896dfcd01480e3ee9c8aa414eac003d6fa;>b6e0b28 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4936;>#4936 from jeremylong/dependabot/github_actions/pnpm/actio... https://github.com/jeremylong/DependencyCheck/commit/4fcf04602be7cd21affdb09eb918758283e055c1;>4fcf046 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4929;>#4929 from jeremylong/dependabot/github_actions/actions/se... https://github.com/jeremylong/DependencyCheck/commit/909c72672dd5f88b8c7c8bc71bac13422ec65f6e;>909c726 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4928;>#4928 from jeremylong/dependabot/github_actions/actions/gi... https://github.com/jeremylong/DependencyCheck/commit/8868a4f052b93d0f9d4fa6d98726cd518ee979fb;>8868a4f Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4927;>#4927 from jeremylong/dependabot/github_actions/JamesIves/... https://github.com/jeremylong/DependencyCheck/commit/acfc3b041f960fd026377d34f890f8f39ceb4710;>acfc3b0 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4926;>#4926 from jeremylong/dependabot/github_actions/actions/se... https://github.com/jeremylong/DependencyCheck/commit/edaba8f89bc371e3f4c0546cc43ab94fb2b6fb27;>edaba8f fix: refactor to prevent concurrent modification exception https://github.com/jeremylong/DependencyCheck/commit/00ed239a4b52ec492cb8014fd637fc1e386c23c0;>00ed239 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4959;>#4959 from slieschke/fix-retirejs-documentation-404 Additional commits viewable in https://github.com/jeremylong/DependencyCheck/compare/v7.2.1...v7.3.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #3350: build(deps): bump dependency-check-maven from 7.2.1 to 7.3.0
dependabot[bot] opened a new pull request, #3350: URL: https://github.com/apache/myfaces-tobago/pull/3350 Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 7.2.1 to 7.3.0. Release notes Sourced from https://github.com/jeremylong/DependencyCheck/releases;>dependency-check-maven's releases. Version 7.3.0 Changes Fixed issue with the Maven plugin that caused concurrent modification exceptions (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935). Migrated from Jackson Afterburner to Blackbird (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4905;>#4905). Added an experimental Dart analyzer (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4869;>#4869). See the full listing of https://github.com/jeremylong/DependencyCheck/milestone/50?closed=1;>changes. Changelog Sourced from https://github.com/jeremylong/DependencyCheck/blob/main/RELEASE_NOTES.md;>dependency-check-maven's changelog. https://github.com/jeremylong/DependencyCheck/releases/tag/v7.3.0;>Version 7.3.0 (2022-10-19) Changes Fixed issue with the Maven plugin that caused concurrent modification exceptions (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935). Migrated from Jackson Afterburner to Blackbird (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4905;>#4905). Added an experimental Dart analyzer (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4869;>#4869). See the full listing of https://github.com/jeremylong/DependencyCheck/milestone/50?closed=1;>changes. Commits https://github.com/jeremylong/DependencyCheck/commit/978800526c25495c253325dd7b8027426751d4da;>9788005 [maven-release-plugin] prepare release v7.3.0 https://github.com/jeremylong/DependencyCheck/commit/5fed581289667f0510887f1aed28579b74fe8114;>5fed581 docs: prepare release https://github.com/jeremylong/DependencyCheck/commit/a4be3beb204246b2d508d730d00e609526fe3613;>a4be3be Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935 from jeremylong/concurrentModification_removeSingleton https://github.com/jeremylong/DependencyCheck/commit/b6e0b2896dfcd01480e3ee9c8aa414eac003d6fa;>b6e0b28 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4936;>#4936 from jeremylong/dependabot/github_actions/pnpm/actio... https://github.com/jeremylong/DependencyCheck/commit/4fcf04602be7cd21affdb09eb918758283e055c1;>4fcf046 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4929;>#4929 from jeremylong/dependabot/github_actions/actions/se... https://github.com/jeremylong/DependencyCheck/commit/909c72672dd5f88b8c7c8bc71bac13422ec65f6e;>909c726 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4928;>#4928 from jeremylong/dependabot/github_actions/actions/gi... https://github.com/jeremylong/DependencyCheck/commit/8868a4f052b93d0f9d4fa6d98726cd518ee979fb;>8868a4f Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4927;>#4927 from jeremylong/dependabot/github_actions/JamesIves/... https://github.com/jeremylong/DependencyCheck/commit/acfc3b041f960fd026377d34f890f8f39ceb4710;>acfc3b0 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4926;>#4926 from jeremylong/dependabot/github_actions/actions/se... https://github.com/jeremylong/DependencyCheck/commit/edaba8f89bc371e3f4c0546cc43ab94fb2b6fb27;>edaba8f fix: refactor to prevent concurrent modification exception https://github.com/jeremylong/DependencyCheck/commit/00ed239a4b52ec492cb8014fd637fc1e386c23c0;>00ed239 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4959;>#4959 from slieschke/fix-retirejs-documentation-404 Additional commits viewable in https://github.com/jeremylong/DependencyCheck/compare/v7.2.1...v7.3.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #3349: build(deps): bump dependency-check-maven from 7.2.1 to 7.3.0
dependabot[bot] opened a new pull request, #3349: URL: https://github.com/apache/myfaces-tobago/pull/3349 Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 7.2.1 to 7.3.0. Release notes Sourced from https://github.com/jeremylong/DependencyCheck/releases;>dependency-check-maven's releases. Version 7.3.0 Changes Fixed issue with the Maven plugin that caused concurrent modification exceptions (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935). Migrated from Jackson Afterburner to Blackbird (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4905;>#4905). Added an experimental Dart analyzer (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4869;>#4869). See the full listing of https://github.com/jeremylong/DependencyCheck/milestone/50?closed=1;>changes. Changelog Sourced from https://github.com/jeremylong/DependencyCheck/blob/main/RELEASE_NOTES.md;>dependency-check-maven's changelog. https://github.com/jeremylong/DependencyCheck/releases/tag/v7.3.0;>Version 7.3.0 (2022-10-19) Changes Fixed issue with the Maven plugin that caused concurrent modification exceptions (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935). Migrated from Jackson Afterburner to Blackbird (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4905;>#4905). Added an experimental Dart analyzer (https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4869;>#4869). See the full listing of https://github.com/jeremylong/DependencyCheck/milestone/50?closed=1;>changes. Commits https://github.com/jeremylong/DependencyCheck/commit/978800526c25495c253325dd7b8027426751d4da;>9788005 [maven-release-plugin] prepare release v7.3.0 https://github.com/jeremylong/DependencyCheck/commit/5fed581289667f0510887f1aed28579b74fe8114;>5fed581 docs: prepare release https://github.com/jeremylong/DependencyCheck/commit/a4be3beb204246b2d508d730d00e609526fe3613;>a4be3be Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4935;>#4935 from jeremylong/concurrentModification_removeSingleton https://github.com/jeremylong/DependencyCheck/commit/b6e0b2896dfcd01480e3ee9c8aa414eac003d6fa;>b6e0b28 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4936;>#4936 from jeremylong/dependabot/github_actions/pnpm/actio... https://github.com/jeremylong/DependencyCheck/commit/4fcf04602be7cd21affdb09eb918758283e055c1;>4fcf046 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4929;>#4929 from jeremylong/dependabot/github_actions/actions/se... https://github.com/jeremylong/DependencyCheck/commit/909c72672dd5f88b8c7c8bc71bac13422ec65f6e;>909c726 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4928;>#4928 from jeremylong/dependabot/github_actions/actions/gi... https://github.com/jeremylong/DependencyCheck/commit/8868a4f052b93d0f9d4fa6d98726cd518ee979fb;>8868a4f Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4927;>#4927 from jeremylong/dependabot/github_actions/JamesIves/... https://github.com/jeremylong/DependencyCheck/commit/acfc3b041f960fd026377d34f890f8f39ceb4710;>acfc3b0 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4926;>#4926 from jeremylong/dependabot/github_actions/actions/se... https://github.com/jeremylong/DependencyCheck/commit/edaba8f89bc371e3f4c0546cc43ab94fb2b6fb27;>edaba8f fix: refactor to prevent concurrent modification exception https://github.com/jeremylong/DependencyCheck/commit/00ed239a4b52ec492cb8014fd637fc1e386c23c0;>00ed239 Merge pull request https://github-redirect.dependabot.com/jeremylong/DependencyCheck/issues/4959;>#4959 from slieschke/fix-retirejs-documentation-404 Additional commits viewable in https://github.com/jeremylong/DependencyCheck/compare/v7.2.1...v7.3.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate
[GitHub] [myfaces] tandraschko commented on a diff in pull request #338: MYFACES-4477 Fix Programmatic Views
tandraschko commented on code in PR #338:
URL: https://github.com/apache/myfaces/pull/338#discussion_r999278095
##
impl/src/main/java/org/apache/myfaces/renderkit/html/base/HtmlTextRendererBase.java:
##
@@ -142,8 +142,8 @@ protected void renderOutput(FacesContext facesContext,
UIComponent component) th
}
else
{
-//default is to escape
-escape = AttributeUtils.getBooleanAttribute(component,
ComponentAttrs.ESCAPE_ATTR, true);
+//default is NOT to escape (Changed true -> false, Myfaces-4477)
+escape = AttributeUtils.getBooleanAttribute(component,
ComponentAttrs.ESCAPE_ATTR, false);
Review Comment:
isnt this a bug security flaw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (MYFACES-4445) "No CDI container started" when using PushContext async
[
https://issues.apache.org/jira/browse/MYFACES-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4445.
Resolution: Fixed
> "No CDI container started" when using PushContext async
> ---
>
> Key: MYFACES-4445
> URL: https://issues.apache.org/jira/browse/MYFACES-4445
> Project: MyFaces Core
> Issue Type: Task
> Components: General
>Affects Versions: 2.3-next-M7
>Reporter: Milan Siebenbürger
>Assignee: Thomas Andraschko
>Priority: Minor
> Fix For: 2.3.11, 3.0.3, 2.3-next-M8, 4.0.0-RC2
>
>
> Hello, we are trying to replace Omnifaces websockets (o:socket) with Myfaces
> implementation in our application and we are encountering some problems that
> prevent us from completing this task.
>
> 1. The most serious problem is that the MyFaces implementation does not work
> when using asynchronous computation (Future interface). Sending a push
> message ends with a "No CDI container started" exception, while the Omnifaces
> implementation works flawlessly.
> {code:java}
> java.lang.IllegalStateException: No CDI container started
> at
> org.apache.webbeans.container.OwbCDI.getWebBeansContext(OwbCDI.java:44)
> at org.apache.webbeans.container.OwbCDI.getBeanManager(OwbCDI.java:61)
> at
> org.apache.myfaces.push.cdi.PushContextImpl.send(PushContextImpl.java:64){code}
> Do you see any way to make this work, or do we have to stick with OmniFaces
> in this situation?
>
> 2. When using another type of push message, in response to a scheduler or jms
> message, sending the message works, but each time it is sent, this warning
> message is logged.
> {code:java}
> org.apache.webbeans.web.context.WebContextsService.lazyStartSessionContext
> Could NOT lazily initialize session context because NO active request
> context{code}
> The reason is this part of the code in PushContextImpl:
>
> {code:java}
> if (CDIUtils.isSessionScopeActive(beanManager)) {
> sessionTokenBean = (WebsocketSessionBean)CDIUtils.get(beanManager,
> WebsocketSessionBean.class, false, new Annotation[0]);
> if (CDIUtils.isViewScopeActive(beanManager)) {
> viewTokenBean = (WebsocketViewBean)CDIUtils.get(beanManager,
> WebsocketViewBean.class, false, new Annotation[0]);
> }
> }{code}
> Method isSessionScopeActive returns false (of course, because there is no
> session scope active in this case) - it fallbacks correctly to application
> scoped WebsocketApplicationBean, but this warning message is logged. Is there
> any way to get rid of this log - other than reconfiguring the logging
> framework?
> I have created a simple demonstration where you can see these problems. Just
> download it and run it on Apache Tomcat. ->
> https://github.com/milansie/websocket-demo
> I'd be grateful for any help or advice or, ideally, for a change in the
> MyFaces implementation.
>
> Thank you!
> Milan Siebenbürger
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [myfaces] tandraschko merged pull request #348: MYFACES-4445: websockets refactoring
tandraschko merged PR #348: URL: https://github.com/apache/myfaces/pull/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] tandraschko merged pull request #347: MYFACES-4445: websockets refactoring - close sessionScope fix
tandraschko merged PR #347: URL: https://github.com/apache/myfaces/pull/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1283777807 I will squash the commits at the final merge into master, the so the accidentally referenced myfaces-4456 commits will be squashed into one single big commit with a myfaces-4466 reference. Renaming atm is not possible anymore due to rebase problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)
werpu commented on PR #356: URL: https://github.com/apache/myfaces/pull/356#issuecomment-1283757935 @melloware I just had to rename the branch, I had accidentally added the wrong jira issue reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu opened a new pull request, #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)
werpu opened a new pull request, #356: URL: https://github.com/apache/myfaces/pull/356 hat to recreate the pull request because i had to rename the branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu closed pull request #325: Feature/myfaces 4456 - New faces.js codebase (target 4.0.0 RC3)
werpu closed pull request #325: Feature/myfaces 4456 - New faces.js codebase (target 4.0.0 RC3) URL: https://github.com/apache/myfaces/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MYFACES-4482) jsf.js and faces.js old codebase fails on my decorator integration test
[ https://issues.apache.org/jira/browse/MYFACES-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Punz resolved MYFACES-4482. -- Fix Version/s: 2.3-next-M8 4.0.0-RC3 Resolution: Fixed was a test issue > jsf.js and faces.js old codebase fails on my decorator integration test > --- > > Key: MYFACES-4482 > URL: https://issues.apache.org/jira/browse/MYFACES-4482 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 4.0.0-RC1 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Minor > Fix For: 2.3-next-M8, 4.0.0-RC3 > > > I have a set of integration tests which are currently hosted in a pull > request for 4.0 > While the tests pass for the new codebase entirely, for the old one they fail > on > test-12 decoration, which tests whether the decorated apis are called > correctly. > This could be an issue with the testcases, but more likely we have a small > bug in the old implementation which bypasses the api for one of the testcases > and calls the impl directly. > We had several bugs in this area in the past, when people started to decorate > the apis. Hence I wrote this test to begin with. > I will work on this issue on monday and get this fixed either in the test or > in the old soon to be legacy codebase. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Plan 4.0.0 RC2
Hi, I am wondering What are the release plans for 4.0.0 RC2? Any specific date already set? Or is it ready, when it´s ready? Werner
