[GitHub] [myfaces-tobago] henningn opened a new pull request, #3426: style(editorconfig): fix indent for java files

2022-11-17 Thread GitBox


henningn opened a new pull request, #3426:
URL: https://github.com/apache/myfaces-tobago/pull/3426

   The indent size for java files is mostly 2 spaces. But in some cases 
(linebreak in method header) it is 4 spaces. Therefore, a fixed indent size 
must not be applied to Java files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn opened a new pull request, #3427: style(editorconfig): fix indent for java files

2022-11-17 Thread GitBox


henningn opened a new pull request, #3427:
URL: https://github.com/apache/myfaces-tobago/pull/3427

   The indent size for java files is mostly 2 spaces. But in some cases 
(linebreak in method header) it is 4 spaces. Therefore, a fixed indent size 
must not be applied to Java files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn merged pull request #3426: style(editorconfig): fix indent for java files

2022-11-17 Thread GitBox


henningn merged PR #3426:
URL: https://github.com/apache/myfaces-tobago/pull/3426


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] henningn merged pull request #3427: style(editorconfig): fix indent for java files

2022-11-17 Thread GitBox


henningn merged PR #3427:
URL: https://github.com/apache/myfaces-tobago/pull/3427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces] tandraschko commented on pull request #385: MYFACES-4425: Save ui input state in repeat

2022-11-17 Thread GitBox


tandraschko commented on PR #385:
URL: https://github.com/apache/myfaces/pull/385#issuecomment-1318517652

   IMO we should not make it per default
   we didnt had any user since 10 years which requires this
   
   can someone start a dicussion with mojarra team?
   
   otherwise i would introduce a webcontext param


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces] tandraschko commented on pull request #354: MYFACES-4469: Fix IllegalArgumentException by retrieving wrapped factory

2022-11-17 Thread GitBox


tandraschko commented on PR #354:
URL: https://github.com/apache/myfaces/pull/354#issuecomment-1318522154

   i dont understand the case exactly but when it works and doesnt break 
something else -> +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] github-code-scanning[bot] commented on a diff in pull request #3428: Tobago 5 optimize editorconfig

2022-11-17 Thread GitBox


github-code-scanning[bot] commented on code in PR #3428:
URL: https://github.com/apache/myfaces-tobago/pull/3428#discussion_r1025158122


##
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIPage.java:
##
@@ -100,7 +100,7 @@
 // TODO: This workaround is stil needed for Mojarra
 // TODO: Otherwise actions in tree/sheet will not be detected
 if (command == null
-  && sourceId != null && sourceId.matches(".*:\\d+:.*")) {
+&& sourceId != null && sourceId.matches(".*:\\d+:.*")) {

Review Comment:
   ## Polynomial regular expression used on uncontrolled data
   
   This [regular expression](1) that depends on a [user-provided value](2) may 
run slow on strings starting with ':9:' and with many repetitions of ':9:'.
   
   [Show more 
details](https://github.com/apache/myfaces-tobago/security/code-scanning/38)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces] werpu commented on pull request #356: Feature/myfaces 4466 faces.js reimplementation (target 4.0.0 RC3)

2022-11-17 Thread GitBox


werpu commented on PR #356:
URL: https://github.com/apache/myfaces/pull/356#issuecomment-1318783645

   Hi short update, I got the two tck bugs in, have not had time to fix them 
today, I will fix them probably tomorrow. As I am busy atm porting the TCK 
tests to Webdriver. I have now about 50% of the mojarra JSF 2.2 TCK tests 
ported and have solved all missing pieces which HTMLUnit had but webdriver does 
not (aka request response data is not exposed by WebDriver, but you can solve 
it over the Chrome debugging engine) 
   So I am making good progress, to get the TCKs updated. I probably will have 
a pull request on the jakarta side ready sometime next week.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces] volosied commented on pull request #385: MYFACES-4425: Save ui input state in repeat

2022-11-17 Thread GitBox


volosied commented on PR #385:
URL: https://github.com/apache/myfaces/pull/385#issuecomment-1318821908

   Hey Thomas, I see you had commented in the original issue here: 
https://github.com/eclipse-ee4j/mojarra/issues/4957#issuecomment-996785168 
   
   You mentioned the viewstate size might be an issue here (and the fact this 
behavior isn't strictly necessary)?  As this test is part of the TCK, (1) we'll 
have to challenge it or (2) at least enable this behavior by default with an 
web parameter to turn it off.  
   
   Perhaps might could create a challenge as I'm not sure all of the concerns 
here and since you were involved in the original issue? Otherwise, I would 
prefer to go with option 2.  
   
   Let know how you'd like to proceed. Thanks! 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MYFACES-4497) In h:inputTextArea comments are shown as value

2022-11-17 Thread Melloware (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635424#comment-17635424
 ] 

Melloware commented on MYFACES-4497:


I know this doesn't fix it but don't you want this in your web.xml?  You 
shouldn't want comments ever rendered in your HTML right?
{code:java}
    
        javax.faces..FACELETS_SKIP_COMMENTS
        true
    {code}

> In h:inputTextArea comments are shown as value
> --
>
> Key: MYFACES-4497
> URL: https://issues.apache.org/jira/browse/MYFACES-4497
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 2.3-next-M7
>Reporter: Vitaly Sidorov
>Priority: Major
>
> Problem:
> If the composite component has an h:inputTextArea inside which there is a 
> comment, then this comment will be displayed in html as the value of the 
> component.
> Playback:
> 1. We have a composite component
>  
> {code:java}
> 
> http://www.w3.org/1999/xhtml";
>       xmlns:h="http://xmlns.jcp.org/jsf/html";
>       xmlns:composite="http://xmlns.jcp.org/jsf/composite";>
>                       shortDescription="test">
> 
> 
>                           rows="5"
>                      cols="8"
>                      value="#{testBean.testInfo}">
>         
>     
> 
> 
> {code}
>  
> 2. Rendered html
> {code:java}
>  
> {code}
> Comment:
> in version 2.3-next-M6 - the comment is rendered before the textarea (not 
> inside).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4497) In h:inputTextArea comments are shown as value

2022-11-17 Thread Melloware (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635424#comment-17635424
 ] 

Melloware edited comment on MYFACES-4497 at 11/17/22 4:02 PM:
--

I know this doesn't fix it but don't you want this in your web.xml?  You 
shouldn't want comments ever rendered in your HTML right?
{code:java}
    
        javax.faces.FACELETS_SKIP_COMMENTS
        true
    {code}


was (Author: melloware):
I know this doesn't fix it but don't you want this in your web.xml?  You 
shouldn't want comments ever rendered in your HTML right?
{code:java}
    
        javax.faces..FACELETS_SKIP_COMMENTS
        true
    {code}

> In h:inputTextArea comments are shown as value
> --
>
> Key: MYFACES-4497
> URL: https://issues.apache.org/jira/browse/MYFACES-4497
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 2.3-next-M7
>Reporter: Vitaly Sidorov
>Priority: Major
>
> Problem:
> If the composite component has an h:inputTextArea inside which there is a 
> comment, then this comment will be displayed in html as the value of the 
> component.
> Playback:
> 1. We have a composite component
>  
> {code:java}
> 
> http://www.w3.org/1999/xhtml";
>       xmlns:h="http://xmlns.jcp.org/jsf/html";
>       xmlns:composite="http://xmlns.jcp.org/jsf/composite";>
>                       shortDescription="test">
> 
> 
>                           rows="5"
>                      cols="8"
>                      value="#{testBean.testInfo}">
>         
>     
> 
> 
> {code}
>  
> 2. Rendered html
> {code:java}
>  
> {code}
> Comment:
> in version 2.3-next-M6 - the comment is rendered before the textarea (not 
> inside).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4499) TCK: Issue3020IT: testDelayNegative Fails

2022-11-17 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635425#comment-17635425
 ] 

Werner Punz commented on MYFACES-4499:
--

I have to postpone both fixes until tomorrow, because I was busy with porting 
the TCK, my preference would be anyway, to get this fixed when I have the TCKs 
fully ported to Selenium (which should be sometime next week). Does anyone have 
objections, or can we wait with the fixes until then?
Then I can run a full TCK ajax test against the new codebase anyway (and 
against the old one)


> TCK: Issue3020IT: testDelayNegative Fails
> -
>
> Key: MYFACES-4499
> URL: https://issues.apache.org/jira/browse/MYFACES-4499
> Project: MyFaces Core
>  Issue Type: Bug
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> App Code: 
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue3020Negative.xhtml#L35]
>  
> Unit Test: 
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue3020IT.java#L49-L54]
>  
> The test verifies that a delay on the f:ajax is a valid input.  The test uses 
> "NaN" and the implementation is expected to throw an exception to stop the 
> request from occurring. 
> Our RC2 code appears to be here: 
> [https://github.com/apache/myfaces/blob/89c747e85615e3f33265e664c8361789f38ea7db/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/Impl.js#L311-L314]
> I've attached the TCK application (with Mojarra) to this issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MYFACES-4503) TCK: Application.getExpressionFactory should return ELManager.getExpressionFactory()

2022-11-17 Thread Paul Nicolucci (Jira)
Paul Nicolucci created MYFACES-4503:
---

 Summary: TCK: Application.getExpressionFactory should return 
ELManager.getExpressionFactory()
 Key: MYFACES-4503
 URL: https://issues.apache.org/jira/browse/MYFACES-4503
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 4.0.0-RC2
Reporter: Paul Nicolucci
Assignee: Paul Nicolucci


[Application.getExpressionFactory() 
|[https://jakarta.ee/specifications/faces/4.0/apidocs/jakarta/faces/application/application#getExpressionFactory()]]
 states the following for Faces 4.0:
{noformat}
The implementation must return the ExpressionFactory from the Expression 
Language container by calling jakarta.el.ELManager.getExpressionFactory().
 {noformat}
Previous to Faces 4.0, for instance Faces 3.0 the same 
[Application.getExpressionFactory() 
|[https://jakarta.ee/specifications/faces/3.0/apidocs/jakarta/faces/application/application#getExpressionFactory()]]states
 the following:
{noformat}
The implementation must return the ExpressionFactory from the Jakarta Server 
Pages container by calling
 
JspFactory.getDefaultFactory().getJspApplicationContext(servletContext).getExpressionFactory().
 {noformat}
Currently, for Faces 4.0 our behavior is incorrect and it needs to be changed 
to leverage the ELManager API.

For reference there is a [TCK 
Challenge|[https://github.com/jakartaee/faces/issues/1718]] relating to this 
behavior.

 

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4499) TCK: Issue3020IT: testDelayNegative Fails

2022-11-17 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635591#comment-17635591
 ] 

Volodymyr Siedlecki commented on MYFACES-4499:
--

No worries. These can be addressed later.  Thanks again for all your help!

> TCK: Issue3020IT: testDelayNegative Fails
> -
>
> Key: MYFACES-4499
> URL: https://issues.apache.org/jira/browse/MYFACES-4499
> Project: MyFaces Core
>  Issue Type: Bug
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> App Code: 
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue3020Negative.xhtml#L35]
>  
> Unit Test: 
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue3020IT.java#L49-L54]
>  
> The test verifies that a delay on the f:ajax is a valid input.  The test uses 
> "NaN" and the implementation is expected to throw an exception to stop the 
> request from occurring. 
> Our RC2 code appears to be here: 
> [https://github.com/apache/myfaces/blob/89c747e85615e3f33265e664c8361789f38ea7db/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/Impl.js#L311-L314]
> I've attached the TCK application (with Mojarra) to this issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call

2022-11-17 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635592#comment-17635592
 ] 

Volodymyr Siedlecki commented on MYFACES-4498:
--

If I recall, I saw the same behavior on both the older and newer codebases.

> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
> 
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code: 
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>  
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue 
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces 
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML: 
> {code:java}
> 
> 
>
>   
>  
>   
>   
>  
>   
>
>  {code}
> The HTML is then set as : 
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
>   @import 
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
> 
>  {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL? 
> Should that occur?  The JavaScript in issue4345result.xhtml specifically 
> looks for a link element. 
> 2) The script tags *are not appended* to the head element, but I do see 
> network requests for them. Additionally, the scripts do run (confirmed by the 
> console: "issue4345.js loaded." ). 
> This fails on both the RC2 scripts and the new TypeScript code. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call

2022-11-17 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635675#comment-17635675
 ] 

Werner Punz edited comment on MYFACES-4498 at 11/18/22 6:17 AM:


Yes.. I was too vague, sorry for that, I meant did you run the TCK against the 
new codebase, I just was wondering, because the TCK is using HTMLUnit and by my 
testing and knowledge it should not work against the new codebase. I guess you 
just replicated the testcase into the new codebase and examined the dom, right?

And yes the new codebase has exactly the same behavior it removes the script 
elements after a short eval period.
Again a mild bug, more a deviation from what is expected.



was (Author: werpu):
Yes.. I was too vague, I meant did you run the TCK against the new codebase, I 
just was wondering, because the TCK is using HTMLUnit and by my testing and 
knowledge it should not work against the new codebase.

And yes the new codebase has exactly the same behavior it removes the script 
elements after a short eval period.
Again a mild bug, more a deviation from what is expected.


> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
> 
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code: 
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>  
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue 
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces 
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML: 
> {code:java}
> 
> 
>
>   
>  
>   
>   
>  
>   
>
>  {code}
> The HTML is then set as : 
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
>   @import 
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
> 
>  {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL? 
> Should that occur?  The JavaScript in issue4345result.xhtml specifically 
> looks for a link element. 
> 2) The script tags *are not appended* to the head element, but I do see 
> network requests for them. Additionally, the scripts do run (confirmed by the 
> console: "issue4345.js loaded." ). 
> This fails on both the RC2 scripts and the new TypeScript code. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call

2022-11-17 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635675#comment-17635675
 ] 

Werner Punz commented on MYFACES-4498:
--

Yes.. I was too vague, I meant did you run the TCK against the new codebase, I 
just was wondering, because the TCK is using HTMLUnit and by my testing and 
knowledge it should not work against the new codebase.

And yes the new codebase has exactly the same behavior it removes the script 
elements after a short eval period.
Again a mild bug, more a deviation from what is expected.


> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
> 
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code: 
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>  
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue 
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces 
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML: 
> {code:java}
> 
> 
>
>   
>  
>   
>   
>  
>   
>
>  {code}
> The HTML is then set as : 
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
>   @import 
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
> 
>  {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL? 
> Should that occur?  The JavaScript in issue4345result.xhtml specifically 
> looks for a link element. 
> 2) The script tags *are not appended* to the head element, but I do see 
> network requests for them. Additionally, the scripts do run (confirmed by the 
> console: "issue4345.js loaded." ). 
> This fails on both the RC2 scripts and the new TypeScript code. 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3425: build(deps): bump dependency-check-maven from 7.3.0 to 7.3.1

2022-11-17 Thread GitBox


lofwyr14 merged PR #3425:
URL: https://github.com/apache/myfaces-tobago/pull/3425


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3419: build(deps): bump dependency-check-maven from 7.3.0 to 7.3.1

2022-11-17 Thread GitBox


lofwyr14 merged PR #3419:
URL: https://github.com/apache/myfaces-tobago/pull/3419


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3424: build(deps): bump dependency-check-maven from 7.3.0 to 7.3.1

2022-11-17 Thread GitBox


lofwyr14 merged PR #3424:
URL: https://github.com/apache/myfaces-tobago/pull/3424


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3422: build(deps): bump dependency-check-maven from 7.3.0 to 7.3.1

2022-11-17 Thread GitBox


lofwyr14 merged PR #3422:
URL: https://github.com/apache/myfaces-tobago/pull/3422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3421: build(deps): bump jakarta.faces from 3.0.2 to 3.0.3

2022-11-17 Thread GitBox


lofwyr14 merged PR #3421:
URL: https://github.com/apache/myfaces-tobago/pull/3421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org