[GitHub] [myfaces-tobago] henningn merged pull request #3455: docs: tomee + liberty
henningn merged PR #3455: URL: https://github.com/apache/myfaces-tobago/pull/3455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #3454: docs: tomee + liberty
henningn merged PR #3454: URL: https://github.com/apache/myfaces-tobago/pull/3454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn opened a new pull request, #3455: docs: tomee + liberty
henningn opened a new pull request, #3455: URL: https://github.com/apache/myfaces-tobago/pull/3455 Add description how to start the demo in TomEE or in open-liberty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn opened a new pull request, #3454: docs: tomee + liberty
henningn opened a new pull request, #3454: URL: https://github.com/apache/myfaces-tobago/pull/3454 Add description how to start the demo in TomEE or in open-liberty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3453: fix: activate fix for liberty
lofwyr14 merged PR #3453: URL: https://github.com/apache/myfaces-tobago/pull/3453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 opened a new pull request, #3453: fix: activate fix for liberty
lofwyr14 opened a new pull request, #3453: URL: https://github.com/apache/myfaces-tobago/pull/3453 issue: TOBAGO-2171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3452: fix: activate fix for liberty
lofwyr14 merged PR #3452: URL: https://github.com/apache/myfaces-tobago/pull/3452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 opened a new pull request, #3452: fix: activate fix for liberty
lofwyr14 opened a new pull request, #3452: URL: https://github.com/apache/myfaces-tobago/pull/3452 issue: TOBAGO-2171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3450: Tobago 5.x demo textarea
lofwyr14 merged PR #3450: URL: https://github.com/apache/myfaces-tobago/pull/3450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3451: demo(textarea): use model
lofwyr14 merged PR #3451: URL: https://github.com/apache/myfaces-tobago/pull/3451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3449: demo(textarea): use model
lofwyr14 merged PR #3449: URL: https://github.com/apache/myfaces-tobago/pull/3449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 closed pull request #3448: Tobago 5.x fix tobago 2171
lofwyr14 closed pull request #3448: Tobago 5.x fix tobago 2171 URL: https://github.com/apache/myfaces-tobago/pull/3448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3447: build(deps): bump logback.version from 1.4.4 to 1.4.5
lofwyr14 merged PR #3447: URL: https://github.com/apache/myfaces-tobago/pull/3447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] dependabot[bot] opened a new pull request, #3447: build(deps): bump logback.version from 1.4.4 to 1.4.5
dependabot[bot] opened a new pull request, #3447: URL: https://github.com/apache/myfaces-tobago/pull/3447 Bumps `logback.version` from 1.4.4 to 1.4.5. Updates `logback-classic` from 1.4.4 to 1.4.5 Commits https://github.com/qos-ch/logback/commit/34a6efc53416709b0f47701e9e7099531cb8b256";>34a6efc preparfe release 1.4.5 https://github.com/qos-ch/logback/commit/0d3ac63114cf1ed2416aca285e96daa71a22ccb7";>0d3ac63 fix LOGBACK-1698, [Nested appenders are not allowed] warning using SiftingApp... https://github.com/qos-ch/logback/commit/a64b8d43b497a39171253a7c7a67d7638b9f29cf";>a64b8d4 make jakarta.servlet-api as both provided and optional https://github.com/qos-ch/logback/commit/114b3ded2dcbfec9dcf2d69d871297f5ac0ed673";>114b3de bump slf4j version https://github.com/qos-ch/logback/commit/1df66621e441e668816414fa21ea5942e5d92c43";>1df6662 fix LOGBACK-1706 https://github.com/qos-ch/logback/commit/ea165fb023f55aec48d3051b817105a69e881eb9";>ea165fb fix LOGBACK-1703 https://github.com/qos-ch/logback/commit/9e07bd075abb3261ccb50f73f46c714a63506473";>9e07bd0 fix LOGBACK-1703 https://github.com/qos-ch/logback/commit/a871e9f1b52e49ebe2ca002a476062b85207fc9c";>a871e9f minor edits in README.md https://github.com/qos-ch/logback/commit/7dc0ce51185f4c887ae50f87f7530a1f89d339aa";>7dc0ce5 Merge pull request https://github-redirect.dependabot.com/qos-ch/logback/issues/605";>#605 from Zardoz89/patch-1 https://github.com/qos-ch/logback/commit/7130dfe3a45816b073fbe6a4d05b7ee47f2d6cd1";>7130dfe README.md MUST inform about Java & Jackarta EE support Additional commits viewable in https://github.com/qos-ch/logback/compare/v_1.4.4...v_1.4.5";>compare view Updates `logback-core` from 1.4.4 to 1.4.5 Commits https://github.com/qos-ch/logback/commit/34a6efc53416709b0f47701e9e7099531cb8b256";>34a6efc preparfe release 1.4.5 https://github.com/qos-ch/logback/commit/0d3ac63114cf1ed2416aca285e96daa71a22ccb7";>0d3ac63 fix LOGBACK-1698, [Nested appenders are not allowed] warning using SiftingApp... https://github.com/qos-ch/logback/commit/a64b8d43b497a39171253a7c7a67d7638b9f29cf";>a64b8d4 make jakarta.servlet-api as both provided and optional https://github.com/qos-ch/logback/commit/114b3ded2dcbfec9dcf2d69d871297f5ac0ed673";>114b3de bump slf4j version https://github.com/qos-ch/logback/commit/1df66621e441e668816414fa21ea5942e5d92c43";>1df6662 fix LOGBACK-1706 https://github.com/qos-ch/logback/commit/ea165fb023f55aec48d3051b817105a69e881eb9";>ea165fb fix LOGBACK-1703 https://github.com/qos-ch/logback/commit/9e07bd075abb3261ccb50f73f46c714a63506473";>9e07bd0 fix LOGBACK-1703 https://github.com/qos-ch/logback/commit/a871e9f1b52e49ebe2ca002a476062b85207fc9c";>a871e9f minor edits in README.md https://github.com/qos-ch/logback/commit/7dc0ce51185f4c887ae50f87f7530a1f89d339aa";>7dc0ce5 Merge pull request https://github-redirect.dependabot.com/qos-ch/logback/issues/605";>#605 from Zardoz89/patch-1 https://github.com/qos-ch/logback/commit/7130dfe3a45816b073fbe6a4d05b7ee47f2d6cd1";>7130dfe README.md MUST inform about Java & Jackarta EE support Additional commits viewable in https://github.com/qos-ch/logback/compare/v_1.4.4...v_1.4.5";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637841#comment-17637841
]
Werner Punz commented on MYFACES-4498:
--
Added a unit test for a more complex case as well
{code:xml}
{code:java}
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637841#comment-17637841
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:43 PM:
Added a unit test for a more complex case as well
{code:xml}
{code}
was (Author: werpu):
Added a unit test for a more complex case as well
{code:xml}
{code:java}
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:42 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637838#comment-17637838
]
Werner Punz commented on MYFACES-4498:
--
Found the second issue.
The way we handle the head replace simply was false... we basically left the
head intact and only evaluated the scripts.
The correct fix is to replace all elements on dom level. (I still do the
deferred eval though, but with sticky scripts!)
This is an issue which has spilled over from the old codebase.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:05 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:04 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:04 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:04 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:04 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:03 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:03 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:03 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:02 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no escript lements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no escript lements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:02 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no script elements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no escript lements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:01 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// failing now, no escript lements in the html head after respond!!!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// Failing here!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 3:00 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
// Failing here!
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 2:59 PM:
Error is reproducible with following unit test
{code}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:typescript}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 2:59 PM:
Error is reproducible with following unit test
{code}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 2:59 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 2:59 PM:
Error is reproducible with following unit test
{code:java}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
{code}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 2:58 PM:
Error is reproducible with following unit test
{code:typescript}
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
{code}
was (Author: werpu):
Error is reproducible with following unit test
```typescript
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
```
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637817#comment-17637817
]
Werner Punz commented on MYFACES-4498:
--
Error is reproducible with following unit test
```typescript
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
```
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637706#comment-17637706
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 1:48 PM:
The link style change is a bug in our codebase... will be fixed
The script disappearing already documented above.
I will fix it for the new codebase first where I can set dedicated unit tests
for this case and then fix it
for our old codebase if requested/needed.
Reedit:
The Link stylesheet bug is a bug in the mona-dish codebase very likely carried
over from the old myfaces codebas where this transformation was needed to apply
styles in IE6 as far as I recall, but definitely obsolete now!
Not having the script elements being sticky in a head replace is clearly a bug,
I already have the sticky flag in the codebase for script evaluation, it very
likely is not used for this case.
was (Author: werpu):
The link style change is a bug in our codebase... will be fixed
The script disappearing already documented above.
I will fix it for the new codebase first where I can set dedicated unit tests
for this case and then fix it
for our old codebase if requested/needed.
Reedit:
The Link stylesheet bug is a bug in the mona-dish codebase very likely carried
over from the old myfaces codebas where this transformation was needed to apply
styles in IE6!
Not having the script elements being sticky in a head replace is clearly a bug,
I already have the sticky flag in the codebase for script evaluation, it very
likely is not used for this case.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637706#comment-17637706
]
Werner Punz edited comment on MYFACES-4498 at 11/23/22 1:47 PM:
The link style change is a bug in our codebase... will be fixed
The script disappearing already documented above.
I will fix it for the new codebase first where I can set dedicated unit tests
for this case and then fix it
for our old codebase if requested/needed.
Reedit:
The Link stylesheet bug is a bug in the mona-dish codebase very likely carried
over from the old myfaces codebas where this transformation was needed to apply
styles in IE6!
Not having the script elements being sticky in a head replace is clearly a bug,
I already have the sticky flag in the codebase for script evaluation, it very
likely is not used for this case.
was (Author: werpu):
The link style change is a bug in our codebase... will be fixed
The script disappearing already documented above.
I will fix it for the new codebase first where I can set dedicated unit tests
for this case and then fix it
for our old codebase if requested/needed.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TOBAGO-2171) Newlines vanished in tc:textarea
[
https://issues.apache.org/jira/browse/TOBAGO-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637744#comment-17637744
]
Udo Schnurpfeil commented on TOBAGO-2171:
-
Is a IBM issue:
https://www.ibm.com/support/pages/apar/PI57951
Fix can be activated in server.xml with
{code}
{code}
> Newlines vanished in tc:textarea
>
>
> Key: TOBAGO-2171
> URL: https://issues.apache.org/jira/browse/TOBAGO-2171
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 5.3.0
>Reporter: Henning Nöth
>Assignee: Udo Schnurpfeil
>Priority: Major
>
> Newlines may vanish in tc:textarea if:
> * open-liberty is used
> * a tc:file is on the page
> Example:
> Textarea has the text:
> "qwe
> asdf". The button is clicked. the value text1 in the textareaController has
> the value "qweasdf".
> {code:xml}
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [myfaces] melloware merged pull request #389: MYFACES-4507: Create contextual storage if it doesn't exist for flow
melloware merged PR #389: URL: https://github.com/apache/myfaces/pull/389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637706#comment-17637706
]
Werner Punz commented on MYFACES-4498:
--
The link style change is a bug in our codebase... will be fixed
The script disappearing already documented above.
I will fix it for the new codebase first where I can set dedicated unit tests
for this case and then fix it
for our old codebase if requested/needed.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637704#comment-17637704
]
Werner Punz commented on MYFACES-4498:
--
Taking over this now, should the fix also go into 2.3 Next?
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml";>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4499) TCK: Issue3020IT: testDelayNegative Fails
[ https://issues.apache.org/jira/browse/MYFACES-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637703#comment-17637703 ] Werner Punz commented on MYFACES-4499: -- Fixed for 2.3 Next, Master and our new codebase! > TCK: Issue3020IT: testDelayNegative Fails > - > > Key: MYFACES-4499 > URL: https://issues.apache.org/jira/browse/MYFACES-4499 > Project: MyFaces Core > Issue Type: Bug >Reporter: Volodymyr Siedlecki >Assignee: Werner Punz >Priority: Major > Fix For: 2.3-next-M8, 4.0.0-RC3 > > Attachments: test-faces22-ajax.war > > > App Code: > [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue3020Negative.xhtml#L35] > > Unit Test: > [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue3020IT.java#L49-L54] > > The test verifies that a delay on the f:ajax is a valid input. The test uses > "NaN" and the implementation is expected to throw an exception to stop the > request from occurring. > Our RC2 code appears to be here: > [https://github.com/apache/myfaces/blob/89c747e85615e3f33265e664c8361789f38ea7db/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/Impl.js#L311-L314] > I've attached the TCK application (with Mojarra) to this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MYFACES-4499) TCK: Issue3020IT: testDelayNegative Fails
[ https://issues.apache.org/jira/browse/MYFACES-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Punz resolved MYFACES-4499. -- Fix Version/s: 2.3-next-M8 4.0.0-RC3 Resolution: Fixed > TCK: Issue3020IT: testDelayNegative Fails > - > > Key: MYFACES-4499 > URL: https://issues.apache.org/jira/browse/MYFACES-4499 > Project: MyFaces Core > Issue Type: Bug >Reporter: Volodymyr Siedlecki >Assignee: Werner Punz >Priority: Major > Fix For: 2.3-next-M8, 4.0.0-RC3 > > Attachments: test-faces22-ajax.war > > > App Code: > [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue3020Negative.xhtml#L35] > > Unit Test: > [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue3020IT.java#L49-L54] > > The test verifies that a delay on the f:ajax is a valid input. The test uses > "NaN" and the implementation is expected to throw an exception to stop the > request from occurring. > Our RC2 code appears to be here: > [https://github.com/apache/myfaces/blob/89c747e85615e3f33265e664c8361789f38ea7db/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/Impl.js#L311-L314] > I've attached the TCK application (with Mojarra) to this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [myfaces] werpu merged pull request #392: https://issues.apache.org/jira/browse/MYFACES-4499: Fix from
werpu merged PR #392: URL: https://github.com/apache/myfaces/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu opened a new pull request, #392: https://issues.apache.org/jira/browse/MYFACES-4499: Fix from
werpu opened a new pull request, #392: URL: https://github.com/apache/myfaces/pull/392 2.3 Brach - cherry picked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu merged pull request #391: https://issues.apache.org/jira/browse/MYFACES-4499: fixing NaN and ot…
werpu merged PR #391: URL: https://github.com/apache/myfaces/pull/391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu opened a new pull request, #391: https://issues.apache.org/jira/browse/MYFACES-4499: fixing NaN and ot…
werpu opened a new pull request, #391: URL: https://github.com/apache/myfaces/pull/391 MYFACES-4499: Fix for 2.3 Next -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3398: build(deps): bump tomee-maven-plugin from 9.0.0-M8 to 9.0.0.RC1
lofwyr14 merged PR #3398: URL: https://github.com/apache/myfaces-tobago/pull/3398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3434: build(deps): bump dependency-check-maven from 7.3.1 to 7.3.2
lofwyr14 merged PR #3434: URL: https://github.com/apache/myfaces-tobago/pull/3434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3437: build(deps): bump dependency-check-maven from 7.3.1 to 7.3.2
lofwyr14 merged PR #3437: URL: https://github.com/apache/myfaces-tobago/pull/3437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3440: build(deps): bump dependency-check-maven from 7.3.1 to 7.3.2
lofwyr14 merged PR #3440: URL: https://github.com/apache/myfaces-tobago/pull/3440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3445: build(deps): bump dependency-check-maven from 7.3.1 to 7.3.2
lofwyr14 merged PR #3445: URL: https://github.com/apache/myfaces-tobago/pull/3445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3435: build(deps): bump slf4j.version from 2.0.3 to 2.0.4
lofwyr14 merged PR #3435: URL: https://github.com/apache/myfaces-tobago/pull/3435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3436: build(deps): bump maven-install-plugin from 3.0.1 to 3.1.0
lofwyr14 merged PR #3436: URL: https://github.com/apache/myfaces-tobago/pull/3436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3438: build(deps): bump maven-install-plugin from 3.0.1 to 3.1.0
lofwyr14 merged PR #3438: URL: https://github.com/apache/myfaces-tobago/pull/3438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3439: build(deps): bump maven-install-plugin from 3.0.1 to 3.1.0
lofwyr14 merged PR #3439: URL: https://github.com/apache/myfaces-tobago/pull/3439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] lofwyr14 merged pull request #3446: build(deps): bump maven-install-plugin from 3.0.1 to 3.1.0
lofwyr14 merged PR #3446: URL: https://github.com/apache/myfaces-tobago/pull/3446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4499) TCK: Issue3020IT: testDelayNegative Fails
[ https://issues.apache.org/jira/browse/MYFACES-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637661#comment-17637661 ] Werner Punz commented on MYFACES-4499: -- Started to work on it, issue is reproducible. Will fix it for the old and new codebase. > TCK: Issue3020IT: testDelayNegative Fails > - > > Key: MYFACES-4499 > URL: https://issues.apache.org/jira/browse/MYFACES-4499 > Project: MyFaces Core > Issue Type: Bug >Reporter: Volodymyr Siedlecki >Assignee: Werner Punz >Priority: Major > Attachments: test-faces22-ajax.war > > > App Code: > [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue3020Negative.xhtml#L35] > > Unit Test: > [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue3020IT.java#L49-L54] > > The test verifies that a delay on the f:ajax is a valid input. The test uses > "NaN" and the implementation is expected to throw an exception to stop the > request from occurring. > Our RC2 code appears to be here: > [https://github.com/apache/myfaces/blob/89c747e85615e3f33265e664c8361789f38ea7db/api/src/main/javascript/META-INF/resources/myfaces/_impl/core/Impl.js#L311-L314] > I've attached the TCK application (with Mojarra) to this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
