[GitHub] [myfaces] melloware commented on pull request #593: MYFACES-4612: FacesMessages don't store in different collections
melloware commented on PR #593: URL: https://github.com/apache/myfaces/pull/593#issuecomment-1620514745 As far as I can see section 6.1.6 Message Queue deals with messages but it just mentions returning Iterators but not whether messages can be removed from the iterator at any phase? **6.1.6. Message Queue** `public void addMessage(String clientId, FacesMessage message);` During the Apply Request Values, Process Validations, Update Model Values, and Invoke Application phases of the request processing lifecycle, messages can be queued to either the component tree as a whole (if clientId is null), or related to a specific component based on its client identifier. ```java public Interator getClientIdsWithMessages(); public Severity getMaximumSeverity(); public Iterator getMessages(String clientId); public Iterator getMessages(); ``` The 1getClientIdsWithMessages()1 method must return an Iterator over the client identifiers for which at least one Message has been queued. This method must be implemented so the clientIds are returned in the order of calls to 1addMessage()1. The 1getMaximumSeverity()1 method returns the highest severity level on any Message that has been queued, regardless of whether or not the message is associated with a specific client identifier or not. The 1getMessages(String)1 method returns an Iterator over queued Messages, either those associated with the specified client identifier, or those associated with no client identifier if the parameter is null. The 1getMessages()1 method returns an Iterator over all queued Messages, whether or not they are associated with a particular client identifier. Both of the 1getMessage()1 variants must be implemented such that the messages are returned in the order in which they were added via calls to 1addMessage()1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #593: MYFACES-4612: FacesMessages don't store in different collections
tandraschko commented on PR #593: URL: https://github.com/apache/myfaces/pull/593#issuecomment-1620493783 Try to check the javadocs and specs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #593: MYFACES-4612: FacesMessages don't store in different collections
melloware commented on PR #593: URL: https://github.com/apache/myfaces/pull/593#issuecomment-1620469560 On the Iterator versions of getMessages I believe it is but on the List implementions of the return you are right its an unmodifiable List.How can we ask? Should I open a question on the Faces API GitHub? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #593: MYFACES-4612: FacesMessages don't store in different collections
tandraschko commented on PR #593: URL: https://github.com/apache/myfaces/pull/593#issuecomment-1620467537 Is remove even supported by Specs? AFAIR we return a unmodifiable list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #593: MYFACES-4612: FacesMessages don't store in different collections
melloware commented on PR #593:
URL: https://github.com/apache/myfaces/pull/593#issuecomment-1620442210
So Mojarra wrote a custom iterator so it could properly handle this scenario.
```java
// -- Inner Classes
private static final class ComponentMessagesIterator implements
Iterator {
private Map> messages;
private int outerIndex = -1;
private int messagesSize;
private Iterator inner;
private Iterator keys;
// ---
Constructors
ComponentMessagesIterator(Map> messages) {
this.messages = messages;
messagesSize = messages.size();
keys = messages.keySet().iterator();
}
// -- Methods from
Iterator
@Override
public boolean hasNext() {
if (outerIndex == -1) {
// pop our first List, if any;
outerIndex++;
inner = messages.get(keys.next()).iterator();
}
while (!inner.hasNext()) {
outerIndex++;
if (outerIndex < messagesSize) {
inner = messages.get(keys.next()).iterator();
} else {
return false;
}
}
return inner.hasNext();
}
@Override
public FacesMessage next() {
if (outerIndex >= messagesSize) {
throw new NoSuchElementException();
}
if (inner != null && inner.hasNext()) {
return inner.next();
} else {
// call this.hasNext() to properly initialize/position
'inner'
if (!hasNext()) {
throw new NoSuchElementException();
} else {
return inner.next();
}
}
}
@Override
public void remove() {
if (outerIndex == -1) {
throw new IllegalStateException();
}
inner.remove();
}
} // END ComponentMessagesIterator
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #593: MYFACES-4612: FacesMessages don't store in different collections
melloware commented on PR #593: URL: https://github.com/apache/myfaces/pull/593#issuecomment-1620433827 I have to make one more fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4612) Quarkus: Duplicate messages
[
https://issues.apache.org/jira/browse/MYFACES-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739942#comment-17739942
]
Melloware commented on MYFACES-4612:
As discussed in the PF ticket this optimization does not outweigh the side
effect of removing a message from the iterator does not remove it from both
collections.
> Quarkus: Duplicate messages
> ---
>
> Key: MYFACES-4612
> URL: https://issues.apache.org/jira/browse/MYFACES-4612
> Project: MyFaces Core
> Issue Type: New Feature
> Components: General
>Affects Versions: 4.0.1
>Reporter: Melloware
>Assignee: Melloware
>Priority: Major
>
> See: [https://github.com/primefaces/primefaces/issues/10279]
>
> MyFaces stores the same message in two different lists and Mojarra does not:
> {code:java}
> _messages = new LinkedHashMap<>(5, 1f);
> _orderedMessages = new ArrayList<>();
> List lst = _messages.computeIfAbsent(clientId, k -> new
> ArrayList<>(3));
> lst.add(message);
> _orderedMessages.add(message); {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (MYFACES-4612) Quarkus: Duplicate messages
[
https://issues.apache.org/jira/browse/MYFACES-4612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Melloware reopened MYFACES-4612:
> Quarkus: Duplicate messages
> ---
>
> Key: MYFACES-4612
> URL: https://issues.apache.org/jira/browse/MYFACES-4612
> Project: MyFaces Core
> Issue Type: New Feature
> Components: General
>Affects Versions: 4.0.1
>Reporter: Melloware
>Assignee: Melloware
>Priority: Major
>
> See: [https://github.com/primefaces/primefaces/issues/10279]
>
> MyFaces stores the same message in two different lists and Mojarra does not:
> {code:java}
> _messages = new LinkedHashMap<>(5, 1f);
> _orderedMessages = new ArrayList<>();
> List lst = _messages.computeIfAbsent(clientId, k -> new
> ArrayList<>(3));
> lst.add(message);
> _orderedMessages.add(message); {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (TOBAGO-2167) Markup small/large for form-components
[ https://issues.apache.org/jira/browse/TOBAGO-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2167. -- Fix Version/s: 5.8.0 (was: 5.x) Resolution: Fixed > Markup small/large for form-components > -- > > Key: TOBAGO-2167 > URL: https://issues.apache.org/jira/browse/TOBAGO-2167 > Project: MyFaces Tobago > Issue Type: New Feature > Components: Core, Themes >Affects Versions: 5.3.0 >Reporter: Henning Nöth >Assignee: Henning Nöth >Priority: Minor > Fix For: 5.8.0 > > > Bootstrap .form-control and .form-select could be rendered as a small/large > component. > https://getbootstrap.com/docs/5.2/forms/form-control/#sizing > https://getbootstrap.com/docs/5.2/forms/select/#sizing > https://getbootstrap.com/docs/5.2/components/buttons/#sizes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [myfaces-tobago] henningn merged pull request #4187: feature: markup small/large for form-components
henningn merged PR #4187: URL: https://github.com/apache/myfaces-tobago/pull/4187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #4188: feature: markup small/large for form-components
henningn merged PR #4188: URL: https://github.com/apache/myfaces-tobago/pull/4188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn opened a new pull request, #4188: feature: markup small/large for form-components
henningn opened a new pull request, #4188: URL: https://github.com/apache/myfaces-tobago/pull/4188 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn opened a new pull request, #4187: feature: markup small/large for form-components
henningn opened a new pull request, #4187: URL: https://github.com/apache/myfaces-tobago/pull/4187 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #4185: chore(deps): update Selenium Firefox (standalone)
henningn merged PR #4185: URL: https://github.com/apache/myfaces-tobago/pull/4185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #4186: chore(deps): update Selenium Firefox (standalone)
henningn merged PR #4186: URL: https://github.com/apache/myfaces-tobago/pull/4186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn opened a new pull request, #4186: chore(deps): update Selenium Firefox (standalone)
henningn opened a new pull request, #4186: URL: https://github.com/apache/myfaces-tobago/pull/4186 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn opened a new pull request, #4185: chore(deps): update Selenium Firefox (standalone)
henningn opened a new pull request, #4185: URL: https://github.com/apache/myfaces-tobago/pull/4185 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #4180: build(deps): bump frontend-maven-plugin from 1.13.3 to 1.13.4
henningn merged PR #4180: URL: https://github.com/apache/myfaces-tobago/pull/4180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #4181: build(deps): bump cargo-maven3-plugin from 1.10.7 to 1.10.8
henningn merged PR #4181: URL: https://github.com/apache/myfaces-tobago/pull/4181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #4182: build(deps): bump frontend-maven-plugin from 1.13.3 to 1.13.4
henningn merged PR #4182: URL: https://github.com/apache/myfaces-tobago/pull/4182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #4183: build(deps): bump cargo-maven3-plugin from 1.10.7 to 1.10.8
henningn merged PR #4183: URL: https://github.com/apache/myfaces-tobago/pull/4183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces-tobago] henningn merged pull request #4184: build(deps): bump frontend-maven-plugin from 1.13.3 to 1.13.4
henningn merged PR #4184: URL: https://github.com/apache/myfaces-tobago/pull/4184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
