[jira] [Commented] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer

2023-09-28 Thread Melloware (Jira) 


[ 
https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770005#comment-17770005
 ] 

Melloware commented on MYFACES-4536:


[~werpu] just found another similar one reported for Myfaces 4.0.1 its 
stripping out custom data: 
https://github.com/orgs/primefaces/discussions/123#discussioncomment-7133027

> PartialResponseWriter: Do no wrap the writer
> 
>
> Key: MYFACES-4536
> URL: https://issues.apache.org/jira/browse/MYFACES-4536
> Project: MyFaces Core
>  Issue Type: Improvement
>  Components: General
>Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: csp-results.zip, mojarra-csp-new.txt
>
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been 
> deprecated in order to force implementors to instead use the constructor 
> taking the wrapped instance (and to raise their awareness), so that logically 
> the inherited {{getWrapped()}} method will be used throughout the 
> implementation instead of the local {{wrapped}} variable. This will ensure 
> that the correct implementation is returned and correct behavior is performed 
> might the {{FacesWrapper}} implementation itself being wrapped by yet another 
> {{FacesWrapper}} implementation further down the chain. Because, when the 
> {{FacesWrapper}} implementation incorrectly/accidentally uses the local 
> {{wrapped}} variable instead of the {{getWrapped()}} method, then that other 
> {{FacesWrapper}} implementation will basically be completely ignored, hereby 
> breaking the decorator pattern.
>  
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MYFACES-4629) PrimeFaces.ajax.Request.handle response is missing validationFailed argument

2023-09-28 Thread Manuel K (Jira) 
Manuel K created MYFACES-4629:
-

 Summary: PrimeFaces.ajax.Request.handle response is missing 
validationFailed argument
 Key: MYFACES-4629
 URL: https://issues.apache.org/jira/browse/MYFACES-4629
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 4.0.1, 4.0.0
Reporter: Manuel K


When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
argument is not sent to the client.

For more details and a reproducer please see 
https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MYFACES-4629) PrimeFaces.ajax.Request.handle response is missing validationFailed argument

2023-09-28 Thread Melloware (Jira) 


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770039#comment-17770039
 ] 

Melloware commented on MYFACES-4629:


Attached is reproducer:

Run `mvn clean jetty:run -Pmyfaces40` to see it not work.

Run `mvn clean jetty:run -Pmojarra40` to see it DOES work.

 

 

> PrimeFaces.ajax.Request.handle response is missing validationFailed argument
> 
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Critical
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MYFACES-4629) PrimeFaces.ajax.Request.handle response is missing validationFailed argument

2023-09-28 Thread Thomas Andraschko (Jira) 


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770040#comment-17770040
 ] 

Thomas Andraschko commented on MYFACES-4629:


It would be interessting if its a response-problem or if validation is just 
never invalidated before

> PrimeFaces.ajax.Request.handle response is missing validationFailed argument
> 
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Critical
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MYFACES-4536) PartialResponseWriter: Do no wrap the writer

2023-09-28 Thread Werner Punz (Jira) 


[ 
https://issues.apache.org/jira/browse/MYFACES-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770196#comment-17770196
 ] 

Werner Punz commented on MYFACES-4536:
--

Thanks I will tackle this now asap, sorry for the delay, I was bound by private 
life and projects. I guess I will find time to start to work on it at the 
weekend!

 

> PartialResponseWriter: Do no wrap the writer
> 
>
> Key: MYFACES-4536
> URL: https://issues.apache.org/jira/browse/MYFACES-4536
> Project: MyFaces Core
>  Issue Type: Improvement
>  Components: General
>Affects Versions: 2.2.14, 2.3.10, 2.3-next-M7, 4.0.0-RC2
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: csp-results.zip, mojarra-csp-new.txt
>
>
> Per BalusC:
> Since JSF 2.3 the default constructor of {{FacesWrapper}} subclasses has been 
> deprecated in order to force implementors to instead use the constructor 
> taking the wrapped instance (and to raise their awareness), so that logically 
> the inherited {{getWrapped()}} method will be used throughout the 
> implementation instead of the local {{wrapped}} variable. This will ensure 
> that the correct implementation is returned and correct behavior is performed 
> might the {{FacesWrapper}} implementation itself being wrapped by yet another 
> {{FacesWrapper}} implementation further down the chain. Because, when the 
> {{FacesWrapper}} implementation incorrectly/accidentally uses the local 
> {{wrapped}} variable instead of the {{getWrapped()}} method, then that other 
> {{FacesWrapper}} implementation will basically be completely ignored, hereby 
> breaking the decorator pattern.
>  
> PrimeFaces ticket: https://github.com/primefaces/primefaces/issues/9518



--
This message was sent by Atlassian Jira
(v8.20.10#820010)