[jira] [Commented] (MYFACES-4632) MyFaces doesnt not generate *.taglib.xml
[ https://issues.apache.org/jira/browse/MYFACES-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772337#comment-17772337 ] Melloware commented on MYFACES-4632: [~tandraschko] not sure but is taglib.xml the same as these TLD's which are generated and also XML? [https://github.com/apache/myfaces/pull/605#issuecomment-1660583634] it looks like they are generated from the Javadoc? > MyFaces doesnt not generate *.taglib.xml > > > Key: MYFACES-4632 > URL: https://issues.apache.org/jira/browse/MYFACES-4632 > Project: MyFaces Core > Issue Type: Bug >Reporter: Thomas Andraschko >Priority: Major > > I was checking if this is rendered correclty: > https://github.com/jakartaee/faces/issues/1811 > but it seems that myfaces doesnt generate a taglib.xml > i checked our codebase a bit and it seems that the "myfaces-faces-plugin" can > generate one, but this was mainly used for pre JSF2 AFAICS > myfaces-builder-plugin, which generates our component classes based on this > annotations, doesnt have this feature?! > TBH i dont know what we should do > maybe take the myfaces-builder-plugin, refactor it completely, add taglib.xml > generation and host it as submodule of myfaces-core? > i dont like to have it in a seperate module, release lifecycle and so on > just pain in the past and now its only used anymore in MF core > another way would be to get rid of the whole generation > but this is likely just more work > anyone interessted? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] refactor(shuttle): DIV around itemLabel [myfaces-tobago]
henningn merged PR #4363: URL: https://github.com/apache/myfaces-tobago/pull/4363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] refactor(shuttle): DIV around itemLabel [myfaces-tobago]
henningn merged PR #4364: URL: https://github.com/apache/myfaces-tobago/pull/4364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] refactor(shuttle): DIV around itemLabel [myfaces-tobago]
henningn opened a new pull request, #4364: URL: https://github.com/apache/myfaces-tobago/pull/4364 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] refactor(shuttle): DIV around itemLabel [myfaces-tobago]
henningn opened a new pull request, #4363: URL: https://github.com/apache/myfaces-tobago/pull/4363 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (MYFACES-4606) Missing source button id:value pair from request parameters in ajax requests
[
https://issues.apache.org/jira/browse/MYFACES-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Werner Punz reopened MYFACES-4606:
--
> Missing source button id:value pair from request parameters in ajax requests
>
>
> Key: MYFACES-4606
> URL: https://issues.apache.org/jira/browse/MYFACES-4606
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 2.0.24, 2.2.15, 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3, 2.2.16, 4.0.2
>
>
> When the non-ajax submit button is pressed, its id and value is sent as a
> request parameter. If the ajax equivalent button is pressed, the id-value
> pair is missing. However, the id is included under the "javax.faces.source"
> attribute, per the spec.
> This becomes a problem if you do some param checks (via binding attr.) to see
> if a particular button is pressed. See more info about this here:
> [https://stackoverflow.com/a/14730658/11402059]
> Here's a sample of the behaviors for ajax and non ajax submissions. The
> required parts are in red (which should appear in both requests):
> {code:java}
>
> Ajax Checkboxes:
>
>
>
>
> Message for ajaxCheckbox ->
>
> Non-Ajax Checkboxes:
>
>
>
>
> Message for nonajaxCheckbox -> :
>
>
>
>
>
> binding="#{nonajaxbtn}"/>
>
> value="#{entry.key}" /> :
>
>
> {code}
>
> It used to work in 2.0, but now fails after refactoring. Haven't tested on
> 4.0, but I think it's also affected.
> 2.3.x:
> [https://github.com/apache/myfaces/blob/2.3.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L38-L63]
>
>
> 2.0.5:
> [https://github.com/apache/myfaces/blob/myfaces-core-project-2.0.5/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L57]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4606) Missing source button id:value pair from request parameters in ajax requests
[
https://issues.apache.org/jira/browse/MYFACES-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772292#comment-17772292
]
Werner Punz edited comment on MYFACES-4606 at 10/5/23 4:33 PM:
---
Working on it, only checkboxes and radio buttons are affected by this problem.
I will need to roll another small jsf_ts bugfix script for it, the fix is
minor, I just check the type and exclude the appendIssuingItem in this case.
Given that the behavior is needed for links or buttons only anyway, I can live
with this small inconsistency!
Also the old branches need to be checked. So expect the final fix for all
affected branches next week!
was (Author: werpu):
Working on it, only checkboxes and radio buttons are affected by this problem.
I will need to roll another small jsf_ts bugfix script for it, the fix is
minor, I just check the type and exclude the appendIssuingItem in this case.
Given that the behavior is needed for links or buttons only anyway, I can live
with this small inconsistency!
> Missing source button id:value pair from request parameters in ajax requests
>
>
> Key: MYFACES-4606
> URL: https://issues.apache.org/jira/browse/MYFACES-4606
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 2.0.24, 2.2.15, 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3, 2.2.16, 4.0.2
>
>
> When the non-ajax submit button is pressed, its id and value is sent as a
> request parameter. If the ajax equivalent button is pressed, the id-value
> pair is missing. However, the id is included under the "javax.faces.source"
> attribute, per the spec.
> This becomes a problem if you do some param checks (via binding attr.) to see
> if a particular button is pressed. See more info about this here:
> [https://stackoverflow.com/a/14730658/11402059]
> Here's a sample of the behaviors for ajax and non ajax submissions. The
> required parts are in red (which should appear in both requests):
> {code:java}
>
> Ajax Checkboxes:
>
>
>
>
> Message for ajaxCheckbox ->
>
> Non-Ajax Checkboxes:
>
>
>
>
> Message for nonajaxCheckbox -> :
>
>
>
>
>
> binding="#{nonajaxbtn}"/>
>
> value="#{entry.key}" /> :
>
>
> {code}
>
> It used to work in 2.0, but now fails after refactoring. Haven't tested on
> 4.0, but I think it's also affected.
> 2.3.x:
> [https://github.com/apache/myfaces/blob/2.3.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L38-L63]
>
>
> 2.0.5:
> [https://github.com/apache/myfaces/blob/myfaces-core-project-2.0.5/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L57]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4606) Missing source button id:value pair from request parameters in ajax requests
[
https://issues.apache.org/jira/browse/MYFACES-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772292#comment-17772292
]
Werner Punz commented on MYFACES-4606:
--
Working on it, only checkboxes and radio buttons are affected by this problem.
I will need to roll another small jsf_ts bugfix script for it, the fix is
minor, I just check the type and exclude the appendIssuingItem in this case.
Given that the behavior is needed for links or buttons only anyway, I can live
with this small inconsistency!
> Missing source button id:value pair from request parameters in ajax requests
>
>
> Key: MYFACES-4606
> URL: https://issues.apache.org/jira/browse/MYFACES-4606
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 2.0.24, 2.2.15, 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3, 2.2.16, 4.0.2
>
>
> When the non-ajax submit button is pressed, its id and value is sent as a
> request parameter. If the ajax equivalent button is pressed, the id-value
> pair is missing. However, the id is included under the "javax.faces.source"
> attribute, per the spec.
> This becomes a problem if you do some param checks (via binding attr.) to see
> if a particular button is pressed. See more info about this here:
> [https://stackoverflow.com/a/14730658/11402059]
> Here's a sample of the behaviors for ajax and non ajax submissions. The
> required parts are in red (which should appear in both requests):
> {code:java}
>
> Ajax Checkboxes:
>
>
>
>
> Message for ajaxCheckbox ->
>
> Non-Ajax Checkboxes:
>
>
>
>
> Message for nonajaxCheckbox -> :
>
>
>
>
>
> binding="#{nonajaxbtn}"/>
>
> value="#{entry.key}" /> :
>
>
> {code}
>
> It used to work in 2.0, but now fails after refactoring. Haven't tested on
> 4.0, but I think it's also affected.
> 2.3.x:
> [https://github.com/apache/myfaces/blob/2.3.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L38-L63]
>
>
> 2.0.5:
> [https://github.com/apache/myfaces/blob/myfaces-core-project-2.0.5/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L57]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (TOBAGO-2251) Possible NPE on ajax error
[ https://issues.apache.org/jira/browse/TOBAGO-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2251. -- Fix Version/s: 5.8.0 6.0.0 Resolution: Fixed > Possible NPE on ajax error > -- > > Key: TOBAGO-2251 > URL: https://issues.apache.org/jira/browse/TOBAGO-2251 > Project: MyFaces Tobago > Issue Type: Bug > Components: JavaScript, Themes >Affects Versions: 5.7.2, 6.0.0-beta-1 >Reporter: Henning Nöth >Assignee: Henning Nöth >Priority: Major > Fix For: 5.8.0, 6.0.0 > > > In tobago-page.ts the jsf.ajax.addOnEvent() is used. The code expect an > event.reponseXML. But this object can be null. > Add a null check. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] fix: NPE on ajax error [myfaces-tobago]
henningn merged PR #4362: URL: https://github.com/apache/myfaces-tobago/pull/4362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: NPE on ajax error [myfaces-tobago]
henningn merged PR #4361: URL: https://github.com/apache/myfaces-tobago/pull/4361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix: NPE on ajax error [myfaces-tobago]
henningn opened a new pull request, #4362: URL: https://github.com/apache/myfaces-tobago/pull/4362 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix: NPE on ajax error [myfaces-tobago]
henningn opened a new pull request, #4361: URL: https://github.com/apache/myfaces-tobago/pull/4361 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (TOBAGO-2231) Add support for toast messages
[ https://issues.apache.org/jira/browse/TOBAGO-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2231. -- Fix Version/s: 5.8.0 6.0.0 Resolution: Fixed > Add support for toast messages > -- > > Key: TOBAGO-2231 > URL: https://issues.apache.org/jira/browse/TOBAGO-2231 > Project: MyFaces Tobago > Issue Type: Wish > Components: Core >Reporter: Carsten Dimmek >Assignee: Henning Nöth >Priority: Major > Fix For: 5.8.0, 6.0.0 > > > It would be nice to have the possibility to display FacesMessages as toast. > [https://getbootstrap.com/docs/5.3/components/toasts/] > > Maybe add a custom FacesMessage implementation where you can specify a > display timeout, position and floating option -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] feature: Toasts [myfaces-tobago]
henningn merged PR #4354: URL: https://github.com/apache/myfaces-tobago/pull/4354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feature: Toasts [myfaces-tobago]
henningn merged PR #4360: URL: https://github.com/apache/myfaces-tobago/pull/4360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (TOBAGO-2251) Possible NPE on ajax error
Henning Nöth created TOBAGO-2251: Summary: Possible NPE on ajax error Key: TOBAGO-2251 URL: https://issues.apache.org/jira/browse/TOBAGO-2251 Project: MyFaces Tobago Issue Type: Bug Components: JavaScript Affects Versions: 6.0.0-beta-1, 5.7.2 Reporter: Henning Nöth In tobago-page.ts the jsf.ajax.addOnEvent() is used. The code expect an event.reponseXML. But this object can be null. Add a null check. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] feature: Toasts [myfaces-tobago]
henningn opened a new pull request, #4360: URL: https://github.com/apache/myfaces-tobago/pull/4360 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (TOBAGO-2250) Ajax request add a new meta tag
Henning Nöth created TOBAGO-2250:
Summary: Ajax request add a new meta tag
Key: TOBAGO-2250
URL: https://issues.apache.org/jira/browse/TOBAGO-2250
Project: MyFaces Tobago
Issue Type: Bug
Components: Core
Affects Versions: 6.0.0-beta-1
Reporter: Henning Nöth
With every ajax request, a
{code:xml}
{code}
tag is added to .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MYFACES-4632) MyFaces doesnt not generate *.taglib.xml
Thomas Andraschko created MYFACES-4632: -- Summary: MyFaces doesnt not generate *.taglib.xml Key: MYFACES-4632 URL: https://issues.apache.org/jira/browse/MYFACES-4632 Project: MyFaces Core Issue Type: Bug Reporter: Thomas Andraschko I was checking if this is rendered correclty: https://github.com/jakartaee/faces/issues/1811 but it seems that myfaces doesnt generate a taglib.xml i checked our codebase a bit and it seems that the "myfaces-faces-plugin" can generate one, but this was mainly used for pre JSF2 AFAICS myfaces-builder-plugin, which generates our component classes based on this annotations, doesnt have this feature?! TBH i dont know what we should do maybe take the myfaces-builder-plugin, refactor it completely, add taglib.xml generation and host it as submodule of myfaces-core? i dont like to have it in a seperate module, release lifecycle and so on just pain in the past another way would be to get rid of the whole generation but this is likely just more work anyone interessted? -- This message was sent by Atlassian Jira (v8.20.10#820010)
