[PR] build(deps): update postcss [myfaces-tobago]
henningn opened a new pull request, #4365: URL: https://github.com/apache/myfaces-tobago/pull/4365 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): update postcss [myfaces-tobago]
henningn merged PR #4365: URL: https://github.com/apache/myfaces-tobago/pull/4365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4632) MyFaces doesnt not generate *.taglib.xml
[ https://issues.apache.org/jira/browse/MYFACES-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772478#comment-17772478 ] Thomas Andraschko commented on MYFACES-4632: dont think its the same, just the same source just check primefaces.taglib.xml, thats missing in MF API currently > MyFaces doesnt not generate *.taglib.xml > > > Key: MYFACES-4632 > URL: https://issues.apache.org/jira/browse/MYFACES-4632 > Project: MyFaces Core > Issue Type: Bug >Reporter: Thomas Andraschko >Priority: Major > > I was checking if this is rendered correclty: > https://github.com/jakartaee/faces/issues/1811 > but it seems that myfaces doesnt generate a taglib.xml > i checked our codebase a bit and it seems that the "myfaces-faces-plugin" can > generate one, but this was mainly used for pre JSF2 AFAICS > myfaces-builder-plugin, which generates our component classes based on this > annotations, doesnt have this feature?! > TBH i dont know what we should do > maybe take the myfaces-builder-plugin, refactor it completely, add taglib.xml > generation and host it as submodule of myfaces-core? > i dont like to have it in a seperate module, release lifecycle and so on > just pain in the past and now its only used anymore in MF core > another way would be to get rid of the whole generation > but this is likely just more work > anyone interessted? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TOBAGO-2250) Ajax request adds a new meta tag
[
https://issues.apache.org/jira/browse/TOBAGO-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772499#comment-17772499
]
Henning Nöth commented on TOBAGO-2250:
--
Seems to be an issue with jsf.js_next_gen
> Ajax request adds a new meta tag
>
>
> Key: TOBAGO-2250
> URL: https://issues.apache.org/jira/browse/TOBAGO-2250
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 6.0.0-beta-1
>Reporter: Henning Nöth
>Assignee: Henning Nöth
>Priority: Critical
>
> With every ajax request, a
> {code:xml}
>
> {code}
> tag is added to .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TOBAGO-2250) Ajax request adds a new meta tag
[
https://issues.apache.org/jira/browse/TOBAGO-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772502#comment-17772502
]
Werner Punz commented on TOBAGO-2250:
-
jsf.js_next_gen does not really add any meta tags, but I can check my js code,
this is more likely on the java side.
> Ajax request adds a new meta tag
>
>
> Key: TOBAGO-2250
> URL: https://issues.apache.org/jira/browse/TOBAGO-2250
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 6.0.0-beta-1
>Reporter: Henning Nöth
>Assignee: Henning Nöth
>Priority: Critical
>
> With every ajax request, a
> {code:xml}
>
> {code}
> tag is added to .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TOBAGO-2250) Ajax request adds a new meta tag
[
https://issues.apache.org/jira/browse/TOBAGO-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772505#comment-17772505
]
Henning Nöth commented on TOBAGO-2250:
--
No, jsf.js_next_gen does not add the meta tag. The meta tag is rendered by
Tobago, but with every ajax response, the
is updated.
The ajax response look like this:
{code:xml}
{code}
The
[jira] [Commented] (TOBAGO-2250) Ajax request adds a new meta tag
[
https://issues.apache.org/jira/browse/TOBAGO-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772509#comment-17772509
]
Werner Punz commented on TOBAGO-2250:
-
Ah ok, thanks for the clarification.
Yes this is then definitely an issue with the jsf.js codebase!
> Ajax request adds a new meta tag
>
>
> Key: TOBAGO-2250
> URL: https://issues.apache.org/jira/browse/TOBAGO-2250
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 6.0.0-beta-1
>Reporter: Henning Nöth
>Assignee: Henning Nöth
>Priority: Critical
>
> With every ajax request, a
> {code:xml}
>
> {code}
> tag is added to .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (TOBAGO-2250) Ajax request adds a new meta tag
[
https://issues.apache.org/jira/browse/TOBAGO-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772509#comment-17772509
]
Werner Punz edited comment on TOBAGO-2250 at 10/6/23 10:03 AM:
---
Ah ok, thanks for the clarification.
Yes this is then definitely an issue with the jsf.js codebase!
I need to check the update code, we have something in the update head to deal
with this, I guess we need to apply the same algorithm, did not have it on the
radar that meta tags also can be in update resource!
was (Author: werpu):
Ah ok, thanks for the clarification.
Yes this is then definitely an issue with the jsf.js codebase!
> Ajax request adds a new meta tag
>
>
> Key: TOBAGO-2250
> URL: https://issues.apache.org/jira/browse/TOBAGO-2250
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 6.0.0-beta-1
>Reporter: Henning Nöth
>Assignee: Henning Nöth
>Priority: Critical
>
> With every ajax request, a
> {code:xml}
>
> {code}
> tag is added to .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MYFACES-4633) Suspicious Logic when setting BeanManager from JNDI
James McLeod created MYFACES-4633:
-
Summary: Suspicious Logic when setting BeanManager from JNDI
Key: MYFACES-4633
URL: https://issues.apache.org/jira/browse/MYFACES-4633
Project: MyFaces Core
Issue Type: Bug
Reporter: James McLeod
Attachments: beanmanager-init-from-jndi.patch
Function {{private}} BeanManager lookupBeanManagerFromJndi() in
[FacesInitializerImpl|https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/webapp/FacesInitializerImpl.java]
(specifically [line 594 of the current
version|https://github.com/apache/myfaces/blob/7905297aee87def27bd77975e07545f2e59aa357/impl/src/main/java/org/apache/myfaces/webapp/FacesInitializerImpl.java#L594]
looks incorrect to me.
The logic in the function is:
# Try to retrieve {{beanManager}} as {{java:comp/BeanManager}} in
{{InitialContext}}
# If this succeeds (i.e. {{beanManager}} is non-null), try to retrieve
{{beanManager}} as {{java:comp/env/BeanManager}} in {{InitialContext}}
The second step should be done if the first attempt to retrieve {{beanManager}}
fails, not if it succeeds. (If my interpretation is wrong, I think an
explanatory comment is warranted here!)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4633) Suspicious Logic when setting BeanManager from JNDI
[
https://issues.apache.org/jira/browse/MYFACES-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772603#comment-17772603
]
Thomas Andraschko commented on MYFACES-4633:
Can you do us a favor and provide a PR?
i think the same code should exist in 4.0.x and 2.3-next branch
> Suspicious Logic when setting BeanManager from JNDI
> ---
>
> Key: MYFACES-4633
> URL: https://issues.apache.org/jira/browse/MYFACES-4633
> Project: MyFaces Core
> Issue Type: Bug
>Reporter: James McLeod
>Priority: Major
> Attachments: beanmanager-init-from-jndi.patch
>
>
> Function {{private}} BeanManager lookupBeanManagerFromJndi() in
> [FacesInitializerImpl|https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/webapp/FacesInitializerImpl.java]
> (specifically [line 594 of the current
> version|https://github.com/apache/myfaces/blob/7905297aee87def27bd77975e07545f2e59aa357/impl/src/main/java/org/apache/myfaces/webapp/FacesInitializerImpl.java#L594]
> looks incorrect to me.
> The logic in the function is:
> # Try to retrieve {{beanManager}} as {{java:comp/BeanManager}} in
> {{InitialContext}}
> # If this succeeds (i.e. {{beanManager}} is non-null), try to retrieve
> {{beanManager}} as {{java:comp/env/BeanManager}} in {{InitialContext}}
> The second step should be done if the first attempt to retrieve
> {{beanManager}} fails, not if it succeeds. (If my interpretation is wrong, I
> think an explanatory comment is warranted here!)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MYFACES-4634) Exception when processing attribute-extension property in faces-config.xml
James McLeod created MYFACES-4634: - Summary: Exception when processing attribute-extension property in faces-config.xml Key: MYFACES-4634 URL: https://issues.apache.org/jira/browse/MYFACES-4634 Project: MyFaces Core Issue Type: Bug Reporter: James McLeod Attachments: faces-config_xml-exception.patch The exception is Oct 03, 2023 8:58:01 A.M. org.apache.myfaces.config.DefaultFacesConfigurationProvider getWebAppFacesConfig INFO: Reading config /WEB-INF/faces-config.xml Oct 03, 2023 8:58:01 A.M. org.apache.myfaces.webapp.FacesInitializerImpl initFaces SEVERE: An error occured while initializing MyFaces: java.lang.NullPointerException: Cannot invoke "java.util.List.add(Object)" because "this.attributeExtensions" is null jakarta.faces.FacesException: java.lang.NullPointerException: Cannot invoke "java.util.List.add(Object)" because "this.attributeExtensions" is null at org.apache.myfaces.config.impl.FacesConfigUnmarshallerImpl.getFacesConfig(FacesConfigUnmarshallerImpl.java:180) at org.apache.myfaces.config.impl.FacesConfigUnmarshallerImpl.getFacesConfig(FacesConfigUnmarshallerImpl.java:77) at org.apache.myfaces.config.DefaultFacesConfigurationProvider.getWebAppFacesConfig(DefaultFacesConfigurationProvider.java:399) at org.apache.myfaces.config.DefaultFacesConfigurationMerger.getFacesConfigData(DefaultFacesConfigurationMerger.java:76) at org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:468) at org.apache.myfaces.webapp.FacesInitializerImpl.buildConfiguration(FacesInitializerImpl.java:382) at org.apache.myfaces.webapp.FacesInitializerImpl.initContainerIntegration(FacesInitializerImpl.java:709) at org.apache.myfaces.webapp.FacesInitializerImpl.initFaces(FacesInitializerImpl.java:179) at org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:54) at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1046) at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:624) at org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:983) at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:740) at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:392) at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1305) at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:902) at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:306) at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:533) at org.eclipse.jetty.maven.plugin.MavenWebAppContext.doStart(MavenWebAppContext.java:294) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121) at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121) at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) at org.eclipse.jetty.server.Server.start(Server.java:470) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114) at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) at org.eclipse.jetty.server.Server.doStart(Server.java:415) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) at org.eclipse.jetty.maven.plugin.JettyEmbedder.doStart(JettyEmbedder.java:223) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) at org.eclipse.jetty.maven.plugin.JettyRunMojo.startJettyEmbedded(JettyRunMojo.java:97) at org.eclipse.jetty.maven.plugin.AbstractWebAppMojo.startJetty(AbstractWebAppMojo.java:441) at org.eclipse.jetty.maven.plugin.AbstractWebAppMojo.execute(AbstractWebAppMojo.java:419) at org.eclipse.jetty.maven.plugin.JettyRunMojo.execute(JettyRunMojo.java:85) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126) at org.apache.maven.lifecy
[jira] [Commented] (MYFACES-4634) Exception when processing attribute-extension property in faces-config.xml
[ https://issues.apache.org/jira/browse/MYFACES-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772619#comment-17772619 ] Thomas Andraschko commented on MYFACES-4634: same here a PR for branches with the same codebase (4.1, 4.0, 2.3-next) would be great > Exception when processing attribute-extension property in faces-config.xml > -- > > Key: MYFACES-4634 > URL: https://issues.apache.org/jira/browse/MYFACES-4634 > Project: MyFaces Core > Issue Type: Bug >Reporter: James McLeod >Priority: Major > Attachments: faces-config_xml-exception.patch > > > The exception is > Oct 03, 2023 8:58:01 A.M. > org.apache.myfaces.config.DefaultFacesConfigurationProvider > getWebAppFacesConfig > INFO: Reading config /WEB-INF/faces-config.xml > Oct 03, 2023 8:58:01 A.M. org.apache.myfaces.webapp.FacesInitializerImpl > initFaces > SEVERE: An error occured while initializing MyFaces: > java.lang.NullPointerException: Cannot invoke "java.util.List.add(Object)" > because "this.attributeExtensions" is null > jakarta.faces.FacesException: java.lang.NullPointerException: Cannot invoke > "java.util.List.add(Object)" because "this.attributeExtensions" is null > at > org.apache.myfaces.config.impl.FacesConfigUnmarshallerImpl.getFacesConfig(FacesConfigUnmarshallerImpl.java:180) > at > org.apache.myfaces.config.impl.FacesConfigUnmarshallerImpl.getFacesConfig(FacesConfigUnmarshallerImpl.java:77) > at > org.apache.myfaces.config.DefaultFacesConfigurationProvider.getWebAppFacesConfig(DefaultFacesConfigurationProvider.java:399) > at > org.apache.myfaces.config.DefaultFacesConfigurationMerger.getFacesConfigData(DefaultFacesConfigurationMerger.java:76) > at > org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:468) > at > org.apache.myfaces.webapp.FacesInitializerImpl.buildConfiguration(FacesInitializerImpl.java:382) > at > org.apache.myfaces.webapp.FacesInitializerImpl.initContainerIntegration(FacesInitializerImpl.java:709) > at > org.apache.myfaces.webapp.FacesInitializerImpl.initFaces(FacesInitializerImpl.java:179) > at > org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:54) > at > org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1046) > at > org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:624) > at > org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:983) > at > org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:740) > at > org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:392) > at > org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1305) > at > org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:902) > at > org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:306) > at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:533) > at > org.eclipse.jetty.maven.plugin.MavenWebAppContext.doStart(MavenWebAppContext.java:294) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) > at org.eclipse.jetty.server.Server.start(Server.java:470) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) > at org.eclipse.jetty.server.Server.doStart(Server.java:415) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) > at > org.eclipse.jetty.maven.plugin.JettyEmbedder.doStart(JettyEmbedder.java:223) > at > org.eclipse.jetty.util.component.AbstractLifeCy
[jira] [Commented] (MYFACES-4634) Exception when processing attribute-extension property in faces-config.xml
[ https://issues.apache.org/jira/browse/MYFACES-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772620#comment-17772620 ] James McLeod commented on MYFACES-4634: --- Shall do; will complete by sometime next week (possibly earlier). > Exception when processing attribute-extension property in faces-config.xml > -- > > Key: MYFACES-4634 > URL: https://issues.apache.org/jira/browse/MYFACES-4634 > Project: MyFaces Core > Issue Type: Bug >Reporter: James McLeod >Priority: Major > Attachments: faces-config_xml-exception.patch > > > The exception is > Oct 03, 2023 8:58:01 A.M. > org.apache.myfaces.config.DefaultFacesConfigurationProvider > getWebAppFacesConfig > INFO: Reading config /WEB-INF/faces-config.xml > Oct 03, 2023 8:58:01 A.M. org.apache.myfaces.webapp.FacesInitializerImpl > initFaces > SEVERE: An error occured while initializing MyFaces: > java.lang.NullPointerException: Cannot invoke "java.util.List.add(Object)" > because "this.attributeExtensions" is null > jakarta.faces.FacesException: java.lang.NullPointerException: Cannot invoke > "java.util.List.add(Object)" because "this.attributeExtensions" is null > at > org.apache.myfaces.config.impl.FacesConfigUnmarshallerImpl.getFacesConfig(FacesConfigUnmarshallerImpl.java:180) > at > org.apache.myfaces.config.impl.FacesConfigUnmarshallerImpl.getFacesConfig(FacesConfigUnmarshallerImpl.java:77) > at > org.apache.myfaces.config.DefaultFacesConfigurationProvider.getWebAppFacesConfig(DefaultFacesConfigurationProvider.java:399) > at > org.apache.myfaces.config.DefaultFacesConfigurationMerger.getFacesConfigData(DefaultFacesConfigurationMerger.java:76) > at > org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:468) > at > org.apache.myfaces.webapp.FacesInitializerImpl.buildConfiguration(FacesInitializerImpl.java:382) > at > org.apache.myfaces.webapp.FacesInitializerImpl.initContainerIntegration(FacesInitializerImpl.java:709) > at > org.apache.myfaces.webapp.FacesInitializerImpl.initFaces(FacesInitializerImpl.java:179) > at > org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:54) > at > org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1046) > at > org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:624) > at > org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:983) > at > org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:740) > at > org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:392) > at > org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1305) > at > org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:902) > at > org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:306) > at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:533) > at > org.eclipse.jetty.maven.plugin.MavenWebAppContext.doStart(MavenWebAppContext.java:294) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:121) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:171) > at org.eclipse.jetty.server.Server.start(Server.java:470) > at > org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114) > at > org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:89) > at org.eclipse.jetty.server.Server.doStart(Server.java:415) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93) > at > org.eclipse.jetty.maven.plugin.JettyEmbedder.doStart(JettyEmbedder.java:223) > at > org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.jav
[jira] [Commented] (MYFACES-4633) Suspicious Logic when setting BeanManager from JNDI
[
https://issues.apache.org/jira/browse/MYFACES-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772621#comment-17772621
]
James McLeod commented on MYFACES-4633:
---
Shall do; will complete by sometime next week (possibly earlier).
> Suspicious Logic when setting BeanManager from JNDI
> ---
>
> Key: MYFACES-4633
> URL: https://issues.apache.org/jira/browse/MYFACES-4633
> Project: MyFaces Core
> Issue Type: Bug
>Reporter: James McLeod
>Priority: Major
> Attachments: beanmanager-init-from-jndi.patch
>
>
> Function {{private}} BeanManager lookupBeanManagerFromJndi() in
> [FacesInitializerImpl|https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/webapp/FacesInitializerImpl.java]
> (specifically [line 594 of the current
> version|https://github.com/apache/myfaces/blob/7905297aee87def27bd77975e07545f2e59aa357/impl/src/main/java/org/apache/myfaces/webapp/FacesInitializerImpl.java#L594]
> looks incorrect to me.
> The logic in the function is:
> # Try to retrieve {{beanManager}} as {{java:comp/BeanManager}} in
> {{InitialContext}}
> # If this succeeds (i.e. {{beanManager}} is non-null), try to retrieve
> {{beanManager}} as {{java:comp/env/BeanManager}} in {{InitialContext}}
> The second step should be done if the first attempt to retrieve
> {{beanManager}} fails, not if it succeeds. (If my interpretation is wrong, I
> think an explanatory comment is warranted here!)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Fix for MYFACES-4633 [myfaces]
Jmcleodfoss opened a new pull request, #620: URL: https://github.com/apache/myfaces/pull/620 Look for java:comp/env/BeanManager if request for… java:comp/BeanManager fails rather than if it succeeds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix for MYFACES-4633 [myfaces]
Jmcleodfoss commented on PR #620: URL: https://github.com/apache/myfaces/pull/620#issuecomment-1751039184 I have never done this before - is the intention that I also submit PRs against 4.0.x and 2.3-next? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix for MYFACES-4633 [myfaces]
volosied commented on PR #620: URL: https://github.com/apache/myfaces/pull/620#issuecomment-1751068624 Yes, please submit PRs for the other branches that are affected (main is 4.1). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] build(deps): bump io.openliberty.tools:liberty-maven-plugin from 3.8.2 to 3.9 [myfaces-tobago]
dependabot[bot] opened a new pull request, #4366: URL: https://github.com/apache/myfaces-tobago/pull/4366 Bumps [io.openliberty.tools:liberty-maven-plugin](https://github.com/OpenLiberty/ci.maven) from 3.8.2 to 3.9. Commits https://github.com/OpenLiberty/ci.maven/commit/f9434449e844a47a85eadaf8f66fb7135e946b1c";>f943444 [maven-release-plugin] prepare release liberty-maven-3.9 https://github.com/OpenLiberty/ci.maven/commit/5956c8cba22d50f32ace4692abd464df861dd923";>5956c8c Merge pull request https://redirect.github.com/OpenLiberty/ci.maven/issues/1736";>#1736 from cherylking/use1829common https://github.com/OpenLiberty/ci.maven/commit/dcf4a979c233d06e0b5982810cb67a9482a10f7e";>dcf4a97 Use 1.8.29 ci.common https://github.com/OpenLiberty/ci.maven/commit/aa177ff26df744f273a2baac0aa1875bf4f6fbd8";>aa177ff Merge pull request https://redirect.github.com/OpenLiberty/ci.maven/issues/1732";>#1732 from cherylking/fixMultiModRestart https://github.com/OpenLiberty/ci.maven/commit/fa18b0ef688865a63c7f16a08eff585e03771222";>fa18b0e Update ci.common version to 1.8.29-SNAPSHOT (https://redirect.github.com/OpenLiberty/ci.maven/issues/1733";>#1733) https://github.com/OpenLiberty/ci.maven/commit/b63f5df76cccb32ac65d2ae6f73ba9bd76af350c";>b63f5df Fix for multimod restart server problem https://github.com/OpenLiberty/ci.maven/commit/b7ff2928734b236b416cce877f6d501051c64c92";>b7ff292 Merge pull request https://redirect.github.com/OpenLiberty/ci.maven/issues/1730";>#1730 from cherylking/useCommon1828snapshot https://github.com/OpenLiberty/ci.maven/commit/277713cdd583dd95974497a69d081d2794dbe2e6";>277713c Use 1.8.28 common release https://github.com/OpenLiberty/ci.maven/commit/cbb75b4300cfe9b5a60da1802f727c36e9118605";>cbb75b4 Use common 1.8.28-SNAPSHOT https://github.com/OpenLiberty/ci.maven/commit/3540af05cf6916399e0d8191d2872d252f4cf804";>3540af0 Merge pull request https://redirect.github.com/OpenLiberty/ci.maven/issues/1729";>#1729 from cherylking/prep39release Additional commits viewable in https://github.com/OpenLiberty/ci.maven/compare/liberty-maven-3.8.2...liberty-maven-3.9";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix for MYFACES-4633 [myfaces]
volosied commented on PR #620: URL: https://github.com/apache/myfaces/pull/620#issuecomment-1751072086 Ah, looks like an accidental change in 45a0e40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix MYFACES-4634 [myfaces]
Jmcleodfoss opened a new pull request, #621: URL: https://github.com/apache/myfaces/pull/621 Check class variable against null rather than passed parameter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] build(deps): bump io.openliberty.tools:liberty-maven-plugin from 3.8.2 to 3.9 [myfaces-tobago]
dependabot[bot] opened a new pull request, #4367: URL: https://github.com/apache/myfaces-tobago/pull/4367 Bumps [io.openliberty.tools:liberty-maven-plugin](https://github.com/OpenLiberty/ci.maven) from 3.8.2 to 3.9. Commits https://github.com/OpenLiberty/ci.maven/commit/f9434449e844a47a85eadaf8f66fb7135e946b1c";>f943444 [maven-release-plugin] prepare release liberty-maven-3.9 https://github.com/OpenLiberty/ci.maven/commit/5956c8cba22d50f32ace4692abd464df861dd923";>5956c8c Merge pull request https://redirect.github.com/OpenLiberty/ci.maven/issues/1736";>#1736 from cherylking/use1829common https://github.com/OpenLiberty/ci.maven/commit/dcf4a979c233d06e0b5982810cb67a9482a10f7e";>dcf4a97 Use 1.8.29 ci.common https://github.com/OpenLiberty/ci.maven/commit/aa177ff26df744f273a2baac0aa1875bf4f6fbd8";>aa177ff Merge pull request https://redirect.github.com/OpenLiberty/ci.maven/issues/1732";>#1732 from cherylking/fixMultiModRestart https://github.com/OpenLiberty/ci.maven/commit/fa18b0ef688865a63c7f16a08eff585e03771222";>fa18b0e Update ci.common version to 1.8.29-SNAPSHOT (https://redirect.github.com/OpenLiberty/ci.maven/issues/1733";>#1733) https://github.com/OpenLiberty/ci.maven/commit/b63f5df76cccb32ac65d2ae6f73ba9bd76af350c";>b63f5df Fix for multimod restart server problem https://github.com/OpenLiberty/ci.maven/commit/b7ff2928734b236b416cce877f6d501051c64c92";>b7ff292 Merge pull request https://redirect.github.com/OpenLiberty/ci.maven/issues/1730";>#1730 from cherylking/useCommon1828snapshot https://github.com/OpenLiberty/ci.maven/commit/277713cdd583dd95974497a69d081d2794dbe2e6";>277713c Use 1.8.28 common release https://github.com/OpenLiberty/ci.maven/commit/cbb75b4300cfe9b5a60da1802f727c36e9118605";>cbb75b4 Use common 1.8.28-SNAPSHOT https://github.com/OpenLiberty/ci.maven/commit/3540af05cf6916399e0d8191d2872d252f4cf804";>3540af0 Merge pull request https://redirect.github.com/OpenLiberty/ci.maven/issues/1729";>#1729 from cherylking/prep39release Additional commits viewable in https://github.com/OpenLiberty/ci.maven/compare/liberty-maven-3.8.2...liberty-maven-3.9";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix for MYFACES-4633 [myfaces]
volosied merged PR #620: URL: https://github.com/apache/myfaces/pull/620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix MYFACES-4634 [myfaces]
volosied merged PR #621: URL: https://github.com/apache/myfaces/pull/621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4633) Suspicious Logic when setting BeanManager from JNDI
[
https://issues.apache.org/jira/browse/MYFACES-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772668#comment-17772668
]
James McLeod commented on MYFACES-4633:
---
On review, it appears no change is necessary for the [2.3-next
branch|https://github.com/apache/myfaces/blob/41fbb9e57b2b9e68f1705b98a9d7298d2601a8de/impl/src/main/java/org/apache/myfaces/webapp/AbstractFacesInitializer.java#L607].
> Suspicious Logic when setting BeanManager from JNDI
> ---
>
> Key: MYFACES-4633
> URL: https://issues.apache.org/jira/browse/MYFACES-4633
> Project: MyFaces Core
> Issue Type: Bug
>Reporter: James McLeod
>Priority: Major
> Attachments: beanmanager-init-from-jndi.patch
>
>
> Function {{private}} BeanManager lookupBeanManagerFromJndi() in
> [FacesInitializerImpl|https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/webapp/FacesInitializerImpl.java]
> (specifically [line 594 of the current
> version|https://github.com/apache/myfaces/blob/7905297aee87def27bd77975e07545f2e59aa357/impl/src/main/java/org/apache/myfaces/webapp/FacesInitializerImpl.java#L594]
> looks incorrect to me.
> The logic in the function is:
> # Try to retrieve {{beanManager}} as {{java:comp/BeanManager}} in
> {{InitialContext}}
> # If this succeeds (i.e. {{beanManager}} is non-null), try to retrieve
> {{beanManager}} as {{java:comp/env/BeanManager}} in {{InitialContext}}
> The second step should be done if the first attempt to retrieve
> {{beanManager}} fails, not if it succeeds. (If my interpretation is wrong, I
> think an explanatory comment is warranted here!)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Fix MYFACES-4634 (2.3-next branch) [myfaces]
Jmcleodfoss opened a new pull request, #622: URL: https://github.com/apache/myfaces/pull/622 Check class variable against null rather than passed parameter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix MYFACES-4634 (2.3-next branch) [myfaces]
melloware merged PR #622: URL: https://github.com/apache/myfaces/pull/622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
