[PR] Draft - Spec 1263: Add rowStatePreserved property to UIRepeat (via new class UIIterate) [myfaces]
volosied opened a new pull request, #629: URL: https://github.com/apache/myfaces/pull/629 `https://github.com/jakartaee/faces/issues/1263` First attempt at this. Might not be the right approach, but I thought to get feedback. It's still buggy bug with the one test I've been using, but no regressions seem to occur (thankfully). I tried to place all similar methods from UIData and UIRepeat into the UIIterate method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4606) Missing source button id:value pair from request parameters in ajax requests
[
https://issues.apache.org/jira/browse/MYFACES-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774160#comment-17774160
]
Werner Punz commented on MYFACES-4606:
--
I have it working for the new codebase, the old one I have not had time to fix
it, will be done by end of the week!
> Missing source button id:value pair from request parameters in ajax requests
>
>
> Key: MYFACES-4606
> URL: https://issues.apache.org/jira/browse/MYFACES-4606
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 2.0.24, 2.2.15, 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3, 2.2.16, 4.0.2
>
>
> When the non-ajax submit button is pressed, its id and value is sent as a
> request parameter. If the ajax equivalent button is pressed, the id-value
> pair is missing. However, the id is included under the "javax.faces.source"
> attribute, per the spec.
> This becomes a problem if you do some param checks (via binding attr.) to see
> if a particular button is pressed. See more info about this here:
> [https://stackoverflow.com/a/14730658/11402059]
> Here's a sample of the behaviors for ajax and non ajax submissions. The
> required parts are in red (which should appear in both requests):
> {code:java}
>
> Ajax Checkboxes:
>
>
>
>
> Message for ajaxCheckbox ->
>
> Non-Ajax Checkboxes:
>
>
>
>
> Message for nonajaxCheckbox -> :
>
>
>
>
>
> binding="#{nonajaxbtn}"/>
>
> value="#{entry.key}" /> :
>
>
> {code}
>
> It used to work in 2.0, but now fails after refactoring. Haven't tested on
> 4.0, but I think it's also affected.
> 2.3.x:
> [https://github.com/apache/myfaces/blob/2.3.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L38-L63]
>
>
> 2.0.5:
> [https://github.com/apache/myfaces/blob/myfaces-core-project-2.0.5/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L57]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] build(deps): bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [myfaces-tobago]
dependabot[bot] opened a new pull request, #4379: URL: https://github.com/apache/myfaces-tobago/pull/4379 Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.1.2-jre to 32.1.3-jre. Release notes Sourced from https://github.com/google/guava/releases;>com.google.guava:guava's releases. 32.1.3 Maven dependency groupIdcom.google.guava/groupId artifactIdguava/artifactId version32.1.3-jre/version !-- or, for Android: -- version32.1.3-android/version /dependency Jar files https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.jar;>32.1.3-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.jar;>32.1.3-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies;>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar;>failureaccess-1.0.1.jar Javadoc http://guava.dev/releases/32.1.3-jre/api/docs/;>32.1.3-jre http://guava.dev/releases/32.1.3-android/api/docs/;>32.1.3-android JDiff http://guava.dev/releases/32.1.3-jre/api/diffs/;>32.1.3-jre vs. 32.1.2-jre http://guava.dev/releases/32.1.3-android/api/diffs/;>32.1.3-android vs. 32.1.2-android http://guava.dev/releases/32.1.3-android/api/androiddiffs/;>32.1.3-android vs. 32.1.3-jre Changelog Changed Gradle Metadata to include dependency versions directly. This may address https://redirect.github.com/google/guava/issues/6657;>Could not find some-dependency errors that some users have reported (which might be a result of users' excluding guava-parent). (c6d35cf1a5) collect: Changed Multisets.unmodifiableMultiset(set).removeIf(predicate) to throw an exception always, even if nothing matches predicate. (61dbccfda3) graph: Fixed the behavior of Graph/ValueGraph views for a node when that node is removed from the graph. (950799691c) io: Fixed Files.createTempDir and FileBackedOutputStream under https://redirect.github.com/google/guava/issues/6634;>Windows services, a rare use case. (The fix actually covers only Java 9+ because Java 8 would require an additional approach. Let us know if you need support under Java 8.) (f87f68cd3e) net: Made MediaType.parse allow and skip over whitespace around the / and = separator tokens in addition to the ; separator, for which it was already being allowed. (2786f83291) util.concurrent: Tweaked Futures.getChecked constructor-selection behavior: The method continues to prefer to call constructors with a String parameter, but now it breaks ties based on whether the constructor has a Throwable parameter. Beyond that, the choice of constructor remains undefined. (For this and other reasons, we discourage the use of getChecked.) (59cfb2267a) Commits See full diff in https://github.com/google/guava/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the
[PR] build(deps): bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [myfaces-tobago]
dependabot[bot] opened a new pull request, #4378: URL: https://github.com/apache/myfaces-tobago/pull/4378 Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.1.2-jre to 32.1.3-jre. Release notes Sourced from https://github.com/google/guava/releases;>com.google.guava:guava's releases. 32.1.3 Maven dependency groupIdcom.google.guava/groupId artifactIdguava/artifactId version32.1.3-jre/version !-- or, for Android: -- version32.1.3-android/version /dependency Jar files https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.jar;>32.1.3-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.jar;>32.1.3-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies;>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar;>failureaccess-1.0.1.jar Javadoc http://guava.dev/releases/32.1.3-jre/api/docs/;>32.1.3-jre http://guava.dev/releases/32.1.3-android/api/docs/;>32.1.3-android JDiff http://guava.dev/releases/32.1.3-jre/api/diffs/;>32.1.3-jre vs. 32.1.2-jre http://guava.dev/releases/32.1.3-android/api/diffs/;>32.1.3-android vs. 32.1.2-android http://guava.dev/releases/32.1.3-android/api/androiddiffs/;>32.1.3-android vs. 32.1.3-jre Changelog Changed Gradle Metadata to include dependency versions directly. This may address https://redirect.github.com/google/guava/issues/6657;>Could not find some-dependency errors that some users have reported (which might be a result of users' excluding guava-parent). (c6d35cf1a5) collect: Changed Multisets.unmodifiableMultiset(set).removeIf(predicate) to throw an exception always, even if nothing matches predicate. (61dbccfda3) graph: Fixed the behavior of Graph/ValueGraph views for a node when that node is removed from the graph. (950799691c) io: Fixed Files.createTempDir and FileBackedOutputStream under https://redirect.github.com/google/guava/issues/6634;>Windows services, a rare use case. (The fix actually covers only Java 9+ because Java 8 would require an additional approach. Let us know if you need support under Java 8.) (f87f68cd3e) net: Made MediaType.parse allow and skip over whitespace around the / and = separator tokens in addition to the ; separator, for which it was already being allowed. (2786f83291) util.concurrent: Tweaked Futures.getChecked constructor-selection behavior: The method continues to prefer to call constructors with a String parameter, but now it breaks ties based on whether the constructor has a Throwable parameter. Beyond that, the choice of constructor remains undefined. (For this and other reasons, we discourage the use of getChecked.) (59cfb2267a) Commits See full diff in https://github.com/google/guava/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the
[PR] build(deps): bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [myfaces-tobago]
dependabot[bot] opened a new pull request, #4377: URL: https://github.com/apache/myfaces-tobago/pull/4377 Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.1.2-jre to 32.1.3-jre. Release notes Sourced from https://github.com/google/guava/releases;>com.google.guava:guava's releases. 32.1.3 Maven dependency groupIdcom.google.guava/groupId artifactIdguava/artifactId version32.1.3-jre/version !-- or, for Android: -- version32.1.3-android/version /dependency Jar files https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.jar;>32.1.3-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.jar;>32.1.3-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies;>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar;>failureaccess-1.0.1.jar Javadoc http://guava.dev/releases/32.1.3-jre/api/docs/;>32.1.3-jre http://guava.dev/releases/32.1.3-android/api/docs/;>32.1.3-android JDiff http://guava.dev/releases/32.1.3-jre/api/diffs/;>32.1.3-jre vs. 32.1.2-jre http://guava.dev/releases/32.1.3-android/api/diffs/;>32.1.3-android vs. 32.1.2-android http://guava.dev/releases/32.1.3-android/api/androiddiffs/;>32.1.3-android vs. 32.1.3-jre Changelog Changed Gradle Metadata to include dependency versions directly. This may address https://redirect.github.com/google/guava/issues/6657;>Could not find some-dependency errors that some users have reported (which might be a result of users' excluding guava-parent). (c6d35cf1a5) collect: Changed Multisets.unmodifiableMultiset(set).removeIf(predicate) to throw an exception always, even if nothing matches predicate. (61dbccfda3) graph: Fixed the behavior of Graph/ValueGraph views for a node when that node is removed from the graph. (950799691c) io: Fixed Files.createTempDir and FileBackedOutputStream under https://redirect.github.com/google/guava/issues/6634;>Windows services, a rare use case. (The fix actually covers only Java 9+ because Java 8 would require an additional approach. Let us know if you need support under Java 8.) (f87f68cd3e) net: Made MediaType.parse allow and skip over whitespace around the / and = separator tokens in addition to the ; separator, for which it was already being allowed. (2786f83291) util.concurrent: Tweaked Futures.getChecked constructor-selection behavior: The method continues to prefer to call constructors with a String parameter, but now it breaks ties based on whether the constructor has a Throwable parameter. Beyond that, the choice of constructor remains undefined. (For this and other reasons, we discourage the use of getChecked.) (59cfb2267a) Commits See full diff in https://github.com/google/guava/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the
[jira] [Commented] (MYFACES-4606) Missing source button id:value pair from request parameters in ajax requests
[
https://issues.apache.org/jira/browse/MYFACES-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774136#comment-17774136
]
Volodymyr Siedlecki commented on MYFACES-4606:
--
[~werpu] Any updates?
> Missing source button id:value pair from request parameters in ajax requests
>
>
> Key: MYFACES-4606
> URL: https://issues.apache.org/jira/browse/MYFACES-4606
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 2.0.24, 2.2.15, 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3, 2.2.16, 4.0.2
>
>
> When the non-ajax submit button is pressed, its id and value is sent as a
> request parameter. If the ajax equivalent button is pressed, the id-value
> pair is missing. However, the id is included under the "javax.faces.source"
> attribute, per the spec.
> This becomes a problem if you do some param checks (via binding attr.) to see
> if a particular button is pressed. See more info about this here:
> [https://stackoverflow.com/a/14730658/11402059]
> Here's a sample of the behaviors for ajax and non ajax submissions. The
> required parts are in red (which should appear in both requests):
> {code:java}
>
> Ajax Checkboxes:
>
>
>
>
> Message for ajaxCheckbox ->
>
> Non-Ajax Checkboxes:
>
>
>
>
> Message for nonajaxCheckbox -> :
>
>
>
>
>
> binding="#{nonajaxbtn}"/>
>
> value="#{entry.key}" /> :
>
>
> {code}
>
> It used to work in 2.0, but now fails after refactoring. Haven't tested on
> 4.0, but I think it's also affected.
> 2.3.x:
> [https://github.com/apache/myfaces/blob/2.3.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L38-L63]
>
>
> 2.0.5:
> [https://github.com/apache/myfaces/blob/myfaces-core-project-2.0.5/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L57]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] build(deps): bump com.google.guava:guava from 32.1.2-jre to 32.1.3-jre [myfaces-tobago]
dependabot[bot] opened a new pull request, #4376: URL: https://github.com/apache/myfaces-tobago/pull/4376 Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.1.2-jre to 32.1.3-jre. Release notes Sourced from https://github.com/google/guava/releases;>com.google.guava:guava's releases. 32.1.3 Maven dependency groupIdcom.google.guava/groupId artifactIdguava/artifactId version32.1.3-jre/version !-- or, for Android: -- version32.1.3-android/version /dependency Jar files https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-jre/guava-32.1.3-jre.jar;>32.1.3-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.jar;>32.1.3-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies;>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar;>failureaccess-1.0.1.jar Javadoc http://guava.dev/releases/32.1.3-jre/api/docs/;>32.1.3-jre http://guava.dev/releases/32.1.3-android/api/docs/;>32.1.3-android JDiff http://guava.dev/releases/32.1.3-jre/api/diffs/;>32.1.3-jre vs. 32.1.2-jre http://guava.dev/releases/32.1.3-android/api/diffs/;>32.1.3-android vs. 32.1.2-android http://guava.dev/releases/32.1.3-android/api/androiddiffs/;>32.1.3-android vs. 32.1.3-jre Changelog Changed Gradle Metadata to include dependency versions directly. This may address https://redirect.github.com/google/guava/issues/6657;>Could not find some-dependency errors that some users have reported (which might be a result of users' excluding guava-parent). (c6d35cf1a5) collect: Changed Multisets.unmodifiableMultiset(set).removeIf(predicate) to throw an exception always, even if nothing matches predicate. (61dbccfda3) graph: Fixed the behavior of Graph/ValueGraph views for a node when that node is removed from the graph. (950799691c) io: Fixed Files.createTempDir and FileBackedOutputStream under https://redirect.github.com/google/guava/issues/6634;>Windows services, a rare use case. (The fix actually covers only Java 9+ because Java 8 would require an additional approach. Let us know if you need support under Java 8.) (f87f68cd3e) net: Made MediaType.parse allow and skip over whitespace around the / and = separator tokens in addition to the ; separator, for which it was already being allowed. (2786f83291) util.concurrent: Tweaked Futures.getChecked constructor-selection behavior: The method continues to prefer to call constructors with a String parameter, but now it breaks ties based on whether the constructor has a Throwable parameter. Beyond that, the choice of constructor remains undefined. (For this and other reasons, we discourage the use of getChecked.) (59cfb2267a) Commits See full diff in https://github.com/google/guava/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the
Re: [PR] Spec 1584 - Rely on CDI Class Scanning [myfaces]
tandraschko commented on PR #615: URL: https://github.com/apache/myfaces/pull/615#issuecomment-1757968800 I can take care of it If the Mojarra Team give their +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4623 (4.0.x) : Check for duplicate IDs to avoid DuplicateIdException [myfaces]
volosied merged PR #627: URL: https://github.com/apache/myfaces/pull/627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Spec 1584 - Rely on CDI Class Scanning [myfaces]
volosied commented on PR #615: URL: https://github.com/apache/myfaces/pull/615#issuecomment-1757845070 Could you be more specific -- I don't quite follow which parts you mean? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MYFACES-4631 (4.0.x) [myfaces]
volosied opened a new pull request, #628: URL: https://github.com/apache/myfaces/pull/628 https://issues.apache.org/jira/browse/MYFACES-4631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] myfaces-4623 check for dup ids to avoid DuplicateIdException [myfaces]
volosied opened a new pull request, #627: URL: https://github.com/apache/myfaces/pull/627 https://issues.apache.org/jira/browse/MYFACES-4623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Create setResponseContentLengthLong in ServletExternalContextImpl [myfaces]
volosied merged PR #625: URL: https://github.com/apache/myfaces/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix MYFACES-4628 - 4.0 branch [myfaces]
volosied merged PR #626: URL: https://github.com/apache/myfaces/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix MYFACES-4628 - 4.0 branch [myfaces]
volosied opened a new pull request, #626: URL: https://github.com/apache/myfaces/pull/626 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump org.codehaus.cargo:cargo-maven3-plugin from 1.10.9 to 1.10.10 [myfaces-tobago]
henningn merged PR #4369: URL: https://github.com/apache/myfaces-tobago/pull/4369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.0 [myfaces-tobago]
henningn merged PR #4372: URL: https://github.com/apache/myfaces-tobago/pull/4372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump org.eclipse.jetty:jetty-maven-plugin from 11.0.16 to 11.0.17 [myfaces-tobago]
henningn merged PR #4371: URL: https://github.com/apache/myfaces-tobago/pull/4371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump org.codehaus.cargo:cargo-maven3-plugin from 1.10.9 to 1.10.10 [myfaces-tobago]
henningn merged PR #4368: URL: https://github.com/apache/myfaces-tobago/pull/4368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump org.eclipse.jetty:jetty-maven-plugin from 9.4.52.v20230823 to 9.4.53.v20231009 [myfaces-tobago]
henningn merged PR #4373: URL: https://github.com/apache/myfaces-tobago/pull/4373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Spec 1584 - Rely on CDI Class Scanning [myfaces]
tandraschko commented on PR #615: URL: https://github.com/apache/myfaces/pull/615#issuecomment-1757000840 yep, i see then we should move the CDI logic to DefaultAnnotationProvider and remove the old stuff -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Spec 1584 - Rely on CDI Class Scanning [myfaces]
tandraschko commented on code in PR #615:
URL: https://github.com/apache/myfaces/pull/615#discussion_r1354298046
##
impl/src/main/java/org/apache/myfaces/config/annotation/DefaultAnnotationProvider.java:
##
@@ -128,21 +128,23 @@ public DefaultAnnotationProvider()
@Override
public Map, Set>>
getAnnotatedClasses(ExternalContext ctx)
{
-if
(MyfacesConfig.getCurrentInstance(ctx).isUseCdiForAnnotationScanning())
+//1. Use CDI
+BeanManager beanManager = CDIUtils.getBeanManager(ctx);
+if(beanManager != null) // shouldnt be null, but needed for our mock
junit tests
Review Comment:
yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
