Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
volosied commented on PR #630: URL: https://github.com/apache/myfaces/pull/630#issuecomment-1762520466 Running tests. Will report later. Thanks for getting this PR up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4606) Missing source button id:value pair from request parameters in ajax requests
[
https://issues.apache.org/jira/browse/MYFACES-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775044#comment-17775044
]
Werner Punz commented on MYFACES-4606:
--
Pull request opened [https://github.com/apache/myfaces/pull/630]
you can check it, I will merge on monday, unless someone else wants to do it!
> Missing source button id:value pair from request parameters in ajax requests
>
>
> Key: MYFACES-4606
> URL: https://issues.apache.org/jira/browse/MYFACES-4606
> Project: MyFaces Core
> Issue Type: Improvement
>Affects Versions: 2.0.24, 2.2.15, 2.3.10, 3.0.2, 2.3-next-M8, 4.0.1
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.11, 3.0.3, 2.2.16, 4.0.2
>
>
> When the non-ajax submit button is pressed, its id and value is sent as a
> request parameter. If the ajax equivalent button is pressed, the id-value
> pair is missing. However, the id is included under the "javax.faces.source"
> attribute, per the spec.
> This becomes a problem if you do some param checks (via binding attr.) to see
> if a particular button is pressed. See more info about this here:
> [https://stackoverflow.com/a/14730658/11402059]
> Here's a sample of the behaviors for ajax and non ajax submissions. The
> required parts are in red (which should appear in both requests):
> {code:java}
>
> Ajax Checkboxes:
>
>
>
>
> Message for ajaxCheckbox ->
>
> Non-Ajax Checkboxes:
>
>
>
>
> Message for nonajaxCheckbox -> :
>
>
>
>
>
> binding="#{nonajaxbtn}"/>
>
> value="#{entry.key}" /> :
>
>
> {code}
>
> It used to work in 2.0, but now fails after refactoring. Haven't tested on
> 4.0, but I think it's also affected.
> 2.3.x:
> [https://github.com/apache/myfaces/blob/2.3.x/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L38-L63]
>
>
> 2.0.5:
> [https://github.com/apache/myfaces/blob/myfaces-core-project-2.0.5/api/src/main/javascript/META-INF/resources/myfaces/_impl/xhrCore/_AjaxUtils.js#L57]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu commented on PR #630: URL: https://github.com/apache/myfaces/pull/630#issuecomment-1762127783 I will leave this pull request open for a few days and merge on monday! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu opened a new pull request, #630: URL: https://github.com/apache/myfaces/pull/630 Fix for MyFaces 4606, checkboxes and radio buttons are not appended automatically if unchecked! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] build(deps): bump com.fasterxml.jackson.core:jackson-core from 2.15.2 to 2.15.3 [myfaces-tobago]
dependabot[bot] opened a new pull request, #4382: URL: https://github.com/apache/myfaces-tobago/pull/4382 Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.15.2 to 2.15.3. Commits https://github.com/FasterXML/jackson-core/commit/80e6c424ef876f31f07d3ce12c68ecd5294fe004;>80e6c42 [maven-release-plugin] prepare release jackson-core-2.15.3 https://github.com/FasterXML/jackson-core/commit/18d61c95b221530070e9f2751190c8c078cc8aba;>18d61c9 Prepare for 2.15.3 release https://github.com/FasterXML/jackson-core/commit/372a009c7f40e44166fc9a27f5fbade1ccdf80e6;>372a009 Update release notes wrt https://redirect.github.com/FasterXML/jackson-core/issues/;># https://github.com/FasterXML/jackson-core/commit/e2d2fc2193f167ddef407d58dbb31af9632061b4;>e2d2fc2 Call the right filterFinishArray/Object from FilteringParserDelegate (https://redirect.github.com/FasterXML/jackson-core/issues/;>#) https://github.com/FasterXML/jackson-core/commit/e5f00049293a8c9c0ee9b72b41c34f2cf5725f73;>e5f0004 Update Maven wrapper version https://github.com/FasterXML/jackson-core/commit/f3da625bb775a36c4b12abb4ed942d77f43214c2;>f3da625 Further tweaking of release notes https://github.com/FasterXML/jackson-core/commit/22fd10878398816d6d03dc438d571034f43b3137;>22fd108 Add ref to https://redirect.github.com/FasterXML/jackson-core/issues/943;>#943 in release-notes/VERSION-2.x https://github.com/FasterXML/jackson-core/commit/c94fd875fc430cb4b21154bb9d2320cf2693c305;>c94fd87 2.15.3-SNAPSHOT https://github.com/FasterXML/jackson-core/commit/b7e1bb9b928b3a7c3f38b15395a56b0d9624da3c;>b7e1bb9 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/FasterXML/jackson-core/compare/jackson-core-2.15.2...jackson-core-2.15.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.1 [myfaces-tobago]
henningn closed pull request #4381: build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.1 URL: https://github.com/apache/myfaces-tobago/pull/4381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.1 [myfaces-tobago]
dependabot[bot] commented on PR #4381: URL: https://github.com/apache/myfaces-tobago/pull/4381#issuecomment-1761013402 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.13.0 to 4.14.1 [myfaces-tobago]
henningn commented on PR #4381: URL: https://github.com/apache/myfaces-tobago/pull/4381#issuecomment-1761013316 Maybe 4.14.1 was recalled? At the moment the newest selenium-java version is 4.14.0. Better close this DBot PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps-dev): bump org.seleniumhq.selenium:selenium-java from 4.14.0 to 4.14.1 [myfaces-tobago]
henningn merged PR #4380: URL: https://github.com/apache/myfaces-tobago/pull/4380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
