[jira] [Commented] (MYFACES-4629) Manual AJAX request does not process TabView correctly

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783613#comment-17783613
 ] 

Thomas Andraschko commented on MYFACES-4629:


ok, i dont know if its a bug or not but this testcase show the issue:

```java
@Test
public void test() {

ArrayList clientIds = new ArrayList<>();
clientIds.add("form:input");
clientIds.add("form");

PartialVisitContext visitContext = new 
PartialVisitContext(facesContext, clientIds,
EnumSet.of(VisitHint.EXECUTE_LIFECYCLE, 
VisitHint.SKIP_UNRENDERED));

UIViewRoot viewRoot = new UIViewRoot();

HtmlForm form = new HtmlForm();
form.setId("form");
viewRoot.getChildren().add(form);

HtmlInputText inputText = new HtmlInputText();
inputText.setId("input");
form.getChildren().add(inputText);

final List visitedComponents = new ArrayList<>();

viewRoot.visitTree(visitContext, (VisitContext context, UIComponent 
target) -> {
visitedComponents.add(target);

// Same as PhaseAwareVisitCallback:
// Return VisitResult.REJECT as processDecodes/Validators/Updates 
already traverse sub tree
return VisitResult.REJECT;
});

// 1 or 2 visitedComponents?
}
```

> Manual AJAX request does not process TabView correctly
> --
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Major
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4629) Manual AJAX request does not process TabView correctly

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783613#comment-17783613
 ] 

Thomas Andraschko edited comment on MYFACES-4629 at 11/7/23 12:47 PM:
--

ok, i dont know if its a bug or not but this testcase show the issue:

{code:java}
@Test
public void test() {

ArrayList clientIds = new ArrayList<>();
clientIds.add("form:input");
clientIds.add("form");

PartialVisitContext visitContext = new 
PartialVisitContext(facesContext, clientIds,
EnumSet.of(VisitHint.EXECUTE_LIFECYCLE, 
VisitHint.SKIP_UNRENDERED));

UIViewRoot viewRoot = new UIViewRoot();

HtmlForm form = new HtmlForm();
form.setId("form");
viewRoot.getChildren().add(form);

HtmlInputText inputText = new HtmlInputText();
inputText.setId("input");
form.getChildren().add(inputText);

final List visitedComponents = new ArrayList<>();

viewRoot.visitTree(visitContext, (VisitContext context, UIComponent 
target) -> {
visitedComponents.add(target);

// Same as PhaseAwareVisitCallback:
// Return VisitResult.REJECT as processDecodes/Validators/Updates 
already traverse sub tree
return VisitResult.REJECT;
});

// 1 or 2 visitedComponents?
}
{code}



was (Author: tandraschko):
ok, i dont know if its a bug or not but this testcase show the issue:

```java
@Test
public void test() {

ArrayList clientIds = new ArrayList<>();
clientIds.add("form:input");
clientIds.add("form");

PartialVisitContext visitContext = new 
PartialVisitContext(facesContext, clientIds,
EnumSet.of(VisitHint.EXECUTE_LIFECYCLE, 
VisitHint.SKIP_UNRENDERED));

UIViewRoot viewRoot = new UIViewRoot();

HtmlForm form = new HtmlForm();
form.setId("form");
viewRoot.getChildren().add(form);

HtmlInputText inputText = new HtmlInputText();
inputText.setId("input");
form.getChildren().add(inputText);

final List visitedComponents = new ArrayList<>();

viewRoot.visitTree(visitContext, (VisitContext context, UIComponent 
target) -> {
visitedComponents.add(target);

// Same as PhaseAwareVisitCallback:
// Return VisitResult.REJECT as processDecodes/Validators/Updates 
already traverse sub tree
return VisitResult.REJECT;
});

// 1 or 2 visitedComponents?
}
```

> Manual AJAX request does not process TabView correctly
> --
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Major
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4629) Manual AJAX request does not process TabView correctly

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783619#comment-17783619
 ] 

Thomas Andraschko commented on MYFACES-4629:


What happens is that MyFaces always processes AJAX source and execute id's, 
which is tested above
Mojarra only processes the AJAX execute

our behavior is documented here: 
https://github.com/apache/myfaces/blob/816d4ae3b3d677752a33569231507a0cd7130c6b/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java#L220
the second hint is here: 
https://github.com/apache/myfaces/blob/816d4ae3b3d677752a33569231507a0cd7130c6b/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java#L732

so what happens in MF internally:
- we process `form`
- we know that the second id is a child of `form`, so we ignore it
- we rely on it that form process its childs

and here we go: PrimeFaces UITabPanel skips its children

i think the MyFaces behavior is good and we need to check if we can fix it in 
PF or not


> Manual AJAX request does not process TabView correctly
> --
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Major
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4629) Manual AJAX request does not process TabView correctly

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783619#comment-17783619
 ] 

Thomas Andraschko edited comment on MYFACES-4629 at 11/7/23 12:53 PM:
--

What happens is that MyFaces always processes AJAX source and execute id's, 
which is tested above
Mojarra only processes the AJAX execute

so Mojarra directly invokes "form:input", whereas MyFaces invokes "form" and 
the form actually processes its child directly

our behavior is documented here: 
https://github.com/apache/myfaces/blob/816d4ae3b3d677752a33569231507a0cd7130c6b/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java#L220
the second hint is here: 
https://github.com/apache/myfaces/blob/816d4ae3b3d677752a33569231507a0cd7130c6b/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java#L732

so what happens in MF internally:
- we process `form`
- we know that the second id is a child of `form`, so we ignore it
- we rely on it that form process its childs

and here we go: PrimeFaces UITabPanel skips its children

i think the MyFaces behavior is good and we need to check if we can fix it in 
PF or not



was (Author: tandraschko):
What happens is that MyFaces always processes AJAX source and execute id's, 
which is tested above
Mojarra only processes the AJAX execute

our behavior is documented here: 
https://github.com/apache/myfaces/blob/816d4ae3b3d677752a33569231507a0cd7130c6b/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java#L220
the second hint is here: 
https://github.com/apache/myfaces/blob/816d4ae3b3d677752a33569231507a0cd7130c6b/impl/src/main/java/org/apache/myfaces/context/servlet/PartialViewContextImpl.java#L732

so what happens in MF internally:
- we process `form`
- we know that the second id is a child of `form`, so we ignore it
- we rely on it that form process its childs

and here we go: PrimeFaces UITabPanel skips its children

i think the MyFaces behavior is good and we need to check if we can fix it in 
PF or not


> Manual AJAX request does not process TabView correctly
> --
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Major
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4629) Manual AJAX request does not process TabView correctly

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783623#comment-17783623
 ] 

Thomas Andraschko commented on MYFACES-4629:


even by design in PrimeFaces, see: 
https://github.com/primefaces/primefaces/issues/10958

> Manual AJAX request does not process TabView correctly
> --
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Major
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Faces 5.0: Spec 1584 - Rely on CDI Class Scanning [myfaces]

2023-11-07 Thread via GitHub


tandraschko closed pull request #615: Faces 5.0: Spec 1584 - Rely on CDI Class 
Scanning
URL: https://github.com/apache/myfaces/pull/615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Faces 5.0: Spec 1584 - Rely on CDI Class Scanning [myfaces]

2023-11-07 Thread via GitHub


tandraschko commented on PR #615:
URL: https://github.com/apache/myfaces/pull/615#issuecomment-1798502155

   i will close this for now and completly remove old scanning after we aligned 
on the spec change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (TOBAGO-2258) SelectItemGroup support

2023-11-07 Thread Bernd Bohmann (Jira)
Bernd Bohmann created TOBAGO-2258:
-

 Summary: SelectItemGroup support
 Key: TOBAGO-2258
 URL: https://issues.apache.org/jira/browse/TOBAGO-2258
 Project: MyFaces Tobago
  Issue Type: Improvement
  Components: Core
Affects Versions: 5.8.0
Reporter: Bernd Bohmann
Assignee: Bernd Bohmann






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4629) Manual AJAX request does not process TabView correctly

2023-11-07 Thread Manuel K (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783652#comment-17783652
 ] 

Manuel K commented on MYFACES-4629:
---

@[~tandraschko] 

Wow, thank you for the thourough and great analysis! Not only that, but also 
thank you very much for finding a solution to our root problem (skipChildren: 
false). I'm sorry that it was a false alarm and MyFaces did everything 
correctly while Mojarra did not.

> Manual AJAX request does not process TabView correctly
> --
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Major
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-07 Thread via GitHub


werpu commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1799032107

   Hi, I fixed the check on FormData level, apparently the hasKey function only 
checked for newly appended values not existing data passed into the existing 
formData object, this should fix the issue for good, a preliminary test locally 
now works for me, and all integration tests still pass. I will check whether 
this issue also is present for the 4.0 code, and if all is well on both code 
levels we can cherry pick the fixes for the older branches!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MYFACES-4629) Manual AJAX request does not process TabView correctly

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783682#comment-17783682
 ] 

Thomas Andraschko commented on MYFACES-4629:


also added a small test for it, that its only processed once

> Manual AJAX request does not process TabView correctly
> --
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Major
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4629) Manual AJAX request does not process TabView correctly

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783682#comment-17783682
 ] 

Thomas Andraschko edited comment on MYFACES-4629 at 11/7/23 4:19 PM:
-

also added a small test for it, that its only processed once:

https://github.com/apache/myfaces/commit/0ebef69316193230cd305c44fd9c2ffe2ea8aa3f


was (Author: tandraschko):
also added a small test for it, that its only processed once

> Manual AJAX request does not process TabView correctly
> --
>
> Key: MYFACES-4629
> URL: https://issues.apache.org/jira/browse/MYFACES-4629
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.0, 4.0.1
>Reporter: Manuel K
>Priority: Major
> Attachments: pf-tabview.zip
>
>
> When manually calling PrimeFaces.ajax.Request.handle the validationFailed 
> argument is not sent to the client.
> For more details and a reproducer please see 
> https://github.com/orgs/primefaces/discussions/123



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] Deprecate composite:extension [myfaces]

2023-11-07 Thread via GitHub


volosied opened a new pull request, #639:
URL: https://github.com/apache/myfaces/pull/639

   TLDDocs are updated and warning is logged once. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-07 Thread via GitHub


volosied commented on PR #638:
URL: https://github.com/apache/myfaces/pull/638#issuecomment-1799343920

   Hi, the changes look good to me. Both scenarios I've tested pass.
   
   Let me run the full TCK and (hopefully) we merge this in!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MYFACES-4637) Have PushContext#Send Support Collection of Records

2023-11-07 Thread Volodymyr Siedlecki (Jira)
Volodymyr Siedlecki created MYFACES-4637:


 Summary: Have PushContext#Send Support Collection of Records
 Key: MYFACES-4637
 URL: https://issues.apache.org/jira/browse/MYFACES-4637
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 5.0.0
Reporter: Volodymyr Siedlecki


Originally brought up via 
https://github.com/OpenLiberty/open-liberty/issues/26854


PushContext#send(Object obj) does not support collections of Records (added in 
Java 14). Currently, empty JSON objects are returned.  This problem occurs 
within Json encoding logic. 

[https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/push/Json.java#L80-L118]

Json.encode will go through all this checks linked above and since none of them 
match, the last one (encodeBean) will be chosen. However, this simply results 
in an empty JSON responses ( such as [ {}, {}, {} ]) 

Only work around I see for how is to call toString on the collection instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4637) Have PushContext#Send Support Collection of Records

2023-11-07 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783780#comment-17783780
 ] 

Volodymyr Siedlecki commented on MYFACES-4637:
--

One scenario where we should use Java 17 – all we'd need to do is use 
`instanceof Record`;

> Have PushContext#Send Support Collection of Records
> ---
>
> Key: MYFACES-4637
> URL: https://issues.apache.org/jira/browse/MYFACES-4637
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
>
> Originally brought up via 
> [https://github.com/OpenLiberty/open-liberty/issues/26854]
> PushContext#send(Object obj) does not support collections of Records (added 
> in Java 14). Currently, empty JSON objects are returned.  This problem occurs 
> within Json encoding logic.
> [https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/push/Json.java#L80-L118]
> Json.encode will go through all the type checks linked above and since none 
> of them match, the last one (encodeBean) will be chosen. However, this simply 
> results in an empty JSON responses ( such as [ {}, {}, {} ]). 
> Only work around I see for how is to call toString on the collection instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4637) Have PushContext#Send Support Collection of Records

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783788#comment-17783788
 ] 

Thomas Andraschko commented on MYFACES-4637:


We should add some tests here with objects and records
So we have to push to java17

> Have PushContext#Send Support Collection of Records
> ---
>
> Key: MYFACES-4637
> URL: https://issues.apache.org/jira/browse/MYFACES-4637
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 5.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
>
> Originally brought up via 
> [https://github.com/OpenLiberty/open-liberty/issues/26854]
> PushContext#send(Object obj) does not support collections of Records (added 
> in Java 14). Currently, empty JSON objects are returned.  This problem occurs 
> within Json encoding logic.
> [https://github.com/apache/myfaces/blob/main/impl/src/main/java/org/apache/myfaces/push/Json.java#L80-L118]
> Json.encode will go through all the type checks linked above and since none 
> of them match, the last one (encodeBean) will be chosen. However, this simply 
> results in an empty JSON responses ( such as [ {}, {}, {} ]). 
> Only work around I see for how is to call toString on the collection instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4485) 2.3/3.0: UnsupportedOperationException with Extensionless Mapping

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783796#comment-17783796
 ] 

Thomas Andraschko commented on MYFACES-4485:


[~paul.nicolucci] still interessted? Otherwise lets just close it.

> 2.3/3.0: UnsupportedOperationException with Extensionless Mapping
> -
>
> Key: MYFACES-4485
> URL: https://issues.apache.org/jira/browse/MYFACES-4485
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 2.3.10, 3.0.2
>Reporter: Paul Nicolucci
>Assignee: Paul Nicolucci
>Priority: Major
>
> The fix for JSF 2.3 / 3.0 is going to take a bit more time to investigate.
>  
> Faces 4.0 / 2.3-next was fixed here: 
> https://issues.apache.org/jira/browse/MYFACES-4447



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4485) 2.3/3.0: UnsupportedOperationException with Extensionless Mapping

2023-11-07 Thread Paul Nicolucci (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783797#comment-17783797
 ] 

Paul Nicolucci commented on MYFACES-4485:
-

I think we should fix it but I haven't had time recently. Let me try to revisit 
it and refresh my memory to see how difficult it will be to solve.

> 2.3/3.0: UnsupportedOperationException with Extensionless Mapping
> -
>
> Key: MYFACES-4485
> URL: https://issues.apache.org/jira/browse/MYFACES-4485
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 2.3.10, 3.0.2
>Reporter: Paul Nicolucci
>Assignee: Paul Nicolucci
>Priority: Major
>
> The fix for JSF 2.3 / 3.0 is going to take a bit more time to investigate.
>  
> Faces 4.0 / 2.3-next was fixed here: 
> https://issues.apache.org/jira/browse/MYFACES-4447



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Deprecate composite:extension [myfaces]

2023-11-07 Thread via GitHub


tandraschko merged PR #639:
URL: https://github.com/apache/myfaces/pull/639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MYFACES-4635) TCK Failure: Cannot find component for expression ":willThrowException" referenced from "submit".

2023-11-07 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783801#comment-17783801
 ] 

Thomas Andraschko commented on MYFACES-4635:


TCK challenge merged

> TCK Failure:  Cannot find component for expression ":willThrowException" 
> referenced from "submit".
> --
>
> Key: MYFACES-4635
> URL: https://issues.apache.org/jira/browse/MYFACES-4635
> Project: MyFaces Core
>  Issue Type: Bug
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Tested on 4.0.1-SNAPSHOT, so this isn't in any released code.
> Test: 
> [https://github.com/jakartaee/faces/blob/2719e03eef7ff5dd999dcf084feb5462a27bbea9/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue3171IT.java#L37]
>  
> App: 
> [https://github.com/jakartaee/faces/blob/2719e03eef7ff5dd999dcf084feb5462a27bbea9/tck/faces22/ajax/src/main/webapp/exceptionDuringRender.xhtml#L53]
>  
> Something must have changed recently that doesn't like the colon.
>         _ value="#\{bean.throwExceptionOnAjax}" />_
>         __
>             __
>         __
> Full Exception: 
> {color:#cc}Caused by: 
> {color}{color:#ce9178}jakarta.faces.component.search.ComponentNotFoundException{color}{color:#cc}:
>  Cannot find component for expression 
> {color}{color:#ce9178}":willThrowException"{color}{color:#cc} referenced 
> from {color}{color:#ce9178}"submit"{color}{color:#cc}.{color}
> {color:#ce9178} at 
> org.apache.myfaces.component.search.SearchExpressionHandlerImpl.resolveClientIds(SearchExpressionHandlerImpl.java:179){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.util.AjaxScriptBuilder.appendIds(AjaxScriptBuilder.java:279){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.util.AjaxScriptBuilder.build(AjaxScriptBuilder.java:205){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.util.AjaxScriptBuilder.build(AjaxScriptBuilder.java:117){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.HtmlAjaxBehaviorRenderer.getScript(HtmlAjaxBehaviorRenderer.java:71){color}
> {color:#ce9178} at 
> jakarta.faces.component.behavior.ClientBehaviorBase.getScript(ClientBehaviorBase.java:92){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.util.ClientBehaviorRendererUtils.appendClientBehaviourScript(ClientBehaviorRendererUtils.java:208){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.util.ClientBehaviorRendererUtils.getClientBehaviorScript(ClientBehaviorRendererUtils.java:186){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.util.ClientBehaviorRendererUtils.buildBehaviorChain(ClientBehaviorRendererUtils.java:349){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.util.ClientBehaviorRendererUtils.buildBehaviorChain(ClientBehaviorRendererUtils.java:315){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.base.HtmlButtonRendererBase.buildBehaviorizedOnClick(HtmlButtonRendererBase.java:340){color}
> {color:#ce9178} at 
> org.apache.myfaces.renderkit.html.base.HtmlButtonRendererBase.encodeBegin(HtmlButtonRendererBase.java:186){color}
> {color:#ce9178} at 
> jakarta.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:561){color}
> {color:#ce9178} at 
> jakarta.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:495){color}
> {color:#ce9178} at 
> jakarta.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:519){color}
> {color:#ce9178} at 
> jakarta.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:519){color}
> {color:#ce9178} at 
> jakarta.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:519){color}
> {color:#ce9178} at 
> org.apache.myfaces.view.facelets.FaceletViewDeclarationLanguage.renderView(FaceletViewDeclarationLanguage.java:1783){color}
> {color:#ce9178} at 
> org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:316){color}
> {color:#ce9178} at 
> jakarta.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:74){color}
> {color:#ce9178} at 
> org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:122){color}
> {color:#ce9178} at 
> org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:241){color}
> {color:#ce9178} at 
> jakarta.faces.webapp.FacesServlet.service(FacesServlet.java:225){color}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [VOTE] Release Tobago 6.0.0 and Tobago 5.8.0

2023-11-07 Thread Bernd Bohmann
Here is my +1

Regards

Bernd

On Mon, Nov 6, 2023 at 4:07 PM Henning Nöth  wrote:

> Hello,
>
> we would like to release:
> * Tobago 6.0.0
> * Tobago 5.8.0
>
> The artifacts were deployed on nexus repository for binary and source
> packages:
> * Tobago 6.0.0 [1]
> * Tobago 5.8.0 [2]
>
> The release notes are in Jira:
> * Tobago 6.0.0 [3]
> * Tobago 5.8.0 [4]
>
> The artifacts are available at the staging repository (Nexus) at:
> * Tobago 6.0.0 [5] (sha-256
> 90a88835788fb30e78ee38808549c549f6a6ebf05300fe1730f3d23b810a4bba)
> * Tobago 5.8.0 [6] (sha-256
> 33239017981ccb09ed1498e98fc3f296927de26ffedacaad706ffe28a6d3328c)
>
> Please vote now! (The vote is open for 72h.)
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Regards,
> Henning
>
> [1]
> https://repository.apache.org/content/repositories/orgapachemyfaces-1236
> [2]
> https://repository.apache.org/content/repositories/orgapachemyfaces-1237
> [3]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273&version=12350675
> [4]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273&version=12353182
> [5]
>
> https://repository.apache.org/content/repositories/orgapachemyfaces-1236/org/apache/myfaces/tobago/tobago/6.0.0/tobago-6.0.0-source-release.zip
> [6]
>
> https://repository.apache.org/content/repositories/orgapachemyfaces-1237/org/apache/myfaces/tobago/tobago/5.8.0/tobago-5.8.0-source-release.zip
>


Re: [VOTE] Release Tobago 6.0.0 and Tobago 5.8.0

2023-11-07 Thread Werner Punz
+1

Werner


Am Mi., 8. Nov. 2023 um 07:25 Uhr schrieb Bernd Bohmann :

> Here is my +1
>
> Regards
>
> Bernd
>
> On Mon, Nov 6, 2023 at 4:07 PM Henning Nöth 
> wrote:
>
>> Hello,
>>
>> we would like to release:
>> * Tobago 6.0.0
>> * Tobago 5.8.0
>>
>> The artifacts were deployed on nexus repository for binary and source
>> packages:
>> * Tobago 6.0.0 [1]
>> * Tobago 5.8.0 [2]
>>
>> The release notes are in Jira:
>> * Tobago 6.0.0 [3]
>> * Tobago 5.8.0 [4]
>>
>> The artifacts are available at the staging repository (Nexus) at:
>> * Tobago 6.0.0 [5] (sha-256
>> 90a88835788fb30e78ee38808549c549f6a6ebf05300fe1730f3d23b810a4bba)
>> * Tobago 5.8.0 [6] (sha-256
>> 33239017981ccb09ed1498e98fc3f296927de26ffedacaad706ffe28a6d3328c)
>>
>> Please vote now! (The vote is open for 72h.)
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Regards,
>> Henning
>>
>> [1]
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1236
>> [2]
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1237
>> [3]
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273&version=12350675
>> [4]
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273&version=12353182
>> [5]
>>
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1236/org/apache/myfaces/tobago/tobago/6.0.0/tobago-6.0.0-source-release.zip
>> [6]
>>
>> https://repository.apache.org/content/repositories/orgapachemyfaces-1237/org/apache/myfaces/tobago/tobago/5.8.0/tobago-5.8.0-source-release.zip
>>
>