[jira] [Commented] (MYFACES-4639) Implementation ClassUtils needs "newInstance" methods added to support OSGI runtimes
[ https://issues.apache.org/jira/browse/MYFACES-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784211#comment-17784211 ] Volodymyr Siedlecki commented on MYFACES-4639: -- Question: Should I duplicate the whole ClassUtils class to avoid further errors like this or just copy over the newInstance methods into the impl ...? > Implementation ClassUtils needs "newInstance" methods added to support OSGI > runtimes > > > Key: MYFACES-4639 > URL: https://issues.apache.org/jira/browse/MYFACES-4639 > Project: MyFaces Core > Issue Type: Bug >Reporter: Volodymyr Siedlecki >Priority: Major > > This is basically the same issue as > https://issues.apache.org/jira/browse/MYFACES-4449 > This variant was originally reported here: > [https://github.com/OpenLiberty/open-liberty/issues/26760] > However, the CNFE occurs with the newInstance methods since the classes are > looked up via the API classloader and therefore not found (since the classes > exist in the Impl and OSGI creates seperate between bundles. See the > discussion in 4449 for more information) > Example of error: > [ERROR ] Class org.apache.myfaces.push.WebsocketInitRenderer not found > org.apache.myfaces.push.WebsocketInitRenderer cannot be found by > io.openliberty.jakarta.faces.4.0_1.0.84.202311061333 > This error is related to whether the renderkit is an instance of > LazyRenderKit. If it's not, then the standard form look up used (via > newInstance). > LazyRenderKit code was added via MYFACES-3815 : > [https://github.com/apache/myfaces/commit/93a2ddf060d04cea658f58f9223c22b5badeea90] > > I'm not entirely sure how this happens in the users case above, but we should > move these methods again to avoid these errors. I'll have a PR up soon. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MYFACES-4639) Implementation ClassUtils needs methods added to support OSGI runtimes
Volodymyr Siedlecki created MYFACES-4639: Summary: Implementation ClassUtils needs methods added to support OSGI runtimes Key: MYFACES-4639 URL: https://issues.apache.org/jira/browse/MYFACES-4639 Project: MyFaces Core Issue Type: Bug Reporter: Volodymyr Siedlecki -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4638) Inputs submitted by AJAX loose all content beginning with ampersand ("&") characters
[
https://issues.apache.org/jira/browse/MYFACES-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784202#comment-17784202
]
Andreas Osterburg commented on MYFACES-4638:
Thank you.
> Inputs submitted by AJAX loose all content beginning with ampersand ("&")
> characters
>
>
> Key: MYFACES-4638
> URL: https://issues.apache.org/jira/browse/MYFACES-4638
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0, 5.0.0
>Reporter: Andreas Osterburg
>Assignee: Werner Punz
>Priority: Major
> Fix For: 4.0.2, 4.1.0, 5.0.0
>
> Attachments: patch-FileUtils.txt, test.xhtml
>
>
> When submitting input fields with AJAX the ampersand "&" character is not
> handled properly on client side.
> A test case ist attached. Just submitting the form works as expected,
> submitting by AJAX
> fails if input contains "&"-signs, like "foo".
> It tracked this down to the function _decodeEncodedValues_ in
> {_}FileUtils.ts{_}. There happens a
> decode of the current ViewState in URI-encoded format.
> Basically the source of the issue is that the input string (in
> "{_}encoded"){_} is processed in wrong order.
> Currently it is first URI-decoded an then splitted by ampersands ("&"). It
> has to be in
> reverse order, since the payload may contain ampersands, which are
> URI-encoded by "%26".
> A small working patch for demonstration is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MYFACES-4638) Inputs submitted by AJAX loose all content beginning with ampersand ("&") characters
[
https://issues.apache.org/jira/browse/MYFACES-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Werner Punz resolved MYFACES-4638.
--
Resolution: Fixed
> Inputs submitted by AJAX loose all content beginning with ampersand ("&")
> characters
>
>
> Key: MYFACES-4638
> URL: https://issues.apache.org/jira/browse/MYFACES-4638
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0, 5.0.0
>Reporter: Andreas Osterburg
>Assignee: Werner Punz
>Priority: Major
> Fix For: 4.0.2, 4.1.0, 5.0.0
>
> Attachments: patch-FileUtils.txt, test.xhtml
>
>
> When submitting input fields with AJAX the ampersand "&" character is not
> handled properly on client side.
> A test case ist attached. Just submitting the form works as expected,
> submitting by AJAX
> fails if input contains "&"-signs, like "foo".
> It tracked this down to the function _decodeEncodedValues_ in
> {_}FileUtils.ts{_}. There happens a
> decode of the current ViewState in URI-encoded format.
> Basically the source of the issue is that the input string (in
> "{_}encoded"){_} is processed in wrong order.
> Currently it is first URI-decoded an then splitted by ampersands ("&"). It
> has to be in
> reverse order, since the payload may contain ampersands, which are
> URI-encoded by "%26".
> A small working patch for demonstration is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4638) Inputs submitted by AJAX loose all content beginning with ampersand ("&") characters
[
https://issues.apache.org/jira/browse/MYFACES-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784108#comment-17784108
]
Werner Punz commented on MYFACES-4638:
--
Fixed
> Inputs submitted by AJAX loose all content beginning with ampersand ("&")
> characters
>
>
> Key: MYFACES-4638
> URL: https://issues.apache.org/jira/browse/MYFACES-4638
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0, 5.0.0
>Reporter: Andreas Osterburg
>Assignee: Werner Punz
>Priority: Major
> Fix For: 4.0.2, 4.1.0, 5.0.0
>
> Attachments: patch-FileUtils.txt, test.xhtml
>
>
> When submitting input fields with AJAX the ampersand "&" character is not
> handled properly on client side.
> A test case ist attached. Just submitting the form works as expected,
> submitting by AJAX
> fails if input contains "&"-signs, like "foo".
> It tracked this down to the function _decodeEncodedValues_ in
> {_}FileUtils.ts{_}. There happens a
> decode of the current ViewState in URI-encoded format.
> Basically the source of the issue is that the input string (in
> "{_}encoded"){_} is processed in wrong order.
> Currently it is first URI-decoded an then splitted by ampersands ("&"). It
> has to be in
> reverse order, since the payload may contain ampersands, which are
> URI-encoded by "%26".
> A small working patch for demonstration is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump @babel/traverse from 7.20.13 to 7.23.2 in /api/src/client [myfaces]
dependabot[bot] closed pull request #632: Bump @babel/traverse from 7.20.13 to 7.23.2 in /api/src/client URL: https://github.com/apache/myfaces/pull/632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump @babel/traverse from 7.20.13 to 7.23.2 in /api/src/client [myfaces]
dependabot[bot] commented on PR #632: URL: https://github.com/apache/myfaces/pull/632#issuecomment-1802201495 Looks like @babel/traverse is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4638: [myfaces]
werpu merged PR #640: URL: https://github.com/apache/myfaces/pull/640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4638: [myfaces]
werpu merged PR #641: URL: https://github.com/apache/myfaces/pull/641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4638: [myfaces]
werpu merged PR #642: URL: https://github.com/apache/myfaces/pull/642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4638: [myfaces]
werpu opened a new pull request, #642: URL: https://github.com/apache/myfaces/pull/642 Fix for myfaces 4638, inlcuding new unit test! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4638: [myfaces]
werpu opened a new pull request, #641: URL: https://github.com/apache/myfaces/pull/641 Fix for myfaces 4638, inlcuding new unit test! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4638: [myfaces]
werpu opened a new pull request, #640: URL: https://github.com/apache/myfaces/pull/640 Fix for myfaces 4638, inlcuding new unit test! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4638) Inputs submitted by AJAX loose all content beginning with ampersand ("&") characters
[
https://issues.apache.org/jira/browse/MYFACES-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784088#comment-17784088
]
Werner Punz commented on MYFACES-4638:
--
Seems like the fix is not entirely complete I am getting a cut off part after
the & in my unit test, I need to debug this out!
> Inputs submitted by AJAX loose all content beginning with ampersand ("&")
> characters
>
>
> Key: MYFACES-4638
> URL: https://issues.apache.org/jira/browse/MYFACES-4638
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0, 5.0.0
>Reporter: Andreas Osterburg
>Assignee: Werner Punz
>Priority: Major
> Fix For: 4.0.2, 4.1.0, 5.0.0
>
> Attachments: patch-FileUtils.txt, test.xhtml
>
>
> When submitting input fields with AJAX the ampersand "&" character is not
> handled properly on client side.
> A test case ist attached. Just submitting the form works as expected,
> submitting by AJAX
> fails if input contains "&"-signs, like "foo".
> It tracked this down to the function _decodeEncodedValues_ in
> {_}FileUtils.ts{_}. There happens a
> decode of the current ViewState in URI-encoded format.
> Basically the source of the issue is that the input string (in
> "{_}encoded"){_} is processed in wrong order.
> Currently it is first URI-decoded an then splitted by ampersands ("&"). It
> has to be in
> reverse order, since the payload may contain ampersands, which are
> URI-encoded by "%26".
> A small working patch for demonstration is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4638) Inputs submitted by AJAX loose all content beginning with ampersand ("&") characters
[
https://issues.apache.org/jira/browse/MYFACES-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784083#comment-17784083
]
Werner Punz edited comment on MYFACES-4638 at 11/8/23 2:54 PM:
---
Patch works, my existing tests pass, but I want to add a dedicated test for
this exact usecase in my unit tests!
So be patient, I will issue a merge request later today for 4 +
PS: Thanks for debugging this out, it was really helpful!
was (Author: werpu):
Patch works, my existing tests pass, but I want to add a dedicated test for
this exact usecase in my unit tests!
So be patient, I will issue a merge request later today for 4 +
> Inputs submitted by AJAX loose all content beginning with ampersand ("&")
> characters
>
>
> Key: MYFACES-4638
> URL: https://issues.apache.org/jira/browse/MYFACES-4638
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0, 5.0.0
>Reporter: Andreas Osterburg
>Assignee: Werner Punz
>Priority: Major
> Fix For: 4.0.2, 4.1.0, 5.0.0
>
> Attachments: patch-FileUtils.txt, test.xhtml
>
>
> When submitting input fields with AJAX the ampersand "&" character is not
> handled properly on client side.
> A test case ist attached. Just submitting the form works as expected,
> submitting by AJAX
> fails if input contains "&"-signs, like "foo".
> It tracked this down to the function _decodeEncodedValues_ in
> {_}FileUtils.ts{_}. There happens a
> decode of the current ViewState in URI-encoded format.
> Basically the source of the issue is that the input string (in
> "{_}encoded"){_} is processed in wrong order.
> Currently it is first URI-decoded an then splitted by ampersands ("&"). It
> has to be in
> reverse order, since the payload may contain ampersands, which are
> URI-encoded by "%26".
> A small working patch for demonstration is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4638) Inputs submitted by AJAX loose all content beginning with ampersand ("&") characters
[
https://issues.apache.org/jira/browse/MYFACES-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784083#comment-17784083
]
Werner Punz commented on MYFACES-4638:
--
Patch works, my existing tests pass, but I want to add a dedicated test for
this exact usecase in my unit tests!
So be patient, I will issue a merge request later today for 4 +
> Inputs submitted by AJAX loose all content beginning with ampersand ("&")
> characters
>
>
> Key: MYFACES-4638
> URL: https://issues.apache.org/jira/browse/MYFACES-4638
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0, 5.0.0
>Reporter: Andreas Osterburg
>Assignee: Werner Punz
>Priority: Major
> Fix For: 4.0.2, 4.1.0, 5.0.0
>
> Attachments: patch-FileUtils.txt, test.xhtml
>
>
> When submitting input fields with AJAX the ampersand "&" character is not
> handled properly on client side.
> A test case ist attached. Just submitting the form works as expected,
> submitting by AJAX
> fails if input contains "&"-signs, like "foo".
> It tracked this down to the function _decodeEncodedValues_ in
> {_}FileUtils.ts{_}. There happens a
> decode of the current ViewState in URI-encoded format.
> Basically the source of the issue is that the input string (in
> "{_}encoded"){_} is processed in wrong order.
> Currently it is first URI-decoded an then splitted by ampersands ("&"). It
> has to be in
> reverse order, since the payload may contain ampersands, which are
> URI-encoded by "%26".
> A small working patch for demonstration is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4638) Inputs submitted by AJAX loose all content beginning with ampersand ("&") characters
[
https://issues.apache.org/jira/browse/MYFACES-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783992#comment-17783992
]
Werner Punz commented on MYFACES-4638:
--
Thanks I will take over this!
> Inputs submitted by AJAX loose all content beginning with ampersand ("&")
> characters
>
>
> Key: MYFACES-4638
> URL: https://issues.apache.org/jira/browse/MYFACES-4638
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0, 5.0.0
>Reporter: Andreas Osterburg
>Assignee: Werner Punz
>Priority: Major
> Fix For: 4.0.2, 4.1.0, 5.0.0
>
> Attachments: patch-FileUtils.txt, test.xhtml
>
>
> When submitting input fields with AJAX the ampersand "&" character is not
> handled properly on client side.
> A test case ist attached. Just submitting the form works as expected,
> submitting by AJAX
> fails if input contains "&"-signs, like "foo".
> It tracked this down to the function _decodeEncodedValues_ in
> {_}FileUtils.ts{_}. There happens a
> decode of the current ViewState in URI-encoded format.
> Basically the source of the issue is that the input string (in
> "{_}encoded"){_} is processed in wrong order.
> Currently it is first URI-decoded an then splitted by ampersands ("&"). It
> has to be in
> reverse order, since the payload may contain ampersands, which are
> URI-encoded by "%26".
> A small working patch for demonstration is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MYFACES-4638) Inputs submitted by AJAX loose all content beginning with ampersand ("&") characters
Andreas Osterburg created MYFACES-4638:
--
Summary: Inputs submitted by AJAX loose all content beginning with
ampersand ("&") characters
Key: MYFACES-4638
URL: https://issues.apache.org/jira/browse/MYFACES-4638
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 4.0.0, 5.0.0
Reporter: Andreas Osterburg
Attachments: patch-FileUtils.txt, test.xhtml
When submitting input fields with AJAX the ampersand "&" character is not
handled properly on client side.
A test case ist attached. Just submitting the form works as expected,
submitting by AJAX
fails if input contains "&"-signs, like "foo".
It tracked this down to the function _decodeEncodedValues_ in
{_}FileUtils.ts{_}. There happens a
decode of the current ViewState in URI-encoded format.
Basically the source of the issue is that the input string (in "{_}encoded"){_}
is processed in wrong order.
Currently it is first URI-decoded an then splitted by ampersands ("&"). It has
to be in
reverse order, since the payload may contain ampersands, which are URI-encoded
by "%26".
A small working patch for demonstration is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] feat(selectList): SelectItemGroup support for Select(One|Many)List [myfaces-tobago]
bohmber opened a new pull request, #4458: URL: https://github.com/apache/myfaces-tobago/pull/4458 issue: TOBAGO-2258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
