[jira] [Commented] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844642#comment-17844642 ] Melloware commented on MYFACES-4378: [~werpu] yes i don't think its your TS I was just wondering what s weird about the issue is that Myfaces is sending the script back in both `javax.faces.Resource` and in `EVAL` sections which to me is the bug. It should only be in the `` section in this scenario. {code:java} {code} > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 2.3.10, 2.3-next-M8, 4.0.2, 4.1.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: pf-11780.zip, test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844671#comment-17844671 ] Werner Punz commented on MYFACES-4378: -- yes the resource part is definitely wrong here... not sure why this is done both ways.. eval suffices to get the script executed, resource is for appending new resources (aka script links, css links etc...) not adding putting scripts as CDATA blocks... Eval is clearly stated being for script blocks which needs separate evaluation! I nevertheless will check our resource section what it does just in case to make sure that we do not get double includes in... > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 2.3.10, 2.3-next-M8, 4.0.2, 4.1.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: pf-11780.zip, test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MYFACES-4666) ClassUtils.simpleClassForName Throws ClassNotFoundException
Volodymyr Siedlecki created MYFACES-4666: Summary: ClassUtils.simpleClassForName Throws ClassNotFoundException Key: MYFACES-4666 URL: https://issues.apache.org/jira/browse/MYFACES-4666 Project: MyFaces Core Issue Type: Bug Affects Versions: 4.1.0-RC1 Reporter: Volodymyr Siedlecki We noticed a new exception in Faces 4.1: {code:java} jakarta.faces.FacesException: java.lang.ClassNotFoundException: XXX at org.apache.myfaces.util.lang.ClassUtils.simpleClassForName(ClassUtils.java:265) at org.apache.myfaces.application.FacesServletMappingUtils.isFacesServlet(FacesServletMappingUtils.java:177) at org.apache.myfaces.webapp.MyFacesContainerInitializer.checkForFacesServlet(MyFacesContainerInitializer.java:330) at org.apache.myfaces.webapp.MyFacesContainerInitializer.onStartup(MyFacesContainerInitializer.java:143){code} This did not occur in 4.0. It only introduced with this change: [https://github.com/apache/myfaces/commit/e7d8521ee9214ff1dce24ed6fc2b8627e6461213#diff-67a433d1677376ea6270fd619b75ff47cb51a57f6ca067aef0077ff202c4eacdR177] true is now passed into simpleClassForName which throws the exception: [https://github.com/apache/myfaces/blob/2fa694a96f8c734a15ab4a46ad87ac52b1101b2a/impl/src/main/java/org/apache/myfaces/util/lang/ClassUtils.java#L253] Was this intentional for any specific scenario? Is an exception appropriate here? We didn't have this before, so I'm wondering if this is needed in 4.1? Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4666) ClassUtils.simpleClassForName Throws ClassNotFoundException
[ https://issues.apache.org/jira/browse/MYFACES-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844675#comment-17844675 ] Volodymyr Siedlecki commented on MYFACES-4666: -- [~tandraschko] We have leave it as is, but hoping you could provide some more information? > ClassUtils.simpleClassForName Throws ClassNotFoundException > --- > > Key: MYFACES-4666 > URL: https://issues.apache.org/jira/browse/MYFACES-4666 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 4.1.0-RC1 >Reporter: Volodymyr Siedlecki >Priority: Major > > We noticed a new exception in Faces 4.1: > {code:java} > jakarta.faces.FacesException: java.lang.ClassNotFoundException: XXX > at > org.apache.myfaces.util.lang.ClassUtils.simpleClassForName(ClassUtils.java:265) > at > org.apache.myfaces.application.FacesServletMappingUtils.isFacesServlet(FacesServletMappingUtils.java:177) > at > org.apache.myfaces.webapp.MyFacesContainerInitializer.checkForFacesServlet(MyFacesContainerInitializer.java:330) > at > org.apache.myfaces.webapp.MyFacesContainerInitializer.onStartup(MyFacesContainerInitializer.java:143){code} > This did not occur in 4.0. It only introduced with this change: > [https://github.com/apache/myfaces/commit/e7d8521ee9214ff1dce24ed6fc2b8627e6461213#diff-67a433d1677376ea6270fd619b75ff47cb51a57f6ca067aef0077ff202c4eacdR177] > true is now passed into simpleClassForName which throws the exception: > [https://github.com/apache/myfaces/blob/2fa694a96f8c734a15ab4a46ad87ac52b1101b2a/impl/src/main/java/org/apache/myfaces/util/lang/ClassUtils.java#L253] > Was this intentional for any specific scenario? Is an exception appropriate > here? We didn't have this before, so I'm wondering if this is needed in 4.1? > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844671#comment-17844671 ] Werner Punz edited comment on MYFACES-4378 at 5/8/24 2:32 PM: -- yes the resource part is definitely wrong here... not sure why this is done both ways.. eval suffices to get the script executed, resource is for appending new resources (aka script links, css links etc...) not adding putting scripts as CDATA blocks... Eval is clearly stated being for script blocks which needs separate evaluation! I nevertheless will check our resource section what it does just in case to make sure that we do not get double includes in... Either way, it is either or not both... you will get a double execution this way! was (Author: werpu): yes the resource part is definitely wrong here... not sure why this is done both ways.. eval suffices to get the script executed, resource is for appending new resources (aka script links, css links etc...) not adding putting scripts as CDATA blocks... Eval is clearly stated being for script blocks which needs separate evaluation! I nevertheless will check our resource section what it does just in case to make sure that we do not get double includes in... > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Task >Affects Versions: 2.3.10, 2.3-next-M8, 4.0.2, 4.1.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: pf-11780.zip, test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4666) ClassUtils.simpleClassForName Throws ClassNotFoundException
[ https://issues.apache.org/jira/browse/MYFACES-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844675#comment-17844675 ] Volodymyr Siedlecki edited comment on MYFACES-4666 at 5/8/24 2:33 PM: -- [~tandraschko] We can leave it as is, but hoping you could provide some more information? was (Author: volosied): [~tandraschko] We have leave it as is, but hoping you could provide some more information? > ClassUtils.simpleClassForName Throws ClassNotFoundException > --- > > Key: MYFACES-4666 > URL: https://issues.apache.org/jira/browse/MYFACES-4666 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.1.0-RC1 >Reporter: Volodymyr Siedlecki >Priority: Trivial > > We noticed a new exception in Faces 4.1: > {code:java} > jakarta.faces.FacesException: java.lang.ClassNotFoundException: XXX > at > org.apache.myfaces.util.lang.ClassUtils.simpleClassForName(ClassUtils.java:265) > at > org.apache.myfaces.application.FacesServletMappingUtils.isFacesServlet(FacesServletMappingUtils.java:177) > at > org.apache.myfaces.webapp.MyFacesContainerInitializer.checkForFacesServlet(MyFacesContainerInitializer.java:330) > at > org.apache.myfaces.webapp.MyFacesContainerInitializer.onStartup(MyFacesContainerInitializer.java:143){code} > This did not occur in 4.0. It only introduced with this change: > [https://github.com/apache/myfaces/commit/e7d8521ee9214ff1dce24ed6fc2b8627e6461213#diff-67a433d1677376ea6270fd619b75ff47cb51a57f6ca067aef0077ff202c4eacdR177] > true is now passed into simpleClassForName which throws the exception: > [https://github.com/apache/myfaces/blob/2fa694a96f8c734a15ab4a46ad87ac52b1101b2a/impl/src/main/java/org/apache/myfaces/util/lang/ClassUtils.java#L253] > Was this intentional for any specific scenario? Is an exception appropriate > here? We didn't have this before, so I'm wondering if this is needed in 4.1? > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844676#comment-17844676 ] Melloware commented on MYFACES-4378: I totally agree and the behavior you describe is what Mojarra does. Resource is only for resources not for scripts. > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.10, 2.3-next-M8, 4.0.2, 4.1.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: pf-11780.zip, test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844671#comment-17844671 ] Werner Punz edited comment on MYFACES-4378 at 5/8/24 2:39 PM: -- I just checked our scripts, there is no dedicated handling of a javax.faces.Resource field... If there is one, it would only get executed/evaled automatically if it is of type script type="text/javascript" in this case the eval would not be needed, in the second case if there is an eval, then a script type="text/javascript" id="javax.faces.Resource" is pointless and you would get a double eval, but the culprit here is a renderer sending such a response! the namespace javax.faces.Resource normally is for resource requests not render areas, but using it is not a spec violation to my knowledge, any id on a script would have produced the same result! was (Author: werpu): yes the resource part is definitely wrong here... not sure why this is done both ways.. eval suffices to get the script executed, resource is for appending new resources (aka script links, css links etc...) not adding putting scripts as CDATA blocks... Eval is clearly stated being for script blocks which needs separate evaluation! I nevertheless will check our resource section what it does just in case to make sure that we do not get double includes in... Either way, it is either or not both... you will get a double execution this way! > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.10, 2.3-next-M8, 4.0.2, 4.1.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: pf-11780.zip, test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844679#comment-17844679 ] Werner Punz commented on MYFACES-4378: -- Does not really matter, see my updated comment, the question is what the resource id field itself is which gets updated, if it is a script tag then it automatically gets evaled, but then the eval section is pointless, on the other hand if you have the eval section you wont need the embedded script doing the same. This is a "garbage" response! > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.10, 2.3-next-M8, 4.0.2, 4.1.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: pf-11780.zip, test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844679#comment-17844679 ] Werner Punz edited comment on MYFACES-4378 at 5/8/24 2:43 PM: -- Does not really matter, see my updated comment, the question is what the resource id field itself is which gets updated, if it is a script tag then it automatically gets evaled, but then the eval section is pointless, on the other hand if you have the eval section you wont need the embedded script doing the same. This is a "garbage" response! Btw forgot, the modern eval method for scripts is to append them to the head and clear them out again, that way the browser safely can do the eval! All 3 implementations of the scripts nowadays use this method for evaling js! Might play into this, but this is just a sidenote! was (Author: werpu): Does not really matter, see my updated comment, the question is what the resource id field itself is which gets updated, if it is a script tag then it automatically gets evaled, but then the eval section is pointless, on the other hand if you have the eval section you wont need the embedded script doing the same. This is a "garbage" response! > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.10, 2.3-next-M8, 4.0.2, 4.1.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: pf-11780.zip, test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4378) onloadScript not rendering with non ajax command button if jstl type tag c:if is present on the page
[ https://issues.apache.org/jira/browse/MYFACES-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844679#comment-17844679 ] Werner Punz edited comment on MYFACES-4378 at 5/8/24 2:45 PM: -- Does not really matter, see my updated comment, the question is what the resource id field itself is which gets updated, if it is a script tag then it automatically gets evaled, but then the eval section is pointless, on the other hand if you have the eval section you wont need the embedded script doing the same. This is a "garbage" response! Btw forgot, the modern eval method for scripts is to append them to the head and clear them out again, that way the browser safely can do the eval! All 3 implementations of the scripts nowadays use this method for evaling js! Might play into this, but this is just a sidenote! {code:java} // code placeholder globalEval(code: string, nonce ?: string): DomQuery { const head = document.getElementsByTagName("head")?.[0] ?? document.documentElement.getElementsByTagName("head")?.[0]; const script = document.createElement("script"); if (nonce) { if ('undefined' != typeof script?.nonce) { script.nonce = nonce; } else { script.setAttribute("nonce", nonce); } } script.type = "text/javascript"; script.innerHTML = code; let newScriptElement = head.appendChild(script); head.removeChild(newScriptElement); return this; } {code} What happens here is at the moment the script is appended it gets evaled by the browser engine, and once evaled it is removed... was (Author: werpu): Does not really matter, see my updated comment, the question is what the resource id field itself is which gets updated, if it is a script tag then it automatically gets evaled, but then the eval section is pointless, on the other hand if you have the eval section you wont need the embedded script doing the same. This is a "garbage" response! Btw forgot, the modern eval method for scripts is to append them to the head and clear them out again, that way the browser safely can do the eval! All 3 implementations of the scripts nowadays use this method for evaling js! Might play into this, but this is just a sidenote! > onloadScript not rendering with non ajax command button if jstl type tag c:if > is present on the page > > > Key: MYFACES-4378 > URL: https://issues.apache.org/jira/browse/MYFACES-4378 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.10, 2.3-next-M8, 4.0.2, 4.1.0-RC1 >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Attachments: pf-11780.zip, test.7z > > > See https://github.com/omnifaces/omnifaces/issues/366 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MYFACES-4666) ClassUtils.simpleClassForName Throws ClassNotFoundException
[ https://issues.apache.org/jira/browse/MYFACES-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844686#comment-17844686 ] Thomas Andraschko commented on MYFACES-4666: You add declared a servlet in web.xml but its not loadable - why should we ignore the exception? > ClassUtils.simpleClassForName Throws ClassNotFoundException > --- > > Key: MYFACES-4666 > URL: https://issues.apache.org/jira/browse/MYFACES-4666 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.1.0-RC1 >Reporter: Volodymyr Siedlecki >Priority: Trivial > > We noticed a new exception in Faces 4.1: > {code:java} > jakarta.faces.FacesException: java.lang.ClassNotFoundException: XXX > at > org.apache.myfaces.util.lang.ClassUtils.simpleClassForName(ClassUtils.java:265) > at > org.apache.myfaces.application.FacesServletMappingUtils.isFacesServlet(FacesServletMappingUtils.java:177) > at > org.apache.myfaces.webapp.MyFacesContainerInitializer.checkForFacesServlet(MyFacesContainerInitializer.java:330) > at > org.apache.myfaces.webapp.MyFacesContainerInitializer.onStartup(MyFacesContainerInitializer.java:143){code} > This did not occur in 4.0. It only introduced with this change: > [https://github.com/apache/myfaces/commit/e7d8521ee9214ff1dce24ed6fc2b8627e6461213#diff-67a433d1677376ea6270fd619b75ff47cb51a57f6ca067aef0077ff202c4eacdR177] > true is now passed into simpleClassForName which throws the exception: > [https://github.com/apache/myfaces/blob/2fa694a96f8c734a15ab4a46ad87ac52b1101b2a/impl/src/main/java/org/apache/myfaces/util/lang/ClassUtils.java#L253] > Was this intentional for any specific scenario? Is an exception appropriate > here? We didn't have this before, so I'm wondering if this is needed in 4.1? > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] fix(lazy-sheet): fetch entries when using column panel [myfaces-tobago]
henningn opened a new pull request, #5121: URL: https://github.com/apache/myfaces-tobago/pull/5121 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix(lazy-sheet): fetch entries when using column panel [myfaces-tobago]
henningn opened a new pull request, #5122: URL: https://github.com/apache/myfaces-tobago/pull/5122 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4666) ClassUtils.simpleClassForName Throws ClassNotFoundException
[ https://issues.apache.org/jira/browse/MYFACES-4666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844695#comment-17844695 ] Volodymyr Siedlecki commented on MYFACES-4666: -- This problem occurred in our OSGI environment with an absence of the web.xml (servlet looks to be added dynamically), and we have a fix (add the class to the thread context loader) . But I agree – let's keep it in. > ClassUtils.simpleClassForName Throws ClassNotFoundException > --- > > Key: MYFACES-4666 > URL: https://issues.apache.org/jira/browse/MYFACES-4666 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.1.0-RC1 >Reporter: Volodymyr Siedlecki >Priority: Trivial > > We noticed a new exception in Faces 4.1: > {code:java} > jakarta.faces.FacesException: java.lang.ClassNotFoundException: XXX > at > org.apache.myfaces.util.lang.ClassUtils.simpleClassForName(ClassUtils.java:265) > at > org.apache.myfaces.application.FacesServletMappingUtils.isFacesServlet(FacesServletMappingUtils.java:177) > at > org.apache.myfaces.webapp.MyFacesContainerInitializer.checkForFacesServlet(MyFacesContainerInitializer.java:330) > at > org.apache.myfaces.webapp.MyFacesContainerInitializer.onStartup(MyFacesContainerInitializer.java:143){code} > This did not occur in 4.0. It only introduced with this change: > [https://github.com/apache/myfaces/commit/e7d8521ee9214ff1dce24ed6fc2b8627e6461213#diff-67a433d1677376ea6270fd619b75ff47cb51a57f6ca067aef0077ff202c4eacdR177] > true is now passed into simpleClassForName which throws the exception: > [https://github.com/apache/myfaces/blob/2fa694a96f8c734a15ab4a46ad87ac52b1101b2a/impl/src/main/java/org/apache/myfaces/util/lang/ClassUtils.java#L253] > Was this intentional for any specific scenario? Is an exception appropriate > here? We didn't have this before, so I'm wondering if this is needed in 4.1? > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] fix(lazy-sheet): fetch entries when using column panel [myfaces-tobago]
henningn merged PR #5121: URL: https://github.com/apache/myfaces-tobago/pull/5121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (TOBAGO-2307) Lazy sheet does not fetch entries when using column panel
[ https://issues.apache.org/jira/browse/TOBAGO-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2307. -- Fix Version/s: 5.12.0 6.4.0 Resolution: Fixed > Lazy sheet does not fetch entries when using column panel > - > > Key: TOBAGO-2307 > URL: https://issues.apache.org/jira/browse/TOBAGO-2307 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core >Affects Versions: 5.11.0, 6.3.0 >Reporter: Marcus Kroeger >Assignee: Henning Nöth >Priority: Major > Fix For: 5.12.0, 6.4.0 > > > When using a column panel within the sheet, the lazy loading does not fetch > entries -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] fix(lazy-sheet): fetch entries when using column panel [myfaces-tobago]
henningn merged PR #5122: URL: https://github.com/apache/myfaces-tobago/pull/5122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: MyFaces last 2.3.X 2.3.-next release?
Hi, I've been focused on one other work, but I'm shifting priorities and am starting to look into a release. I'm first running the TCK against the current 2.3.11 snapshot. I'll share the results once I have them. Thanks, Volodymyr On 2024/04/22 14:59:55 Melloware Inc wrote: > Thank you for looking into this! > > On Mon, Apr 22, 2024 at 10:39 AM Volodymyr Siedlecki > wrote: > > > Hi, > > > > I can look into doing releases for both. > > > > Only concern I have is that there may be TCK failures in the current 2.3 > > branch. I tried to do a release sometime last year, but discovered a number > > of failures. I'll run another build with teh current snapshot to see if > > there are still there. > > > > Although, it's possible the failures may have been infrastructure/network > > related? > > > > I'll let you know more once I found out. > > > > Best, > > Volodymyr > > > > On 2024/04/22 13:56:54 Melloware Inc wrote: > > > Hey team, > > > > > > I know we are slowing down stopping on the 2.3.x branch but one last > > > release since it's been a year would be great. We have one bug with > > > PrimeFaces around SearchExpressions which has been fixed but not released > > > in 2.3 and 2.3-next that is going to cause a lot of heartache upgrading > > to > > > PF14. > > > > > > Volodymyr, I know this burden is on you and sorry in advance for > > asking. I > > > know the effort it takes. > > > > > > Mello > > > > > > -- > > > == > > > Melloware > > > melloware...@gmail.com > > > http://melloware.com > > > == > > > > > > > > -- > == > Melloware > melloware...@gmail.com > http://melloware.com > == >
[PR] MYFACES-4665: Implement BeforeDestroyed [myfaces]
volosied opened a new pull request, #710: URL: https://github.com/apache/myfaces/pull/710 If it looks good, I'll merge it into main, too. I'm just calling this method before the actual destroy, so it ought to be enough...? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [DRAFT] MYFACES-4637: Encode Java Records to JSON [myfaces]
volosied opened a new pull request, #711: URL: https://github.com/apache/myfaces/pull/711 DRAFT FIX https://issues.apache.org/jira/browse/MYFACES-4637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DRAFT] MYFACES-4637: Encode Java Records to JSON [myfaces]
volosied commented on code in PR #711: URL: https://github.com/apache/myfaces/pull/711#discussion_r1594585268 ## impl/src/main/java/org/apache/myfaces/push/Json.java: ## @@ -111,12 +112,45 @@ else if (object instanceof Class) { encode(((Class) object).getName(), builder); } +else if (object instanceof Record) +{ +encodeRecord(object, builder); +} else { encodeBean(object, builder); } } +private static void encodeRecord(Object recordObject, StringBuilder builder) { + +builder.append('{'); +boolean fieldsFound = false; + +for (Field field : recordObject.getClass().getDeclaredFields()) +{ +field.setAccessible(true); +fieldsFound = true; +String name = field.getName(); +builder.append(name); +builder.append(':'); +try { +encode(field.get(recordObject), builder); +} catch (IllegalArgumentException e) { +e.printStackTrace(); +} catch (IllegalAccessException e) { +e.printStackTrace(); +} Review Comment: I'm not sure what I should do with error handling here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org