[PR] build(deps-dev): bump testcontainers.version from 1.19.7 to 1.19.8 [myfaces-tobago]
dependabot[bot] opened a new pull request, #5123: URL: https://github.com/apache/myfaces-tobago/pull/5123 Bumps `testcontainers.version` from 1.19.7 to 1.19.8. Updates `org.testcontainers:testcontainers` from 1.19.7 to 1.19.8 Release notes Sourced from https://github.com/testcontainers/testcontainers-java/releases";>org.testcontainers:testcontainers's releases. 1.19.8 Testcontainers for Java 1.19.8 🚀 Features & Enhancements support backtick enquoting in SQL script splitter (https://redirect.github.com/testcontainers/testcontainers-java/issues/8593";>#8593) https://github.com/peterhalicky";>@peterhalicky [localstack] Automatically add LAMBDA_DOCKER_FLAGS with testcontainers labels (https://redirect.github.com/testcontainers/testcontainers-java/issues/8595";>#8595) https://github.com/dfangl";>@dfangl [qdrant] Allow to set key and config file (https://redirect.github.com/testcontainers/testcontainers-java/issues/8556";>#8556) https://github.com/eddumelendez";>@eddumelendez [weaviate] Support new project container registry (https://redirect.github.com/testcontainers/testcontainers-java/issues/8512";>#8512) https://github.com/ThomasVitale";>@ThomasVitale [kafka] Add support for apache/kafka (https://redirect.github.com/testcontainers/testcontainers-java/issues/8416";>#8416) https://github.com/eddumelendez";>@eddumelendez [kafka] Skip starting zookeeper when using a Kafka container with the provided Zookeeper (https://redirect.github.com/testcontainers/testcontainers-java/issues/8433";>#8433) https://github.com/silh";>@silh Use Awaitility to Poll the Image Pull (https://redirect.github.com/testcontainers/testcontainers-java/issues/8453";>#8453) https://github.com/JKomoroski";>@JKomoroski Avoid usage of the non monotonic clock System.currentTimeMillis() in favor of System.nanoTime() (https://redirect.github.com/testcontainers/testcontainers-java/issues/6392";>#6392) https://github.com/Nateckert";>@Nateckert Fix DateTimeParseException when created is not set in image config (https://redirect.github.com/testcontainers/testcontainers-java/issues/8302";>#8302) https://github.com/SgtSilvio";>@SgtSilvio [redpanda] Override entrypoint (https://redirect.github.com/testcontainers/testcontainers-java/issues/8450";>#8450) https://github.com/eddumelendez";>@eddumelendez [weaviae] Add method for getting gRPC port (https://redirect.github.com/testcontainers/testcontainers-java/issues/8431";>#8431) https://github.com/antas-marcin";>@antas-marcin [clickhouse] Add getDatabaseName() method (https://redirect.github.com/testcontainers/testcontainers-java/issues/8339";>#8339) https://github.com/colin-lee";>@colin-lee 🐛 Bug Fixes Pass env to ComposeDelegate in DockerComposeContainer#stop (https://redirect.github.com/testcontainers/testcontainers-java/issues/8493";>#8493) https://github.com/mmusenbr";>@mmusenbr 📖 Documentation 🧹 Housekeeping Add Weaviate module tests with modules (https://redirect.github.com/testcontainers/testcontainers-java/issues/8481";>#8481) https://github.com/antas-marcin";>@antas-marcin Update alpine image version to 3.17 (https://redirect.github.com/testcontainers/testcontainers-java/issues/8476";>#8476) https://github.com/eddumelendez";>@eddumelendez fix getConnectionString javadoc (https://redirect.github.com/testcontainers/testcontainers-java/issues/8129";>#8129) https://github.com/gabrielluciano";>@gabrielluciano 📦 Dependency updates Move to gradle/actions/wrapper-validation (https://redirect.github.com/testcontainers/testcontainers-java/issues/8559";>#8559) https://github.com/eddumelendez";>@eddumelendez upgrade to github actions setup-java v4 (https://redirect.github.com/testcontainers/testcontainers-java/issues/8475";>#8475) https://github.com/sullis";>@sullis Update ryuk version to 0.7.0 (https://redirect.github.com/testcontainers/testcontainers-java/issues/8451";>#8451) https://github.com/eddumelendez";>@eddumelendez chore: use new sshd:1.2.0 image (https://redirect.github.com/testcontainers/testcontainers-java/issues/8574";>#8574) https://github.com/mdelapenya";>@mdelapenya Commits https://github.com/testcontainers/testcontainers-java/commit/9b780dd8f27b7665f34c54ae738c41eccf73ad44";>9b780dd Add support for backtick enquoting in SQL script splitter (https://redirect.github.com/testcontainers/testcontainers-java/issues/8593";>#8593) https://github.com/testcontainers/testcontainers-java/commit/8b9eb0cdd8c7b7d6b04ef68c21b89e771441a758";>8b9eb0c Fix Ollama code snippet https://github.com/testcontainers/testcontainers-java/commit/2195610f0d2a0864d1f9bd79bedf2c66e8386393";>2195610 Add LAMBDA_DOCKER_FLAGS with testcontainers labels (https://redirect.github.com/testcontainers/testcontainers-java/issues/8595";>#8595) https://github.com/testcontainers/testcontainers-java/commit/994b385761dde7d832ab7b6
[jira] [Commented] (MYFACES-4654) Investigate Jakarta Schema Xsd Files Updates for 4.1
[ https://issues.apache.org/jira/browse/MYFACES-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845038#comment-17845038 ] Volodymyr Siedlecki commented on MYFACES-4654: -- Looks like only bean.xml is final. This Jira may be pushed back into a further release. > Investigate Jakarta Schema Xsd Files Updates for 4.1 > > > Key: MYFACES-4654 > URL: https://issues.apache.org/jira/browse/MYFACES-4654 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 4.1.0-RC1 >Reporter: Volodymyr Siedlecki >Priority: Major > Fix For: 4.1.0-RC3 > > > Not sure if we need any updates, but we should look into it. > [https://github.com/apache/myfaces/tree/4.1.x/impl/src/main/resources/org/apache/myfaces/resource] > > It doesn't look like any changes changed for 4.0 (maybe should have?) > I don't see any updates for EE11: > [https://jakarta.ee/xml/ns/jakartaee/] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MYFACES-4665: Implement BeforeDestroyed [5.0] [myfaces]
volosied merged PR #713: URL: https://github.com/apache/myfaces/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MYFACES-4665) @BeforeDestroyed Not Implemented for 4.1
[ https://issues.apache.org/jira/browse/MYFACES-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Siedlecki resolved MYFACES-4665. -- Resolution: Fixed > @BeforeDestroyed Not Implemented for 4.1 > > > Key: MYFACES-4665 > URL: https://issues.apache.org/jira/browse/MYFACES-4665 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 4.1.0-RC2 >Reporter: Volodymyr Siedlecki >Assignee: Volodymyr Siedlecki >Priority: Major > > @Initialized and @Destroyed were completed in MYFACES-4506 but not for > @BeforeDestroyed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MYFACES-4637 : Encode Java Records to JSON [5.0] [myfaces]
volosied merged PR #712: URL: https://github.com/apache/myfaces/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MYFACES-4665: Implement BeforeDestroyed [5.0] [myfaces]
volosied opened a new pull request, #713: URL: https://github.com/apache/myfaces/pull/713 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4665: Implement BeforeDestroyed [myfaces]
volosied merged PR #710: URL: https://github.com/apache/myfaces/pull/710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MYFACES-4637 : Encode Java Records to JSON [5.0] [myfaces]
volosied opened a new pull request, #712: URL: https://github.com/apache/myfaces/pull/712 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4637: Encode Java Records to JSON [myfaces]
volosied merged PR #711: URL: https://github.com/apache/myfaces/pull/711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DRAFT] MYFACES-4637: Encode Java Records to JSON [myfaces]
melloware commented on PR #711: URL: https://github.com/apache/myfaces/pull/711#issuecomment-2102848101 Slick! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DRAFT] MYFACES-4637: Encode Java Records to JSON [myfaces]
volosied commented on PR #711: URL: https://github.com/apache/myfaces/pull/711#issuecomment-2102797966 @melloware Take a look at the new code -- I used a Record Specific class to get the fields. https://download.java.net/java/early_access/panama/docs/api/java.base/java/lang/reflect/RecordComponent.html ( Only found Java 19 javadoc, but this class was added in 16). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DRAFT] MYFACES-4637: Encode Java Records to JSON [myfaces]
melloware commented on code in PR #711:
URL: https://github.com/apache/myfaces/pull/711#discussion_r1595338968
##
impl/src/main/java/org/apache/myfaces/push/Json.java:
##
@@ -111,12 +112,45 @@ else if (object instanceof Class)
{
encode(((Class) object).getName(), builder);
}
+else if (object instanceof Record)
+{
+encodeRecord(object, builder);
+}
else
{
encodeBean(object, builder);
}
}
+private static void encodeRecord(Object recordObject, StringBuilder
builder) {
+
+builder.append('{');
+boolean fieldsFound = false;
+
+for (Field field : recordObject.getClass().getDeclaredFields())
+{
+field.setAccessible(true);
Review Comment:
I could be wrong but is this the kind of thing they are removing in JDK 21?
Being able to change field access? I don't follow those JDK reflection updates
much but i thought they were removing a lot of things?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [DRAFT] MYFACES-4637: Encode Java Records to JSON [myfaces]
melloware commented on code in PR #711:
URL: https://github.com/apache/myfaces/pull/711#discussion_r1595338303
##
impl/src/main/java/org/apache/myfaces/push/Json.java:
##
@@ -111,12 +112,45 @@ else if (object instanceof Class)
{
encode(((Class) object).getName(), builder);
}
+else if (object instanceof Record)
+{
+encodeRecord(object, builder);
+}
else
{
encodeBean(object, builder);
}
}
+private static void encodeRecord(Object recordObject, StringBuilder
builder) {
+
+builder.append('{');
+boolean fieldsFound = false;
+
+for (Field field : recordObject.getClass().getDeclaredFields())
+{
+field.setAccessible(true);
+fieldsFound = true;
+String name = field.getName();
+builder.append(name);
+builder.append(':');
+try {
+encode(field.get(recordObject), builder);
+} catch (IllegalArgumentException e) {
+e.printStackTrace();
+} catch (IllegalAccessException e) {
+e.printStackTrace();
+}
Review Comment:
I feel like we should throw some sort of unchecked exception here right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
