[jira] [Commented] (MYFACES-4667) UIData#invokeOnComponent does not find components

2024-05-21 Thread SteGr (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848226#comment-17848226
 ] 

SteGr commented on MYFACES-4667:


Kind of, yes.

Your found issue just mentions the restriction for renderers. But according to 
BalusC, the spec does not mention the check on {{UIColumn}} for 
{{{}invokeOnComponent{}}}. So this could be fixed without a spec change.

> UIData#invokeOnComponent does not find components
> -
>
> Key: MYFACES-4667
> URL: https://issues.apache.org/jira/browse/MYFACES-4667
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.3.10
>Reporter: SteGr
>Priority: Major
>
> While working an a bug in [mojarra 
> implementation|https://github.com/eclipse-ee4j/mojarra/issues/5445#issuecomment-2115154280]]
>  I found an [old primefaces 
> issue|https://github.com/primefaces/primefaces/issues/9245#issuecomment-2122507698]
>  which was somehow related to my issue. Using the reproducer of that PF 
> issue, I was able to really find the root cause of the issue and that even 
> myfaces is affected - contrary to what was assumed at the time.
>  
> *What happens?*
> A {{p:datatable}} with {{p:column*s*}} was updated by the backend using 
> {{{}PrimeFaces#Ajax#update{}}}. The implementation used 
> {{UIComponent#invokeOnComponent}} to find the component of the given 
> clientId. As {{p:dataTable}} relies on {{UIData}} of myfaces, {{p:columns}} 
> won't be handled. Nothing could be found and {{PrimeFaces#Ajax#update}} falls 
> back to just forwarding the given clientId.
> *Why does it happen?*
> Like mojarra, myfaces filters the children on processing using {{{}instanceof 
> UIColumn{}}}. But {{p:columns}} does not extend that class. Therefore 
> {{p:columns}} is not a candiate and is simply ignored.
> *Possible fix* (not yet tested)
> Remove the check.
> *How to reproduce*
> Use the [reproducer 
> |https://github.com/primefaces/primefaces/files/9664695/primefaces-test.zip] 
> and change the PROJECT_STAGE to Development. Run the project using the 
> myfaces23 profile. You should get a lot of logging entries like
> {quote}Mai 21, 2024 2:53:41 PM org.primefaces.PrimeFaces$Ajax update
> WARNUNG: PrimeFaces.current().ajax().update() called but component cant be 
> resolved! Expression will just be added to the renderIds: \{0}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4667) UIData#invokeOnComponent does not find components

2024-05-21 Thread Melloware (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848222#comment-17848222
 ] 

Melloware commented on MYFACES-4667:


Oh good point it might be!

> UIData#invokeOnComponent does not find components
> -
>
> Key: MYFACES-4667
> URL: https://issues.apache.org/jira/browse/MYFACES-4667
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.3.10
>Reporter: SteGr
>Priority: Major
>
> While working an a bug in [mojarra 
> implementation|https://github.com/eclipse-ee4j/mojarra/issues/5445#issuecomment-2115154280]]
>  I found an [old primefaces 
> issue|https://github.com/primefaces/primefaces/issues/9245#issuecomment-2122507698]
>  which was somehow related to my issue. Using the reproducer of that PF 
> issue, I was able to really find the root cause of the issue and that even 
> myfaces is affected - contrary to what was assumed at the time.
>  
> *What happens?*
> A {{p:datatable}} with {{p:column*s*}} was updated by the backend using 
> {{{}PrimeFaces#Ajax#update{}}}. The implementation used 
> {{UIComponent#invokeOnComponent}} to find the component of the given 
> clientId. As {{p:dataTable}} relies on {{UIData}} of myfaces, {{p:columns}} 
> won't be handled. Nothing could be found and {{PrimeFaces#Ajax#update}} falls 
> back to just forwarding the given clientId.
> *Why does it happen?*
> Like mojarra, myfaces filters the children on processing using {{{}instanceof 
> UIColumn{}}}. But {{p:columns}} does not extend that class. Therefore 
> {{p:columns}} is not a candiate and is simply ignored.
> *Possible fix* (not yet tested)
> Remove the check.
> *How to reproduce*
> Use the [reproducer 
> |https://github.com/primefaces/primefaces/files/9664695/primefaces-test.zip] 
> and change the PROJECT_STAGE to Development. Run the project using the 
> myfaces23 profile. You should get a lot of logging entries like
> {quote}Mai 21, 2024 2:53:41 PM org.primefaces.PrimeFaces$Ajax update
> WARNUNG: PrimeFaces.current().ajax().update() called but component cant be 
> resolved! Expression will just be added to the renderIds: \{0}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4667) UIData#invokeOnComponent does not find components

2024-05-21 Thread Thomas Andraschko (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848207#comment-17848207
 ] 

Thomas Andraschko commented on MYFACES-4667:


isnt it? https://github.com/jakartaee/faces/issues/1905

> UIData#invokeOnComponent does not find components
> -
>
> Key: MYFACES-4667
> URL: https://issues.apache.org/jira/browse/MYFACES-4667
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.3.10
>Reporter: SteGr
>Priority: Major
>
> While working an a bug in [mojarra implementation|#issuecomment-2115154280]] 
> I found an [old primefaces 
> issue|https://github.com/primefaces/primefaces/issues/9245#issuecomment-2122507698]
>  which was somehow related to my issue. Using the reproducer of that PF 
> issue, I was able to really find the root cause of the issue and that even 
> myfaces is affected - contrary to what was assumed at the time.
>  
> *What happens?*
> A {{p:datatable}} with {{p:column*s*}} was updated by the backend using 
> {{{}PrimeFaces#Ajax#update{}}}. The implementation used 
> {{UIComponent#invokeOnComponent}} to find the component of the given 
> clientId. As {{p:dataTable}} relies on {{UIData}} of myfaces, {{p:columns}} 
> won't be handled. Nothing could be found and {{PrimeFaces#Ajax#update}} falls 
> back to just forwarding the given clientId.
> *Why does it happen?*
> Like mojarra, myfaces filters the children on processing using {{{}instanceof 
> UIColumn{}}}. But {{p:columns}} does not extend that class. Therefore 
> {{p:columns}} is not a candiate and is simply ignored.
> *Possible fix* (not yet tested)
> Remove the check.
> *How to reproduce*
> Use the [reproducer 
> |https://github.com/primefaces/primefaces/files/9664695/primefaces-test.zip] 
> and change the PROJECT_STAGE to Development. Run the project using the 
> myfaces23 profile. You should get a lot of logging entries like
> {quote}Mai 21, 2024 2:53:41 PM org.primefaces.PrimeFaces$Ajax update
> WARNUNG: PrimeFaces.current().ajax().update() called but component cant be 
> resolved! Expression will just be added to the renderIds: \{0}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4667) UIData#invokeOnComponent does not find components

2024-05-21 Thread Melloware (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848204#comment-17848204
 ] 

Melloware commented on MYFACES-4667:


Mojarra fix: https://github.com/eclipse-ee4j/mojarra/pull/5446

> UIData#invokeOnComponent does not find components
> -
>
> Key: MYFACES-4667
> URL: https://issues.apache.org/jira/browse/MYFACES-4667
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 2.3.10
>Reporter: SteGr
>Priority: Major
>
> While working an a bug in [mojarra implementation|#issuecomment-2115154280]] 
> I found an [old primefaces 
> issue|https://github.com/primefaces/primefaces/issues/9245#issuecomment-2122507698]
>  which was somehow related to my issue. Using the reproducer of that PF 
> issue, I was able to really find the root cause of the issue and that even 
> myfaces is affected - contrary to what was assumed at the time.
>  
> *What happens?*
> A {{p:datatable}} with {{p:column*s*}} was updated by the backend using 
> {{{}PrimeFaces#Ajax#update{}}}. The implementation used 
> {{UIComponent#invokeOnComponent}} to find the component of the given 
> clientId. As {{p:dataTable}} relies on {{UIData}} of myfaces, {{p:columns}} 
> won't be handled. Nothing could be found and {{PrimeFaces#Ajax#update}} falls 
> back to just forwarding the given clientId.
> *Why does it happen?*
> Like mojarra, myfaces filters the children on processing using {{{}instanceof 
> UIColumn{}}}. But {{p:columns}} does not extend that class. Therefore 
> {{p:columns}} is not a candiate and is simply ignored.
> *Possible fix* (not yet tested)
> Remove the check.
> *How to reproduce*
> Use the [reproducer 
> |https://github.com/primefaces/primefaces/files/9664695/primefaces-test.zip] 
> and change the PROJECT_STAGE to Development. Run the project using the 
> myfaces23 profile. You should get a lot of logging entries like
> {quote}Mai 21, 2024 2:53:41 PM org.primefaces.PrimeFaces$Ajax update
> WARNUNG: PrimeFaces.current().ajax().update() called but component cant be 
> resolved! Expression will just be added to the renderIds: \{0}
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MYFACES-4667) UIData#invokeOnComponent does not find components

2024-05-21 Thread SteGr (Jira)
SteGr created MYFACES-4667:
--

 Summary: UIData#invokeOnComponent does not find components
 Key: MYFACES-4667
 URL: https://issues.apache.org/jira/browse/MYFACES-4667
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.3.10
Reporter: SteGr


While working an a bug in [mojarra implementation|#issuecomment-2115154280]] I 
found an [old primefaces 
issue|https://github.com/primefaces/primefaces/issues/9245#issuecomment-2122507698]
 which was somehow related to my issue. Using the reproducer of that PF issue, 
I was able to really find the root cause of the issue and that even myfaces is 
affected - contrary to what was assumed at the time.

 

*What happens?*
A {{p:datatable}} with {{p:column*s*}} was updated by the backend using 
{{{}PrimeFaces#Ajax#update{}}}. The implementation used 
{{UIComponent#invokeOnComponent}} to find the component of the given clientId. 
As {{p:dataTable}} relies on {{UIData}} of myfaces, {{p:columns}} won't be 
handled. Nothing could be found and {{PrimeFaces#Ajax#update}} falls back to 
just forwarding the given clientId.

*Why does it happen?*
Like mojarra, myfaces filters the children on processing using {{{}instanceof 
UIColumn{}}}. But {{p:columns}} does not extend that class. Therefore 
{{p:columns}} is not a candiate and is simply ignored.

*Possible fix* (not yet tested)
Remove the check.

*How to reproduce*
Use the [reproducer 
|https://github.com/primefaces/primefaces/files/9664695/primefaces-test.zip] 
and change the PROJECT_STAGE to Development. Run the project using the 
myfaces23 profile. You should get a lot of logging entries like
{quote}Mai 21, 2024 2:53:41 PM org.primefaces.PrimeFaces$Ajax update
WARNUNG: PrimeFaces.current().ajax().update() called but component cant be 
resolved! Expression will just be added to the renderIds: \{0}
{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (TOBAGO-2314) SelectOneList, SelectManyList: dropdown menu is not removed after ajax reload

2024-05-21 Thread Jira
Henning Nöth created TOBAGO-2314:


 Summary: SelectOneList, SelectManyList: dropdown menu is not 
removed after ajax reload
 Key: TOBAGO-2314
 URL: https://issues.apache.org/jira/browse/TOBAGO-2314
 Project: MyFaces Tobago
  Issue Type: Bug
  Components: Core, JavaScript
Affects Versions: 6.4.0, 5.12.0
Reporter: Henning Nöth






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[PR] fix: select2 with MyFaces 2.0.16 [myfaces-tobago]

2024-05-21 Thread via GitHub


henningn opened a new pull request, #5128:
URL: https://github.com/apache/myfaces-tobago/pull/5128

   * set an ID for the customItemContainer
   
   Issue: TOBAGO-2312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org