[jira] [Comment Edited] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-05-28 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850259#comment-17850259
 ] 

Werner Punz edited comment on MYFACES-4669 at 5/29/24 5:44 AM:
---

I will have a look the next few days, lets see what I can find out!

Have assigned it temporarily to me, so that it does not get lost on me!

 


was (Author: werpu):
I will have a look the next few days, lets see what I can find out!

 

> Programmatic Facelet Not Rendering Correctly
> 
>
> Key: MYFACES-4669
> URL: https://issues.apache.org/jira/browse/MYFACES-4669
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2024-05-28-17-42-16-539.png, 
> image-2024-05-28-17-43-37-052.png, programmatic_view.zip
>
>
> Attached is an example:
> Run 
> {code:java}
> mvn clean jetty:run -Pmojarra40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders correctly.
> !image-2024-05-28-17-42-16-539.png!
>  
> Run 
> {code:java}
> mvn clean jetty:run -Pmyfaces40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders incorrectly with ESCAPED HTML tags.  [~werpu] this 
> looks like more double escaping for XML?
> !image-2024-05-28-17-43-37-052.png!
> {code:java}
> package org.apache.myfaces.core.extensions.quarkus.showcase.view;
> import jakarta.enterprise.context.ApplicationScoped;
> import jakarta.faces.annotation.View;
> import jakarta.faces.application.StateManager;
> import jakarta.faces.component.UIComponent;
> import jakarta.faces.component.UIOutput;
> import jakarta.faces.component.html.HtmlBody;
> import jakarta.faces.component.html.HtmlCommandButton;
> import jakarta.faces.component.html.HtmlForm;
> import jakarta.faces.component.html.HtmlOutputText;
> import jakarta.faces.context.FacesContext;
> import jakarta.faces.view.facelets.Facelet;
> @View("/facelet.xhtml")
> @ApplicationScoped
> public class FaceletView extends Facelet
> {
> @Override
> public void apply(FacesContext facesContext, UIComponent parent)
> {
> if 
> (!facesContext.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE))
> {
> return;
> }
> var components = new ComponentBuilder(facesContext);
> var rootChildren = parent.getChildren();
> var doctype = new UIOutput();
> doctype.setValue("");
> rootChildren.add(doctype);
> var htmlTag = new UIOutput();
> htmlTag.setValue("http://www.w3.org/1999/xhtml\";>");
> rootChildren.add(htmlTag);
> HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
> rootChildren.add(body);
> HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
> form.setId("form");
> body.getChildren().add(form);
> HtmlOutputText message = 
> components.create(HtmlOutputText.COMPONENT_TYPE);
> message.setId("message");
> HtmlCommandButton actionButton = 
> components.create(HtmlCommandButton.COMPONENT_TYPE);
> actionButton.setId("button");
> actionButton.addActionListener(
> e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
> Jakarta EE 10"));
> actionButton.setValue("Greet");
> form.getChildren().add(actionButton);
> parent.getChildren().add(message);
> htmlTag = new UIOutput();
> htmlTag.setValue("");
> rootChildren.add(htmlTag);
> }
> private static class ComponentBuilder
> {
> FacesContext facesContext;
> ComponentBuilder(FacesContext facesContext)
> {
> this.facesContext = facesContext;
> }
> @SuppressWarnings("unchecked")
>  T create(String componentType)
> {
> try
> {
> return (T) 
> facesContext.getApplication().createComponent(componentType);
> }
> catch (ClassCastException e)
> {
> throw new IllegalArgumentException("Component type " + 
> componentType + " is not valid.", e);
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-05-28 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850259#comment-17850259
 ] 

Werner Punz commented on MYFACES-4669:
--

I will have a look the next few days, lets see what I can find out!

 

> Programmatic Facelet Not Rendering Correctly
> 
>
> Key: MYFACES-4669
> URL: https://issues.apache.org/jira/browse/MYFACES-4669
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2024-05-28-17-42-16-539.png, 
> image-2024-05-28-17-43-37-052.png, programmatic_view.zip
>
>
> Attached is an example:
> Run 
> {code:java}
> mvn clean jetty:run -Pmojarra40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders correctly.
> !image-2024-05-28-17-42-16-539.png!
>  
> Run 
> {code:java}
> mvn clean jetty:run -Pmyfaces40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders incorrectly with ESCAPED HTML tags.  [~werpu] this 
> looks like more double escaping for XML?
> !image-2024-05-28-17-43-37-052.png!
> {code:java}
> package org.apache.myfaces.core.extensions.quarkus.showcase.view;
> import jakarta.enterprise.context.ApplicationScoped;
> import jakarta.faces.annotation.View;
> import jakarta.faces.application.StateManager;
> import jakarta.faces.component.UIComponent;
> import jakarta.faces.component.UIOutput;
> import jakarta.faces.component.html.HtmlBody;
> import jakarta.faces.component.html.HtmlCommandButton;
> import jakarta.faces.component.html.HtmlForm;
> import jakarta.faces.component.html.HtmlOutputText;
> import jakarta.faces.context.FacesContext;
> import jakarta.faces.view.facelets.Facelet;
> @View("/facelet.xhtml")
> @ApplicationScoped
> public class FaceletView extends Facelet
> {
> @Override
> public void apply(FacesContext facesContext, UIComponent parent)
> {
> if 
> (!facesContext.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE))
> {
> return;
> }
> var components = new ComponentBuilder(facesContext);
> var rootChildren = parent.getChildren();
> var doctype = new UIOutput();
> doctype.setValue("");
> rootChildren.add(doctype);
> var htmlTag = new UIOutput();
> htmlTag.setValue("http://www.w3.org/1999/xhtml\";>");
> rootChildren.add(htmlTag);
> HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
> rootChildren.add(body);
> HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
> form.setId("form");
> body.getChildren().add(form);
> HtmlOutputText message = 
> components.create(HtmlOutputText.COMPONENT_TYPE);
> message.setId("message");
> HtmlCommandButton actionButton = 
> components.create(HtmlCommandButton.COMPONENT_TYPE);
> actionButton.setId("button");
> actionButton.addActionListener(
> e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
> Jakarta EE 10"));
> actionButton.setValue("Greet");
> form.getChildren().add(actionButton);
> parent.getChildren().add(message);
> htmlTag = new UIOutput();
> htmlTag.setValue("");
> rootChildren.add(htmlTag);
> }
> private static class ComponentBuilder
> {
> FacesContext facesContext;
> ComponentBuilder(FacesContext facesContext)
> {
> this.facesContext = facesContext;
> }
> @SuppressWarnings("unchecked")
>  T create(String componentType)
> {
> try
> {
> return (T) 
> facesContext.getApplication().createComponent(componentType);
> }
> catch (ClassCastException e)
> {
> throw new IllegalArgumentException("Component type " + 
> componentType + " is not valid.", e);
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-05-28 Thread Melloware (Jira)
Melloware created MYFACES-4669:
--

 Summary: Programmatic Facelet Not Rendering Correctly
 Key: MYFACES-4669
 URL: https://issues.apache.org/jira/browse/MYFACES-4669
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
Reporter: Melloware
 Attachments: image-2024-05-28-17-42-16-539.png, 
image-2024-05-28-17-43-37-052.png, programmatic_view.zip

Attached is an example:

Run `mvn clean jetty:run -Pmojarra40` and you will see the programmatic view 
renders correctly.

!image-2024-05-28-17-42-16-539.png!

 

Run `mvn clean jetty:run -Pmyfaces40` and you will see the programmatic view 
renders incorrectly with ESCAPED HTML tags.  [~werpu] this looks like more 
double escaping for XML?

!image-2024-05-28-17-43-37-052.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MYFACES-4668) Quarkus: Programmatic Views not working

2024-05-28 Thread Melloware (Jira)
Melloware created MYFACES-4668:
--

 Summary: Quarkus: Programmatic Views not working
 Key: MYFACES-4668
 URL: https://issues.apache.org/jira/browse/MYFACES-4668
 Project: MyFaces Core
  Issue Type: Bug
  Components: Extension Feature
Affects Versions: 4.1.0-RC1, 4.0.2, 5.0.0
Reporter: Melloware


Original report: [https://github.com/melloware/quarkus-faces/issues/444]

 

I tried to add a programmatic view with the `@View` annotation, but when I 
access http://localhost:8080/facelet.xhml it returns 404

 
{code:java}
@View("/facelet.xhtml")
@ApplicationScoped
public class FaceletView extends Facelet {
    @Override
    public void apply(FacesContext facesContext, UIComponent parent) {
        if 
(!facesContext.getAttributes().containsKey(IS_BUILDING_INITIAL_STATE)) {
            return;
        }
        var components = new ComponentBuilder(facesContext);
        var rootChildren = parent.getChildren();
        var doctype = new UIOutput();
        doctype.setValue("");
        rootChildren.add(doctype);
        var htmlTag = new UIOutput();
        htmlTag.setValue("http://www.w3.org/1999/xhtml\";>");
        rootChildren.add(htmlTag);
        HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
        rootChildren.add(body);
        HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
        form.setId("form");
        body.getChildren().add(form);
        HtmlOutputText message = 
components.create(HtmlOutputText.COMPONENT_TYPE);
        message.setId("message");
        HtmlCommandButton actionButton = 
components.create(HtmlCommandButton.COMPONENT_TYPE);
        actionButton.setId("button");
        actionButton.addActionListener(
                e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
Jakarta EE 10"));
        actionButton.setValue("Greet");
        form.getChildren().add(actionButton);
        parent.getChildren().add(message);
        htmlTag = new UIOutput();
        htmlTag.setValue("");
        rootChildren.add(htmlTag);
    }
    private static class ComponentBuilder {
        FacesContext facesContext;
        ComponentBuilder(FacesContext facesContext) {
            this.facesContext = facesContext;
        }
        @SuppressWarnings("unchecked")
         T create(String componentType) {
            return (T) 
facesContext.getApplication().createComponent(facesContext, componentType, 
null);
        }
    }
}
 
{code}
 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] fix: select2 with MyFaces 2.0.16 [myfaces-tobago]

2024-05-28 Thread via GitHub


weber-oldenburg merged PR #5128:
URL: https://github.com/apache/myfaces-tobago/pull/5128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] refactor: update to minor version [myfaces-tobago]

2024-05-28 Thread via GitHub


henningn merged PR #5138:
URL: https://github.com/apache/myfaces-tobago/pull/5138


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] refactor: update to minor version [myfaces-tobago]

2024-05-28 Thread via GitHub


henningn merged PR #5139:
URL: https://github.com/apache/myfaces-tobago/pull/5139


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] refactor: update to minor version [myfaces-tobago]

2024-05-28 Thread via GitHub


henningn opened a new pull request, #5139:
URL: https://github.com/apache/myfaces-tobago/pull/5139

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] refactor: update to minor version [myfaces-tobago]

2024-05-28 Thread via GitHub


henningn opened a new pull request, #5138:
URL: https://github.com/apache/myfaces-tobago/pull/5138

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org