[jira] [Comment Edited] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-06-04 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852188#comment-17852188
 ] 

Werner Punz edited comment on MYFACES-4669 at 6/4/24 8:43 PM:
--

I I just checked the comments on this one, wanted to take over it on thursday, 
if it is a Mojarra bug then yes it needs to be filed on the mojarra side not on 
the MyFaces side. MyFaces seems to follow the spec here, Mojarra not!

I will unassign me from this bug then, feel free to close it!

 


was (Author: werpu):
I I just checked the comments on this one, wanted to take over it on thursday, 
if it is a mojarra bug then yes it needs to be filed on the mojarra side not on 
the myfaces side. MyFaces seems to follow the spec here, Mojarra not!

I will unassign me from this bug then, feel free to close it!

 

> Programmatic Facelet Not Rendering Correctly
> 
>
> Key: MYFACES-4669
> URL: https://issues.apache.org/jira/browse/MYFACES-4669
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
>Reporter: Melloware
>Priority: Major
> Attachments: image-2024-05-28-17-42-16-539.png, 
> image-2024-05-28-17-43-37-052.png, programmatic_view.zip
>
>
> Attached is an example:
> Run 
> {code:java}
> mvn clean jetty:run -Pmojarra40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders correctly.
> !image-2024-05-28-17-42-16-539.png!
>  
> Run 
> {code:java}
> mvn clean jetty:run -Pmyfaces40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders incorrectly with ESCAPED HTML tags.  [~werpu] this 
> looks like more double escaping for XML?
> !image-2024-05-28-17-43-37-052.png!
> {code:java}
> package org.apache.myfaces.core.extensions.quarkus.showcase.view;
> import jakarta.enterprise.context.ApplicationScoped;
> import jakarta.faces.annotation.View;
> import jakarta.faces.application.StateManager;
> import jakarta.faces.component.UIComponent;
> import jakarta.faces.component.UIOutput;
> import jakarta.faces.component.html.HtmlBody;
> import jakarta.faces.component.html.HtmlCommandButton;
> import jakarta.faces.component.html.HtmlForm;
> import jakarta.faces.component.html.HtmlOutputText;
> import jakarta.faces.context.FacesContext;
> import jakarta.faces.view.facelets.Facelet;
> @View("/facelet.xhtml")
> @ApplicationScoped
> public class FaceletView extends Facelet
> {
> @Override
> public void apply(FacesContext facesContext, UIComponent parent)
> {
> if 
> (!facesContext.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE))
> {
> return;
> }
> var components = new ComponentBuilder(facesContext);
> var rootChildren = parent.getChildren();
> var doctype = new UIOutput();
> doctype.setValue("");
> rootChildren.add(doctype);
> var htmlTag = new UIOutput();
> htmlTag.setValue("http://www.w3.org/1999/xhtml\;>");
> rootChildren.add(htmlTag);
> HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
> rootChildren.add(body);
> HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
> form.setId("form");
> body.getChildren().add(form);
> HtmlOutputText message = 
> components.create(HtmlOutputText.COMPONENT_TYPE);
> message.setId("message");
> HtmlCommandButton actionButton = 
> components.create(HtmlCommandButton.COMPONENT_TYPE);
> actionButton.setId("button");
> actionButton.addActionListener(
> e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
> Jakarta EE 10"));
> actionButton.setValue("Greet");
> form.getChildren().add(actionButton);
> parent.getChildren().add(message);
> htmlTag = new UIOutput();
> htmlTag.setValue("");
> rootChildren.add(htmlTag);
> }
> private static class ComponentBuilder
> {
> FacesContext facesContext;
> ComponentBuilder(FacesContext facesContext)
> {
> this.facesContext = facesContext;
> }
> @SuppressWarnings("unchecked")
>  T create(String componentType)
> {
> try
> {
> return (T) 
> facesContext.getApplication().createComponent(componentType);
> }
> catch (ClassCastException e)
> {
> throw new IllegalArgumentException("Component type " + 
> componentType + " is not valid.", e);
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-06-04 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852188#comment-17852188
 ] 

Werner Punz commented on MYFACES-4669:
--

I I just checked the comments on this one, wanted to take over it on thursday, 
if it is a mojarra bug then yes it needs to be filed on the mojarra side not on 
the myfaces side. MyFaces seems to follow the spec here, Mojarra not!

 

> Programmatic Facelet Not Rendering Correctly
> 
>
> Key: MYFACES-4669
> URL: https://issues.apache.org/jira/browse/MYFACES-4669
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2024-05-28-17-42-16-539.png, 
> image-2024-05-28-17-43-37-052.png, programmatic_view.zip
>
>
> Attached is an example:
> Run 
> {code:java}
> mvn clean jetty:run -Pmojarra40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders correctly.
> !image-2024-05-28-17-42-16-539.png!
>  
> Run 
> {code:java}
> mvn clean jetty:run -Pmyfaces40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders incorrectly with ESCAPED HTML tags.  [~werpu] this 
> looks like more double escaping for XML?
> !image-2024-05-28-17-43-37-052.png!
> {code:java}
> package org.apache.myfaces.core.extensions.quarkus.showcase.view;
> import jakarta.enterprise.context.ApplicationScoped;
> import jakarta.faces.annotation.View;
> import jakarta.faces.application.StateManager;
> import jakarta.faces.component.UIComponent;
> import jakarta.faces.component.UIOutput;
> import jakarta.faces.component.html.HtmlBody;
> import jakarta.faces.component.html.HtmlCommandButton;
> import jakarta.faces.component.html.HtmlForm;
> import jakarta.faces.component.html.HtmlOutputText;
> import jakarta.faces.context.FacesContext;
> import jakarta.faces.view.facelets.Facelet;
> @View("/facelet.xhtml")
> @ApplicationScoped
> public class FaceletView extends Facelet
> {
> @Override
> public void apply(FacesContext facesContext, UIComponent parent)
> {
> if 
> (!facesContext.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE))
> {
> return;
> }
> var components = new ComponentBuilder(facesContext);
> var rootChildren = parent.getChildren();
> var doctype = new UIOutput();
> doctype.setValue("");
> rootChildren.add(doctype);
> var htmlTag = new UIOutput();
> htmlTag.setValue("http://www.w3.org/1999/xhtml\;>");
> rootChildren.add(htmlTag);
> HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
> rootChildren.add(body);
> HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
> form.setId("form");
> body.getChildren().add(form);
> HtmlOutputText message = 
> components.create(HtmlOutputText.COMPONENT_TYPE);
> message.setId("message");
> HtmlCommandButton actionButton = 
> components.create(HtmlCommandButton.COMPONENT_TYPE);
> actionButton.setId("button");
> actionButton.addActionListener(
> e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
> Jakarta EE 10"));
> actionButton.setValue("Greet");
> form.getChildren().add(actionButton);
> parent.getChildren().add(message);
> htmlTag = new UIOutput();
> htmlTag.setValue("");
> rootChildren.add(htmlTag);
> }
> private static class ComponentBuilder
> {
> FacesContext facesContext;
> ComponentBuilder(FacesContext facesContext)
> {
> this.facesContext = facesContext;
> }
> @SuppressWarnings("unchecked")
>  T create(String componentType)
> {
> try
> {
> return (T) 
> facesContext.getApplication().createComponent(componentType);
> }
> catch (ClassCastException e)
> {
> throw new IllegalArgumentException("Component type " + 
> componentType + " is not valid.", e);
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-06-04 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852188#comment-17852188
 ] 

Werner Punz edited comment on MYFACES-4669 at 6/4/24 8:42 PM:
--

I I just checked the comments on this one, wanted to take over it on thursday, 
if it is a mojarra bug then yes it needs to be filed on the mojarra side not on 
the myfaces side. MyFaces seems to follow the spec here, Mojarra not!

I will unassign me from this bug then, feel free to close it!

 


was (Author: werpu):
I I just checked the comments on this one, wanted to take over it on thursday, 
if it is a mojarra bug then yes it needs to be filed on the mojarra side not on 
the myfaces side. MyFaces seems to follow the spec here, Mojarra not!

 

> Programmatic Facelet Not Rendering Correctly
> 
>
> Key: MYFACES-4669
> URL: https://issues.apache.org/jira/browse/MYFACES-4669
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2024-05-28-17-42-16-539.png, 
> image-2024-05-28-17-43-37-052.png, programmatic_view.zip
>
>
> Attached is an example:
> Run 
> {code:java}
> mvn clean jetty:run -Pmojarra40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders correctly.
> !image-2024-05-28-17-42-16-539.png!
>  
> Run 
> {code:java}
> mvn clean jetty:run -Pmyfaces40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders incorrectly with ESCAPED HTML tags.  [~werpu] this 
> looks like more double escaping for XML?
> !image-2024-05-28-17-43-37-052.png!
> {code:java}
> package org.apache.myfaces.core.extensions.quarkus.showcase.view;
> import jakarta.enterprise.context.ApplicationScoped;
> import jakarta.faces.annotation.View;
> import jakarta.faces.application.StateManager;
> import jakarta.faces.component.UIComponent;
> import jakarta.faces.component.UIOutput;
> import jakarta.faces.component.html.HtmlBody;
> import jakarta.faces.component.html.HtmlCommandButton;
> import jakarta.faces.component.html.HtmlForm;
> import jakarta.faces.component.html.HtmlOutputText;
> import jakarta.faces.context.FacesContext;
> import jakarta.faces.view.facelets.Facelet;
> @View("/facelet.xhtml")
> @ApplicationScoped
> public class FaceletView extends Facelet
> {
> @Override
> public void apply(FacesContext facesContext, UIComponent parent)
> {
> if 
> (!facesContext.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE))
> {
> return;
> }
> var components = new ComponentBuilder(facesContext);
> var rootChildren = parent.getChildren();
> var doctype = new UIOutput();
> doctype.setValue("");
> rootChildren.add(doctype);
> var htmlTag = new UIOutput();
> htmlTag.setValue("http://www.w3.org/1999/xhtml\;>");
> rootChildren.add(htmlTag);
> HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
> rootChildren.add(body);
> HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
> form.setId("form");
> body.getChildren().add(form);
> HtmlOutputText message = 
> components.create(HtmlOutputText.COMPONENT_TYPE);
> message.setId("message");
> HtmlCommandButton actionButton = 
> components.create(HtmlCommandButton.COMPONENT_TYPE);
> actionButton.setId("button");
> actionButton.addActionListener(
> e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
> Jakarta EE 10"));
> actionButton.setValue("Greet");
> form.getChildren().add(actionButton);
> parent.getChildren().add(message);
> htmlTag = new UIOutput();
> htmlTag.setValue("");
> rootChildren.add(htmlTag);
> }
> private static class ComponentBuilder
> {
> FacesContext facesContext;
> ComponentBuilder(FacesContext facesContext)
> {
> this.facesContext = facesContext;
> }
> @SuppressWarnings("unchecked")
>  T create(String componentType)
> {
> try
> {
> return (T) 
> facesContext.getApplication().createComponent(componentType);
> }
> catch (ClassCastException e)
> {
> throw new IllegalArgumentException("Component type " + 
> componentType + " is not valid.", e);
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-06-04 Thread Melloware (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852185#comment-17852185
 ] 

Melloware commented on MYFACES-4669:


OK its a Mojarra bug should we close this Myfaces bug?

> Programmatic Facelet Not Rendering Correctly
> 
>
> Key: MYFACES-4669
> URL: https://issues.apache.org/jira/browse/MYFACES-4669
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2024-05-28-17-42-16-539.png, 
> image-2024-05-28-17-43-37-052.png, programmatic_view.zip
>
>
> Attached is an example:
> Run 
> {code:java}
> mvn clean jetty:run -Pmojarra40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders correctly.
> !image-2024-05-28-17-42-16-539.png!
>  
> Run 
> {code:java}
> mvn clean jetty:run -Pmyfaces40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders incorrectly with ESCAPED HTML tags.  [~werpu] this 
> looks like more double escaping for XML?
> !image-2024-05-28-17-43-37-052.png!
> {code:java}
> package org.apache.myfaces.core.extensions.quarkus.showcase.view;
> import jakarta.enterprise.context.ApplicationScoped;
> import jakarta.faces.annotation.View;
> import jakarta.faces.application.StateManager;
> import jakarta.faces.component.UIComponent;
> import jakarta.faces.component.UIOutput;
> import jakarta.faces.component.html.HtmlBody;
> import jakarta.faces.component.html.HtmlCommandButton;
> import jakarta.faces.component.html.HtmlForm;
> import jakarta.faces.component.html.HtmlOutputText;
> import jakarta.faces.context.FacesContext;
> import jakarta.faces.view.facelets.Facelet;
> @View("/facelet.xhtml")
> @ApplicationScoped
> public class FaceletView extends Facelet
> {
> @Override
> public void apply(FacesContext facesContext, UIComponent parent)
> {
> if 
> (!facesContext.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE))
> {
> return;
> }
> var components = new ComponentBuilder(facesContext);
> var rootChildren = parent.getChildren();
> var doctype = new UIOutput();
> doctype.setValue("");
> rootChildren.add(doctype);
> var htmlTag = new UIOutput();
> htmlTag.setValue("http://www.w3.org/1999/xhtml\;>");
> rootChildren.add(htmlTag);
> HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
> rootChildren.add(body);
> HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
> form.setId("form");
> body.getChildren().add(form);
> HtmlOutputText message = 
> components.create(HtmlOutputText.COMPONENT_TYPE);
> message.setId("message");
> HtmlCommandButton actionButton = 
> components.create(HtmlCommandButton.COMPONENT_TYPE);
> actionButton.setId("button");
> actionButton.addActionListener(
> e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
> Jakarta EE 10"));
> actionButton.setValue("Greet");
> form.getChildren().add(actionButton);
> parent.getChildren().add(message);
> htmlTag = new UIOutput();
> htmlTag.setValue("");
> rootChildren.add(htmlTag);
> }
> private static class ComponentBuilder
> {
> FacesContext facesContext;
> ComponentBuilder(FacesContext facesContext)
> {
> this.facesContext = facesContext;
> }
> @SuppressWarnings("unchecked")
>  T create(String componentType)
> {
> try
> {
> return (T) 
> facesContext.getApplication().createComponent(componentType);
> }
> catch (ClassCastException e)
> {
> throw new IllegalArgumentException("Component type " + 
> componentType + " is not valid.", e);
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-06-04 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852172#comment-17852172
 ] 

Volodymyr Siedlecki edited comment on MYFACES-4669 at 6/4/24 7:35 PM:
--

I reported a similar problem here: 
[https://github.com/jakartaee/faces/issues/1796]

MyFaces will need to NOT escape the XML.  I think this is a spec bug? 

Code to set escape to false: 
https://github.com/apache/myfaces/blob/1b8695232fdf601cad043e45be570da89a4e65b3/integration-tests/automaticExtensionlessMapping/src/main/java/org/apache/myfaces/core/integrationtests/ProgrammaticViewBean.java#L59C1-L62C34


was (Author: volosied):
I reported a similar problem here: 
[https://github.com/jakartaee/faces/issues/1796]

MyFaces will need to escape the XML.  I think this is a spec bug.

> Programmatic Facelet Not Rendering Correctly
> 
>
> Key: MYFACES-4669
> URL: https://issues.apache.org/jira/browse/MYFACES-4669
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2024-05-28-17-42-16-539.png, 
> image-2024-05-28-17-43-37-052.png, programmatic_view.zip
>
>
> Attached is an example:
> Run 
> {code:java}
> mvn clean jetty:run -Pmojarra40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders correctly.
> !image-2024-05-28-17-42-16-539.png!
>  
> Run 
> {code:java}
> mvn clean jetty:run -Pmyfaces40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders incorrectly with ESCAPED HTML tags.  [~werpu] this 
> looks like more double escaping for XML?
> !image-2024-05-28-17-43-37-052.png!
> {code:java}
> package org.apache.myfaces.core.extensions.quarkus.showcase.view;
> import jakarta.enterprise.context.ApplicationScoped;
> import jakarta.faces.annotation.View;
> import jakarta.faces.application.StateManager;
> import jakarta.faces.component.UIComponent;
> import jakarta.faces.component.UIOutput;
> import jakarta.faces.component.html.HtmlBody;
> import jakarta.faces.component.html.HtmlCommandButton;
> import jakarta.faces.component.html.HtmlForm;
> import jakarta.faces.component.html.HtmlOutputText;
> import jakarta.faces.context.FacesContext;
> import jakarta.faces.view.facelets.Facelet;
> @View("/facelet.xhtml")
> @ApplicationScoped
> public class FaceletView extends Facelet
> {
> @Override
> public void apply(FacesContext facesContext, UIComponent parent)
> {
> if 
> (!facesContext.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE))
> {
> return;
> }
> var components = new ComponentBuilder(facesContext);
> var rootChildren = parent.getChildren();
> var doctype = new UIOutput();
> doctype.setValue("");
> rootChildren.add(doctype);
> var htmlTag = new UIOutput();
> htmlTag.setValue("http://www.w3.org/1999/xhtml\;>");
> rootChildren.add(htmlTag);
> HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
> rootChildren.add(body);
> HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
> form.setId("form");
> body.getChildren().add(form);
> HtmlOutputText message = 
> components.create(HtmlOutputText.COMPONENT_TYPE);
> message.setId("message");
> HtmlCommandButton actionButton = 
> components.create(HtmlCommandButton.COMPONENT_TYPE);
> actionButton.setId("button");
> actionButton.addActionListener(
> e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
> Jakarta EE 10"));
> actionButton.setValue("Greet");
> form.getChildren().add(actionButton);
> parent.getChildren().add(message);
> htmlTag = new UIOutput();
> htmlTag.setValue("");
> rootChildren.add(htmlTag);
> }
> private static class ComponentBuilder
> {
> FacesContext facesContext;
> ComponentBuilder(FacesContext facesContext)
> {
> this.facesContext = facesContext;
> }
> @SuppressWarnings("unchecked")
>  T create(String componentType)
> {
> try
> {
> return (T) 
> facesContext.getApplication().createComponent(componentType);
> }
> catch (ClassCastException e)
> {
> throw new IllegalArgumentException("Component type " + 
> componentType + " is not valid.", e);
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4669) Programmatic Facelet Not Rendering Correctly

2024-06-04 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852172#comment-17852172
 ] 

Volodymyr Siedlecki commented on MYFACES-4669:
--

I reported a similar problem here: 
[https://github.com/jakartaee/faces/issues/1796]

MyFaces will need to escape the XML.  I think this is a spec bug.

> Programmatic Facelet Not Rendering Correctly
> 
>
> Key: MYFACES-4669
> URL: https://issues.apache.org/jira/browse/MYFACES-4669
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: General
>Affects Versions: 4.0.2, 5.0.0, 4.1.0-RC3
>Reporter: Melloware
>Assignee: Werner Punz
>Priority: Major
> Attachments: image-2024-05-28-17-42-16-539.png, 
> image-2024-05-28-17-43-37-052.png, programmatic_view.zip
>
>
> Attached is an example:
> Run 
> {code:java}
> mvn clean jetty:run -Pmojarra40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders correctly.
> !image-2024-05-28-17-42-16-539.png!
>  
> Run 
> {code:java}
> mvn clean jetty:run -Pmyfaces40{code}
>  and navigate to [http://localhost:8080/facelet.xhtml] you will see the 
> programmatic view renders incorrectly with ESCAPED HTML tags.  [~werpu] this 
> looks like more double escaping for XML?
> !image-2024-05-28-17-43-37-052.png!
> {code:java}
> package org.apache.myfaces.core.extensions.quarkus.showcase.view;
> import jakarta.enterprise.context.ApplicationScoped;
> import jakarta.faces.annotation.View;
> import jakarta.faces.application.StateManager;
> import jakarta.faces.component.UIComponent;
> import jakarta.faces.component.UIOutput;
> import jakarta.faces.component.html.HtmlBody;
> import jakarta.faces.component.html.HtmlCommandButton;
> import jakarta.faces.component.html.HtmlForm;
> import jakarta.faces.component.html.HtmlOutputText;
> import jakarta.faces.context.FacesContext;
> import jakarta.faces.view.facelets.Facelet;
> @View("/facelet.xhtml")
> @ApplicationScoped
> public class FaceletView extends Facelet
> {
> @Override
> public void apply(FacesContext facesContext, UIComponent parent)
> {
> if 
> (!facesContext.getAttributes().containsKey(StateManager.IS_BUILDING_INITIAL_STATE))
> {
> return;
> }
> var components = new ComponentBuilder(facesContext);
> var rootChildren = parent.getChildren();
> var doctype = new UIOutput();
> doctype.setValue("");
> rootChildren.add(doctype);
> var htmlTag = new UIOutput();
> htmlTag.setValue("http://www.w3.org/1999/xhtml\;>");
> rootChildren.add(htmlTag);
> HtmlBody body = components.create(HtmlBody.COMPONENT_TYPE);
> rootChildren.add(body);
> HtmlForm form = components.create(HtmlForm.COMPONENT_TYPE);
> form.setId("form");
> body.getChildren().add(form);
> HtmlOutputText message = 
> components.create(HtmlOutputText.COMPONENT_TYPE);
> message.setId("message");
> HtmlCommandButton actionButton = 
> components.create(HtmlCommandButton.COMPONENT_TYPE);
> actionButton.setId("button");
> actionButton.addActionListener(
> e -> message.setValue("Hello, World! Welcome to Faces 4.0 on 
> Jakarta EE 10"));
> actionButton.setValue("Greet");
> form.getChildren().add(actionButton);
> parent.getChildren().add(message);
> htmlTag = new UIOutput();
> htmlTag.setValue("");
> rootChildren.add(htmlTag);
> }
> private static class ComponentBuilder
> {
> FacesContext facesContext;
> ComponentBuilder(FacesContext facesContext)
> {
> this.facesContext = facesContext;
> }
> @SuppressWarnings("unchecked")
>  T create(String componentType)
> {
> try
> {
> return (T) 
> facesContext.getApplication().createComponent(componentType);
> }
> catch (ClassCastException e)
> {
> throw new IllegalArgumentException("Component type " + 
> componentType + " is not valid.", e);
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4670) [Invalid] Cannot Uncheck CheckBox (MYFACES-4606 Regression)

2024-06-04 Thread Werner Punz (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852162#comment-17852162
 ] 

Werner Punz commented on MYFACES-4670:
--

Great thanks for the update, as for the other issue assigned to me, I will 
start to work on it on thursday, wont have time before!

 

> [Invalid] Cannot Uncheck CheckBox (MYFACES-4606 Regression) 
> 
>
> Key: MYFACES-4670
> URL: https://issues.apache.org/jira/browse/MYFACES-4670
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Minor
> Attachments: checkbox.war
>
>
> You cannot uncheck a checkbox after it is selected.  App is attached. It 
> looks like a regression from MYFACES-4606. MyFaces 3.0/2.3 look fine and only 
> 4.0 seems to be affected here.
> Form Data is found below:
> Working (3.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Second >>>
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Failing (4.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"{code}
> Second >
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1:box    "true"{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4670) Cannot Uncheck CheckBox (MYFACES-4606 Regression)

2024-06-04 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852156#comment-17852156
 ] 

Volodymyr Siedlecki commented on MYFACES-4670:
--

Turns out this is fixed in the latest code.  My changes didn't include 
https://issues.apache.org/jira/browse/MYFACES-4658.

> Cannot Uncheck CheckBox (MYFACES-4606 Regression)
> -
>
> Key: MYFACES-4670
> URL: https://issues.apache.org/jira/browse/MYFACES-4670
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: checkbox.war
>
>
> You cannot uncheck a checkbox after it is selected.  App is attached. It 
> looks like a regression from MYFACES-4606. MyFaces 3.0/2.3 look fine and only 
> 4.0 seems to be affected here.
> Form Data is found below:
> Working (3.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Second >>>
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Failing (4.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"{code}
> Second >
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1:box    "true"{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MYFACES-4670) Cannot Uncheck CheckBox (MYFACES-4606 Regression)

2024-06-04 Thread Volodymyr Siedlecki (Jira)


 [ 
https://issues.apache.org/jira/browse/MYFACES-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Volodymyr Siedlecki resolved MYFACES-4670.
--
Resolution: Invalid

> Cannot Uncheck CheckBox (MYFACES-4606 Regression)
> -
>
> Key: MYFACES-4670
> URL: https://issues.apache.org/jira/browse/MYFACES-4670
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: checkbox.war
>
>
> You cannot uncheck a checkbox after it is selected.  App is attached. It 
> looks like a regression from MYFACES-4606. MyFaces 3.0/2.3 look fine and only 
> 4.0 seems to be affected here.
> Form Data is found below:
> Working (3.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Second >>>
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Failing (4.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"{code}
> Second >
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1:box    "true"{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4670) Cannot Uncheck CheckBox (MYFACES-4606 Regression)

2024-06-04 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852146#comment-17852146
 ] 

Volodymyr Siedlecki edited comment on MYFACES-4670 at 6/4/24 6:24 PM:
--

Looks like the extra 
form1:box true 
is the problem?

Code: 
https://github.com/apache/myfaces/blob/4.0.x/api/src/client/typescript/faces/impl/xhrCore/XhrRequest.ts#L419-L422


was (Author: volosied):
Looks like the extra 
form1:box true 
is the problem?

> Cannot Uncheck CheckBox (MYFACES-4606 Regression)
> -
>
> Key: MYFACES-4670
> URL: https://issues.apache.org/jira/browse/MYFACES-4670
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: checkbox.war
>
>
> You cannot uncheck a checkbox after it is selected.  App is attached. It 
> looks like a regression from MYFACES-4606. MyFaces 3.0/2.3 look fine and only 
> 4.0 seems to be affected here.
> Form Data is found below:
> Working (3.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Second >>>
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Failing (4.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"{code}
> Second >
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1:box    "true"{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MYFACES-4670) Cannot Uncheck CheckBox (MYFACES-4606 Regression)

2024-06-04 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852146#comment-17852146
 ] 

Volodymyr Siedlecki edited comment on MYFACES-4670 at 6/4/24 6:24 PM:
--

Looks like the extra "form1:box true" is the problem?

Added here:

 
[https://github.com/apache/myfaces/blob/4.0.x/api/src/client/typescript/faces/impl/xhrCore/XhrRequest.ts#L419-L422]


was (Author: volosied):
Looks like the extra 
form1:box true 
is the problem?

Code: 
https://github.com/apache/myfaces/blob/4.0.x/api/src/client/typescript/faces/impl/xhrCore/XhrRequest.ts#L419-L422

> Cannot Uncheck CheckBox (MYFACES-4606 Regression)
> -
>
> Key: MYFACES-4670
> URL: https://issues.apache.org/jira/browse/MYFACES-4670
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: checkbox.war
>
>
> You cannot uncheck a checkbox after it is selected.  App is attached. It 
> looks like a regression from MYFACES-4606. MyFaces 3.0/2.3 look fine and only 
> 4.0 seems to be affected here.
> Form Data is found below:
> Working (3.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Second >>>
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Failing (4.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"{code}
> Second >
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1:box    "true"{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4670) Cannot Uncheck CheckBox (MYFACES-4606 Regression)

2024-06-04 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852146#comment-17852146
 ] 

Volodymyr Siedlecki commented on MYFACES-4670:
--

Looks like the extra 
form1:box true 
is the problem?

> Cannot Uncheck CheckBox (MYFACES-4606 Regression)
> -
>
> Key: MYFACES-4670
> URL: https://issues.apache.org/jira/browse/MYFACES-4670
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: checkbox.war
>
>
> You cannot uncheck a checkbox after it is selected.  App is attached. It 
> looks like a regression from MYFACES-4606. MyFaces 3.0/2.3 look fine and only 
> 4.0 seems to be affected here.
> Form Data is found below:
> Working (3.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Second >>>
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Failing (4.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"{code}
> Second >
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1:box    "true"{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MYFACES-4670) Cannot Uncheck CheckBox (MYFACES-4606 Regression)

2024-06-04 Thread Volodymyr Siedlecki (Jira)


[ 
https://issues.apache.org/jira/browse/MYFACES-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852144#comment-17852144
 ] 

Volodymyr Siedlecki commented on MYFACES-4670:
--

[~werpu]  Could you take a look?

> Cannot Uncheck CheckBox (MYFACES-4606 Regression)
> -
>
> Key: MYFACES-4670
> URL: https://issues.apache.org/jira/browse/MYFACES-4670
> Project: MyFaces Core
>  Issue Type: Bug
>Affects Versions: 4.0.0
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: checkbox.war
>
>
> You cannot uncheck a checkbox after it is selected.  App is attached. It 
> looks like a regression from MYFACES-4606. MyFaces 3.0 looks fine and only 
> 4.0 seems to be affected here. 
> Form Data is found below: 
> Working (3.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Second >>>
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1    "form1"{code}
> Failing (4.0):
> First Request 
> {code:java}
> form1:box    "true"
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"{code}
> Second >
> {code:java}
> form1_SUBMIT    "1"
> jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
> jakarta.faces.behavior.event    "change"
> jakarta.faces.partial.event    "change"
> jakarta.faces.source    "form1:box"
> jakarta.faces.partial.ajax    "true"
> form1    "form1"
> jakarta.faces.partial.execute    "form1:box"
> jakarta.faces.partial.render    "form1:box"
> form1:box    "true"{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MYFACES-4670) Cannot Uncheck CheckBox (MYFACES-4606 Regression)

2024-06-04 Thread Volodymyr Siedlecki (Jira)
Volodymyr Siedlecki created MYFACES-4670:


 Summary: Cannot Uncheck CheckBox (MYFACES-4606 Regression)
 Key: MYFACES-4670
 URL: https://issues.apache.org/jira/browse/MYFACES-4670
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 4.0.0
Reporter: Volodymyr Siedlecki


You cannot uncheck a checkbox after it is selected.  App is attached. It looks 
like a regression from MYFACES-4606. MyFaces 3.0 looks fine and only 4.0 seems 
to be affected here. 

Form Data is found below: 

Working (3.0):

First Request 
{code:java}
form1:box    "true"
form1_SUBMIT    "1"
jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
jakarta.faces.behavior.event    "change"
jakarta.faces.partial.event    "change"
jakarta.faces.source    "form1:box"
jakarta.faces.partial.ajax    "true"
jakarta.faces.partial.execute    "form1:box"
jakarta.faces.partial.render    "form1:box"
form1    "form1"{code}
Second >>>
{code:java}
form1_SUBMIT    "1"
jakarta.faces.ViewState    "ODcyODU5ZDg0NDRmZmZmMzAwMDAwMDAx"
jakarta.faces.behavior.event    "change"
jakarta.faces.partial.event    "change"
jakarta.faces.source    "form1:box"
jakarta.faces.partial.ajax    "true"
jakarta.faces.partial.execute    "form1:box"
jakarta.faces.partial.render    "form1:box"
form1    "form1"{code}
Failing (4.0):

First Request 
{code:java}
form1:box    "true"
form1_SUBMIT    "1"
jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
jakarta.faces.behavior.event    "change"
jakarta.faces.partial.event    "change"
jakarta.faces.source    "form1:box"
jakarta.faces.partial.ajax    "true"
form1    "form1"
jakarta.faces.partial.execute    "form1:box"
jakarta.faces.partial.render    "form1:box"{code}
Second >
{code:java}
form1_SUBMIT    "1"
jakarta.faces.ViewState    "MDJmNTEzOWQ0NDFlZDVlYjAwMDAwMDAx"
jakarta.faces.behavior.event    "change"
jakarta.faces.partial.event    "change"
jakarta.faces.source    "form1:box"
jakarta.faces.partial.ajax    "true"
form1    "form1"
jakarta.faces.partial.execute    "form1:box"
jakarta.faces.partial.render    "form1:box"
form1:box    "true"{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (TOBAGO-2320) tc:popup throws PropertyNotWriteableException

2024-06-04 Thread Carsten Dimmek (Jira)


[ 
https://issues.apache.org/jira/browse/TOBAGO-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851958#comment-17851958
 ] 

Carsten Dimmek commented on TOBAGO-2320:


{code:java}
org.apache.myfaces.view.facelets.el.ContextAwarePropertyNotWritableException: 
jakarta.el.PropertyNotWritableException: Illegal Syntax for Set Operation
    at 
org.apache.myfaces.view.facelets.el.ContextAwareTagValueExpression.setValue(ContextAwareTagValueExpression.java:162)
 ~[myfaces-impl-4.0.1.jar:4.0.1]
    at 
org.apache.myfaces.tobago.internal.component.AbstractUICollapsiblePanel.processState(AbstractUICollapsiblePanel.java:107)
 ~[tobago-core-6.4.0.jar:6.4.0]
    at 
org.apache.myfaces.tobago.internal.component.AbstractUIPopup.processUpdates(AbstractUIPopup.java:35)
 ~[tobago-core-6.4.0.jar:6.4.0]
    at 
org.apache.myfaces.tobago.internal.component.AbstractUIFormBase.processUpdates(AbstractUIFormBase.java:98)
 ~[tobago-core-6.4.0.jar:6.4.0]
    at 
jakarta.faces.component.UIComponentBase.processUpdates(UIComponentBase.java:1427)
 ~[myfaces-api-4.0.1.jar:4.0.1]
    at 
jakarta.faces.component.UIViewRoot._processUpdatesDefault(UIViewRoot.java:1741) 
~[myfaces-api-4.0.1.jar:4.0.1]
    at 
jakarta.faces.component.UIViewRoot$UpdateModelPhaseProcessor.process(UIViewRoot.java:1881)
 ~[myfaces-api-4.0.1.jar:4.0.1]
    at jakarta.faces.component.UIViewRoot._process(UIViewRoot.java:1702) 
~[myfaces-api-4.0.1.jar:4.0.1]
    at jakarta.faces.component.UIViewRoot.processUpdates(UIViewRoot.java:967) 
~[myfaces-api-4.0.1.jar:4.0.1]
    at 
org.apache.myfaces.lifecycle.UpdateModelValuesExecutor.execute(UpdateModelValuesExecutor.java:39)
 ~[myfaces-impl-4.0.1.jar:4.0.1]
    at 
org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:172) 
~[myfaces-impl-4.0.1.jar:4.0.1]
    at 
org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:125) 
~[myfaces-impl-4.0.1.jar:4.0.1]
    at jakarta.faces.webapp.FacesServlet.service(FacesServlet.java:223) 
~[myfaces-api-4.0.1.jar:4.0.1]
    at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:205)
 ~[tomcat-embed-core-10.1.19.jar:10.1.19]
    at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:149)
 ~[tomcat-embed-core-10.1.19.jar:10.1.19]
    at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51) 
~[tomcat-embed-websocket-10.1.19.jar:10.1.19]
    at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:174)
 ~[tomcat-embed-core-10.1.19.jar:10.1.19]
    at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:149)
 ~[tomcat-embed-core-10.1.19.jar:10.1.19] {code}

> tc:popup throws PropertyNotWriteableException
> -
>
> Key: TOBAGO-2320
> URL: https://issues.apache.org/jira/browse/TOBAGO-2320
> Project: MyFaces Tobago
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 6.4.0
>Reporter: Carsten Dimmek
>Priority: Major
>
> When a more complex value expression is set for the collapsed attribute a 
> PropertyNotWriteableException is thrown
> {code:java}
>  /> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)