[jira] Created: (ORCHESTRA-56) When used with Prettyfaces, the conversationContext param is added to the URL multiple times
When used with Prettyfaces, the conversationContext param is added to the URL multiple times Key: ORCHESTRA-56 URL: https://issues.apache.org/jira/browse/ORCHESTRA-56 Project: MyFaces Orchestra Issue Type: Bug Components: RequestParameterProvider Affects Versions: 1.4 Reporter: Bruno Aranda See this Prettyfaces issue for more information: http://code.google.com/p/prettyfaces/issues/detail?id=65 Prettyfaces calls twice the .encodeURL method twice and this keeps replicating the parameters (eg. conversationContext), leading to a Too Long URL exception after some clicks. This can be probably fixed by checking if that parameter already exists in the URL? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ORCHESTRA-56) When used with Prettyfaces, the conversationContext param is added to the URL multiple times
[ https://issues.apache.org/jira/browse/ORCHESTRA-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved ORCHESTRA-56. --- Resolution: Fixed Fix Version/s: 1.5 A check for the param is done now before adding it again When used with Prettyfaces, the conversationContext param is added to the URL multiple times Key: ORCHESTRA-56 URL: https://issues.apache.org/jira/browse/ORCHESTRA-56 Project: MyFaces Orchestra Issue Type: Bug Components: RequestParameterProvider Affects Versions: 1.4 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 1.5 See this Prettyfaces issue for more information: http://code.google.com/p/prettyfaces/issues/detail?id=65 Prettyfaces calls the RequestParameterResponseWrapper.encodeURL method twice and this keeps replicating the parameters (eg. conversationContext), leading to a Too Long URL exception after some clicks. This can be probably fixed by checking if that parameter already exists in the URL? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2942) Memory Leak in MyFaces 2.0.1 probably as well in 2.0.2
[ https://issues.apache.org/jira/browse/MYFACES-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921323#action_12921323 ] Bruno Aranda commented on MYFACES-2942: --- Using tomcat 7 I get this warning... SEVERE: The web application [/editor-2.0-SNAPSHOT] created a ThreadLocal with key of type [java.lang.ThreadLocal] (value [java.lang.threadlo...@41649a55]) and a value of type [org.apache.myfaces.config.RuntimeConfig] (value [org.apache.myfaces.config.runtimecon...@33d063fd]) but failed to remove it when the web application was stopped. This is very likely to create a memory leak. I don't know if the RuntimeConfig could be the one responsible of the leak in Jboss? Memory Leak in MyFaces 2.0.1 probably as well in 2.0.2 -- Key: MYFACES-2942 URL: https://issues.apache.org/jira/browse/MYFACES-2942 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.0.1, 2.0.2 Environment: JBOSS AS Reporter: Werner Punz Priority: Critical Stan Silvert from JBoss reports: I'm pretty sure 2.0.1 has a memory leak on undeploy. Mojarra had an undeploy leak and it took a long time to track it down. The same test I was using on Mojarra also failed on MyFaces but I haven't had time to track down the leak in MyFaces. Maybe this is fixed in 2.0.2? If not maybe someone can go ahead and take a look? The mem leak keeps MyFaces from passing TCK on JBoss AS. To test, all you need to do is create a small exploaded JSF app. Then have a script that touches web.xml every 10 seconds. That will cause the app to redeploy. You will get a PermGen error in about an hour. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-2903) ErrorPageWriter may try to write a null to the partialWriter if the exception message is null
ErrorPageWriter may try to write a null to the partialWriter if the exception message is null - Key: MYFACES-2903 URL: https://issues.apache.org/jira/browse/MYFACES-2903 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda Priority: Minor When trying to handle an exception and write the output to the writer, if the cause and the message of an exception are null a NullPointerException is thrown (ErrorPageWriter,379). Checking if the ex.getMessage() is not null will fix this problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2903) ErrorPageWriter may try to write a null to the partialWriter if the exception message is null
[ https://issues.apache.org/jira/browse/MYFACES-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-2903. --- Fix Version/s: 2.0.2-SNAPSHOT Resolution: Fixed ErrorPageWriter may try to write a null to the partialWriter if the exception message is null - Key: MYFACES-2903 URL: https://issues.apache.org/jira/browse/MYFACES-2903 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda Priority: Minor Fix For: 2.0.2-SNAPSHOT When trying to handle an exception and write the output to the writer, if the cause and the message of an exception are null a NullPointerException is thrown (ErrorPageWriter,379). Checking if the ex.getMessage() is not null will fix this problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891536#action_12891536 ] Bruno Aranda commented on MYFACES-2836: --- Werner said this in the mailing list: Btw. one issue about this, check if your fix does not break anything in the ppr case. The problem is that the ppr responseWriter simply delegates the HtmlResponseWriterImpl, but the issue is that CDATA blocks are automatically opened before any html is rendered, any valid CDATA block inside should not be swallowed but escaped in that case. That is not a problem, as PartialResponseWriterImpl does not depend on HtmlResponseWriterImpl, but on the superclass ResponseWriter, which is not affected by the patch. HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script --- Key: MYFACES-2836 URL: https://issues.apache.org/jira/browse/MYFACES-2836 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Attachments: MUFACES-2836.patch Hi, When the default response writer writes a script, it includes CDATA tags around the body. If the script is being written inside another CDATA section for some reason (Primefaces does this in its partial response), then invalid XML is created. I attach patch for the fix to be reviewed, before I commit something not quite right again and we can discuss. Basically, a simple boolean is used to check if a CDATA is already open or not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-2836. --- Assignee: Bruno Aranda Fix Version/s: 2.0.2-SNAPSHOT Resolution: Fixed The patch has been commited after created the constants commented by Jakob, HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script --- Key: MYFACES-2836 URL: https://issues.apache.org/jira/browse/MYFACES-2836 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Attachments: MUFACES-2836.patch Hi, When the default response writer writes a script, it includes CDATA tags around the body. If the script is being written inside another CDATA section for some reason (Primefaces does this in its partial response), then invalid XML is created. I attach patch for the fix to be reviewed, before I commit something not quite right again and we can discuss. Basically, a simple boolean is used to check if a CDATA is already open or not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2831) Avoid neested CDATA section for PPR e.g. with Primefaces
[ https://issues.apache.org/jira/browse/MYFACES-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda updated MYFACES-2831: -- Status: Resolved (was: Patch Available) Assignee: Bruno Aranda Fix Version/s: 2.0.2-SNAPSHOT Resolution: Fixed Avoid neested CDATA section for PPR e.g. with Primefaces Key: MYFACES-2831 URL: https://issues.apache.org/jira/browse/MYFACES-2831 Project: MyFaces Core Issue Type: Improvement Components: JSR-314 Affects Versions: 2.0.2-SNAPSHOT Reporter: Marcus Büttner Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Attachments: MYFACES-2831.patch In PPR with Primefaces a neested CDATA section is rendered for components with script sections. I attached a patch for the HtmlResponseWriterImpl in myfaces-shared which avoid the double rendering of the CDATA section. Primefaces uses startCDATA and endCDATA of ResponseWriter for it's cdata section. I've overridden this two methods to memorise if a cdata section is open. If a cdata section is open it's not opened a second one. I added this check to the writeScriptContent() method because there occurse the problem with Primefaces. Please review the patch because I'm not sure if there are any site effects. Thanks, Regards Marcus -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891551#action_12891551 ] Bruno Aranda commented on MYFACES-2836: --- Uhm, you are right... I probably ran the test without updating shared before the second fix (adding the constants). And that is the problem, the CDATA constants already present contained a line return as part of the value, making some assertions fail in myfaces-impl. So nothing is really broken... I am going to add new constants and commit again... HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script --- Key: MYFACES-2836 URL: https://issues.apache.org/jira/browse/MYFACES-2836 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Attachments: MUFACES-2836.patch Hi, When the default response writer writes a script, it includes CDATA tags around the body. If the script is being written inside another CDATA section for some reason (Primefaces does this in its partial response), then invalid XML is created. I attach patch for the fix to be reviewed, before I commit something not quite right again and we can discuss. Basically, a simple boolean is used to check if a CDATA is already open or not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-2836. --- Resolution: Fixed Everything is passing. Checked and double-checked :) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script --- Key: MYFACES-2836 URL: https://issues.apache.org/jira/browse/MYFACES-2836 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Attachments: MUFACES-2836.patch Hi, When the default response writer writes a script, it includes CDATA tags around the body. If the script is being written inside another CDATA section for some reason (Primefaces does this in its partial response), then invalid XML is created. I attach patch for the fix to be reviewed, before I commit something not quite right again and we can discuss. Basically, a simple boolean is used to check if a CDATA is already open or not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-2835) ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs
ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs -- Key: MYFACES-2835 URL: https://issues.apache.org/jira/browse/MYFACES-2835 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Hence, the body of this methods should be empty. This is highlighted by a problem with Primefaces, where Mojarra works without problems and Myfaces not, because it adds nested CDATA sections, hence breaking the custom partial response XML created by Primefaces. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2835) ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs
[ https://issues.apache.org/jira/browse/MYFACES-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-2835. --- Fix Version/s: 2.0.2-SNAPSHOT Resolution: Fixed This has now been fixed ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs -- Key: MYFACES-2835 URL: https://issues.apache.org/jira/browse/MYFACES-2835 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Hence, the body of this methods should be empty. This is highlighted by a problem with Primefaces, where Mojarra works without problems and Myfaces not, because it adds nested CDATA sections, hence breaking the custom partial response XML created by Primefaces. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2831) Avoid neested CDATA section for PPR e.g. with Primefaces
[ https://issues.apache.org/jira/browse/MYFACES-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891110#action_12891110 ] Bruno Aranda commented on MYFACES-2831: --- See MYFACES-2835 In Mojarra, the same code works and not in myfaces. This means that Mojarra is actually not doing anything at all when ResponseWriter.CDATA is invoked. No action is taken at all, following the javadocs. Avoid neested CDATA section for PPR e.g. with Primefaces Key: MYFACES-2831 URL: https://issues.apache.org/jira/browse/MYFACES-2831 Project: MyFaces Core Issue Type: Improvement Components: JSR-314 Affects Versions: 2.0.2-SNAPSHOT Reporter: Marcus Büttner Attachments: MYFACES-2831.patch In PPR with Primefaces a neested CDATA section is rendered for components with script sections. I attached a patch for the HtmlResponseWriterImpl in myfaces-shared which avoid the double rendering of the CDATA section. Primefaces uses startCDATA and endCDATA of ResponseWriter for it's cdata section. I've overridden this two methods to memorise if a cdata section is open. If a cdata section is open it's not opened a second one. I added this check to the writeScriptContent() method because there occurse the problem with Primefaces. Please review the patch because I'm not sure if there are any site effects. Thanks, Regards Marcus -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2835) ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs
[ https://issues.apache.org/jira/browse/MYFACES-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891118#action_12891118 ] Bruno Aranda commented on MYFACES-2835: --- I am afraid it is the solution. The javadocs read: Open an XML CDATA block. Note that XML does not allow nested CDATA blocks, though this method does not enforce that constraint. The default implementation of this method takes no action when invoked. https://javaserverfaces.dev.java.net/nonav/docs/2.0/javadocs/index.html Which means that ResponseWriter (and maybe HtmlResponseWriterImpl) should do nothing where invoked. For the PartialResponseWriterImpl we already have a nested CDATA check in place... ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs -- Key: MYFACES-2835 URL: https://issues.apache.org/jira/browse/MYFACES-2835 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Hence, the body of this methods should be empty. This is highlighted by a problem with Primefaces, where Mojarra works without problems and Myfaces not, because it adds nested CDATA sections, hence breaking the custom partial response XML created by Primefaces. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2835) ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs
[ https://issues.apache.org/jira/browse/MYFACES-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891127#action_12891127 ] Bruno Aranda commented on MYFACES-2835: --- Ah yes, I see, you are right. I will fix that. I guess nothing should be done in the HtmlResponseWriterImpl, right (if that is the default implementation - I will do a black box test with Mojarra and see) but PartialResponseWriterImpl needs to be updated definitely ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs -- Key: MYFACES-2835 URL: https://issues.apache.org/jira/browse/MYFACES-2835 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Hence, the body of this methods should be empty. This is highlighted by a problem with Primefaces, where Mojarra works without problems and Myfaces not, because it adds nested CDATA sections, hence breaking the custom partial response XML created by Primefaces. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2835) ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs
[ https://issues.apache.org/jira/browse/MYFACES-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891142#action_12891142 ] Bruno Aranda commented on MYFACES-2835: --- Diferent quick tests I have done (black box tests): // USING MOJARRA /// // The abstract class // DEFAULT IMPL ResponseWriter rw = new HtmlResponseWriter(w, text/html, UTF-8); rw.startCDATA(); rw.endCDATA(); Renders: ![CDATA[]] / ResponseWriter rw = new HtmlResponseWriter(w, text/html, UTF-8); rw.startCDATA(); rw.startCDATA(); rw.endCDATA(); rw.endCDATA(); This throws IllegalStateException: CDATA tags may not nest // CUSTOM IMPL ResponseWriter cw = new ResponseWriter() { ... empty implementation here ... }; cw.startCDATA(); cw.endCDATA(); // PARTIAL ResponseWriter rw = new HtmlResponseWriter(w, text/html, UTF-8); ResponseWriter pw = new PartialResponseWriter(rw); pw.startCDATA(); pw.startCDATA(); pw.endCDATA(); pw.endCDATA(); This throws IllegalStateException: CDATA tags may not nest Conclusions (differences between Mojarra and MyFaces) *** ResponseWriter: The endCDATA method in Mojarra throws an UnsupportedOperationException (undocumented in the javadocs). This shows how the ResponseWriter class has an empty startCDATA and throws an exception on endCDATA. HtmlResponseWriterImpl Apparently we should take care here of nested CDATAs. In Mojarra they throw an exception if that is the case. PartialResponseWriterImpl The same than in the HtmlResponseWriter. An exception is thrown if there are nested CDATAs. ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs -- Key: MYFACES-2835 URL: https://issues.apache.org/jira/browse/MYFACES-2835 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Hence, the body of this methods should be empty. This is highlighted by a problem with Primefaces, where Mojarra works without problems and Myfaces not, because it adds nested CDATA sections, hence breaking the custom partial response XML created by Primefaces. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2835) ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs
[ https://issues.apache.org/jira/browse/MYFACES-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891183#action_12891183 ] Bruno Aranda commented on MYFACES-2835: --- Ok, I will revert my change of this morning and we can work on this when we get an answer from the jsf open list. And the problem may be in Primefaces, but I guess it is due to Mojarra and MyFaces behaving in a different way for the same code. It can be Primefaces today, but any other library in the future. ResponseWriter.startCDATA() and endCDATA() methods should take no action according to the Javadocs -- Key: MYFACES-2835 URL: https://issues.apache.org/jira/browse/MYFACES-2835 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.2-SNAPSHOT Hence, the body of this methods should be empty. This is highlighted by a problem with Primefaces, where Mojarra works without problems and Myfaces not, because it adds nested CDATA sections, hence breaking the custom partial response XML created by Primefaces. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script
HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script --- Key: MYFACES-2836 URL: https://issues.apache.org/jira/browse/MYFACES-2836 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 2.0.1 Reporter: Bruno Aranda Hi, When the default response writer writes a script, it includes CDATA tags around the body. If the script is being written inside another CDATA section for some reason (Primefaces does this in its partial response), then invalid XML is created. I attach patch for the fix to be reviewed, before I commit something not quite right again and we can discuss. Basically, a simple boolean is used to check if a CDATA is already open or not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-2812) Problem with nested CDATA sections in scripts in a PPR
Problem with nested CDATA sections in scripts in a PPR -- Key: MYFACES-2812 URL: https://issues.apache.org/jira/browse/MYFACES-2812 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.0.1-SNAPSHOT Reporter: Bruno Aranda I have a partial response that contains invalid syntax because CDATA sections are nested. For example, in my app this code is generated in the partial response: ?xml version=1.0 encoding=UTF-8?partialResponsecomponentscomponentideditorForm/idoutput![CDATA[form id=editorForm name=editorForm method=post action=/editor/curate/publication.jsf?conversationContext=2 enctype=application/x-www-form-urlencodedspan id=growl/spanscript type=text/javascript//![CDATA[ jQuery.gritter.add({title:'Publication saved',text:'AC: EBI-2637354',image:'/editor/primefaces_resource/2.0.3-SNAPSHOT/primefaces/growl/assets/info.png?conversationContext=2',sticky:false}); //]]/script ... I use Primefaces, which is generating the script section inside the partial response (in this case, the growl renderer). MyFaces wraps the script content in a CDATA section. However, because the output section itself has the CDATA this is provoking the problem. The agent thinks that the first CDATA is closed when it reachs the end of the nested CDATA, creating an invalid response. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2811) Partial Response still embedded CDATA possible
[ https://issues.apache.org/jira/browse/MYFACES-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12887378#action_12887378 ] Bruno Aranda commented on MYFACES-2811: --- And Cagatay mentions that: It should be an implementation issue as PrimeFaces delegate CDATA calls to Impl using ResponseWriter.startCData and endCData api, PF uses standard apis for this. Something to check with myfaces 2 actually to see how my friends handled that. Partial Response still embedded CDATA possible -- Key: MYFACES-2811 URL: https://issues.apache.org/jira/browse/MYFACES-2811 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.0.1-SNAPSHOT Reporter: Werner Punz We worked on this issue a while ago yet I got another error report in - Bruno Aranda is reporting: Hi, I have a partial response that contains invalid syntax because CDATA sections are nested. For example, in my app this code is generated in the partial response: ?xml version=1.0 encoding=UTF-8?partialResponsecomponentscomponentideditorForm/idoutput![CDATA[form id=editorForm name=editorForm method=post action=/editor/curate/publication.jsf?conversationContext=2 enctype=application/x-www-form-urlencodedspan id=growl/spanscript type=text/javascript//![CDATA[ jQuery.gritter.add({title:'Publication saved',text:'AC: EBI-2637354',image:'/editor/primefaces_resource/2.0.3-SNAPSHOT/primefaces/growl/assets/info.png?conversationContext=2',sticky:false}); //]]/script -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2811) Partial Response still embedded CDATA possible
[ https://issues.apache.org/jira/browse/MYFACES-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12887377#action_12887377 ] Bruno Aranda commented on MYFACES-2811: --- And even if you don't use a growl component in the first case, and just put the script section. It still fails: ?xml version=1.0 encoding=UTF-8? !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd; html xmlns=http://www.w3.org/1999/xhtml; xmlns:h=http://java.sun.com/jsf/html; xmlns:f=http://java.sun.com/jsf/core; xmlns:ui=http://java.sun.com/jsf/facelets; xmlns:p=http://primefaces.prime.com.tr/ui; f:view contentType=text/html h:head titleTest case/title /h:head h:body h:form id=testForm prependId=false script type=text/javascript var lala; /script p:commandButton update=testForm/ /h:form /h:body /f:view /html And the same problem may be happening with Mojarra, as I can read from this thread I just found: http://primefaces.prime.com.tr/forum/viewtopic.php?f=3t=1617start=10 Partial Response still embedded CDATA possible -- Key: MYFACES-2811 URL: https://issues.apache.org/jira/browse/MYFACES-2811 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.0.1-SNAPSHOT Reporter: Werner Punz We worked on this issue a while ago yet I got another error report in - Bruno Aranda is reporting: Hi, I have a partial response that contains invalid syntax because CDATA sections are nested. For example, in my app this code is generated in the partial response: ?xml version=1.0 encoding=UTF-8?partialResponsecomponentscomponentideditorForm/idoutput![CDATA[form id=editorForm name=editorForm method=post action=/editor/curate/publication.jsf?conversationContext=2 enctype=application/x-www-form-urlencodedspan id=growl/spanscript type=text/javascript//![CDATA[ jQuery.gritter.add({title:'Publication saved',text:'AC: EBI-2637354',image:'/editor/primefaces_resource/2.0.3-SNAPSHOT/primefaces/growl/assets/info.png?conversationContext=2',sticky:false}); //]]/script -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2811) Partial Response still embedded CDATA possible
[ https://issues.apache.org/jira/browse/MYFACES-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12887394#action_12887394 ] Bruno Aranda commented on MYFACES-2811: --- However it should be nice if we checked, unless it is a performance hit, or are yet another context parameter... Partial Response still embedded CDATA possible -- Key: MYFACES-2811 URL: https://issues.apache.org/jira/browse/MYFACES-2811 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.0.1-SNAPSHOT Reporter: Werner Punz We worked on this issue a while ago yet I got another error report in - Bruno Aranda is reporting: Hi, I have a partial response that contains invalid syntax because CDATA sections are nested. For example, in my app this code is generated in the partial response: ?xml version=1.0 encoding=UTF-8?partialResponsecomponentscomponentideditorForm/idoutput![CDATA[form id=editorForm name=editorForm method=post action=/editor/curate/publication.jsf?conversationContext=2 enctype=application/x-www-form-urlencodedspan id=growl/spanscript type=text/javascript//![CDATA[ jQuery.gritter.add({title:'Publication saved',text:'AC: EBI-2637354',image:'/editor/primefaces_resource/2.0.3-SNAPSHOT/primefaces/growl/assets/info.png?conversationContext=2',sticky:false}); //]]/script -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2811) Partial Response still embedded CDATA possible
[ https://issues.apache.org/jira/browse/MYFACES-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12887392#action_12887392 ] Bruno Aranda commented on MYFACES-2811: --- As the spec says, we should not enforce nested CDATA blocks if it is not necessary I think... In PrimeFaces, the (standard) responsewriter is created in http://code.google.com/p/primefaces/source/browse/core2/trunk/src/main/java/org/primefaces/application/PrimeFacesPhaseListener.java By invoking Renderkit.createResponseWriter. Partial Response still embedded CDATA possible -- Key: MYFACES-2811 URL: https://issues.apache.org/jira/browse/MYFACES-2811 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.0.1-SNAPSHOT Reporter: Werner Punz We worked on this issue a while ago yet I got another error report in - Bruno Aranda is reporting: Hi, I have a partial response that contains invalid syntax because CDATA sections are nested. For example, in my app this code is generated in the partial response: ?xml version=1.0 encoding=UTF-8?partialResponsecomponentscomponentideditorForm/idoutput![CDATA[form id=editorForm name=editorForm method=post action=/editor/curate/publication.jsf?conversationContext=2 enctype=application/x-www-form-urlencodedspan id=growl/spanscript type=text/javascript//![CDATA[ jQuery.gritter.add({title:'Publication saved',text:'AC: EBI-2637354',image:'/editor/primefaces_resource/2.0.3-SNAPSHOT/primefaces/growl/assets/info.png?conversationContext=2',sticky:false}); //]]/script -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (MYFACES-2811) Partial Response still embedded CDATA possible
[ https://issues.apache.org/jira/browse/MYFACES-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12887394#action_12887394 ] Bruno Aranda edited comment on MYFACES-2811 at 7/12/10 11:06 AM: - However it should be nice if we checked, unless it is a performance hit, or add yet another context parameter... was (Author: bruno_dev): However it should be nice if we checked, unless it is a performance hit, or are yet another context parameter... Partial Response still embedded CDATA possible -- Key: MYFACES-2811 URL: https://issues.apache.org/jira/browse/MYFACES-2811 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.0.1-SNAPSHOT Reporter: Werner Punz We worked on this issue a while ago yet I got another error report in - Bruno Aranda is reporting: Hi, I have a partial response that contains invalid syntax because CDATA sections are nested. For example, in my app this code is generated in the partial response: ?xml version=1.0 encoding=UTF-8?partialResponsecomponentscomponentideditorForm/idoutput![CDATA[form id=editorForm name=editorForm method=post action=/editor/curate/publication.jsf?conversationContext=2 enctype=application/x-www-form-urlencodedspan id=growl/spanscript type=text/javascript//![CDATA[ jQuery.gritter.add({title:'Publication saved',text:'AC: EBI-2637354',image:'/editor/primefaces_resource/2.0.3-SNAPSHOT/primefaces/growl/assets/info.png?conversationContext=2',sticky:false}); //]]/script -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-2609) f:event type throws ClassNotFoundException for type 'preRenderView'
f:event type throws ClassNotFoundException for type 'preRenderView' --- Key: MYFACES-2609 URL: https://issues.apache.org/jira/browse/MYFACES-2609 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.0-beta-3 Reporter: Bruno Aranda Priority: Minor It appears that the PreRenderViewEvent event is not mapped in the NamedEventManager. Thanks to Leonardo for pointing that out! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2609) f:event type throws ClassNotFoundException for type 'preRenderView'
[ https://issues.apache.org/jira/browse/MYFACES-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-2609. --- Resolution: Duplicate Fix Version/s: 2.0.0-beta-3 Assignee: Bruno Aranda Duplicate of MYFACES-2608 f:event type throws ClassNotFoundException for type 'preRenderView' --- Key: MYFACES-2609 URL: https://issues.apache.org/jira/browse/MYFACES-2609 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.0-beta-3 Reporter: Bruno Aranda Assignee: Bruno Aranda Priority: Minor Fix For: 2.0.0-beta-3 It appears that the PreRenderViewEvent event is not mapped in the NamedEventManager. Thanks to Leonardo for pointing that out! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-2610) h:link not being rendered correctly when disabled - no value shown
h:link not being rendered correctly when disabled - no value shown -- Key: MYFACES-2610 URL: https://issues.apache.org/jira/browse/MYFACES-2610 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.0-beta-3 Reporter: Bruno Aranda Assignee: Bruno Aranda The h:link component is not being rendered correctly when disabled. Only the span tags are rendered, but not the value. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2610) h:link not being rendered correctly when disabled - no value shown
[ https://issues.apache.org/jira/browse/MYFACES-2610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-2610. --- Resolution: Fixed Fix Version/s: 2.0.0-beta-3 h:link not being rendered correctly when disabled - no value shown -- Key: MYFACES-2610 URL: https://issues.apache.org/jira/browse/MYFACES-2610 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.0-beta-3 Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.0-beta-3 The h:link component is not being rendered correctly when disabled. Only the span tags are rendered, but not the value. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1520) NPE from Google Bot (unknown agent)
[ https://issues.apache.org/jira/browse/TRINIDAD-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12741280#action_12741280 ] Bruno Aranda commented on TRINIDAD-1520: Yeah, having the same problem now. This is causing problems on how the link to your app show in google (a nice NullPointer as the title). I would say is probably the _locale.hashCode() method the one causing this. NPE from Google Bot (unknown agent) --- Key: TRINIDAD-1520 URL: https://issues.apache.org/jira/browse/TRINIDAD-1520 Project: MyFaces Trinidad Issue Type: Bug Affects Versions: 1.2.11-core Environment: myfaces 1.2.6 facelets 1.1.14 trinidad 1.2.11 jetty 6.1.5 Reporter: Joe Rossi Assignee: Matthias Weßendorf Priority: Minor This seems like a duplicate of [Trinidad-1146], though the stack trace I'm seeing is different. SEVERE: Error Rendering View[/public/contact.xhtml] java.lang.NullPointerException at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$Key.hashCode(FileSystemStyleCache.java:1213) at java.util.Hashtable.get(Hashtable.java:334) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:456) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:428) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.getStyleSheetURIs(FileSystemStyleCache.java:160) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.StyleSheetRenderer.encodeAll(StyleSheetRenderer.java:90) at org.apache.myfaces.trinidad.render.CoreRenderer.delegateRenderer(CoreRenderer.java:446) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HeadRenderer.encodeBegin(HeadRenderer.java:80) at org.apache.myfaces.trinidad.render.CoreRenderer.delegateRendererBegin(CoreRenderer.java:467) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:74) at org.apache.myfaces.trinidad.render.CoreRenderer.encodeEnd(CoreRenderer.java:335) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:751) at org.apache.myfaces.trinidad.component.UIXComponentBase.__encodeRecursive(UIXComponentBase.java:1494) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeAll(UIXComponentBase.java:771) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:257) at com.sun.facelets.FaceletViewHandler.renderView(FaceletViewHandler.java:592) at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:48) at org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:188) at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:41) at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:140) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:155) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093) at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl._doFilterImpl(TrinidadFilterImpl.java:245) at org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl.doFilter(TrinidadFilterImpl.java:155) at org.apache.myfaces.trinidad.webapp.TrinidadFilter.doFilter(TrinidadFilter.java:92) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at tn.view.error.UncaughtExceptionInterceptor.doFilter(UncaughtExceptionInterceptor.java:57) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:292) at net.sf.acegisecurity.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:108) at net.sf.acegisecurity.intercept.web.SecurityEnforcementFilter.doFilter(SecurityEnforcementFilter.java:197) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303) at net.sf.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:143) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
[jira] Issue Comment Edited: (TRINIDAD-1520) NPE from Google Bot (unknown agent)
[ https://issues.apache.org/jira/browse/TRINIDAD-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12741280#action_12741280 ] Bruno Aranda edited comment on TRINIDAD-1520 at 8/10/09 5:10 AM: - Yeah, having the same problem now. This is causing problems on how the link to your app show in google (a nice NullPointer as the title). I would say is probably the _locale instance the one causing this. was (Author: bruno_dev): Yeah, having the same problem now. This is causing problems on how the link to your app show in google (a nice NullPointer as the title). I would say is probably the _locale.hashCode() method the one causing this. NPE from Google Bot (unknown agent) --- Key: TRINIDAD-1520 URL: https://issues.apache.org/jira/browse/TRINIDAD-1520 Project: MyFaces Trinidad Issue Type: Bug Affects Versions: 1.2.11-core Environment: myfaces 1.2.6 facelets 1.1.14 trinidad 1.2.11 jetty 6.1.5 Reporter: Joe Rossi Assignee: Matthias Weßendorf Priority: Minor This seems like a duplicate of [Trinidad-1146], though the stack trace I'm seeing is different. SEVERE: Error Rendering View[/public/contact.xhtml] java.lang.NullPointerException at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$Key.hashCode(FileSystemStyleCache.java:1213) at java.util.Hashtable.get(Hashtable.java:334) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:456) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:428) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.getStyleSheetURIs(FileSystemStyleCache.java:160) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.StyleSheetRenderer.encodeAll(StyleSheetRenderer.java:90) at org.apache.myfaces.trinidad.render.CoreRenderer.delegateRenderer(CoreRenderer.java:446) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HeadRenderer.encodeBegin(HeadRenderer.java:80) at org.apache.myfaces.trinidad.render.CoreRenderer.delegateRendererBegin(CoreRenderer.java:467) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:74) at org.apache.myfaces.trinidad.render.CoreRenderer.encodeEnd(CoreRenderer.java:335) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:751) at org.apache.myfaces.trinidad.component.UIXComponentBase.__encodeRecursive(UIXComponentBase.java:1494) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeAll(UIXComponentBase.java:771) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:257) at com.sun.facelets.FaceletViewHandler.renderView(FaceletViewHandler.java:592) at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:48) at org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:188) at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:41) at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:140) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:155) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093) at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl._doFilterImpl(TrinidadFilterImpl.java:245) at org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl.doFilter(TrinidadFilterImpl.java:155) at org.apache.myfaces.trinidad.webapp.TrinidadFilter.doFilter(TrinidadFilter.java:92) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at tn.view.error.UncaughtExceptionInterceptor.doFilter(UncaughtExceptionInterceptor.java:57) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:292) at net.sf.acegisecurity.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:108) at net.sf.acegisecurity.intercept.web.SecurityEnforcementFilter.doFilter(SecurityEnforcementFilter.java:197) at
[jira] Reopened: (TRINIDAD-1520) NPE from Google Bot (unknown agent)
[ https://issues.apache.org/jira/browse/TRINIDAD-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda reopened TRINIDAD-1520: NPE from Google Bot (unknown agent) --- Key: TRINIDAD-1520 URL: https://issues.apache.org/jira/browse/TRINIDAD-1520 Project: MyFaces Trinidad Issue Type: Bug Affects Versions: 1.2.11-core Environment: myfaces 1.2.6 facelets 1.1.14 trinidad 1.2.11 jetty 6.1.5 Reporter: Joe Rossi Assignee: Bruno Aranda Priority: Minor Fix For: 1.2.12-core This seems like a duplicate of [Trinidad-1146], though the stack trace I'm seeing is different. SEVERE: Error Rendering View[/public/contact.xhtml] java.lang.NullPointerException at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$Key.hashCode(FileSystemStyleCache.java:1213) at java.util.Hashtable.get(Hashtable.java:334) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:456) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:428) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.getStyleSheetURIs(FileSystemStyleCache.java:160) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.StyleSheetRenderer.encodeAll(StyleSheetRenderer.java:90) at org.apache.myfaces.trinidad.render.CoreRenderer.delegateRenderer(CoreRenderer.java:446) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HeadRenderer.encodeBegin(HeadRenderer.java:80) at org.apache.myfaces.trinidad.render.CoreRenderer.delegateRendererBegin(CoreRenderer.java:467) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:74) at org.apache.myfaces.trinidad.render.CoreRenderer.encodeEnd(CoreRenderer.java:335) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:751) at org.apache.myfaces.trinidad.component.UIXComponentBase.__encodeRecursive(UIXComponentBase.java:1494) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeAll(UIXComponentBase.java:771) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:257) at com.sun.facelets.FaceletViewHandler.renderView(FaceletViewHandler.java:592) at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:48) at org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:188) at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:41) at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:140) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:155) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093) at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl._doFilterImpl(TrinidadFilterImpl.java:245) at org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl.doFilter(TrinidadFilterImpl.java:155) at org.apache.myfaces.trinidad.webapp.TrinidadFilter.doFilter(TrinidadFilter.java:92) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at tn.view.error.UncaughtExceptionInterceptor.doFilter(UncaughtExceptionInterceptor.java:57) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:292) at net.sf.acegisecurity.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:108) at net.sf.acegisecurity.intercept.web.SecurityEnforcementFilter.doFilter(SecurityEnforcementFilter.java:197) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303) at net.sf.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:143) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303) at net.sf.acegisecurity.ui.basicauth.BasicProcessingFilter.doFilter(BasicProcessingFilter.java:214) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303) at
[jira] Resolved: (TRINIDAD-1520) NPE from Google Bot (unknown agent)
[ https://issues.apache.org/jira/browse/TRINIDAD-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved TRINIDAD-1520. Resolution: Fixed Fix Version/s: 1.2.12-core NPE from Google Bot (unknown agent) --- Key: TRINIDAD-1520 URL: https://issues.apache.org/jira/browse/TRINIDAD-1520 Project: MyFaces Trinidad Issue Type: Bug Affects Versions: 1.2.11-core Environment: myfaces 1.2.6 facelets 1.1.14 trinidad 1.2.11 jetty 6.1.5 Reporter: Joe Rossi Assignee: Bruno Aranda Priority: Minor Fix For: 1.2.12-core This seems like a duplicate of [Trinidad-1146], though the stack trace I'm seeing is different. SEVERE: Error Rendering View[/public/contact.xhtml] java.lang.NullPointerException at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$Key.hashCode(FileSystemStyleCache.java:1213) at java.util.Hashtable.get(Hashtable.java:334) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:456) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:428) at org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.getStyleSheetURIs(FileSystemStyleCache.java:160) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.StyleSheetRenderer.encodeAll(StyleSheetRenderer.java:90) at org.apache.myfaces.trinidad.render.CoreRenderer.delegateRenderer(CoreRenderer.java:446) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HeadRenderer.encodeBegin(HeadRenderer.java:80) at org.apache.myfaces.trinidad.render.CoreRenderer.delegateRendererBegin(CoreRenderer.java:467) at org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.DocumentRenderer.encodeAll(DocumentRenderer.java:74) at org.apache.myfaces.trinidad.render.CoreRenderer.encodeEnd(CoreRenderer.java:335) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:751) at org.apache.myfaces.trinidad.component.UIXComponentBase.__encodeRecursive(UIXComponentBase.java:1494) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeAll(UIXComponentBase.java:771) at javax.faces.component.UIComponent.encodeAll(UIComponent.java:257) at com.sun.facelets.FaceletViewHandler.renderView(FaceletViewHandler.java:592) at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:48) at org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:188) at org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:41) at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:140) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:155) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:487) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1093) at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:147) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl._doFilterImpl(TrinidadFilterImpl.java:245) at org.apache.myfaces.trinidadinternal.webapp.TrinidadFilterImpl.doFilter(TrinidadFilterImpl.java:155) at org.apache.myfaces.trinidad.webapp.TrinidadFilter.doFilter(TrinidadFilter.java:92) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at tn.view.error.UncaughtExceptionInterceptor.doFilter(UncaughtExceptionInterceptor.java:57) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1084) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:292) at net.sf.acegisecurity.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:108) at net.sf.acegisecurity.intercept.web.SecurityEnforcementFilter.doFilter(SecurityEnforcementFilter.java:197) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303) at net.sf.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:143) at net.sf.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303) at net.sf.acegisecurity.ui.basicauth.BasicProcessingFilter.doFilter(BasicProcessingFilter.java:214) at
[jira] Commented: (MYFACES-1692) CommandLink does not execute action if no javascript is allowed
[ https://issues.apache.org/jira/browse/MYFACES-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12584097#action_12584097 ] Bruno Aranda commented on MYFACES-1692: --- Yes, styling the commandButton as a link is the classic solution to this... CommandLink does not execute action if no javascript is allowed --- Key: MYFACES-1692 URL: https://issues.apache.org/jira/browse/MYFACES-1692 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.2.0 Environment: Tomcat 6.0, javax.faces.STATE_SAVING_METHOD=server, org.apache.myfaces.ALLOW_JAVASCRIPT=false Reporter: Thomas Fischer Situation: The tag h:commandLink action=#{someBean.someAction} value=submit/h:commandLink is used in a jsp page, which is visited by the user. The user clicks on the link. Expected behaviour: The method someBean.someAction() should be called, and the navigation rule which matches the outcome should determine the page to be displayed. Wrong behaviour: The method defined in action is not called and the same jsp page is rendered again. I did some debugging to find the reason of this problem. It seems to me that the server does not recognize that the click on the link is a postback. In line 172 in org.apache.myfaces.renderkit.html.HtmlResponseStateManager, the HTTP Parameter ResponseStateManager.VIEW_STATE_PARAM is checked for existence. If it is there, the request is a callback, and if it is not there, the request is not treated as postback. This parameter is not encoded in the link rendered by h:commandLink, thus the request is not treated as a postback, and the page is just rendered again. If javaScript rendering is allowed, this works fine because the HTTP parameter ResponseStateManager.VIEW_STATE_PARAM is rendered as a hidden input field, and the javascript code does a form submit. It seems to me that the problem could be solved by adding the parameter ResponseStateManager.VIEW_STATE_PARAM to the generated link (but I did not check it). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1780) EL Expressions that evaluate to a null property (without base) make the application fail
EL Expressions that evaluate to a null property (without base) make the application fail Key: MYFACES-1780 URL: https://issues.apache.org/jira/browse/MYFACES-1780 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0 Reporter: Bruno Aranda Priority: Critical Fix For: 1.2.1-SNAPSHOT This is due to the fact thtat the ScopeAttributeResolver (the last resolver in the chain) is not marking the property as resolved if it resolves to null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1780) EL Expressions that evaluate to a null property (without base) make the application fail
[ https://issues.apache.org/jira/browse/MYFACES-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1780. --- Resolution: Fixed Assignee: Bruno Aranda EL Expressions that evaluate to a null property (without base) make the application fail Key: MYFACES-1780 URL: https://issues.apache.org/jira/browse/MYFACES-1780 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0 Reporter: Bruno Aranda Assignee: Bruno Aranda Priority: Critical Fix For: 1.2.1-SNAPSHOT This is due to the fact thtat the ScopeAttributeResolver (the last resolver in the chain) is not marking the property as resolved if it resolves to null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1765) h:selectOneMenu doesn't call setter
[ https://issues.apache.org/jira/browse/MYFACES-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547652 ] Bruno Aranda commented on MYFACES-1765: --- hehe Seems that Leonardo and I were trying this at the same time. FYI, I have added a selectOneMenu to the test-webapp for myfaces 1.2.1-SNAPSHOT, demonstrating that it should work, Cheers, Bruno h:selectOneMenu doesn't call setter --- Key: MYFACES-1765 URL: https://issues.apache.org/jira/browse/MYFACES-1765 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.2.0 Environment: MyFaces 1.2.1 - Tomahawk 2.0 Snapshot - Facelets 1.1.13 Reporter: Wolf Benz Assignee: Bruno Aranda Priority: Blocker Fix For: 1.2.1-SNAPSHOT I don't know whether this error only occurs in combination with facelets, but this is what happens: the return value: of a h:selectOneMenu in always null in the sense that the SETTER IS NEVER CALLED (- value stays null) So for: h:selectOneMenu value=#{testOverviewBean.compoundCodeFromMenu} valueChangeListener=#{testOverviewBean.fillTestSeqNrs} onchange=submit(); f:selectItem itemLabel=Choose One itemValue=choose_one/ f:selectItems value=#{utilBean.compoundCodes} / /h:selectOneMenu ... the setCompoundCodeFromMenu() is never called, which always leads to NPEs later on. As this is one of the few core components (h:), I think labelling it blocking is justiefied. -Wolf -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1767) h:messages generates style property as styleClass propery.
[ https://issues.apache.org/jira/browse/MYFACES-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda updated MYFACES-1767: -- Resolution: Fixed Fix Version/s: 1.2.1-SNAPSHOT 1.1.6-SNAPSHOT Status: Resolved (was: Patch Available) Well spotted! Many thanks Brainard for the patch. It was a typo indeed. h:messages generates style property as styleClass propery. --- Key: MYFACES-1767 URL: https://issues.apache.org/jira/browse/MYFACES-1767 Project: MyFaces Core Issue Type: Bug Affects Versions: 1.1.5 Reporter: Guy Bashan Assignee: Bruno Aranda Fix For: 1.1.6-SNAPSHOT, 1.2.1-SNAPSHOT Attachments: HtmlMessageRendererBase.patch, HtmlMessagesRendererBase.patch For this fregment: h:messages globalOnly=true styleClass=error_message style=width:0px layout=table / This is the HTML that is being produced: tabletrtdspan style=error_message class=error_messageTotal % Audience should be 100% or 0%/span/td/tr/table Seems like style is sharing same property with styleClass. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit
[ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537532 ] Bruno Aranda commented on TOMAHAWK-777: --- I have just applied the patch in the sources now, so if you want to get the fixed version now you should recompile from sources. Thanks for the reminder, Bruno DataScroller breaks facets functionality when using trinidad default renderkit -- Key: TOMAHAWK-777 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777 Project: MyFaces Tomahawk Issue Type: Bug Components: Data Scroller Affects Versions: 1.1.5-SNAPSHOT Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot Reporter: Danijel Jevtic Assignee: Bruno Aranda Fix For: 1.1.7-SNAPSHOT Attachments: patch10FacetDataScroller.patch The trinidad renderkit seems to have some negative impact on the data scroller, because the images inside the facets are not rendered as links anymore. This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components. Please, fix! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit
[ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved TOMAHAWK-777. --- Resolution: Fixed DataScroller breaks facets functionality when using trinidad default renderkit -- Key: TOMAHAWK-777 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777 Project: MyFaces Tomahawk Issue Type: Bug Components: Data Scroller Affects Versions: 1.1.5-SNAPSHOT Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot Reporter: Danijel Jevtic Assignee: Bruno Aranda Fix For: 1.1.7-SNAPSHOT Attachments: patch10FacetDataScroller.patch The trinidad renderkit seems to have some negative impact on the data scroller, because the images inside the facets are not rendered as links anymore. This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components. Please, fix! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit
[ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537634 ] Bruno Aranda commented on TOMAHAWK-777: --- The snapshot has been deployed to the snapshots repo DataScroller breaks facets functionality when using trinidad default renderkit -- Key: TOMAHAWK-777 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777 Project: MyFaces Tomahawk Issue Type: Bug Components: Data Scroller Affects Versions: 1.1.5-SNAPSHOT Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot Reporter: Danijel Jevtic Assignee: Bruno Aranda Fix For: 1.1.7-SNAPSHOT Attachments: patch10FacetDataScroller.patch The trinidad renderkit seems to have some negative impact on the data scroller, because the images inside the facets are not rendered as links anymore. This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components. Please, fix! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit
[ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516217 ] Bruno Aranda commented on TOMAHAWK-777: --- Hi, if it works with the RI, feel free to change it... but there was not copy and paste either as the rendered link had a different implementation independent behaviour. thanks, Bruno DataScroller breaks facets functionality when using trinidad default renderkit -- Key: TOMAHAWK-777 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777 Project: MyFaces Tomahawk Issue Type: Bug Components: Data Scroller Affects Versions: 1.1.5-SNAPSHOT Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot Reporter: Danijel Jevtic Assignee: Bruno Aranda Fix For: 1.1.7-SNAPSHOT The trinidad renderkit seems to have some negative impact on the data scroller, because the images inside the facets are not rendered as links anymore. This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components. Please, fix! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOMAHAWK-777) DataScroller breaks facets functionality when using trinidad default renderkit
[ https://issues.apache.org/jira/browse/TOMAHAWK-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved TOMAHAWK-777. --- Resolution: Fixed Fix Version/s: 1.1.7-SNAPSHOT Assignee: Bruno Aranda Fixed in the trunk for tomahawk DataScroller breaks facets functionality when using trinidad default renderkit -- Key: TOMAHAWK-777 URL: https://issues.apache.org/jira/browse/TOMAHAWK-777 Project: MyFaces Tomahawk Issue Type: Bug Components: Data Scroller Affects Versions: 1.1.5-SNAPSHOT Environment: Trinidad SVN Incubator and Tomahawk SVN 1.1.5 Snapshot Reporter: Danijel Jevtic Assignee: Bruno Aranda Fix For: 1.1.7-SNAPSHOT The trinidad renderkit seems to have some negative impact on the data scroller, because the images inside the facets are not rendered as links anymore. This breaks forward/backward/ff/fb/first/last functionality when using t:datatable and t:datascroller together with the trinidad components. Please, fix! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1660) memory leak in JspStateManagerImpl
[ https://issues.apache.org/jira/browse/MYFACES-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1660. --- Resolution: Duplicate Assignee: Bruno Aranda memory leak in JspStateManagerImpl -- Key: MYFACES-1660 URL: https://issues.apache.org/jira/browse/MYFACES-1660 Project: MyFaces Core Issue Type: Bug Affects Versions: 1.1.6-SNAPSHOT, 1.2.0-SNAPSHOT Reporter: Thomas Spiegl Assignee: Bruno Aranda Priority: Blocker André Næss reported a memory leak in JspStateManagerImpl: http://www.mail-archive.com/dev@myfaces.apache.org/msg22905.html _oldSerializedViews = new ReferenceMap(); needs to be substituted by _oldSerializedViews = new ReferenceMap(AbstractReferenceMap.WEAK, AbstractReferenceMap.WEAK, true); -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1656) Wrong coercing in #{} for h:inputText
[ https://issues.apache.org/jira/browse/MYFACES-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502462 ] Bruno Aranda commented on MYFACES-1656: --- Definitely it seems to be a bug in tomcat's el api, as the test-webapp runs well also in glassfish Wrong coercing in #{} for h:inputText --- Key: MYFACES-1656 URL: https://issues.apache.org/jira/browse/MYFACES-1656 Project: MyFaces Core Issue Type: Bug Affects Versions: 1.2.0-SNAPSHOT Environment: geronimo 2.0 - M6, winxp Reporter: Alexander Zynevich Attachments: Bad coercing.jpg I tried to run GuessNumber application on the latest SNAPSHOT of 1.2.0 Looks like is cannot coerce #{integer-value} for string. A week ago this code worked. Now it prints: /greeting.jsp(44,3) '#{UserNumberBean.userNumber}' java.lang.IllegalArgumentException: argument type mismatch snip from bean: public void setUserNumber(Integer user_number) { userNumber = user_number; System.out.println(Set userNumber + userNumber); } public Integer getUserNumber() { System.out.println(get userNumber + userNumber); return userNumber; } snip from jsp: h:inputText id=userNo value=#{UserNumberBean.userNumber} validator=#{UserNumberBean.validate}/ you may download war from GERONIMO-3167 see also screen shot -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1658) Memory leak in JspStateManagerImpl
[ https://issues.apache.org/jira/browse/MYFACES-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1658. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT 1.1.6-SNAPSHOT Assignee: Bruno Aranda Resolved with the solution proposed by Thomas in this post: http://www.nabble.com/Possible-memory-leak-in-JspStateManagerImpl-t3863826.html Many thanks Andre for spotting and reporting the problem with detailed explanation and proposing a solution! Memory leak in JspStateManagerImpl -- Key: MYFACES-1658 URL: https://issues.apache.org/jira/browse/MYFACES-1658 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.1.5 Environment: JDK1.5, using Tomcat 5.5. Reporter: André Næss Assignee: Bruno Aranda Fix For: 1.1.6-SNAPSHOT, 1.2.0-SNAPSHOT We are working on a JSF project and recently started stress testing the system. This stress-testing caused the JVM to run out of memory and spend most of it time doing Full GC. Analyzing the heap revealed that most of the memory was being retained by SerializedViewCollection instances. We also noticed that the value of NUMBER_OF_VIEWS_IN_SESSION didn't seem to affect the memory usage. It seems the problem is due to the _oldSerializedViews hashmap which is supposed to use soft references and hence be GC-ed whenever there is a lack of memory, but this apparently doesn't work. Removing this hashmap completely solved the problem. It is however difficult to provide a simple testcase as we used JMeter to load the server with 600 users fetching a fairly big JSF page with a constant throughput of 20 requests per second. I should also mention that we found this problem with 1.1.4 but I fixed it with the 1.1.5 release. Here's the diff output: ~/code/myfaces-1.1.5/impl/src/main/java/org/apache/myfaces/application/jsp$ svn diff Index: JspStateManagerImpl.java === --- JspStateManagerImpl.java(revision 543859) +++ JspStateManagerImpl.java(working copy) @@ -18,7 +18,6 @@ */ package org.apache.myfaces.application.jsp; -import org.apache.commons.collections.map.ReferenceMap; import org.apache.commons.lang.builder.EqualsBuilder; import org.apache.commons.lang.builder.HashCodeBuilder; import org.apache.commons.logging.Log; @@ -609,10 +608,6 @@ private final List _keys = new ArrayList(DEFAULT_NUMBER_OF_VIEWS_IN_SESSION); private final Map _serializedViews = new HashMap(); -// old views will be hold as soft references which will be removed by -// the garbage collector if free memory is low -private transient Map _oldSerializedViews = null; - public synchronized void add(FacesContext context, Object state) { Object key = new SerializedViewKey(context); _serializedViews.put(key, state); @@ -623,10 +618,7 @@ int views = getNumberOfViewsInSession(context); while (_keys.size() views) { key = _keys.remove(0); -Object oldView = _serializedViews.remove(key); -if (oldView != null) { -getOldSerializedViewsMap().put(key, oldView); -} +_serializedViews.remove(key); } } @@ -660,23 +652,9 @@ return views; } -/** - * @return old serialized views map - */ -protected Map getOldSerializedViewsMap() { -if (_oldSerializedViews == null) { -_oldSerializedViews = new ReferenceMap(); -} -return _oldSerializedViews; -} - public Object get(Integer sequence, String viewId) { Object key = new SerializedViewKey(viewId, sequence); -Object value = _serializedViews.get(key); -if (value == null) { -value = getOldSerializedViewsMap().get(key); -} -return value; +return _serializedViews.get(key); } } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1656) Wrong coercing in #{} for h:inputText
[ https://issues.apache.org/jira/browse/MYFACES-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502114 ] Bruno Aranda commented on MYFACES-1656: --- I have modified the test-webapp of myfaces-1.2 in order to reproduce this issue. When executing the app with the jetty maven plugin it works ok. If I deploy it in geronimo (+tomcat) I can reproduce the issue. Any ideas? Wrong coercing in #{} for h:inputText --- Key: MYFACES-1656 URL: https://issues.apache.org/jira/browse/MYFACES-1656 Project: MyFaces Core Issue Type: Bug Affects Versions: 1.2.0-SNAPSHOT Environment: geronimo 2.0 - M6, winxp Reporter: Alexander Zynevich Attachments: Bad coercing.jpg I tried to run GuessNumber application on the latest SNAPSHOT of 1.2.0 Looks like is cannot coerce #{integer-value} for string. A week ago this code worked. Now it prints: /greeting.jsp(44,3) '#{UserNumberBean.userNumber}' java.lang.IllegalArgumentException: argument type mismatch snip from bean: public void setUserNumber(Integer user_number) { userNumber = user_number; System.out.println(Set userNumber + userNumber); } public Integer getUserNumber() { System.out.println(get userNumber + userNumber); return userNumber; } snip from jsp: h:inputText id=userNo value=#{UserNumberBean.userNumber} validator=#{UserNumberBean.validate}/ you may download war from GERONIMO-3167 see also screen shot -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1651) Default converters and validators not correctly registered
[ https://issues.apache.org/jira/browse/MYFACES-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1651. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT Already fixed Default converters and validators not correctly registered -- Key: MYFACES-1651 URL: https://issues.apache.org/jira/browse/MYFACES-1651 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Not registered at all, since they do not appear in the standard-faces-config.xml file... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1223) JSR-252 Issue #54: Added new extension elements to the Faces XML schema.
[ https://issues.apache.org/jira/browse/MYFACES-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1223. --- Resolution: Fixed Assignee: Bruno Aranda Already implemented JSR-252 Issue #54: Added new extension elements to the Faces XML schema. Key: MYFACES-1223 URL: https://issues.apache.org/jira/browse/MYFACES-1223 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Assignee: Bruno Aranda Priority: Minor Fix For: 1.2.0-SNAPSHOT Added new extension elements to the Faces XML schema. Please see Section 1.1 XML Schema Definition. Also see https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=54 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1218) JSR-252 Issue #45: Avoided concurrent read issues by using a java.util.HashMap instead of java.util.WeakHashMap for a component's Property Descriptor Map
[ https://issues.apache.org/jira/browse/MYFACES-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1218. --- Resolution: Invalid Fix Version/s: 1.2.0-SNAPSHOT Assignee: Bruno Aranda (was: Matthias Weßendorf) This does not apply to myfaces, right? Closing it JSR-252 Issue #45: Avoided concurrent read issues by using a java.util.HashMap instead of java.util.WeakHashMap for a component's Property Descriptor Map - Key: MYFACES-1218 URL: https://issues.apache.org/jira/browse/MYFACES-1218 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Reporter: Stan Silvert Assignee: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Avoided concurrent read issues by using a java.util.HashMap instead of java.util.WeakHashMap for a component's Property Descriptor Map. This also fixes the performance problem as identified in the forum. Please refer the the Property Descriptor methods and the constructor in javax.faces.component.UIComponentBase. Also see https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=45 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1262) JSR-252 Issue #99: Specified Java EE 5 Generics usage where applicable.
[ https://issues.apache.org/jira/browse/MYFACES-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1262. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT I guess we can close this one, as it is difficult to assess when will be done and the current implementation works fine JSR-252 Issue #99: Specified Java EE 5 Generics usage where applicable. --- Key: MYFACES-1262 URL: https://issues.apache.org/jira/browse/MYFACES-1262 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Assignee: Mathias Broekelmann Fix For: 1.2.0-SNAPSHOT Specified Java EE 5 Generics usage where applicable. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=99 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1243) JSR-252 Issue #87: Modified specification for the setVariableResolver() and setPropertyResolver() methods on Application to state that they may not be called after the
[ https://issues.apache.org/jira/browse/MYFACES-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1243. --- Resolution: Invalid This applies to the spec JSR-252 Issue #87: Modified specification for the setVariableResolver() and setPropertyResolver() methods on Application to state that they may not be called after the app has served any requests. Key: MYFACES-1243 URL: https://issues.apache.org/jira/browse/MYFACES-1243 Project: MyFaces Core Issue Type: Improvement Components: JSR-252 Reporter: Stan Silvert Assignee: Mathias Broekelmann Modified specification for the setVariableResolver() and setPropertyResolver() methods on Application to state that they may not be called after the app has served any requests. See https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=87 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1233) JSR-252 Issue #73: Added a new FacesException - javax.faces.application.ViewExpiredException
[ https://issues.apache.org/jira/browse/MYFACES-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1233. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT Done JSR-252 Issue #73: Added a new FacesException - javax.faces.application.ViewExpiredException -- Key: MYFACES-1233 URL: https://issues.apache.org/jira/browse/MYFACES-1233 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Assignee: Matthias Weßendorf Fix For: 1.2.0-SNAPSHOT Added a new FacesException - javax.faces.application.ViewExpiredException. Specified that the implementation must throw this exception when an attempt to restore a view results in failure on postback. Please see Section 2.2.1 Restore View for more details. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=73 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-1262) JSR-252 Issue #99: Specified Java EE 5 Generics usage where applicable.
[ https://issues.apache.org/jira/browse/MYFACES-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda reopened MYFACES-1262: --- Assignee: Bruno Aranda (was: Mathias Broekelmann) JSR-252 Issue #99: Specified Java EE 5 Generics usage where applicable. --- Key: MYFACES-1262 URL: https://issues.apache.org/jira/browse/MYFACES-1262 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Assignee: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Specified Java EE 5 Generics usage where applicable. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=99 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1262) JSR-252 Issue #99: Specified Java EE 5 Generics usage where applicable.
[ https://issues.apache.org/jira/browse/MYFACES-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1262. --- Resolution: Fixed JSR-252 Issue #99: Specified Java EE 5 Generics usage where applicable. --- Key: MYFACES-1262 URL: https://issues.apache.org/jira/browse/MYFACES-1262 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Assignee: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Specified Java EE 5 Generics usage where applicable. https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=99 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1652) Current shared 2.0 and 3.0 should be compatible
[ https://issues.apache.org/jira/browse/MYFACES-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1652. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT Tomahawk compiles now with myfaces shared 3.0.0-snapshot, so it is backwards compatible Current shared 2.0 and 3.0 should be compatible --- Key: MYFACES-1652 URL: https://issues.apache.org/jira/browse/MYFACES-1652 Project: MyFaces Core Issue Type: Task Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 1.2.0-SNAPSHOT New methods added to shared 2.0 since the branching shared 3.0 must be added to 3.0, so tomahawk compiles with it -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1653) h:form popups to the top of h:view
[ https://issues.apache.org/jira/browse/MYFACES-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1653. --- Resolution: Fixed Does this happen with the latest myfaces 1.2 code? h:form popups to the top of h:view -- Key: MYFACES-1653 URL: https://issues.apache.org/jira/browse/MYFACES-1653 Project: MyFaces Core Issue Type: Bug Affects Versions: 1.2.0-SNAPSHOT Environment: geronimo-2.0-M6-SNAPSHOT Reporter: Alexander Zynevich Priority: Critical Attachments: body_in_html.txt, body_in_jsp.txt This problem is very similair to https://issues.apache.org/jira/browse/MYFACES-1633 and https://issues.apache.org/jira/browse/GERONIMO-3167 however now all the h:form is shifted, see attachments -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1651) Default converters and validators not correctly registered
Default converters and validators not correctly registered -- Key: MYFACES-1651 URL: https://issues.apache.org/jira/browse/MYFACES-1651 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda Not registered at all, since they do not appear in the standard-faces-config.xml file... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-1010) Allow the sandbox examples to be build with the different configurations (1.1 and 1.2 for both myfaces and ri)
Allow the sandbox examples to be build with the different configurations (1.1 and 1.2 for both myfaces and ri) -- Key: TOMAHAWK-1010 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1010 Project: MyFaces Tomahawk Issue Type: New Feature Affects Versions: 1.1.6-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda Priority: Minor Fix For: 1.1.6-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOMAHAWK-1010) Allow the sandbox examples to be build with the different configurations (1.1 and 1.2 for both myfaces and ri)
[ https://issues.apache.org/jira/browse/TOMAHAWK-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved TOMAHAWK-1010. Resolution: Fixed Allow the sandbox examples to be build with the different configurations (1.1 and 1.2 for both myfaces and ri) -- Key: TOMAHAWK-1010 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1010 Project: MyFaces Tomahawk Issue Type: New Feature Affects Versions: 1.1.6-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda Priority: Minor Fix For: 1.1.6-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-41) Create more specific packageContains configuration attributes for the maven-faces-plugin, for validators and converters
[ https://issues.apache.org/jira/browse/TRINIDAD-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved TRINIDAD-41. -- Resolution: Fixed Implemented in the branch of may Create more specific packageContains configuration attributes for the maven-faces-plugin, for validators and converters - Key: TRINIDAD-41 URL: https://issues.apache.org/jira/browse/TRINIDAD-41 Project: MyFaces Trinidad Issue Type: New Feature Components: Plugins Affects Versions: 1.0.0-incubating-plugins Reporter: Bruno Aranda Assignee: Bruno Aranda Fix For: 2.0.0-plugins For the myfaces 1.2 build, the implementation artifact needs to include the components, renderkits, converters and validators. The converters and validators, from the api, are in the package javax.faces, while the renderkits are in org.apache.myfaces. I need to include all of them in the generated faces-config.xml. The solution, is to create two new configuration attributes (validatorPackageContains and converterPackageContains) that allow to choose the packages for converters/validators without affecting the rest. If these attributes are not set, the value of packageContains is used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1650) convertDateTime tag not implemented correctly in myfaces 1.2
[ https://issues.apache.org/jira/browse/MYFACES-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1650. --- Resolution: Fixed I submitted a fix for this yesterday convertDateTime tag not implemented correctly in myfaces 1.2 Key: MYFACES-1650 URL: https://issues.apache.org/jira/browse/MYFACES-1650 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda Priority: Critical Fix For: 1.2.0-SNAPSHOT It is not using ValueExpressions -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1643) f:convertDateTime has wrong signatures of all setters (does not accept javax.el.ValueExpression)
[ https://issues.apache.org/jira/browse/MYFACES-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1643. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT Assignee: Bruno Aranda This should be fixed in the myfaces 1.2 trunk. Thanks for reporting! f:convertDateTime has wrong signatures of all setters (does not accept javax.el.ValueExpression) Key: MYFACES-1643 URL: https://issues.apache.org/jira/browse/MYFACES-1643 Project: MyFaces Core Issue Type: Bug Components: General Affects Versions: 1.2.0-SNAPSHOT Environment: geronimo-2.0 M5/M6 Reporter: Alexander Zynevich Assignee: Bruno Aranda Priority: Critical Fix For: 1.2.0-SNAPSHOT I get nightly build of Geronimo 2.0. It uses MyFaces-1.2.0-SNAP. I see that http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/core/myfaces-impl/1.2.0-SNAPSHOT/myfaces-impl-1.2.0-SNAPSHOT.jar has /META-INF/myfaces_core.tld which declares all attributes for f:convertDataTime as deffeted-value however methods of org.apache.myfaces.taglib.core.ConvertDateTimeTag (derived from org.apache.myfaces.shared_impl.taglib.core.ConvertDateTimeTagBase) accept only strings(thus it may not be deffered): http://svn.apache.org/viewvc/myfaces/shared/branches/3_0_0/core/src/main/java/org/apache/myfaces/shared/taglib/core/ConvertDateTimeTagBase.java?revision=479743view=markup code private String _dateStyle = default; // the default value as required by the spec (default in this case) private String _locale = null; private String _pattern = null; private String _timeStyle = default; // the default value as required by the spec (default in this case) private String _timeZone = null; private String _type = null; public void setDateStyle(String dateStyle) { _dateStyle = dateStyle; } public void setLocale(String locale) { _locale = locale; } public void setPattern(String pattern) { _pattern = pattern; } public void setTimeStyle(String timeStyle) { _timeStyle = timeStyle; } public void setTimeZone(String timeZone) { _timeZone = timeZone; } public void setType(String type) { _type = type; } /code The indication is: javax.servlet.ServletException: Unable to compile class for JSP: An error occurred at line: 72 in the jsp file: /jsp/cust/customer_details_spc.jsp The method setPattern(String) in the type ConvertDateTimeTagBase is not applicable for the arguments (JspValueExpression) 69: /f:facet 70: w:dragSource dndTypeId=%=DnDIds.ID_SPECIAL% dndObjId=#{obj.spclID} dndText=#{obj.spclShrtName} 71: h:outputText id=cellFrom styleClass=specials-text-norm-dnd-ds value=#{obj.spclStrtDate} 72: f:convertDateTime pattern=-MM-dd timeZone=#{commonInfo.timeZone} / 73: /h:outputText 74: /w:dragSource 75: /h:column An error occurred at line: 72 in the jsp file: /jsp/cust/customer_details_spc.jsp The method setTimeZone(String) in the type ConvertDateTimeTagBase is not applicable for the arguments (JspValueExpression) 69: /f:facet 70: w:dragSource dndTypeId=%=DnDIds.ID_SPECIAL% dndObjId=#{obj.spclID} dndText=#{obj.spclShrtName} 71: h:outputText id=cellFrom styleClass=specials-text-norm-dnd-ds value=#{obj.spclStrtDate} 72: f:convertDateTime pattern=-MM-dd timeZone=#{commonInfo.timeZone} / 73: /h:outputText 74: /w:dragSource 75: /h:column -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1652) Current shared 2.0 and 3.0 should be compatible
Current shared 2.0 and 3.0 should be compatible --- Key: MYFACES-1652 URL: https://issues.apache.org/jira/browse/MYFACES-1652 Project: MyFaces Core Issue Type: Task Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assignee: Bruno Aranda New methods added to shared 2.0 since the branching shared 3.0 must be added to 3.0, so tomahawk compiles with it -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1646) Using alternative configurations (e.g. ViewHandlers) not working properly
Using alternative configurations (e.g. ViewHandlers) not working properly - Key: MYFACES-1646 URL: https://issues.apache.org/jira/browse/MYFACES-1646 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Priority: Critical Fix For: 1.2.0-SNAPSHOT The autogeneration for myfaces impl is creating a faces-config.xml file with the default configuration of myfaces. Instead it should create a standard-faces-config.xml file (that replaces the old standard config file). This ensures that, when an app is configured, the myfaces config goes first and alternative configurations (such as Trinidad's) override the configuration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1646) Using alternative configurations (e.g. ViewHandlers) not working properly
[ https://issues.apache.org/jira/browse/MYFACES-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1646. --- Resolution: Fixed Using alternative configurations (e.g. ViewHandlers) not working properly - Key: MYFACES-1646 URL: https://issues.apache.org/jira/browse/MYFACES-1646 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Priority: Critical Fix For: 1.2.0-SNAPSHOT The autogeneration for myfaces impl is creating a faces-config.xml file with the default configuration of myfaces. Instead it should create a standard-faces-config.xml file (that replaces the old standard config file). This ensures that, when an app is configured, the myfaces config goes first and alternative configurations (such as Trinidad's) override the configuration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1647) Alternative renderkits not working in myfaces
Alternative renderkits not working in myfaces - Key: MYFACES-1647 URL: https://issues.apache.org/jira/browse/MYFACES-1647 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Priority: Critical Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1647) Alternative renderkits not working in myfaces
[ https://issues.apache.org/jira/browse/MYFACES-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1647. --- Resolution: Fixed Alternative renderkits not working in myfaces - Key: MYFACES-1647 URL: https://issues.apache.org/jira/browse/MYFACES-1647 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Priority: Critical Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1648) myfaces-build should have scope provided as it is only needed on build time
myfaces-build should have scope provided as it is only needed on build time - Key: MYFACES-1648 URL: https://issues.apache.org/jira/browse/MYFACES-1648 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1648) myfaces-build should have scope provided as it is only needed on build time
[ https://issues.apache.org/jira/browse/MYFACES-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1648. --- Resolution: Fixed myfaces-build should have scope provided as it is only needed on build time - Key: MYFACES-1648 URL: https://issues.apache.org/jira/browse/MYFACES-1648 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1648) myfaces-build should have scope provided as it is only needed on build time
[ https://issues.apache.org/jira/browse/MYFACES-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499432 ] Bruno Aranda commented on MYFACES-1648: --- As proposed by Wendy, instead of using a provided dependency, a build extension will be used myfaces-build should have scope provided as it is only needed on build time - Key: MYFACES-1648 URL: https://issues.apache.org/jira/browse/MYFACES-1648 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1649) Converter tag incorrecly mapped in the myfaces_core.tld
Converter tag incorrecly mapped in the myfaces_core.tld --- Key: MYFACES-1649 URL: https://issues.apache.org/jira/browse/MYFACES-1649 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT It is not pointing to the implementation ConverterTag -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1649) Converter tag incorrecly mapped in the myfaces_core.tld
[ https://issues.apache.org/jira/browse/MYFACES-1649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1649. --- Resolution: Fixed Converter tag incorrecly mapped in the myfaces_core.tld --- Key: MYFACES-1649 URL: https://issues.apache.org/jira/browse/MYFACES-1649 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT It is not pointing to the implementation ConverterTag -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1650) convertDateTime tag not implemented correctly in myfaces 1.2
convertDateTime tag not implemented correctly in myfaces 1.2 Key: MYFACES-1650 URL: https://issues.apache.org/jira/browse/MYFACES-1650 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Priority: Critical Fix For: 1.2.0-SNAPSHOT It is not using ValueExpressions -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1645) UIViewRoot.getLocale is not implemented according to the spec
UIViewRoot.getLocale is not implemented according to the spec - Key: MYFACES-1645 URL: https://issues.apache.org/jira/browse/MYFACES-1645 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT See http://java.sun.com/javaee/javaserverfaces/1.2/docs/api/javax/faces/component/UIViewRoot.html#getLocale() for the implementation explanation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1645) UIViewRoot.getLocale is not implemented according to the spec
[ https://issues.apache.org/jira/browse/MYFACES-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1645. --- Resolution: Fixed UIViewRoot.getLocale is not implemented according to the spec - Key: MYFACES-1645 URL: https://issues.apache.org/jira/browse/MYFACES-1645 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT See http://java.sun.com/javaee/javaserverfaces/1.2/docs/api/javax/faces/component/UIViewRoot.html#getLocale() for the implementation explanation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1642) Id attribute not present in the rendered HTML for the commandLink, even if the id was provided
Id attribute not present in the rendered HTML for the commandLink, even if the id was provided -- Key: MYFACES-1642 URL: https://issues.apache.org/jira/browse/MYFACES-1642 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1642) Id attribute not present in the rendered HTML for the commandLink, even if the id was provided
[ https://issues.apache.org/jira/browse/MYFACES-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1642. --- Resolution: Fixed Id attribute not present in the rendered HTML for the commandLink, even if the id was provided -- Key: MYFACES-1642 URL: https://issues.apache.org/jira/browse/MYFACES-1642 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1639) Some DTDs hold Sun Microsystems copyrights.
[ https://issues.apache.org/jira/browse/MYFACES-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497765 ] Bruno Aranda commented on MYFACES-1639: --- In 1.2 the DTDs are not needed. They have been removed as they were an artifact of 1.1 Some DTDs hold Sun Microsystems copyrights. Key: MYFACES-1639 URL: https://issues.apache.org/jira/browse/MYFACES-1639 Project: MyFaces Core Issue Type: Task Components: General Affects Versions: 1.1.4 Reporter: Grant Smith Assigned To: Grant Smith For now, I will follow GERONIMO's lead and retype the DTDs by hand, with ASF headers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1636) When getting the converter of an array of type String, an exception is thrown
When getting the converter of an array of type String, an exception is thrown - Key: MYFACES-1636 URL: https://issues.apache.org/jira/browse/MYFACES-1636 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Observable in the sample2.jsf page from the simple examples, when removing quotes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1637) ClassCastException in UIComponentClassicTagBase.createVerbatimComponent
ClassCastException in UIComponentClassicTagBase.createVerbatimComponent --- Key: MYFACES-1637 URL: https://issues.apache.org/jira/browse/MYFACES-1637 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Wrong cast to set, instead of list -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1636) When getting the converter of an array of type String, an exception is thrown
[ https://issues.apache.org/jira/browse/MYFACES-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1636. --- Resolution: Fixed When getting the converter of an array of type String, an exception is thrown - Key: MYFACES-1636 URL: https://issues.apache.org/jira/browse/MYFACES-1636 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Observable in the sample2.jsf page from the simple examples, when removing quotes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1637) ClassCastException in UIComponentClassicTagBase.createVerbatimComponent
[ https://issues.apache.org/jira/browse/MYFACES-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1637. --- Resolution: Fixed ClassCastException in UIComponentClassicTagBase.createVerbatimComponent --- Key: MYFACES-1637 URL: https://issues.apache.org/jira/browse/MYFACES-1637 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Wrong cast to set, instead of list -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-1478) Implement JSR-252 core tag: convertDateTimeTag
[ https://issues.apache.org/jira/browse/MYFACES-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda updated MYFACES-1478: -- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT Status: Resolved (was: Patch Available) Implement JSR-252 core tag: convertDateTimeTag -- Key: MYFACES-1478 URL: https://issues.apache.org/jira/browse/MYFACES-1478 Project: MyFaces Core Issue Type: Sub-task Reporter: Andreas Berger Fix For: 1.2.0-SNAPSHOT Attachments: ConvertDateTimeTag.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1564) Submitted Values get lost in case conversion/validation errors
[ https://issues.apache.org/jira/browse/MYFACES-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1564. --- Resolution: Cannot Reproduce Submitted Values get lost in case conversion/validation errors -- Key: MYFACES-1564 URL: https://issues.apache.org/jira/browse/MYFACES-1564 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Cagatay Civici Assigned To: Christoph Ebner When a conversion or validation error occurs, the submitted values are erased and components are rendered with empty values. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1485) Implement JSR-252 core tag: FacetTag
[ https://issues.apache.org/jira/browse/MYFACES-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1485. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT Implement JSR-252 core tag: FacetTag Key: MYFACES-1485 URL: https://issues.apache.org/jira/browse/MYFACES-1485 Project: MyFaces Core Issue Type: Sub-task Reporter: Andreas Berger Assigned To: Matthias Weßendorf Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1434) All attributes in tags must be of type ValueExpression. In the tld, the attributes must contain a deferred-type element with the attribute type
[ https://issues.apache.org/jira/browse/MYFACES-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1434. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT All attributes in tags must be of type ValueExpression. In the tld, the attributes must contain a deferred-type element with the attribute type - Key: MYFACES-1434 URL: https://issues.apache.org/jira/browse/MYFACES-1434 Project: MyFaces Core Issue Type: Improvement Components: JSR-252 Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Attributes in tags are of type javax.el.ValueExpression. In the tld, following the jsp 2.1 spec we have to put the deferred-type element, with the type of the attribute. This is a major change in the codebase. Now methods such as UIComponentTagUtils.setIntegerProperty, UIComponentTagUtils.setStringProperty, etc, will be deprecated in favor of a unique UIComponentTagUtils.setProperty (accepting a ValueExpression instead of a String). This methods are called in the setProperties() methods of the tags -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1201) JSR-252 Issue #4: Added headerClass and footerClass attributes at the h:column level.
[ https://issues.apache.org/jira/browse/MYFACES-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1201. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT JSR-252 Issue #4: Added headerClass and footerClass attributes at the h:column level. --- Key: MYFACES-1201 URL: https://issues.apache.org/jira/browse/MYFACES-1201 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Assigned To: Matthias Weßendorf Fix For: 1.2.0-SNAPSHOT JSR-252 Issue #4: Added headerClass and footerClass attributes at the h:column level. Please see Section 8.5 Standard HTML RenderKit Implementation for more details. See https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=4 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1563) Re-rendered input components redisplay their locale value on non-immediate action
[ https://issues.apache.org/jira/browse/MYFACES-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497564 ] Bruno Aranda commented on MYFACES-1563: --- Hi, you were trying this when the implementation was not yet complete. Could you try it again? Now it should work. Cheers, Bruno Re-rendered input components redisplay their locale value on non-immediate action - Key: MYFACES-1563 URL: https://issues.apache.org/jira/browse/MYFACES-1563 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.1.5 Environment: Tomcat 5.5, Jetty 6.1, Java 1.4.2, Java 1.5.0 Reporter: sarah haas Priority: Critical Fix For: 1.1.5 Attachments: NonRenderedComp.java, nonRenderedComp.jsp, PersonBean.java, test.jsp Since the component was previously not rendered, its submitted value is null. The local value that is set in restoreState is not null. This does not get reset by validation since non-rendered components are not validated (processValidators). Therefore the associated value-binding expression is not evaluated in getValue,and hence the local value is returned. It seems to me that restoreState should set the local value to null. This would result in the value-binding expression being evaluated and displayed. Example: I have a number of input text fields and a select-one-menu (which has an immedate valueChangeListener) a command button (with an non-immedate action). The menu switches the rendered mode of some display fields. The button saves the entered text and clears the input fields. In addition I have a data-table which displays the saved data and contains a column with a button, whose on-immediate action puts the selected data item into the input fields. I enter data in the input fields and save the data. It is displayed in the table. Then I use the menu to select a mode in which some of the input text fields are no longer rendered. I then select the original data from the table. The fields which remain rendered are displayed and filled correctly. However the fields which were previously NOT rendered are displayed but are EMPTY. This bug does not occur with Sun's reference implementation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1217) JSR-252 Issue #43: Migrated over to using XML Schema (from DTD) for configuration file validation.
[ https://issues.apache.org/jira/browse/MYFACES-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1217. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT Assignee: Bruno Aranda JSR-252 Issue #43: Migrated over to using XML Schema (from DTD) for configuration file validation. -- Key: MYFACES-1217 URL: https://issues.apache.org/jira/browse/MYFACES-1217 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT Migrated over to using XML Schema (from DTD) for configuration file validation. Please see Section 1.1 XML Schema Definition. Also see https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=43 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1264) JSR-252 Issue #108: JSF in Java EE containers must validate the application resource file against the XML schema.
[ https://issues.apache.org/jira/browse/MYFACES-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1264. --- Resolution: Fixed JSR-252 Issue #108: JSF in Java EE containers must validate the application resource file against the XML schema. - Key: MYFACES-1264 URL: https://issues.apache.org/jira/browse/MYFACES-1264 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Specified that JSF implementations that are part of a Java EE technology-compliant implementation are required to validate the application resource file against the XML schema for structural correctness. Also specified that validation is recommended, but not required for JSF implementations that are not part of a Java EE technology compliant implementation. Please refer to Section 10.4.2 Application Startup Behavior for more details. Also see https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=108 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1218) JSR-252 Issue #45: Avoided concurrent read issues by using a java.util.HashMap instead of java.util.WeakHashMap for a component's Property Descriptor Map
[ https://issues.apache.org/jira/browse/MYFACES-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497567 ] Bruno Aranda commented on MYFACES-1218: --- This issue is RI specific. Is this appliable to _ComponentAttributesMap? JSR-252 Issue #45: Avoided concurrent read issues by using a java.util.HashMap instead of java.util.WeakHashMap for a component's Property Descriptor Map - Key: MYFACES-1218 URL: https://issues.apache.org/jira/browse/MYFACES-1218 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Reporter: Stan Silvert Assigned To: Matthias Weßendorf Avoided concurrent read issues by using a java.util.HashMap instead of java.util.WeakHashMap for a component's Property Descriptor Map. This also fixes the performance problem as identified in the forum. Please refer the the Property Descriptor methods and the constructor in javax.faces.component.UIComponentBase. Also see https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=45 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1327) Make example webapp with 1.2 features
[ https://issues.apache.org/jira/browse/MYFACES-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1327. --- Resolution: Fixed Hi, what is the state of this? Cheers, Bruno Make example webapp with 1.2 features - Key: MYFACES-1327 URL: https://issues.apache.org/jira/browse/MYFACES-1327 Project: MyFaces Core Issue Type: Improvement Components: JSR-252 Reporter: Dennis Byrne Assigned To: Dennis Byrne ... should show off invokeOnComponent and content interweaving. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-1327) Make example webapp with 1.2 features
[ https://issues.apache.org/jira/browse/MYFACES-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda reopened MYFACES-1327: --- I have resolved it instead of just writing a comment :-) Make example webapp with 1.2 features - Key: MYFACES-1327 URL: https://issues.apache.org/jira/browse/MYFACES-1327 Project: MyFaces Core Issue Type: Improvement Components: JSR-252 Reporter: Dennis Byrne Assigned To: Dennis Byrne ... should show off invokeOnComponent and content interweaving. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1232) JSR-252 Issue #72: Improve XHTML compliance by rendering both lang and xml:lang attributes.
[ https://issues.apache.org/jira/browse/MYFACES-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1232. --- Resolution: Won't Fix This issue is RI specific, right? JSR-252 Issue #72: Improve XHTML compliance by rendering both lang and xml:lang attributes. --- Key: MYFACES-1232 URL: https://issues.apache.org/jira/browse/MYFACES-1232 Project: MyFaces Core Issue Type: New Feature Components: JSR-252 Reporter: Stan Silvert Assigned To: Matthias Weßendorf Improve XHTML compliance by rendering both lang and xml:lang attributes. See https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=72 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1638) Do not render id and name attributes in links, if id is not specified
Do not render id and name attributes in links, if id is not specified - Key: MYFACES-1638 URL: https://issues.apache.org/jira/browse/MYFACES-1638 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1638) Do not render id and name attributes in links, if id is not specified
[ https://issues.apache.org/jira/browse/MYFACES-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1638. --- Resolution: Fixed Following the general notes on encoding: http://java.sun.com/javaee/javaserverfaces/1.2/docs/renderkitdocs/HTML_BASIC/renderkit-summary.html Do not render id and name attributes in links, if id is not specified - Key: MYFACES-1638 URL: https://issues.apache.org/jira/browse/MYFACES-1638 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-1640) Content after the view tag incorrectly written to the response
Content after the view tag incorrectly written to the response -- Key: MYFACES-1640 URL: https://issues.apache.org/jira/browse/MYFACES-1640 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT This could be observed in the fileUpload example, which didn't work -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1640) Content after the view tag incorrectly written to the response
[ https://issues.apache.org/jira/browse/MYFACES-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1640. --- Resolution: Fixed Content after the view tag incorrectly written to the response -- Key: MYFACES-1640 URL: https://issues.apache.org/jira/browse/MYFACES-1640 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Reporter: Bruno Aranda Assigned To: Bruno Aranda Fix For: 1.2.0-SNAPSHOT This could be observed in the fileUpload example, which didn't work -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-1633) Incorret view rendering after postback
[ https://issues.apache.org/jira/browse/MYFACES-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-1633. --- Resolution: Fixed Fix Version/s: 1.2.0-SNAPSHOT New IDs where generated on post back for components that already had one due to a bug in the generation of the id. Components where inserted in the wrong place as the list of component IDs and the actual child components for a parent where different. Incorret view rendering after postback -- Key: MYFACES-1633 URL: https://issues.apache.org/jira/browse/MYFACES-1633 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Priority: Blocker Fix For: 1.2.0-SNAPSHOT The rendered code and the html code from the page are not ordered correctly. Visual mess. Easily observable when running the simple examples with our 1.2 implementation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1633) Incorret view rendering after postback
[ https://issues.apache.org/jira/browse/MYFACES-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496996 ] Bruno Aranda commented on MYFACES-1633: --- A snippet as simple as this can reproduce the issue: f:view h:outputLabel value=LABEL/ h:form id=form h:commandButton id=button value=BUTTON action=none / /h:form h:outputLabel value=END/ /f:view When the button is clicked, the form is moved to the bottom. Seems to be an issue in UIComponentClassicTagBase or in the rendering of the view. If the end label has id, everything is all right, of if everything is nested in another component (e.g. panelGroup). If the id of the form is removed, everything works ok too. I will investigate further on sunday... Incorret view rendering after postback -- Key: MYFACES-1633 URL: https://issues.apache.org/jira/browse/MYFACES-1633 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions: 1.2.0-SNAPSHOT Reporter: Bruno Aranda Assigned To: Bruno Aranda Priority: Blocker The rendered code and the html code from the page are not ordered correctly. Visual mess. Easily observable when running the simple examples with our 1.2 implementation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.