[jira] [Commented] (TOBAGO-2084) CVE suppression for Tobago 5
[ https://issues.apache.org/jira/browse/TOBAGO-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354216#comment-17354216 ] Dennis Kieselhorst commented on TOBAGO-2084: Why do we require a checkstyle suppression for CVE-2021-23343 path-parse? https://nvd.nist.gov/vuln/detail/CVE-2021-23343 mentions that it's fixed in 1.0.7, can't we just use that version? > CVE suppression for Tobago 5 > > > Key: TOBAGO-2084 > URL: https://issues.apache.org/jira/browse/TOBAGO-2084 > Project: MyFaces Tobago > Issue Type: Task > Components: Build >Reporter: Udo Schnurpfeil >Assignee: Udo Schnurpfeil >Priority: Minor > Fix For: 4.5.4, 5.0.0 > > > Split CVE suppression list between Tobago 4 and 5 > Also: > * add CVE suppression for npm path-parse -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TRINIDAD-2566) NullPointerException after upgrading from apache-tomcat-8.5.47 to apache-tomcat-8.5.49
[
https://issues.apache.org/jira/browse/TRINIDAD-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990422#comment-16990422
]
Dennis Kieselhorst commented on TRINIDAD-2566:
--
Thanks for your bug report. There are no active Trinidad developers at the
moment. Any chance that you create a pull request with a fix? You can find the
code here:
https://github.com/apache/myfaces-trinidad/blob/master/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/AgentAtRuleMatcher.java
> NullPointerException after upgrading from apache-tomcat-8.5.47 to
> apache-tomcat-8.5.49
> ---
>
> Key: TRINIDAD-2566
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2566
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
>Affects Versions: 2.2.0-core
> Environment: apache-tomcat-8.5.49
>Reporter: Pervasync
>Priority: Blocker
>
> After upgrading from apache-tomcat-8.5.47 to apache-tomcat-8.5.49, got this
> exception when loading jspx page:
>
> {{java.lang.NullPointerException
> at
> org.apache.myfaces.trinidadinternal.skin.AgentAtRuleMatcher$TouchScreenCapabilityMatcher.match(AgentAtRuleMatcher.java:863)
> at
> org.apache.myfaces.trinidadinternal.skin.AgentAtRuleMatcher.match(AgentAtRuleMatcher.java:502)
> at
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNode._compareBrowserAndVersion(StyleSheetNode.java:379)
> at
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetNode.compareVariants(StyleSheetNode.java:194)
> at
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetDocument._getStyleSheets(StyleSheetDocument.java:569)
> at
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetDocument.getStyleSheetsAsCollection(StyleSheetDocument.java:201)
> at
> org.apache.myfaces.trinidadinternal.style.xml.parse.StyleSheetDocument.getStyleSheets(StyleSheetDocument.java:196)
> at
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getNamespacePrefixes(FileSystemStyleCache.java:1324)
> at
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getStyleSheetDocument(FileSystemStyleCache.java:956)
> at
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache._getEntry(FileSystemStyleCache.java:425)
> at
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache.getStyleSheetURIs(FileSystemStyleCache.java:142)
> at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.StyleSheetRenderer.encodeAll(StyleSheetRenderer.java:81)
> at
> org.apache.myfaces.trinidad.render.CoreRenderer.delegateRenderer(CoreRenderer.java:688)
> at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.HeadRenderer.encodeEnd(HeadRenderer.java:97)
> at
> org.apache.myfaces.trinidad.render.CoreRenderer.encodeEnd(CoreRenderer.java:551)
> at
> org.apache.myfaces.trinidad.component.UIXComponentBase.encodeEnd(UIXComponentBase.java:1239)
> at javax.faces.component.UIComponent.encodeAll(UIComponent.java:823)
> at javax.faces.component.UIComponent.encodeAll(UIComponent.java:819)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at
> org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.actuallyRenderView(JspViewDeclarationLanguageBase.java:351)
> at
> org.apache.myfaces.shared.view.JspViewDeclarationLanguageBase.renderView(JspViewDeclarationLanguageBase.java:200)
> at
> org.apache.myfaces.trinidad.view.ViewDeclarationLanguageWrapper.renderView(ViewDeclarationLanguageWrapper.java:101)
> at
> org.apache.myfaces.trinidadinternal.application.ViewDeclarationLanguageFactoryImpl$ChangeApplyingVDLWrapper.renderView(ViewDeclarationLanguageFactoryImpl.java:338)
> at
> org.apache.myfaces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:313)
> at
> javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:58)
> at
> org.apache.myfaces.trinidadinternal.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:170)
> at
> org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:116)
> at
> org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:267)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> at pervasync.server.console.AccessControlFilter.doFilter(SourceFile:97)
> at
> org.apache.catalina.core.Applicat
[jira] [Commented] (TRINIDAD-2564) maven-faces-plugin
[ https://issues.apache.org/jira/browse/TRINIDAD-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515854#comment-16515854 ] Dennis Kieselhorst commented on TRINIDAD-2564: -- Find a dev who prepares a release and starts a vote by asking on the mailinglist: [https://lists.apache.org/list.html?dev@myfaces.apache.org] [~bommel] has experiences with doing Trinidad releases, but he is quite busy at the moment. > maven-faces-plugin > -- > > Key: TRINIDAD-2564 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2564 > Project: MyFaces Trinidad > Issue Type: Bug > Components: Plugins >Affects Versions: 2.2.0-core > Environment: Windows 8.1, Windows 10, Tomcat 8+, Glassfish >Reporter: Médéric Martin >Priority: Critical > Original Estimate: 5m > Remaining Estimate: 5m > > Hi, > I detect one bog in the last version which is relative to TRINIDAD-2483 . > [~arobinson74] said on July 2014 "Fixed in both the plugins and the trunk." > Yes it was, but the plugin maven has no release since 13/11/2013 (maven repo > public). So, actually the bog is always there, and we have NullPointer with > new version of EL on Tomcat 8+. Furthermore, I checkouted source SVN of > maven-faces-plugin, and the pom.xml is 2.0.9-SNAPSHOT. With these version, it > works... So, is it possible to release a 2.0.9 maven-faces-plugin please ?? > (y) > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TOBAGO-1899) Error building tobago 4.2.1 on windows 10
[ https://issues.apache.org/jira/browse/TOBAGO-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477002#comment-16477002 ] Dennis Kieselhorst commented on TOBAGO-1899: I was able to reproduce this on a Windows machine. > Error building tobago 4.2.1 on windows 10 > - > > Key: TOBAGO-1899 > URL: https://issues.apache.org/jira/browse/TOBAGO-1899 > Project: MyFaces Tobago > Issue Type: Bug > Components: Build >Affects Versions: 4.2.0 > Environment: git clone + maven + windows 10 >Reporter: maurel >Priority: Minor > > Failure is encountered when building tobago-4.2.1 on windows 10: > --- > Test set: org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest > --- > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.292 sec <<< > FAILURE! - in org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest > testCompareBootstrapCss(org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest) > Time elapsed: 0.054 sec <<< FAILURE! > java.lang.AssertionError: These classes are missing in bootstrap.css: > [ALIGN_ITEMS_BASELINE, ALIGN_ITEMS_CENTER, ALIGN_ITEMS_END, > ALIGN_ITEMS_START, ALIGN_ITEMS_STRETCH, BG_DARK, BORDER_DANGER, BORDER_INFO, > BORDER_WARNING, D_FLEX, D_INLINE, D_NONE, D_SM_NONE, FIXED_BOTTOM, FIXED_TOP, > FLEX_COLUMN, FLEX_COLUMN_REVERSE, FLEX_ROW, FLEX_ROW_REVERSE, INVISIBLE, > JUSTIFY_CONTENT_AROUND, JUSTIFY_CONTENT_BETWEEN, JUSTIFY_CONTENT_CENTER, > JUSTIFY_CONTENT_END, JUSTIFY_CONTENT_START, ML_AUTO, ML_LG_AUTO, ML_MD_AUTO, > ML_SM_AUTO, ML_XL_AUTO, MR_AUTO, MR_LG_AUTO, MR_MD_AUTO, MR_SM_AUTO, > MR_XL_AUTO, MY_LG_0, MY_LG_1, MY_LG_2, MY_LG_3, MY_LG_4, MY_LG_5, MX_AUTO, > MX_LG_AUTO, MX_MD_AUTO, MX_SM_AUTO, MX_XL_AUTO, SR_ONLY, TEXT_CENTER, > TEXT_JUSTIFY, TEXT_LEFT, TEXT_RIGHT] > at > org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest.testCompareBootstrapCss(BootstrapClassUnitTest.java:86) > If I comment org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest > testCompareBootstrapCss(org.apache.myfaces.tobago.renderkit.css.BootstrapClassUnitTest) > then everything runs fine. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRINIDAD-2564) maven-faces-plugin
[ https://issues.apache.org/jira/browse/TRINIDAD-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463427#comment-16463427 ] Dennis Kieselhorst commented on TRINIDAD-2564: -- Please note that the sources have been moved to Git: https://github.com/apache/myfaces-trinidad-maven > maven-faces-plugin > -- > > Key: TRINIDAD-2564 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2564 > Project: MyFaces Trinidad > Issue Type: Bug > Components: Plugins >Affects Versions: 2.2.0-core > Environment: Windows 8.1, Windows 10, Tomcat 8+, Glassfish >Reporter: Médéric Martin >Priority: Critical > Original Estimate: 5m > Remaining Estimate: 5m > > Hi, > I detect one bog in the last version which is relative to TRINIDAD-2483 . > [~arobinson74] said on July 2014 "Fixed in both the plugins and the trunk." > Yes it was, but the plugin maven has no release since 13/11/2013 (maven repo > public). So, actually the bog is always there, and we have NullPointer with > new version of EL on Tomcat 8+. Furthermore, I checkouted source SVN of > maven-faces-plugin, and the pom.xml is 2.0.9-SNAPSHOT. With these version, it > works... So, is it possible to release a 2.0.9 maven-faces-plugin please ?? > (y) > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRINIDAD-2527) Row selection retains with tr:table
[
https://issues.apache.org/jira/browse/TRINIDAD-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463426#comment-16463426
]
Dennis Kieselhorst commented on TRINIDAD-2527:
--
Mike's statement above is still valid. So please fork the project
http://github.com/apache/myfaces-trinidad and provide a pull request. We will
review and apply it.
> Row selection retains with tr:table
> ---
>
> Key: TRINIDAD-2527
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2527
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Archetype
>Affects Versions: 2.1.1-core
> Environment: Windows 7, Java 7
>Reporter: Deepan
>Priority: Major
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> A page contains with rowSelection as "Single/Multiple" and the
> beans are session scoped.
> - Select a row using the radio or checkbox
> - Navigate to some other pages
> - Again come back to page 1. Now, previously selected radio or checkbox are
> selected.
> {code:title=Sample code|borderStyle=solid}
> rowSelection="single"
> value="#{myBean.myList}"
> var="groups" varStatus="rowId" rowBandingInterval="1"
> verticalGridVisible="true"
> selectionListener="#{myBackingBean.myRowSelectListener}">
> ...
> ...
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TOBAGO-1868) Update release process: remove MD5 support
[
https://issues.apache.org/jira/browse/TOBAGO-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386034#comment-16386034
]
Dennis Kieselhorst commented on TOBAGO-1868:
Should be done in myfaces-master-pom for all projects, shouldn't it? I noticed
there is a new apache pom version 19 with digest-algo set.
> Update release process: remove MD5 support
> --
>
> Key: TOBAGO-1868
> URL: https://issues.apache.org/jira/browse/TOBAGO-1868
> Project: MyFaces Tobago
> Issue Type: Task
> Components: Build
>Reporter: Udo Schnurpfeil
>Assignee: Udo Schnurpfeil
>Priority: Major
> Fix For: 4.1.1
>
>
> The rules on the Apache pages has been changed:
> http://www.apache.org/dev/release-distribution#sigs-and-sums
> {panel:title=Point 4}
> SHOULD NOT supply a MD5 checksum file (because MD5 is too broken).
> {panel}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TOBAGO-1837) Update Bootstrap to 4.0.0 beta 3 (from beta 2)
[ https://issues.apache.org/jira/browse/TOBAGO-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331943#comment-16331943 ] Dennis Kieselhorst commented on TOBAGO-1837: FYI 4.0.0 stable has just been released. > Update Bootstrap to 4.0.0 beta 3 (from beta 2) > -- > > Key: TOBAGO-1837 > URL: https://issues.apache.org/jira/browse/TOBAGO-1837 > Project: MyFaces Tobago > Issue Type: Task > Components: Core, Themes >Affects Versions: 4.0.0 >Reporter: Henning Noeth >Assignee: Henning Noeth >Priority: Major > Fix For: 4.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (MYFACES-4140) NullPointerException instead of InvalidViewIdException
[
https://issues.apache.org/jira/browse/MYFACES-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved MYFACES-4140.
-
Resolution: Duplicate
Assignee: Dennis Kieselhorst
Fix Version/s: 2.3.0
No longer reproducible, resolving as duplicate of MYFACES-4183.
> NullPointerException instead of InvalidViewIdException
> --
>
> Key: MYFACES-4140
> URL: https://issues.apache.org/jira/browse/MYFACES-4140
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3.0-beta
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.3.0
>
>
> In case of an invalid viewId an NPE is thrown instead of
> InvalidViewIdException. This is reproducible using tobago-example-demo
> (NavigationTree /content/root-dummy.xhtml).
> {noformat}
> Caused by: java.lang.NullPointerException
> at
> org.apache.myfaces.application.ViewHandlerImpl.getViewParameterList(ViewHandlerImpl.java:459)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getBookmarkableURL(ViewHandlerImpl.java:141)
> at
> javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
> at
> javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
> at
> org.apache.myfaces.tobago.internal.util.RenderUtils.generateUrl(RenderUtils.java:229)
> at
> org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.encodeBegin(CommandRendererBase.java:86)
> at
> javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at
> org.apache.myfaces.tobago.internal.renderkit.renderer.TreeRenderer.encodeEnd(TreeRenderer.java:130)
> at
> javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:675)
> at javax.faces.component.UIData.encodeEnd(UIData.java:1811)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:555)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at javax.faces.render.Renderer.encodeChildren(Renderer.java:95)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (MYFACES-4002) Regression? - References to external entities not working with WebXmlParser
[
https://issues.apache.org/jira/browse/MYFACES-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst updated MYFACES-4002:
Resolution: Not A Problem
Status: Resolved (was: Patch Available)
[~ttimbul] closing for now, feel free to reopen with more information
> Regression? - References to external entities not working with WebXmlParser
> ---
>
> Key: MYFACES-4002
> URL: https://issues.apache.org/jira/browse/MYFACES-4002
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.4
> Environment: Myfaces 2.2.4, Tomcat 8.0.23, JDK 1.8_20, Windows 7 64bit
>Reporter: Thomas Timbul
> Attachments: patch1.txt
>
>
> I've searched JIRA and there are a few issues related to WebXmlParser, but
> this seems almost like a recurrence of MYFACES-1754.
> My web.xml is split into multiple files, each declared as an XML entity
> relative to the web.xml file itself:
> {code:xml}
>
> {code}
> (As a side note I used to use
> {{jndi:/localhost/WEB-INF/webxml/context-params.xml}}, but for some reason
> Tomcat 8 claims that jndi is an invalid protocol).
> Using resource relative system identifiers Tomcat is now happy and the
> context starts correctly. However, during its initialization MyFaces
> re-parses the web.xml descriptor and resolves the entities incorrectly,
> leading to failure with the message:
> {code}
> 2015-06-17 15:48:13.853 [localhost-startStop-1] ERROR
> o.a.m.s.w.webxml.WebXmlParser - Unable to parse web.xml
> java.lang.IllegalArgumentException: The resource path
> [file:///WEB-INF/webxml/context-params.xml] is not valid
> {code}
> The solution is to remove the file:// prefix before passing to the external
> context to resolve, as in this patch:
> {code}
> Index: org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
> ===
> --- WebXmlParser.java (revision ???)
> +++ WebXmlParser.java (working copy)
> @@ -138,6 +138,9 @@
>
> private InputSource createContextInputSource(String publicId, String
> systemId)
> {
> +if(systemId.startsWith("file:")) {
> +systemId = systemId.substring(7); // remove file://
> +}
> InputStream inStream = _context.getResourceAsStream(systemId);
> if (inStream == null)
> {
> {code}
> Those three lines of code are based on other work by the MyFaces team
> (org.apache.myfaces.config.impl.FacesConfigEntityResolver) and even if it
> weren't is made available free of charge and free from license restrictions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (TOBAGO-1836) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
[ https://issues.apache.org/jira/browse/TOBAGO-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1836. Resolution: Fixed Fix Version/s: 4.1.0 I've set this to org.apache.myfaces.tobago for tobago-core for now, but I'm open for other proposals... > Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility > - > > Key: TOBAGO-1836 > URL: https://issues.apache.org/jira/browse/TOBAGO-1836 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Build >Affects Versions: 4.0.0 >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst >Priority: Minor > Fix For: 4.1.0 > > > http://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html > https://github.com/jodastephen/jpms-module-names > Similar issues: CXF-7600, IO-551, LANG-1338, CODEC-242 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TOBAGO-1836) Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility
Dennis Kieselhorst created TOBAGO-1836: -- Summary: Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility Key: TOBAGO-1836 URL: https://issues.apache.org/jira/browse/TOBAGO-1836 Project: MyFaces Tobago Issue Type: Improvement Components: Build Affects Versions: 4.0.0 Reporter: Dennis Kieselhorst Priority: Minor http://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html https://github.com/jodastephen/jpms-module-names Similar issues: CXF-7600, IO-551, LANG-1338, CODEC-242 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TRINIDAD-2561) JSF Partial State Saving is not enabled
[ https://issues.apache.org/jira/browse/TRINIDAD-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275991#comment-16275991 ] Dennis Kieselhorst commented on TRINIDAD-2561: -- We welcome your pull requests: https://github.com/apache/myfaces-trinidad/ > JSF Partial State Saving is not enabled > --- > > Key: TRINIDAD-2561 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2561 > Project: MyFaces Trinidad > Issue Type: Improvement > Components: Components >Affects Versions: 2.1.1-core >Reporter: Deepan > > JSF Partial State Saving needs to be enabled in Trinidad. Whenever the PSS is > turned on via web xml, Trinidad is printing a log stating that "Partial State > Saving won't work with Trinidad and has to be turned off". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4140) NullPointerException instead of InvalidViewIdException
[
https://issues.apache.org/jira/browse/MYFACES-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159837#comment-16159837
]
Dennis Kieselhorst commented on MYFACES-4140:
-
Well I'm unsure how to fix it. Simply adding a null check and throw
InvalidViewIdException will probably cause side effects in other cases. The
code already contains a comment from [~lu4242] "Temporally reverted by TCK
issues."
> NullPointerException instead of InvalidViewIdException
> --
>
> Key: MYFACES-4140
> URL: https://issues.apache.org/jira/browse/MYFACES-4140
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3.0-beta
>Reporter: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.3.0
>
>
> In case of an invalid viewId an NPE is thrown instead of
> InvalidViewIdException. This is reproducible using tobago-example-demo
> (NavigationTree /content/root-dummy.xhtml).
> {noformat}
> Caused by: java.lang.NullPointerException
> at
> org.apache.myfaces.application.ViewHandlerImpl.getViewParameterList(ViewHandlerImpl.java:459)
> at
> org.apache.myfaces.application.ViewHandlerImpl.getBookmarkableURL(ViewHandlerImpl.java:141)
> at
> javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
> at
> javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
> at
> org.apache.myfaces.tobago.internal.util.RenderUtils.generateUrl(RenderUtils.java:229)
> at
> org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.encodeBegin(CommandRendererBase.java:86)
> at
> javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at
> org.apache.myfaces.tobago.internal.renderkit.renderer.TreeRenderer.encodeEnd(TreeRenderer.java:130)
> at
> javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:675)
> at javax.faces.component.UIData.encodeEnd(UIData.java:1811)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:555)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> at javax.faces.render.Renderer.encodeChildren(Renderer.java:95)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons
[ https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152667#comment-16152667 ] Dennis Kieselhorst commented on MYFACES-4135: - I think we should keep it. The beanutils library is small and mature. > Use Java8 instead of commons > > > Key: MYFACES-4135 > URL: https://issues.apache.org/jira/browse/MYFACES-4135 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Fix For: 2.3.0 > > > e.g. Base64 - will check other used parts > Collections: > * EmptyIterator (/) > * LRUMap (/) > * CollectionUtils.filter (/) > * Predicate (/) > Coded: (/) > * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/) > * DecoderException (/) > * Base64 (/) > Digester: > * Digester (x) > BeanUtils: > * BeanUtils (x) > * PropertyUtils (x) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons
[ https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144239#comment-16144239 ] Dennis Kieselhorst commented on MYFACES-4135: - Ok, just fixed the log message and simplified the code. > Use Java8 instead of commons > > > Key: MYFACES-4135 > URL: https://issues.apache.org/jira/browse/MYFACES-4135 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Fix For: 2.3.0 > > > e.g. Base64 - will check other used parts > Collections: > * EmptyIterator (/) > * LRUMap (/) > * CollectionUtils.filter (/) > * Predicate (/) > Coded: (/) > * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/) > * DecoderException (/) > * Base64 (/) > Digester: > * Digester (x) > BeanUtils: > * BeanUtils (x) > * PropertyUtils (x) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons
[ https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142663#comment-16142663 ] Dennis Kieselhorst commented on MYFACES-4135: - I would use java.util.function.Predicate. > Use Java8 instead of commons > > > Key: MYFACES-4135 > URL: https://issues.apache.org/jira/browse/MYFACES-4135 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Fix For: 2.3.0 > > > e.g. Base64 - will check other used parts > Collections: > * EmptyIterator (/) > * LRUMap (/) > * CollectionUtils.filter > * Predicate > Coded: (/) > * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/) > * DecoderException (/) > * Base64 (/) > Digester: > * Digester (x) > BeanUtils: > * BeanUtils (x) > * PropertyUtils (x) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons
[ https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141320#comment-16141320 ] Dennis Kieselhorst commented on MYFACES-4135: - How to migrate the org.apache.myfaces.EL_RESOLVER_PREDICATE stuff? Change it to java.util.function.Predicate and add a migration warning? > Use Java8 instead of commons > > > Key: MYFACES-4135 > URL: https://issues.apache.org/jira/browse/MYFACES-4135 > Project: MyFaces Core > Issue Type: Bug >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Fix For: 2.3.0 > > > e.g. Base64 - will check other used parts > Collections: > * EmptyIterator (/) > * LRUMap > * CollectionUtils.filter > * Predicate > Coded: (/) > * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/) > * DecoderException (/) > * Base64 (/) > Digester: > * Digester (x) > BeanUtils: > * BeanUtils (x) > * PropertyUtils (x) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4135) Use Java8 instead of commons
[ https://issues.apache.org/jira/browse/MYFACES-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141317#comment-16141317 ] Dennis Kieselhorst commented on MYFACES-4135: - [~tandraschko] in the comment you mentioned accessOrder=true but actually it wasn't set. I changed it to keep the LRUMap behavior and added a test. > Use Java8 instead of commons > > > Key: MYFACES-4135 > URL: https://issues.apache.org/jira/browse/MYFACES-4135 > Project: MyFaces Core > Issue Type: Bug >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Minor > Fix For: 2.3.0 > > > e.g. Base64 - will check other used parts > Collections: > * EmptyIterator (/) > * LRUMap > * CollectionUtils.filter > * Predicate > Coded: (/) > * Hex (Could be replaced by javax/xml/bind/DatatypeConverter) (/) > * DecoderException (/) > * Base64 (/) > Digester: > * Digester (x) > BeanUtils: > * BeanUtils (x) > * PropertyUtils (x) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MYFACES-4140) NullPointerException instead of InvalidViewIdException
Dennis Kieselhorst created MYFACES-4140:
---
Summary: NullPointerException instead of InvalidViewIdException
Key: MYFACES-4140
URL: https://issues.apache.org/jira/browse/MYFACES-4140
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 2.3.0-beta
Reporter: Dennis Kieselhorst
Priority: Minor
In case of an invalid viewId an NPE is thrown instead of
InvalidViewIdException. This is reproducible using tobago-example-demo
(NavigationTree /content/root-dummy.xhtml).
{noformat}
Caused by: java.lang.NullPointerException
at
org.apache.myfaces.application.ViewHandlerImpl.getViewParameterList(ViewHandlerImpl.java:459)
at
org.apache.myfaces.application.ViewHandlerImpl.getBookmarkableURL(ViewHandlerImpl.java:141)
at
javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
at
javax.faces.application.ViewHandlerWrapper.getBookmarkableURL(ViewHandlerWrapper.java:134)
at
org.apache.myfaces.tobago.internal.util.RenderUtils.generateUrl(RenderUtils.java:229)
at
org.apache.myfaces.tobago.internal.renderkit.renderer.CommandRendererBase.encodeBegin(CommandRendererBase.java:86)
at
javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597)
at
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527)
at
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
at
org.apache.myfaces.tobago.internal.renderkit.renderer.TreeRenderer.encodeEnd(TreeRenderer.java:130)
at
javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:675)
at javax.faces.component.UIData.encodeEnd(UIData.java:1811)
at
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:555)
at
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
at javax.faces.render.Renderer.encodeChildren(Renderer.java:95)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MYFACES-4134) Update to commons-collections 4
[ https://issues.apache.org/jira/browse/MYFACES-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138407#comment-16138407 ] Dennis Kieselhorst commented on MYFACES-4134: - Ok great I'll close this one as duplicate. > Update to commons-collections 4 > --- > > Key: MYFACES-4134 > URL: https://issues.apache.org/jira/browse/MYFACES-4134 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.3.0-beta >Reporter: Dennis Kieselhorst >Priority: Minor > Fix For: 2.3.0 > > > Should we update to commons-collection 4 for 2.3.0? If nobody objects, I can > do the changes... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TRINIDAD-2559) UNZIP_STATE_FAILED Exception
[ https://issues.apache.org/jira/browse/TRINIDAD-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135518#comment-16135518 ] Dennis Kieselhorst commented on TRINIDAD-2559: -- Please tell us more about the page structure, I assume it has many components. Ideally you provide a testcase and attach it to this issue. For the meantime you can set COMPRESS_VIEW_STATE to false to avoid the issue. > UNZIP_STATE_FAILED Exception > > > Key: TRINIDAD-2559 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2559 > Project: MyFaces Trinidad > Issue Type: Bug >Affects Versions: 2.1.1-core > Environment: MyFaces 2.1.17 > OS: Any > WebSphere 8.5.5 > Java 7 >Reporter: Deepan >Priority: Blocker > Attachments: UNZIP_Exception.txt > > > One particular page in our application is sporadically not responding and we > are getting "*UNZIP_STATE_FAILED*" exception. I've attached the exception > trace. > Please help us to resolve this issue. > *+Web.xml details:+* > * STATE_SAVING_METHOD - Client > * CLIENT_STATE_METHOD - Token > * CACHE_VIEW_ROOT - True > * CLIENT_STATE_MAX_TOKENS - 100 > * COMPRESS_VIEW_STATE - True -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4134) Update to commons-collections 4
[ https://issues.apache.org/jira/browse/MYFACES-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130193#comment-16130193 ] Dennis Kieselhorst commented on MYFACES-4134: - Only four classes are in use: * org.apache.commons.collections.map.LRUMap * org.apache.commons.collections.Predicate * org.apache.commons.collections.CollectionUtils.filter * org.apache.commons.collections.iterators.EmptyIterator I'm not aware of a LRUMap in Java 8 but this could be implemented based on LinkedHashMap. What I just noticed: If org.apache.myfaces.EL_RESOLVER_PREDICATE is in use, users will have to migrate their Predicates to commons-collections4 too. > Update to commons-collections 4 > --- > > Key: MYFACES-4134 > URL: https://issues.apache.org/jira/browse/MYFACES-4134 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.3.0-beta >Reporter: Dennis Kieselhorst >Priority: Minor > Fix For: 2.3.0 > > > Should we update to commons-collection 4 for 2.3.0? If nobody objects, I can > do the changes... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MYFACES-4134) Update to commons-collections 4
Dennis Kieselhorst created MYFACES-4134: --- Summary: Update to commons-collections 4 Key: MYFACES-4134 URL: https://issues.apache.org/jira/browse/MYFACES-4134 Project: MyFaces Core Issue Type: Improvement Affects Versions: 2.3.0-beta Reporter: Dennis Kieselhorst Priority: Minor Should we update to commons-collection 4 for 2.3.0? If nobody objects, I can do the changes... -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (TOBAGO-1781) Update to commons-lang 3
[ https://issues.apache.org/jira/browse/TOBAGO-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1781. Resolution: Fixed > Update to commons-lang 3 > > > Key: TOBAGO-1781 > URL: https://issues.apache.org/jira/browse/TOBAGO-1781 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 3.0.5 >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst >Priority: Minor > Fix For: 4.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TOBAGO-1781) Update to commons-lang 3
Dennis Kieselhorst created TOBAGO-1781: -- Summary: Update to commons-lang 3 Key: TOBAGO-1781 URL: https://issues.apache.org/jira/browse/TOBAGO-1781 Project: MyFaces Tobago Issue Type: Improvement Components: Core Affects Versions: 3.0.5 Reporter: Dennis Kieselhorst Assignee: Dennis Kieselhorst Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (TOBAGO-1780) Update to commons-collections 4
[ https://issues.apache.org/jira/browse/TOBAGO-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1780. Resolution: Fixed > Update to commons-collections 4 > --- > > Key: TOBAGO-1780 > URL: https://issues.apache.org/jira/browse/TOBAGO-1780 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 3.0.5 >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst >Priority: Minor > Fix For: 4.0.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TOBAGO-1780) Update to commons-collections 4
Dennis Kieselhorst created TOBAGO-1780: -- Summary: Update to commons-collections 4 Key: TOBAGO-1780 URL: https://issues.apache.org/jira/browse/TOBAGO-1780 Project: MyFaces Tobago Issue Type: Improvement Components: Core Affects Versions: 3.0.5 Reporter: Dennis Kieselhorst Assignee: Dennis Kieselhorst Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-3525) javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL value affects display behavior for required fields
[
https://issues.apache.org/jira/browse/MYFACES-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100499#comment-16100499
]
Dennis Kieselhorst commented on MYFACES-3525:
-
Looks like all related issues have been closed:
https://github.com/javaee/javaserverfaces-spec/issues?utf8=%E2%9C%93&q=INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL
> javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL value affects
> display behavior for required fields
> --
>
> Key: MYFACES-3525
> URL: https://issues.apache.org/jira/browse/MYFACES-3525
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.12
>Reporter: VS
>Assignee: Bill Lucy
> Fix For: 2.0.25-SNAPSHOT, 2.1.19-SNAPSHOT, 2.2.13-SNAPSHOT
>
> Attachments: MYFACES-3525.patch
>
>
> Inconsistent behavior for required field validation when
> javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL is set to true
> versus false
> To observe behavior:
> 1. Set javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL to true in
> web.xml
> 2. Create JSF Page:
>
>
> required="true"
> requiredMessage="You must enter a first name"/>
>
>
> 3. Create Managed Bean:
> @ManagedBean
> public class Page1Controller
> {
> public String getFirstName()
> { return "Default Value"; }
> public void setFirstName(String value)
> { // no-op (for example purposes only) }
> 4. Load JSF page, blank out value in the input field and click Submit
> 5. Error message is displayed, however the value in the input field (which
> you formerly blanked out) is now reset back to its original value.
> 6. Change the javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL
> setting to false and re-run the test.
> 7. Note that the value in the input field remains blank.
> Behavior is inconsistent and should be fixed
> (javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL setting of true
> or false should not result in inconsistent behavior with required fields)
>
> To state in a different way:
> When INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL is TRUE, and you blank
> out a value for a required field that had previously been populated by the
> model, submit the form, you will see the OLD data from the model in the
> field. However, if that field had had a format validation applied to it and
> the user submits the form with a format validation error, the OLD data is NOT
> shown in the field (instead, the submitted/invalid data is shown). The same
> should happen for required field validation errors. The field should show the
> "blank" data and not the original model data. In order to get the correct
> behavior, the developer has to currently set
> INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL to false. But they should not
> have to do this... whether INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL is
> true or false, the behavior of showing the blank field that the user
> submitted should be the same.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (TOBAGO-1753) Update Fileupload dependency
[ https://issues.apache.org/jira/browse/TOBAGO-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1753. Resolution: Fixed > Update Fileupload dependency > > > Key: TOBAGO-1753 > URL: https://issues.apache.org/jira/browse/TOBAGO-1753 > Project: MyFaces Tobago > Issue Type: Task >Affects Versions: 2.0.10 >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst > Fix For: 2.0.11 > > > A new version of commons fileupload with a security fix was released (see > FILEUPLOAD-279). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TOBAGO-1753) Update Fileupload dependency
Dennis Kieselhorst created TOBAGO-1753: -- Summary: Update Fileupload dependency Key: TOBAGO-1753 URL: https://issues.apache.org/jira/browse/TOBAGO-1753 Project: MyFaces Tobago Issue Type: Task Affects Versions: 2.0.10 Reporter: Dennis Kieselhorst Assignee: Dennis Kieselhorst A new version of commons fileupload with a security fix was released (see FILEUPLOAD-279). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4121) Fix javadoc for 2.3 branch and update maven-javadoc-plugin
[ https://issues.apache.org/jira/browse/MYFACES-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038384#comment-16038384 ] Dennis Kieselhorst commented on MYFACES-4121: - In my view it would be also ok to configure it to be less strict. > Fix javadoc for 2.3 branch and update maven-javadoc-plugin > --- > > Key: MYFACES-4121 > URL: https://issues.apache.org/jira/browse/MYFACES-4121 > Project: MyFaces Core > Issue Type: Task > Components: JSR-372 >Reporter: Leonardo Uribe >Assignee: Leonardo Uribe >Priority: Blocker > > MyFaces 2.3 branch requires Java 8 and an updated maven-javadoc-plugin. The > problem is the new versions are more strict to generate the javadoc, so we > need to check the javadoc and fix its generation. > This is a blocker issue for beta release, since we cannot generate all > artifacts without fix this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (TRINIDAD-2554) Avoid duplicated trinidad-assembly artifacts
Dennis Kieselhorst created TRINIDAD-2554: Summary: Avoid duplicated trinidad-assembly artifacts Key: TRINIDAD-2554 URL: https://issues.apache.org/jira/browse/TRINIDAD-2554 Project: MyFaces Trinidad Issue Type: Bug Components: Build Affects Versions: 2.2.0-core Reporter: Dennis Kieselhorst Priority: Minor trinidad-assembly contains duplicated artifacts (with and without -dist). No need to upload them twice. According to download page -dist is expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TRINIDAD-2434) Usage of Class.getMethod in TreeRenderer.retrieveGetNodeTypeMethod is a critical performance issue
[
https://issues.apache.org/jira/browse/TRINIDAD-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961725#comment-15961725
]
Dennis Kieselhorst commented on TRINIDAD-2434:
--
Patch applied, thanks. Next time please attach svn diff that makes it easier to
apply.
> Usage of Class.getMethod in TreeRenderer.retrieveGetNodeTypeMethod is a
> critical performance issue
> --
>
> Key: TRINIDAD-2434
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2434
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components, Facelets
>Affects Versions: 2.0.1-core
> Environment: WebSphere, IBM JRE.
>Reporter: Volker Malzahn
>Assignee: Dennis Kieselhorst
>Priority: Critical
> Fix For: 2.1.3-core
>
>
> We have a webapp with SWF 2.3.0, JSF 2.1 and Trinidad 2.0.1 and have done
> performance tests in an environment with WebSphere and IBM JRE. When we
> reached a number of concurrent users of around 80 we get hot spots in calls
> of Class.getMethod. The stack trace contains following Trinidad method which
> perform this call often:
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.TreeRenderer.getNodeType(UIXHierarchy)
> Inspecting the source of this method I detected that it calls
> rowClass.getMethod("getNodeType") every time it's called - without caching
> the method handles reached in previous calls.
> After doing a quick fix for this by caching the method handles we have solved
> this hot spot:
> private final Map, Method> getNodeTypeMethodMap = new
> HashMap, Method>();
> private Method retrieveGetNodeTypeMethod(Class rowClass) {
> try {
> synchronized (getNodeTypeMethodMap) {
> if (getNodeTypeMethodMap.containsKey(rowClass)) {
> return getNodeTypeMethodMap.get(rowClass);
> }
> Method getNodeTypeMethod = rowClass.getMethod("getNodeType");
> getNodeTypeMethodMap.put(rowClass, getNodeTypeMethod);
> return getNodeTypeMethod;
> }
> } catch (Exception e) { return null; }
> }
> Could you please fix this for the next Trinidad release?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (TRINIDAD-2434) Usage of Class.getMethod in TreeRenderer.retrieveGetNodeTypeMethod is a critical performance issue
[
https://issues.apache.org/jira/browse/TRINIDAD-2434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved TRINIDAD-2434.
--
Resolution: Fixed
> Usage of Class.getMethod in TreeRenderer.retrieveGetNodeTypeMethod is a
> critical performance issue
> --
>
> Key: TRINIDAD-2434
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2434
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components, Facelets
>Affects Versions: 2.0.1-core
> Environment: WebSphere, IBM JRE.
>Reporter: Volker Malzahn
>Assignee: Dennis Kieselhorst
>Priority: Critical
> Fix For: 2.1.3-core
>
>
> We have a webapp with SWF 2.3.0, JSF 2.1 and Trinidad 2.0.1 and have done
> performance tests in an environment with WebSphere and IBM JRE. When we
> reached a number of concurrent users of around 80 we get hot spots in calls
> of Class.getMethod. The stack trace contains following Trinidad method which
> perform this call often:
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.TreeRenderer.getNodeType(UIXHierarchy)
> Inspecting the source of this method I detected that it calls
> rowClass.getMethod("getNodeType") every time it's called - without caching
> the method handles reached in previous calls.
> After doing a quick fix for this by caching the method handles we have solved
> this hot spot:
> private final Map, Method> getNodeTypeMethodMap = new
> HashMap, Method>();
> private Method retrieveGetNodeTypeMethod(Class rowClass) {
> try {
> synchronized (getNodeTypeMethodMap) {
> if (getNodeTypeMethodMap.containsKey(rowClass)) {
> return getNodeTypeMethodMap.get(rowClass);
> }
> Method getNodeTypeMethod = rowClass.getMethod("getNodeType");
> getNodeTypeMethodMap.put(rowClass, getNodeTypeMethod);
> return getNodeTypeMethod;
> }
> } catch (Exception e) { return null; }
> }
> Could you please fix this for the next Trinidad release?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (TRINIDAD-2339) Trinidad on Jboss AS 6. Cannot deploy application because of syntax error in tld
[ https://issues.apache.org/jira/browse/TRINIDAD-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TRINIDAD-2339. -- Resolution: Fixed > Trinidad on Jboss AS 6. Cannot deploy application because of syntax error in > tld > > > Key: TRINIDAD-2339 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2339 > Project: MyFaces Trinidad > Issue Type: Bug >Affects Versions: 2.0.1-core > Environment: Jboss Application Server 6. With Myface 2.0 >Reporter: Shoaib Ali Khan >Assignee: Dennis Kieselhorst >Priority: Critical > Fix For: 2.1.3-core > > > When deploy application on Jboss 6 I get a XML parsing error for tr.tld. on > line 113. The syntax error is on tag ' filedownloadactionlistener' . I have > moved the description xml tag immediately after . Then it worked please > refer to following change for solution to this problem. > > <--Moved this description tag. > The fileDownloadActionListener tag provides a declarative syntax for > downloading files to a user from a command component. > > fileDownloadActionListener > > org.apache.myfaces.trinidadinternal.taglib.listener.FileDownloadActionListenerTag > empty > > > > the content or mime type of the file - e.g., text/html or > application/pdf > > contentType > > > .. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (TRINIDAD-2261) Error serializing the attribute PageState in a clustered enviroment
[ https://issues.apache.org/jira/browse/TRINIDAD-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst updated TRINIDAD-2261: - Status: Open (was: Patch Available) > Error serializing the attribute PageState in a clustered enviroment > --- > > Key: TRINIDAD-2261 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2261 > Project: MyFaces Trinidad > Issue Type: Bug >Affects Versions: 2.0.0-core > Environment: Tomcat 7 >Reporter: Arsene Costin >Priority: Critical > Attachments: SerialozationProblem.patch > > > The PageState it is Private class and can not be deserialized in a Clustered > Enviroment. We have also attached a patch that contains the modification.The > patch is created from the trunk of the trinidad repository. It will help us a > lot if you will put this in your next release. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TRINIDAD-2527) Row selection retains with tr:table
[
https://issues.apache.org/jira/browse/TRINIDAD-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960665#comment-15960665
]
Dennis Kieselhorst commented on TRINIDAD-2527:
--
[~bommel] and me decided that this is not a blocker.
> Row selection retains with tr:table
> ---
>
> Key: TRINIDAD-2527
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2527
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Archetype
>Affects Versions: 2.1.1-core
> Environment: Windows 7, Java 7
>Reporter: Deepan Chakkaravarthy
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> A page contains with rowSelection as "Single/Multiple" and the
> beans are session scoped.
> - Select a row using the radio or checkbox
> - Navigate to some other pages
> - Again come back to page 1. Now, previously selected radio or checkbox are
> selected.
> {code:title=Sample code|borderStyle=solid}
> rowSelection="single"
> value="#{myBean.myList}"
> var="groups" varStatus="rowId" rowBandingInterval="1"
> verticalGridVisible="true"
> selectionListener="#{myBackingBean.myRowSelectListener}">
> ...
> ...
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (TRINIDAD-2534) JSF Page Navigation is not working while partialSubmit="true" on Commandbutton or commandlink.
[ https://issues.apache.org/jira/browse/TRINIDAD-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TRINIDAD-2534. -- Resolution: Duplicate > JSF Page Navigation is not working while partialSubmit="true" on > Commandbutton or commandlink. > -- > > Key: TRINIDAD-2534 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2534 > Project: MyFaces Trinidad > Issue Type: Bug >Affects Versions: 2.1.0-core > Environment: JSF enviornment >Reporter: jyotirmoy >Priority: Blocker > Fix For: 2.1.3-core > > > JSF Page Navigation is not working while partialSubmit="true" on > Commandbutton.I am using Trinidad 2.1 and myfaces 2.2.6.Same code is working > with Trinidad 2.1 and myfaces 2.1.10. I tried with myfaces 2.2.7 issue is > still replicable. In case of partialSubmit="false" i am able to navigate -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (TRINIDAD-2519) myfaces-api-2.2.6.jar,myfaces-impl-2.2.6.jar,trinidad-api-2.1.0.jar,trinidad-impl-2.1.0.jar
[ https://issues.apache.org/jira/browse/TRINIDAD-2519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TRINIDAD-2519. -- Resolution: Duplicate > myfaces-api-2.2.6.jar,myfaces-impl-2.2.6.jar,trinidad-api-2.1.0.jar,trinidad-impl-2.1.0.jar > --- > > Key: TRINIDAD-2519 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2519 > Project: MyFaces Trinidad > Issue Type: Bug >Affects Versions: 2.1.0-core > Environment: myfaces-api-2.2.6.jar, > myfaces-impl-2.2.6.jar, > trinidad-api-2.1.0.jar, > trinidad-impl-2.1.0.jar > Appserver:Websphere 8.5.5.1 > IDE:RAD > JDK:Appserver provided JDK1.7_64 >Reporter: Swathi > > On upgrading the jars to the trinidad 2.1.0 we are getting the Following > exception on server startup. > We are using the myfaces and trinidad jars in the Application/WEB-INF/lib. > 5 8:10:59:823 EST] 00b1 annotations E CWWAM0003E: An exception > occurred while validating an annotation: > com.ibm.wsspi.amm.validate.ValidationException: SRVE8016E: The > @MultipartConfig annotation cannot be applied to the class, > javax.faces.webapp.FacesServlet, because it extends the wrong super class > com.ibm.wsspi.amm.validate.ValidationException: SRVE8016E: The > @MultipartConfig annotation cannot be applied to the class, > javax.faces.webapp.FacesServlet, because it extends the wrong super class > at > com.ibm.ws.webcontainer.annotation.validator.MultipartConfigValidator.validateClassAnnotation(MultipartConfigValidator.java:44) > at > com.ibm.ws.webcontainer.annotation.validator.MultipartConfigValidator.validateClassAnnotation(MultipartConfigValidator.java:39) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (TOBAGO-1616) Rounded corners for tc:progress
[ https://issues.apache.org/jira/browse/TOBAGO-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1616. Resolution: Fixed Patch applied, thank you. > Rounded corners for tc:progress > --- > > Key: TOBAGO-1616 > URL: https://issues.apache.org/jira/browse/TOBAGO-1616 > Project: MyFaces Tobago > Issue Type: Bug > Components: Themes >Affects Versions: 3.0.0-alpha-6 >Reporter: Henning Noeth >Assignee: Dennis Kieselhorst >Priority: Minor > Fix For: 3.1.0 > > Attachments: TOBAGO_1616.patch > > > The progress bar have rounded corners on the left. But on the right site the > corners are only rounded if the value attribute contain the number "100". > Rounded corners should be always visible, also for value=20>. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TOBAGO-1709) Duplicated IDs when using 'labelLayout=segmentLeft' or 'labelLayout=segmentRight'
[
https://issues.apache.org/jira/browse/TOBAGO-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931872#comment-15931872
]
Dennis Kieselhorst commented on TOBAGO-1709:
There is already a switch case statement for labelLayout. Shouldn't we simplify
the code by combining them?
> Duplicated IDs when using 'labelLayout=segmentLeft' or
> 'labelLayout=segmentRight'
> -
>
> Key: TOBAGO-1709
> URL: https://issues.apache.org/jira/browse/TOBAGO-1709
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Attachments:
> TOBAGO_1709_Duplicated_IDs_when_using__labelLayout_segmentLeft__or__labelLayout_segmentRig.patch
>
>
> The following code produce duplicated IDs on the rendered DIV. It doesn't
> matter if an ID is set.
> {code:xml}
>
>
> {code}
> The rendered result for 'inputOne' is:
> {code:xml}
>
>
> Input
>
>
>
>
>id="page:mainForm:inputOne::field" class="tobago-in form-control">
>
>
> ...
> {code}
> The result for 'inputTwo' is very similar.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TOBAGO-1708) The Dropdownmenu of a radiobutton group in an input group is not always on top
[
https://issues.apache.org/jira/browse/TOBAGO-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931865#comment-15931865
]
Dennis Kieselhorst commented on TOBAGO-1708:
Looks like the patch has already been applied. Can we resolve this?
> The Dropdownmenu of a radiobutton group in an input group is not always on top
> --
>
> Key: TOBAGO-1708
> URL: https://issues.apache.org/jira/browse/TOBAGO-1708
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Themes
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
>Priority: Minor
> Fix For: 3.1.0
>
> Attachments: screenshot.png,
> TOBAGO_1708_The_Dropdownmenu_of_a_radiobutton_group_in_an_input_group_is_not_always_on_top.patch
>
>
> {code:java}
>
>
>
>
>
>
>
>
>
>
>
>
>
> {code}
> The first input field contain a facet with a dropdown menu with a radiobutton
> group inside. If pressing this button the dropdown menu is behind the button
> from the second input group.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (TOBAGO-1703) No ID for tc:out with labelLayout=skip
[
https://issues.apache.org/jira/browse/TOBAGO-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst updated TOBAGO-1703:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch applied with some additional cleanups.
> No ID for tc:out with labelLayout=skip
> --
>
> Key: TOBAGO-1703
> URL: https://issues.apache.org/jira/browse/TOBAGO-1703
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Fix For: 3.1.0
>
> Attachments: 1703___1707.patch,
> TOBAGO_1703_No_ID_for_tc_out_with_labelLayout_skip.patch
>
>
> ID is not rendered for: {code:xml}{code}
> The ID is set to an outer DIV. "labelLayout='skip'" remove that outer DIV and
> thus also the ID.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TOBAGO-1703) No ID for tc:out with labelLayout=skip
[
https://issues.apache.org/jira/browse/TOBAGO-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893883#comment-15893883
]
Dennis Kieselhorst commented on TOBAGO-1703:
Please check if AbstractUISelectManyShuttle also needs to be adapted.
> No ID for tc:out with labelLayout=skip
> --
>
> Key: TOBAGO-1703
> URL: https://issues.apache.org/jira/browse/TOBAGO-1703
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Fix For: 3.1.0
>
> Attachments: 1703___1707.patch,
> TOBAGO_1703_No_ID_for_tc_out_with_labelLayout_skip.patch
>
>
> ID is not rendered for: {code:xml}{code}
> The ID is set to an outer DIV. "labelLayout='skip'" remove that outer DIV and
> thus also the ID.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (TOBAGO-1703) No ID for tc:out with labelLayout=skip
[
https://issues.apache.org/jira/browse/TOBAGO-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884761#comment-15884761
]
Dennis Kieselhorst edited comment on TOBAGO-1703 at 2/27/17 10:18 AM:
--
We should fix this for all classes that implement SupportsLabelLayout,
shouldn't we?
was (Author: deki):
Can you please elaborate a bit more on that? Why is it not always rendered?
> No ID for tc:out with labelLayout=skip
> --
>
> Key: TOBAGO-1703
> URL: https://issues.apache.org/jira/browse/TOBAGO-1703
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Fix For: 3.1.0
>
> Attachments: TOBAGO_1703_No_ID_for_tc_out_with_labelLayout_skip.patch
>
>
> ID is not rendered for: {code:xml}{code}
> The ID is set to an outer DIV. "labelLayout='skip'" remove that outer DIV and
> thus also the ID.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TOBAGO-1700) Re-Add the version of Tobago to the resources URL to avoid caching when updating Tobago
[ https://issues.apache.org/jira/browse/TOBAGO-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884771#comment-15884771 ] Dennis Kieselhorst commented on TOBAGO-1700: Please note that the integration tests are still failing: https://builds.apache.org/view/M-R/view/MyFaces/job/Tobago Trunk integration-test/ > Re-Add the version of Tobago to the resources URL to avoid caching when > updating Tobago > --- > > Key: TOBAGO-1700 > URL: https://issues.apache.org/jira/browse/TOBAGO-1700 > Project: MyFaces Tobago > Issue Type: Bug > Components: Themes >Affects Versions: 3.0.3 >Reporter: Henning Noeth >Assignee: Udo Schnurpfeil > Fix For: 3.1.0 > > > In Tobago 2.0 the version of Tobago was put in the URL of the resources. This > was managed by the ResourceManager, which is not part of Tobago 3. > So, we need a replacement to cover this feature. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TOBAGO-1691) Markup large/small for
[
https://issues.apache.org/jira/browse/TOBAGO-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884762#comment-15884762
]
Dennis Kieselhorst commented on TOBAGO-1691:
Is there something missing or why is this issue not resolved yet?
> Markup large/small for
> -
>
> Key: TOBAGO-1691
> URL: https://issues.apache.org/jira/browse/TOBAGO-1691
> Project: MyFaces Tobago
> Issue Type: New Feature
> Components: Core
>Affects Versions: 3.0.2
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Fix For: 3.1.0
>
> Attachments: TOBAGO_1691.patch
>
>
> There should be two new markups for ('small' and 'large') which
> influence the width of the popup.
> {code:xml}{code}
> {code:xml}{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TOBAGO-1703) No ID for tc:out with labelLayout=skip
[
https://issues.apache.org/jira/browse/TOBAGO-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884761#comment-15884761
]
Dennis Kieselhorst commented on TOBAGO-1703:
Can you please elaborate a bit more on that? Why is it not always rendered?
> No ID for tc:out with labelLayout=skip
> --
>
> Key: TOBAGO-1703
> URL: https://issues.apache.org/jira/browse/TOBAGO-1703
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.0.3
>Reporter: Henning Noeth
>Assignee: Henning Noeth
> Attachments: TOBAGO_1703_No_ID_for_tc_out_with_labelLayout_skip.patch
>
>
> ID is not rendered for: {code:xml}{code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (TOBAGO-1705) tc:sheet is empty after filtering results
[ https://issues.apache.org/jira/browse/TOBAGO-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1705. Resolution: Fixed Patch applied, thanks! > tc:sheet is empty after filtering results > - > > Key: TOBAGO-1705 > URL: https://issues.apache.org/jira/browse/TOBAGO-1705 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core >Affects Versions: 3.0.3 >Reporter: Henning Noeth >Assignee: Dennis Kieselhorst > Fix For: 3.1.0 > > Attachments: > TOBAGO_1705_tc_sheet_is_empty_after_filtering_results.patch > > > Steps to reproduce: > 1. The sheet has enough rows for 5 pages. > 2. Select page 4. > 3. Filter results (so only one page is available) > 4. No results are shown (probably because page 4 is still selected) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (TOBAGO-1689) change event is not executed for
[
https://issues.apache.org/jira/browse/TOBAGO-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst updated TOBAGO-1689:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> change event is not executed for
> -
>
> Key: TOBAGO-1689
> URL: https://issues.apache.org/jira/browse/TOBAGO-1689
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Themes
>Affects Versions: 3.0.2
>Reporter: Henning Noeth
>Assignee: Dennis Kieselhorst
> Fix For: 3.1.0
>
> Attachments: tobago-1689.patch, TOBAGO_1689.patch
>
>
> A change event is not executed for if a suggestion is selected.
> {code:xml}
>
>
>
>
>
>
> {code}
> Same if is replaced by .
> The change event is only executed if no suggestion is available for the
> entered string or if the suggested string is completely written by the user.
> Example:
> knows the values "Sun, Moon, Stars".
> If the user enter 'Su' and select 'Sun' from the suggestion list: no change
> event is executed.
> If the user enter 'Su' and press TAB to complete the string 'Sun': no change
> event is executed.
> If the user enter 'Sun': change event is executed.
> If the user enter 'Jupiter': change event is executed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (TOBAGO-1689) change event is not executed for
[
https://issues.apache.org/jira/browse/TOBAGO-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst updated TOBAGO-1689:
---
Status: Patch Available (was: Reopened)
> change event is not executed for
> -
>
> Key: TOBAGO-1689
> URL: https://issues.apache.org/jira/browse/TOBAGO-1689
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Themes
>Affects Versions: 3.0.2
>Reporter: Henning Noeth
>Assignee: Dennis Kieselhorst
> Fix For: 3.1.0
>
> Attachments: tobago-1689.patch, TOBAGO_1689.patch
>
>
> A change event is not executed for if a suggestion is selected.
> {code:xml}
>
>
>
>
>
>
> {code}
> Same if is replaced by .
> The change event is only executed if no suggestion is available for the
> entered string or if the suggested string is completely written by the user.
> Example:
> knows the values "Sun, Moon, Stars".
> If the user enter 'Su' and select 'Sun' from the suggestion list: no change
> event is executed.
> If the user enter 'Su' and press TAB to complete the string 'Sun': no change
> event is executed.
> If the user enter 'Sun': change event is executed.
> If the user enter 'Jupiter': change event is executed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (TOBAGO-1689) change event is not executed for
[
https://issues.apache.org/jira/browse/TOBAGO-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved TOBAGO-1689.
Resolution: Fixed
Patch applied. Thanks to [~sub_ft1] and [~hnoeth] for providing this patch.
> change event is not executed for
> -
>
> Key: TOBAGO-1689
> URL: https://issues.apache.org/jira/browse/TOBAGO-1689
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Themes
>Affects Versions: 3.0.2
>Reporter: Henning Noeth
>Assignee: Dennis Kieselhorst
> Fix For: 3.1.0
>
> Attachments: tobago-1689.patch, tobago-1689.patch
>
>
> A change event is not executed for if a suggestion is selected.
> {code:xml}
>
>
>
>
>
>
> {code}
> Same if is replaced by .
> The change event is only executed if no suggestion is available for the
> entered string or if the suggested string is completely written by the user.
> Example:
> knows the values "Sun, Moon, Stars".
> If the user enter 'Su' and select 'Sun' from the suggestion list: no change
> event is executed.
> If the user enter 'Su' and press TAB to complete the string 'Sun': no change
> event is executed.
> If the user enter 'Sun': change event is executed.
> If the user enter 'Jupiter': change event is executed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (TOBAGO-1689) change event is not executed for
[
https://issues.apache.org/jira/browse/TOBAGO-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst updated TOBAGO-1689:
---
Status: Patch Available (was: Open)
> change event is not executed for
> -
>
> Key: TOBAGO-1689
> URL: https://issues.apache.org/jira/browse/TOBAGO-1689
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Themes
>Affects Versions: 3.0.2
>Reporter: Henning Noeth
>Assignee: Udo Schnurpfeil
> Attachments: tobago-1689.patch
>
>
> A change event is not executed for if a suggestion is selected.
> {code:xml}
>
>
>
>
>
>
> {code}
> Same if is replaced by .
> The change event is only executed if no suggestion is available for the
> entered string or if the suggested string is completely written by the user.
> Example:
> knows the values "Sun, Moon, Stars".
> If the user enter 'Su' and select 'Sun' from the suggestion list: no change
> event is executed.
> If the user enter 'Su' and press TAB to complete the string 'Sun': no change
> event is executed.
> If the user enter 'Sun': change event is executed.
> If the user enter 'Jupiter': change event is executed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (TOBAGO-1674) Allow programmatic configuration in addition to tobago-config.xml
[
https://issues.apache.org/jira/browse/TOBAGO-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved TOBAGO-1674.
Resolution: Fixed
It's now possible to pass a TobagoConfigFragment to the TobagoConfigBuilder
directly:
{code:java}
TobagoConfigFragment tobagoConfigFragment = new TobagoConfigFragment();
tobagoConfigFragment.setCheckSecurityAnnotations(false);
TobagoConfigBuilder tobagoConfigBuilder =
new TobagoConfigBuilder(servletContext,
Collections.singletonList(tobagoConfigFragment));
tobagoConfigBuilder.build();
{code}
The lock mechanism from TOBAGO-1398 is still called within initialization (in
the build Method).
> Allow programmatic configuration in addition to tobago-config.xml
> -
>
> Key: TOBAGO-1674
> URL: https://issues.apache.org/jira/browse/TOBAGO-1674
> Project: MyFaces Tobago
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.0.0
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
> Fix For: 3.1.0
>
>
> Currently Tobago is configured using a tobago-config.xml file.
> TobagoConfigBuilder doesn't allow to specify parameters programmatically and
> TobagoConfigImpl cannot be instantiated from outside the package.
> We need to improve it to allow Spring auto configuration. See draft for
> org.joinfaces.tobago.TobagoServletContextConfigurer in:
> https://github.com/deki/joinfaces/tree/tobago
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (TOBAGO-1694) Remove Tobago ProjectStage in favor for JSF ProjectStage
[ https://issues.apache.org/jira/browse/TOBAGO-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1694. Resolution: Fixed replaced and marked as deprecated, will be deleted in version 4 > Remove Tobago ProjectStage in favor for JSF ProjectStage > > > Key: TOBAGO-1694 > URL: https://issues.apache.org/jira/browse/TOBAGO-1694 > Project: MyFaces Tobago > Issue Type: Improvement >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst > Fix For: 3.1.0 > > > Enum is part of the standard and no longer needed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (TOBAGO-1694) Remove Tobago ProjectStage in favor for JSF ProjectStage
Dennis Kieselhorst created TOBAGO-1694: -- Summary: Remove Tobago ProjectStage in favor for JSF ProjectStage Key: TOBAGO-1694 URL: https://issues.apache.org/jira/browse/TOBAGO-1694 Project: MyFaces Tobago Issue Type: Improvement Reporter: Dennis Kieselhorst Assignee: Dennis Kieselhorst Enum is part of the standard and no longer needed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MYFACES-4011) Old namespaces in tld-files
[ https://issues.apache.org/jira/browse/MYFACES-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851229#comment-15851229 ] Dennis Kieselhorst commented on MYFACES-4011: - According to Eclipse bug, the issue was fixed for Oxygen release. So no additional change needed... > Old namespaces in tld-files > --- > > Key: MYFACES-4011 > URL: https://issues.apache.org/jira/browse/MYFACES-4011 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 2.2.8 > Environment: Eclipse >Reporter: Kristian Jörg >Assignee: Dennis Kieselhorst > Fix For: 2.2.9 > > Attachments: MYFACES_4011.patch > > > Myfaces 2.2.8 does not support the new namespaces in TLD files i.e > xmlns:f="http://xmlns.jcp.org/jsf/core"; > xmlns:h="http://xmlns.jcp.org/jsf/html"; > xmlns:jl="http://xmlns.jcp.org/jsf/composite/jsflive"; > In Eclipse, which autoloads namespace definitions from JAR files, I get > "Can't find facelet tag library for uri http://xmlns.jcp.org/jsf/core";. The > TLD files that are contained in Myfaces 2.2.8 corresponds to JSF 2.1, and > does not include f:viewAction. > I've seen that the code for viewAction is there in the 2.2.8 impl jars. The > problem is that the TLD file does not list it so I can't use it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (MYFACES-4011) Old namespaces in tld-files
[ https://issues.apache.org/jira/browse/MYFACES-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved MYFACES-4011. - Resolution: Fixed Fix Version/s: 2.2.9 > Old namespaces in tld-files > --- > > Key: MYFACES-4011 > URL: https://issues.apache.org/jira/browse/MYFACES-4011 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 2.2.8 > Environment: Eclipse >Reporter: Kristian Jörg >Assignee: Dennis Kieselhorst > Fix For: 2.2.9 > > Attachments: MYFACES_4011.patch > > > Myfaces 2.2.8 does not support the new namespaces in TLD files i.e > xmlns:f="http://xmlns.jcp.org/jsf/core"; > xmlns:h="http://xmlns.jcp.org/jsf/html"; > xmlns:jl="http://xmlns.jcp.org/jsf/composite/jsflive"; > In Eclipse, which autoloads namespace definitions from JAR files, I get > "Can't find facelet tag library for uri http://xmlns.jcp.org/jsf/core";. The > TLD files that are contained in Myfaces 2.2.8 corresponds to JSF 2.1, and > does not include f:viewAction. > I've seen that the code for viewAction is there in the 2.2.8 impl jars. The > problem is that the TLD file does not list it so I can't use it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (TOBAGO-1693) Support Tobago facelets as view in MVC 1.0 (JSR 371)
Dennis Kieselhorst created TOBAGO-1693: -- Summary: Support Tobago facelets as view in MVC 1.0 (JSR 371) Key: TOBAGO-1693 URL: https://issues.apache.org/jira/browse/TOBAGO-1693 Project: MyFaces Tobago Issue Type: New Feature Reporter: Dennis Kieselhorst Tobago should be supported as view technology in MVC 1.0 (JSR 371). Reference implementation is Ozark: https://ozark.java.net -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (TOBAGO-1692) Regex validation doesn't work
Dennis Kieselhorst created TOBAGO-1692:
--
Summary: Regex validation doesn't work
Key: TOBAGO-1692
URL: https://issues.apache.org/jira/browse/TOBAGO-1692
Project: MyFaces Tobago
Issue Type: Bug
Components: Core
Affects Versions: 3.0.2
Reporter: Dennis Kieselhorst
Check sample in content-validation.xhtml, regardless of the given value there
is always a validation error after submit.
Logfile warning
{noformat}
javax.faces.validator.BeanValidator validate
WARNUNG: cannot validate component with empty value:
page:mainForm:regexValidation:in
{noformat}
Moreover in TextareaRenderer and InRenderer code with RegexValidator is
commented out, if it's no longer needed writeAttribute for pattern should be
removed as well.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Resolved] (TOBAGO-1688) Security check (e.g. @RolesAllowed) should be configurable
[
https://issues.apache.org/jira/browse/TOBAGO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved TOBAGO-1688.
Resolution: Fixed
> Security check (e.g. @RolesAllowed) should be configurable
> --
>
> Key: TOBAGO-1688
> URL: https://issues.apache.org/jira/browse/TOBAGO-1688
> Project: MyFaces Tobago
> Issue Type: Improvement
> Components: Core
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
> Fix For: 3.1.0
>
>
> If CDI is not available, a NameNotFoundException is thrown:
> {noformat}
> WARN o.a.m.t.i.u.AuthorizationHelper - Can't obtain 'java:comp/BeanManager'
> javax.naming.NameNotFoundException: null
> at org.eclipse.jetty.jndi.NamingContext.lookup(NamingContext.java:476)
> at org.eclipse.jetty.jndi.NamingContext.lookup(NamingContext.java:563)
> at org.eclipse.jetty.jndi.NamingContext.lookup(NamingContext.java:578)
> at
> org.eclipse.jetty.jndi.java.javaRootURLContext.lookup(javaRootURLContext.java:106)
> at javax.naming.InitialContext.lookup(InitialContext.java:417)
> at
> org.apache.myfaces.tobago.internal.util.AuthorizationHelper.(AuthorizationHelper.java:78)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at java.lang.Class.newInstance(Class.java:442)
> at
> org.apache.myfaces.config.annotation.Tomcat7AnnotationLifecycleProvider.newInstance(Tomcat7AnnotationLifecycleProvider.java:60)
> at
> org.apache.myfaces.config.ManagedBeanBuilder.buildManagedBean(ManagedBeanBuilder.java:156)
> at
> org.apache.myfaces.el.unified.resolver.ManagedBeanResolver.createManagedBean(ManagedBeanResolver.java:333)
> at
> org.apache.myfaces.el.unified.resolver.ManagedBeanResolver.getValue(ManagedBeanResolver.java:296)
> at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:62)
> at
> org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver.getValue(FacesCompositeELResolver.java:179)
> at
> org.apache.myfaces.tobago.internal.util.AuthorizationHelper.getInstance(AuthorizationHelper.java:94)
> at
> org.apache.myfaces.tobago.internal.component.AbstractUICommandBase.isAllowed(AbstractUICommandBase.java:116)
> at
> org.apache.myfaces.tobago.internal.component.AbstractUICommandBase.isRendered(AbstractUICommandBase.java:92)
> at
> org.apache.myfaces.tobago.internal.renderkit.renderer.TobagoClientBehaviorRenderer.getScript(TobagoClientBehaviorRenderer.java:101)
> at
> org.apache.myfaces.tobago.internal.util.RenderUtils.getBehaviorCommands(RenderUtils.java:263)
> at
> org.apache.myfaces.tobago.internal.renderkit.renderer.PageRenderer.encodeBegin(PageRenderer.java:260)
> at
> javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597)
> at
> org.apache.myfaces.tobago.internal.component.AbstractUIPage.encodeBegin(AbstractUIPage.java:60)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527)
> at
> javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
> {noformat}
> This should be configurable by a new config option
> check-security-annotations. Default should be true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TOBAGO-1688) Security check (e.g. @RolesAllowed) should be configurable
Dennis Kieselhorst created TOBAGO-1688:
--
Summary: Security check (e.g. @RolesAllowed) should be configurable
Key: TOBAGO-1688
URL: https://issues.apache.org/jira/browse/TOBAGO-1688
Project: MyFaces Tobago
Issue Type: Improvement
Components: Core
Reporter: Dennis Kieselhorst
Assignee: Dennis Kieselhorst
If CDI is not available, a NameNotFoundException is thrown:
{noformat}
WARN o.a.m.t.i.u.AuthorizationHelper - Can't obtain 'java:comp/BeanManager'
javax.naming.NameNotFoundException: null
at org.eclipse.jetty.jndi.NamingContext.lookup(NamingContext.java:476)
at org.eclipse.jetty.jndi.NamingContext.lookup(NamingContext.java:563)
at org.eclipse.jetty.jndi.NamingContext.lookup(NamingContext.java:578)
at
org.eclipse.jetty.jndi.java.javaRootURLContext.lookup(javaRootURLContext.java:106)
at javax.naming.InitialContext.lookup(InitialContext.java:417)
at
org.apache.myfaces.tobago.internal.util.AuthorizationHelper.(AuthorizationHelper.java:78)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at java.lang.Class.newInstance(Class.java:442)
at
org.apache.myfaces.config.annotation.Tomcat7AnnotationLifecycleProvider.newInstance(Tomcat7AnnotationLifecycleProvider.java:60)
at
org.apache.myfaces.config.ManagedBeanBuilder.buildManagedBean(ManagedBeanBuilder.java:156)
at
org.apache.myfaces.el.unified.resolver.ManagedBeanResolver.createManagedBean(ManagedBeanResolver.java:333)
at
org.apache.myfaces.el.unified.resolver.ManagedBeanResolver.getValue(ManagedBeanResolver.java:296)
at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:62)
at
org.apache.myfaces.el.unified.resolver.FacesCompositeELResolver.getValue(FacesCompositeELResolver.java:179)
at
org.apache.myfaces.tobago.internal.util.AuthorizationHelper.getInstance(AuthorizationHelper.java:94)
at
org.apache.myfaces.tobago.internal.component.AbstractUICommandBase.isAllowed(AbstractUICommandBase.java:116)
at
org.apache.myfaces.tobago.internal.component.AbstractUICommandBase.isRendered(AbstractUICommandBase.java:92)
at
org.apache.myfaces.tobago.internal.renderkit.renderer.TobagoClientBehaviorRenderer.getScript(TobagoClientBehaviorRenderer.java:101)
at
org.apache.myfaces.tobago.internal.util.RenderUtils.getBehaviorCommands(RenderUtils.java:263)
at
org.apache.myfaces.tobago.internal.renderkit.renderer.PageRenderer.encodeBegin(PageRenderer.java:260)
at
javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:597)
at
org.apache.myfaces.tobago.internal.component.AbstractUIPage.encodeBegin(AbstractUIPage.java:60)
at
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:527)
at
javax.faces.component.UIComponentBase.encodeAll(UIComponentBase.java:551)
{noformat}
This should be configurable by a new config option check-security-annotations.
Default should be true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TOBAGO-1674) Allow programmatic configuration instead of tobago-config.xml
Dennis Kieselhorst created TOBAGO-1674: -- Summary: Allow programmatic configuration instead of tobago-config.xml Key: TOBAGO-1674 URL: https://issues.apache.org/jira/browse/TOBAGO-1674 Project: MyFaces Tobago Issue Type: Improvement Components: Core Affects Versions: 3.0.0 Reporter: Dennis Kieselhorst Currently Tobago is configured using a tobago-config.xml file. TobagoConfigBuilder doesn't allow to specify parameters programmatically and TobagoConfigImpl cannot be instantiated from outside the package. We need to improve it to allow Spring auto configuration. See draft for org.joinfaces.tobago.TobagoServletContextConfigurer in: https://github.com/deki/joinfaces/tree/tobago -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (TOBAGO-1673) Update logback and slf4j dependency
[ https://issues.apache.org/jira/browse/TOBAGO-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1673. Resolution: Fixed > Update logback and slf4j dependency > --- > > Key: TOBAGO-1673 > URL: https://issues.apache.org/jira/browse/TOBAGO-1673 > Project: MyFaces Tobago > Issue Type: Task >Affects Versions: 3.0.0 >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst >Priority: Trivial > Fix For: 3.0.1 > > > Update slf4j to 1.7.22 and logback to 1.1.8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TOBAGO-1673) Update logback and slf4j dependency
Dennis Kieselhorst created TOBAGO-1673: -- Summary: Update logback and slf4j dependency Key: TOBAGO-1673 URL: https://issues.apache.org/jira/browse/TOBAGO-1673 Project: MyFaces Tobago Issue Type: Task Reporter: Dennis Kieselhorst Assignee: Dennis Kieselhorst Update slf4j to 1.7.22 and logback to 1.1.8 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (TOBAGO-1473) Remove selenium legacy dependency
[ https://issues.apache.org/jira/browse/TOBAGO-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1473. Resolution: Won't Fix Tests in 3.x will be integrated in the demo and implemented using Arquillian and QUnit. Afterwards the tobago-example-test module will be removed. > Remove selenium legacy dependency > - > > Key: TOBAGO-1473 > URL: https://issues.apache.org/jira/browse/TOBAGO-1473 > Project: MyFaces Tobago > Issue Type: Improvement >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst > Fix For: 3.0.0 > > > The selenium tests were migrated to use Webdriver in TOBAGO-1369 to make them > runnable with current browser versions. This change has not been merged to > 3.x branch yet. We need a different implementation in future as the current > Selenium legacy support will be dropped in Selenium 3. > Since everybody is happy with the current approach (record scripts with > Selenium IDE and run them in Unittests) we should stick to this. > Unfortunately there is no official runner for it (see > https://code.google.com/p/selenium/issues/detail?id=175). Adapting this kind > of approach using > Arquillian Graphene/ Gebish will be lots of effort, but there is a runner on > Github that looks promising: https://github.com/vmi/selenese-runner-java > (Apache license) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TRINIDAD-2536) Where can i download Trinidad 2.1.1
[ https://issues.apache.org/jira/browse/TRINIDAD-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221470#comment-15221470 ] Dennis Kieselhorst commented on TRINIDAD-2536: -- The vote for 2.1.1 was started http://myfaces.10567.n7.nabble.com/VOTE-Release-of-MyFaces-Trinidad-2-1-1-tt121187.html but it's not yet released. > Where can i download Trinidad 2.1.1 > --- > > Key: TRINIDAD-2536 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2536 > Project: MyFaces Trinidad > Issue Type: Wish >Reporter: Gopichand > > I need information for some questions > 1. What is the latest version of trinidad api / impl ? > 2. From where can i download the latest version of trinidad api / impl > (Please provide me the link) ? > 3. If Trinidad 2.1.1 is not released yet, when are you planning to release > it ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-3987) NPE in FlashImpl.isKeepMessages
[
https://issues.apache.org/jira/browse/MYFACES-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151865#comment-15151865
]
Dennis Kieselhorst commented on MYFACES-3987:
-
It's a selenium test, not a unittest, that's why it made sense to fix the NPEs
(e.g. isEmpty() should return true instead of throwing NPE). Apart from that
I've opened TOBAGO-1530 to fix the ExceptionHandler causing at least some of
this issues.
> NPE in FlashImpl.isKeepMessages
> ---
>
> Key: MYFACES-3987
> URL: https://issues.apache.org/jira/browse/MYFACES-3987
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.23, 2.1.17, 2.2.8
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.2.10
>
>
> Happens during Selenium test execution in
> http://svn.apache.org/repos/asf/myfaces/tobago/trunk/tobago-example/tobago-example-test/
> for sheet-selector.jspx:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.myfaces.shared.context.flash.FlashImpl.isKeepMessages(FlashImpl.java:395)
> at
> org.apache.myfaces.shared.context.flash.FlashImpl._saveMessages(FlashImpl.java:686)
> at
> org.apache.myfaces.shared.context.flash.FlashImpl.doPostPhaseActions(FlashImpl.java:271)
> at
> org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:280)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:806)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
> at
> org.apache.myfaces.tobago.webapp.TobagoMultipartFormdataFilter.doFilter(TobagoMultipartFormdataFilter.java:124)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:550)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1128)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1062)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:113)
> at org.eclipse.jetty.server.Server.handle(Server.java:507)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:284)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:237)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:240)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:93)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:53)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceRun.produceAndRun(ExecuteProduceRun.java:191)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceRun.run(ExecuteProduceRun.java:126)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:641)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:559)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TOBAGO-1530) TestExceptionHandler causes severe error messages
Dennis Kieselhorst created TOBAGO-1530:
--
Summary: TestExceptionHandler causes severe error messages
Key: TOBAGO-1530
URL: https://issues.apache.org/jira/browse/TOBAGO-1530
Project: MyFaces Tobago
Issue Type: Bug
Reporter: Dennis Kieselhorst
Priority: Minor
To reproduce run tobago-example-test suite with myfaces-core 2.2.10-SNAPSHOT
{noformat}
org.apache.myfaces.context.servlet.ServletExternalContextImpl
setResponseContentType
SEVERE: Cannot set content type. Response already committed
{noformat}
Stacktrace
{noformat}
org.apache.myfaces.context.servlet.ServletExternalContextImpl.setResponseContentType(ServletExternalContextImpl.java:657)
org.apache.myfaces.renderkit.ErrorPageWriter.handle(ErrorPageWriter.java:464)
org.apache.myfaces.context.MyFacesExceptionHandlerWrapperImpl.handle(MyFacesExceptionHandlerWrapperImpl.java:301)
javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:61)
org.apache.myfaces.tobago.example.test.TestExceptionHandler.handle(TestExceptionHandler.java:65)
org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:287)
javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (MYFACES-3987) NPE in FlashImpl.isKeepMessages
[
https://issues.apache.org/jira/browse/MYFACES-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved MYFACES-3987.
-
Resolution: Fixed
> NPE in FlashImpl.isKeepMessages
> ---
>
> Key: MYFACES-3987
> URL: https://issues.apache.org/jira/browse/MYFACES-3987
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.23, 2.1.17, 2.2.8
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.2.10
>
>
> Happens during Selenium test execution in
> http://svn.apache.org/repos/asf/myfaces/tobago/trunk/tobago-example/tobago-example-test/
> for sheet-selector.jspx:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.myfaces.shared.context.flash.FlashImpl.isKeepMessages(FlashImpl.java:395)
> at
> org.apache.myfaces.shared.context.flash.FlashImpl._saveMessages(FlashImpl.java:686)
> at
> org.apache.myfaces.shared.context.flash.FlashImpl.doPostPhaseActions(FlashImpl.java:271)
> at
> org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:280)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:806)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
> at
> org.apache.myfaces.tobago.webapp.TobagoMultipartFormdataFilter.doFilter(TobagoMultipartFormdataFilter.java:124)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:550)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1128)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1062)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:113)
> at org.eclipse.jetty.server.Server.handle(Server.java:507)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:284)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:237)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:240)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:93)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:53)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceRun.produceAndRun(ExecuteProduceRun.java:191)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceRun.run(ExecuteProduceRun.java:126)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:641)
> at
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:559)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MYFACES-3987) NPE in FlashImpl.isKeepMessages
[
https://issues.apache.org/jira/browse/MYFACES-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150131#comment-15150131
]
Dennis Kieselhorst commented on MYFACES-3987:
-
You were right, there was another NPE coming up which is fixed now.
{noformat}
java.lang.NullPointerException
at
org.apache.myfaces.shared.context.flash.FlashImpl._getExecuteFlashMap(FlashImpl.java:970)
at
org.apache.myfaces.shared.context.flash.FlashImpl._getFlashMapForReading(FlashImpl.java:1049)
at
org.apache.myfaces.shared.context.flash.FlashImpl.isEmpty(FlashImpl.java:477)
at
org.apache.myfaces.renderkit.ErrorPageWriter._writeVariables(ErrorPageWriter.java:792)
at
org.apache.myfaces.renderkit.ErrorPageWriter._writeVariables(ErrorPageWriter.java:779)
at
org.apache.myfaces.renderkit.ErrorPageWriter.debugHtml(ErrorPageWriter.java:357)
at
org.apache.myfaces.renderkit.ErrorPageWriter.handle(ErrorPageWriter.java:471)
at
org.apache.myfaces.context.MyFacesExceptionHandlerWrapperImpl.handle(MyFacesExceptionHandlerWrapperImpl.java:301)
at
javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:61)
at
org.apache.myfaces.tobago.example.test.TestExceptionHandler.handle(TestExceptionHandler.java:65)
at
org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:287)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
{noformat}
> NPE in FlashImpl.isKeepMessages
> ---
>
> Key: MYFACES-3987
> URL: https://issues.apache.org/jira/browse/MYFACES-3987
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.23, 2.1.17, 2.2.8
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.2.10
>
>
> Happens during Selenium test execution in
> http://svn.apache.org/repos/asf/myfaces/tobago/trunk/tobago-example/tobago-example-test/
> for sheet-selector.jspx:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.myfaces.shared.context.flash.FlashImpl.isKeepMessages(FlashImpl.java:395)
> at
> org.apache.myfaces.shared.context.flash.FlashImpl._saveMessages(FlashImpl.java:686)
> at
> org.apache.myfaces.shared.context.flash.FlashImpl.doPostPhaseActions(FlashImpl.java:271)
> at
> org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:280)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:806)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
> at
> org.apache.myfaces.tobago.webapp.TobagoMultipartFormdataFilter.doFilter(TobagoMultipartFormdataFilter.java:124)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:550)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1128)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1062)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
> at
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110)
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:113)
> at org.eclipse.jetty.server.Server.handle(Server.java:507)
> at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:284)
> at
> org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:237)
> at
> org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:240)
> at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:93)
> at
> org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:53)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceRun.produceAndRun(ExecuteProduceRun.java:191)
> at
> org.eclipse.jetty.util.thread.strategy.ExecuteProduceRun.run(ExecuteProduceRun.java:126)
> at
> org.eclipse.jetty.util.thread.Qu
[jira] [Resolved] (TOBAGO-1522) AJAX-Overlay never disappears when heavily double clicking
[ https://issues.apache.org/jira/browse/TOBAGO-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1522. Resolution: Fixed The problem occured when the server was no longer answering ajax requests (e.g. on shutdown wrong way sign is shown). Looks better now... > AJAX-Overlay never disappears when heavily double clicking > -- > > Key: TOBAGO-1522 > URL: https://issues.apache.org/jira/browse/TOBAGO-1522 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core >Affects Versions: 2.0.8, 3.0.0-alpha-2 > Environment: Microsoft Internet Explorer 11.0.9600.18098 > Firefox 43.0.1 (Mac OS X) >Reporter: Dennis Kieselhorst >Assignee: Volker Weber > Fix For: 3.0.0-alpha-3, 2.0.9 > > Attachments: 1522.patch, blocking-overlay.png > > > Using Internet Explorer 11 it is possible to produce a situation where the > overlay. > To reproduce open the sheet control page in the demo and heavily double click > until the overlay appears. > !blocking-overlay.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TOBAGO-1522) AJAX-Overlay never disappears when heavily double clicking
[
https://issues.apache.org/jira/browse/TOBAGO-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115781#comment-15115781
]
Dennis Kieselhorst commented on TOBAGO-1522:
Reopen, just discovered the following error in the console:
{noformat}
Error: Error: "TypeError: container.overlay is not a function" ON
http://localhost:8080/xxx/org/apache/myfaces/tobago/renderkit/2.0.9-SNAPSHOT/html/standard/standard/script/tobago.js
line: 2074
{noformat}
> AJAX-Overlay never disappears when heavily double clicking
> --
>
> Key: TOBAGO-1522
> URL: https://issues.apache.org/jira/browse/TOBAGO-1522
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.8, 3.0.0-alpha-2
> Environment: Microsoft Internet Explorer 11.0.9600.18098
> Firefox 43.0.1 (Mac OS X)
>Reporter: Dennis Kieselhorst
>Assignee: Volker Weber
> Fix For: 3.0.0-alpha-3, 2.0.9
>
> Attachments: 1522.patch, blocking-overlay.png
>
>
> Using Internet Explorer 11 it is possible to produce a situation where the
> overlay.
> To reproduce open the sheet control page in the demo and heavily double click
> until the overlay appears.
> !blocking-overlay.png!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (TOBAGO-1522) AJAX-Overlay never disappears when heavily double clicking
[ https://issues.apache.org/jira/browse/TOBAGO-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst reopened TOBAGO-1522: > AJAX-Overlay never disappears when heavily double clicking > -- > > Key: TOBAGO-1522 > URL: https://issues.apache.org/jira/browse/TOBAGO-1522 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core >Affects Versions: 2.0.8, 3.0.0-alpha-2 > Environment: Microsoft Internet Explorer 11.0.9600.18098 > Firefox 43.0.1 (Mac OS X) >Reporter: Dennis Kieselhorst >Assignee: Volker Weber > Fix For: 3.0.0-alpha-3, 2.0.9 > > Attachments: 1522.patch, blocking-overlay.png > > > Using Internet Explorer 11 it is possible to produce a situation where the > overlay. > To reproduce open the sheet control page in the demo and heavily double click > until the overlay appears. > !blocking-overlay.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TOBAGO-1522) AJAX-Overlay never disappears when heavily double clicking
[ https://issues.apache.org/jira/browse/TOBAGO-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115623#comment-15115623 ] Dennis Kieselhorst commented on TOBAGO-1522: Just verified it, still works as expected, thx! > AJAX-Overlay never disappears when heavily double clicking > -- > > Key: TOBAGO-1522 > URL: https://issues.apache.org/jira/browse/TOBAGO-1522 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core >Affects Versions: 2.0.8, 3.0.0-alpha-2 > Environment: Microsoft Internet Explorer 11.0.9600.18098 > Firefox 43.0.1 (Mac OS X) >Reporter: Dennis Kieselhorst >Assignee: Volker Weber > Fix For: 3.0.0-alpha-3, 2.0.9 > > Attachments: 1522.patch, blocking-overlay.png > > > Using Internet Explorer 11 it is possible to produce a situation where the > overlay. > To reproduce open the sheet control page in the demo and heavily double click > until the overlay appears. > !blocking-overlay.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TOBAGO-1522) AJAX-Overlay never disappears when heavily double clicking
[ https://issues.apache.org/jira/browse/TOBAGO-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114335#comment-15114335 ] Dennis Kieselhorst commented on TOBAGO-1522: The patch fixes the problem, however it changes the behaviour in some cases (there is no longer a transition overlay where it was shown before). Before commit console logging and doc (request function returns "true if the request is queued or ignored, because of a double request.") needs to be cleaned up. > AJAX-Overlay never disappears when heavily double clicking > -- > > Key: TOBAGO-1522 > URL: https://issues.apache.org/jira/browse/TOBAGO-1522 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core >Affects Versions: 2.0.8, 3.0.0-alpha-2 > Environment: Microsoft Internet Explorer 11.0.9600.18098 > Firefox 43.0.1 (Mac OS X) >Reporter: Dennis Kieselhorst > Fix For: 2.0.9 > > Attachments: 1522.patch, blocking-overlay.png > > > Using Internet Explorer 11 it is possible to produce a situation where the > overlay. > To reproduce open the sheet control page in the demo and heavily double click > until the overlay appears. > !blocking-overlay.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TOBAGO-1524) Use standard ajax mechanism
Dennis Kieselhorst created TOBAGO-1524: -- Summary: Use standard ajax mechanism Key: TOBAGO-1524 URL: https://issues.apache.org/jira/browse/TOBAGO-1524 Project: MyFaces Tobago Issue Type: Improvement Components: Core Affects Versions: 3.0.0-alpha-2, 2.0.8 Reporter: Dennis Kieselhorst Tobago supports Ajax from the very beginning. With JSF 2.0 Ajax became part of the standard (f:ajax). We should move over to the standard javascript to enhance the robustness. Currently we have several open issues related to Ajax requests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TOBAGO-1522) Overlay never disappears in IE11
Dennis Kieselhorst created TOBAGO-1522: -- Summary: Overlay never disappears in IE11 Key: TOBAGO-1522 URL: https://issues.apache.org/jira/browse/TOBAGO-1522 Project: MyFaces Tobago Issue Type: Bug Components: Core Affects Versions: 2.0.8 Environment: Microsoft Internet Explorer 11.0.9600.18098 Reporter: Dennis Kieselhorst Using Internet Explorer 11 it is possible to produce a situation where the overlay. To reproduce open the sheet control page in the demo and heavily double click until the overlay appears. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TOBAGO-1473) Remove selenium legacy dependency
[ https://issues.apache.org/jira/browse/TOBAGO-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056202#comment-15056202 ] Dennis Kieselhorst commented on TOBAGO-1473: Pull request created: https://github.com/vmi/selenese-runner-java/pull/177 > Remove selenium legacy dependency > - > > Key: TOBAGO-1473 > URL: https://issues.apache.org/jira/browse/TOBAGO-1473 > Project: MyFaces Tobago > Issue Type: Improvement >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst > Fix For: 3.0.0 > > > The selenium tests were migrated to use Webdriver in TOBAGO-1369 to make them > runnable with current browser versions. This change has not been merged to > 3.x branch yet. We need a different implementation in future as the current > Selenium legacy support will be dropped in Selenium 3. > Since everybody is happy with the current approach (record scripts with > Selenium IDE and run them in Unittests) we should stick to this. > Unfortunately there is no official runner for it (see > https://code.google.com/p/selenium/issues/detail?id=175). Adapting this kind > of approach using > Arquillian Graphene/ Gebish will be lots of effort, but there is a runner on > Github that looks promising: https://github.com/vmi/selenese-runner-java > (Apache license) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-3987) NPE in FlashImpl.isKeepMessages
[
https://issues.apache.org/jira/browse/MYFACES-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029985#comment-15029985
]
Dennis Kieselhorst commented on MYFACES-3987:
-
FacesContext is somehow gone in that case.
{noformat}
java.lang.NullPointerException
at javax.faces.component.UIViewRoot.getViewMap(UIViewRoot.java:837)
at javax.faces.component.UIViewRoot.getViewMap(UIViewRoot.java:822)
at
org.apache.myfaces.renderkit.ErrorPageWriter._writeVariables(ErrorPageWriter.java:770)
at
org.apache.myfaces.renderkit.ErrorPageWriter.debugHtml(ErrorPageWriter.java:357)
at
org.apache.myfaces.renderkit.ErrorPageWriter.handle(ErrorPageWriter.java:471)
at
org.apache.myfaces.context.MyFacesExceptionHandlerWrapperImpl.handle(MyFacesExceptionHandlerWrapperImpl.java:301)
at
javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:61)
at
org.apache.myfaces.tobago.example.test.TestExceptionHandler.handle(TestExceptionHandler.java:65)
at
org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:287)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
at
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:808)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
{noformat}
{noformat}
java.lang.NullPointerException
at
org.apache.myfaces.view.ViewScopeProxyMap.getWrapped(ViewScopeProxyMap.java:69)
at
org.apache.myfaces.view.ViewScopeProxyMap.isEmpty(ViewScopeProxyMap.java:94)
at
org.apache.myfaces.renderkit.ErrorPageWriter._writeVariables(ErrorPageWriter.java:792)
at
org.apache.myfaces.renderkit.ErrorPageWriter._writeVariables(ErrorPageWriter.java:770)
at
org.apache.myfaces.renderkit.ErrorPageWriter.debugHtml(ErrorPageWriter.java:357)
at
org.apache.myfaces.renderkit.ErrorPageWriter.handle(ErrorPageWriter.java:471)
at
org.apache.myfaces.context.MyFacesExceptionHandlerWrapperImpl.handle(MyFacesExceptionHandlerWrapperImpl.java:301)
at
javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:61)
at
org.apache.myfaces.tobago.example.test.TestExceptionHandler.handle(TestExceptionHandler.java:65)
at
org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:287)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
{noformat}
> NPE in FlashImpl.isKeepMessages
> ---
>
> Key: MYFACES-3987
> URL: https://issues.apache.org/jira/browse/MYFACES-3987
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.0.23, 2.1.17, 2.2.8
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
>Priority: Minor
> Fix For: 2.2.10
>
>
> Happens during Selenium test execution in
> http://svn.apache.org/repos/asf/myfaces/tobago/trunk/tobago-example/tobago-example-test/
> for sheet-selector.jspx:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.myfaces.shared.context.flash.FlashImpl.isKeepMessages(FlashImpl.java:395)
> at
> org.apache.myfaces.shared.context.flash.FlashImpl._saveMessages(FlashImpl.java:686)
> at
> org.apache.myfaces.shared.context.flash.FlashImpl.doPostPhaseActions(FlashImpl.java:271)
> at
> org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:280)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:200)
> at
> org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:806)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
> at
> org.apache.myfaces.tobago.webapp.TobagoMultipartFormdataFilter.doFilter(TobagoMultipartFormdataFilter.java:124)
> at
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:550)
> at
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1128)
> at
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
> at
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
> at
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1062)
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
> at
> org.eclipse.jetty.server.handler.ContextHandle
[jira] [Comment Edited] (TOBAGO-1473) Remove selenium legacy dependency
[
https://issues.apache.org/jira/browse/TOBAGO-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029940#comment-15029940
]
Dennis Kieselhorst edited comment on TOBAGO-1473 at 11/27/15 2:57 PM:
--
I played around with selenese-runner and was able to execute most of the test
scripts.
However we need to find a replacement for TobagoSelenium.checkPage and
implement missing stuff like this (I will create pull requests for this
https://github.com/vmi/selenese-runner-java/issues/173):
{noformat}
java.lang.UnsupportedOperationException: Unknown locator type:
class=tobago-popup
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElementsInternal(WebDriverElementFinder.java:218)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElements(WebDriverElementFinder.java:259)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElements(WebDriverElementFinder.java:271)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElement(WebDriverElementFinder.java:288)
at
com.thoughtworks.selenium.webdriven.commands.IsElementPresent.handleSeleneseCommand(IsElementPresent.java:36)
at
com.thoughtworks.selenium.webdriven.commands.IsElementPresent.handleSeleneseCommand(IsElementPresent.java:26)
at
com.thoughtworks.selenium.webdriven.SeleneseCommand.apply(SeleneseCommand.java:36)
at
jp.vmi.selenium.selenese.subcommand.WDCommand.execute(WDCommand.java:39)
at
jp.vmi.selenium.selenese.command.Assertion.executeImpl(Assertion.java:98)
at
jp.vmi.selenium.selenese.command.AbstractCommand.execute(AbstractCommand.java:145)
at
jp.vmi.selenium.selenese.command.CommandList.doCommand(CommandList.java:98)
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c.CGLIB$doCommand$13()
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c$$FastClassByGuice$$64bfcffb.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ScreenshotInterceptor.invoke(ScreenshotInterceptor.java:29)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.HighlightInterceptor.invoke(HighlightInterceptor.java:40)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.CommandLogInterceptor.invoke(CommandLogInterceptor.java:78)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c.doCommand()
at
jp.vmi.selenium.selenese.command.CommandList.execute(CommandList.java:152)
at jp.vmi.selenium.selenese.TestCase.execute(TestCase.java:299)
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740.CGLIB$execute$0()
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740$$FastClassByGuice$$9ee2623e.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ExecuteTestCaseInterceptor.invoke(ExecuteTestCaseInterceptor.java:55)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740.execute()
at jp.vmi.selenium.selenese.TestSuite.execute(TestSuite.java:158)
at
jp.vmi.selenium.selenese.TestSuite$$EnhancerByGuice$$5f71ecf1.CGLIB$execute$0()
at
jp.vmi.selenium.selenese.TestSuite$$EnhancerByGuice$$5f71ecf1$$FastClassByGuice$$c9431ffe.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ExecuteTestSuiteInterceptor.invoke(ExecuteTestSuiteInterceptor.java:54)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(Intercepto
[jira] [Comment Edited] (TOBAGO-1473) Remove selenium legacy dependency
[
https://issues.apache.org/jira/browse/TOBAGO-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029940#comment-15029940
]
Dennis Kieselhorst edited comment on TOBAGO-1473 at 11/27/15 2:57 PM:
--
I played around with selenese-runner and was able to execute most of the test
scripts.
However we need to find a replacement for TobagoSelenium.checkPage and
implement missing stuff like this (I will create pull requests for this
https://github.com/vmi/selenese-runner-java/issues/173 ):
{noformat}
java.lang.UnsupportedOperationException: Unknown locator type:
class=tobago-popup
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElementsInternal(WebDriverElementFinder.java:218)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElements(WebDriverElementFinder.java:259)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElements(WebDriverElementFinder.java:271)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElement(WebDriverElementFinder.java:288)
at
com.thoughtworks.selenium.webdriven.commands.IsElementPresent.handleSeleneseCommand(IsElementPresent.java:36)
at
com.thoughtworks.selenium.webdriven.commands.IsElementPresent.handleSeleneseCommand(IsElementPresent.java:26)
at
com.thoughtworks.selenium.webdriven.SeleneseCommand.apply(SeleneseCommand.java:36)
at
jp.vmi.selenium.selenese.subcommand.WDCommand.execute(WDCommand.java:39)
at
jp.vmi.selenium.selenese.command.Assertion.executeImpl(Assertion.java:98)
at
jp.vmi.selenium.selenese.command.AbstractCommand.execute(AbstractCommand.java:145)
at
jp.vmi.selenium.selenese.command.CommandList.doCommand(CommandList.java:98)
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c.CGLIB$doCommand$13()
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c$$FastClassByGuice$$64bfcffb.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ScreenshotInterceptor.invoke(ScreenshotInterceptor.java:29)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.HighlightInterceptor.invoke(HighlightInterceptor.java:40)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.CommandLogInterceptor.invoke(CommandLogInterceptor.java:78)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c.doCommand()
at
jp.vmi.selenium.selenese.command.CommandList.execute(CommandList.java:152)
at jp.vmi.selenium.selenese.TestCase.execute(TestCase.java:299)
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740.CGLIB$execute$0()
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740$$FastClassByGuice$$9ee2623e.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ExecuteTestCaseInterceptor.invoke(ExecuteTestCaseInterceptor.java:55)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740.execute()
at jp.vmi.selenium.selenese.TestSuite.execute(TestSuite.java:158)
at
jp.vmi.selenium.selenese.TestSuite$$EnhancerByGuice$$5f71ecf1.CGLIB$execute$0()
at
jp.vmi.selenium.selenese.TestSuite$$EnhancerByGuice$$5f71ecf1$$FastClassByGuice$$c9431ffe.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ExecuteTestSuiteInterceptor.invoke(ExecuteTestSuiteInterceptor.java:54)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(Intercept
[jira] [Commented] (TOBAGO-1473) Remove selenium legacy dependency
[
https://issues.apache.org/jira/browse/TOBAGO-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029940#comment-15029940
]
Dennis Kieselhorst commented on TOBAGO-1473:
I played around with selenese-runner and was able to execute most of the test
scripts.
However we need to find a replacement for TobagoSelenium.checkPage and
implement missing stuff like this (I will create pull requests for this):
{noformat}
java.lang.UnsupportedOperationException: Unknown locator type:
class=tobago-popup
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElementsInternal(WebDriverElementFinder.java:218)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElements(WebDriverElementFinder.java:259)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElements(WebDriverElementFinder.java:271)
at
jp.vmi.selenium.selenese.locator.WebDriverElementFinder.findElement(WebDriverElementFinder.java:288)
at
com.thoughtworks.selenium.webdriven.commands.IsElementPresent.handleSeleneseCommand(IsElementPresent.java:36)
at
com.thoughtworks.selenium.webdriven.commands.IsElementPresent.handleSeleneseCommand(IsElementPresent.java:26)
at
com.thoughtworks.selenium.webdriven.SeleneseCommand.apply(SeleneseCommand.java:36)
at
jp.vmi.selenium.selenese.subcommand.WDCommand.execute(WDCommand.java:39)
at
jp.vmi.selenium.selenese.command.Assertion.executeImpl(Assertion.java:98)
at
jp.vmi.selenium.selenese.command.AbstractCommand.execute(AbstractCommand.java:145)
at
jp.vmi.selenium.selenese.command.CommandList.doCommand(CommandList.java:98)
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c.CGLIB$doCommand$13()
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c$$FastClassByGuice$$64bfcffb.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ScreenshotInterceptor.invoke(ScreenshotInterceptor.java:29)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.HighlightInterceptor.invoke(HighlightInterceptor.java:40)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.CommandLogInterceptor.invoke(CommandLogInterceptor.java:78)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
at
jp.vmi.selenium.selenese.command.CommandList$$EnhancerByGuice$$eda6b15c.doCommand()
at
jp.vmi.selenium.selenese.command.CommandList.execute(CommandList.java:152)
at jp.vmi.selenium.selenese.TestCase.execute(TestCase.java:299)
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740.CGLIB$execute$0()
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740$$FastClassByGuice$$9ee2623e.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ExecuteTestCaseInterceptor.invoke(ExecuteTestCaseInterceptor.java:55)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
com.google.inject.internal.InterceptorStackCallback.intercept(InterceptorStackCallback.java:52)
at
jp.vmi.selenium.selenese.TestCase$$EnhancerByGuice$$6df3b740.execute()
at jp.vmi.selenium.selenese.TestSuite.execute(TestSuite.java:158)
at
jp.vmi.selenium.selenese.TestSuite$$EnhancerByGuice$$5f71ecf1.CGLIB$execute$0()
at
jp.vmi.selenium.selenese.TestSuite$$EnhancerByGuice$$5f71ecf1$$FastClassByGuice$$c9431ffe.invoke()
at
com.google.inject.internal.cglib.proxy.$MethodProxy.invokeSuper(MethodProxy.java:228)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
jp.vmi.selenium.selenese.inject.ExecuteTestSuiteInterceptor.invoke(ExecuteTestSuiteInterceptor.java:54)
at
com.google.inject.internal.InterceptorStackCallback$InterceptedMethodInvocation.proceed(InterceptorStackCallback.java:72)
at
com.google.inject.internal.InterceptorStackCallback.intercept(Intercept
[jira] [Resolved] (MYFACES-4020) Update commons-collections to 3.2.2
[
https://issues.apache.org/jira/browse/MYFACES-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved MYFACES-4020.
-
Resolution: Fixed
> Update commons-collections to 3.2.2
> ---
>
> Key: MYFACES-4020
> URL: https://issues.apache.org/jira/browse/MYFACES-4020
> Project: MyFaces Core
> Issue Type: Task
>Affects Versions: 2.2.8
>Reporter: Dennis Kieselhorst
>Assignee: Dennis Kieselhorst
> Fix For: 2.2.10
>
>
> {quote}
> 2015-11-23 16:37 GMT-05:00 Mike Kienenberger:
> let's upgrade our commons-collections
> dependency to 3.2.2 as certain JSF configurations likely present
> attack vectors.
> https://issues.apache.org/jira/browse/COLLECTIONS-580
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MYFACES-4020) Update commons-collections to 3.2.2
Dennis Kieselhorst created MYFACES-4020:
---
Summary: Update commons-collections to 3.2.2
Key: MYFACES-4020
URL: https://issues.apache.org/jira/browse/MYFACES-4020
Project: MyFaces Core
Issue Type: Task
Affects Versions: 2.2.8
Reporter: Dennis Kieselhorst
Assignee: Dennis Kieselhorst
{quote}
2015-11-23 16:37 GMT-05:00 Mike Kienenberger:
let's upgrade our commons-collections
dependency to 3.2.2 as certain JSF configurations likely present
attack vectors.
https://issues.apache.org/jira/browse/COLLECTIONS-580
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (TOBAGO-1507) Unable to build Tobago without all-modules profile
[ https://issues.apache.org/jira/browse/TOBAGO-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1507. Resolution: Fixed > Unable to build Tobago without all-modules profile > -- > > Key: TOBAGO-1507 > URL: https://issues.apache.org/jira/browse/TOBAGO-1507 > Project: MyFaces Tobago > Issue Type: Bug >Reporter: Dennis Kieselhorst >Assignee: Dennis Kieselhorst >Priority: Minor > Fix For: 2.0.9 > > > Reported by G. Ann Campbell on the mailinglist: > http://myfaces.10567.n7.nabble.com/Tobago-problems-building-td120745.html > Sources jar is required by sandbox so this should be build not only in > all-modules profile -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TOBAGO-1507) Unable to build Tobago without all-modules profile
Dennis Kieselhorst created TOBAGO-1507: -- Summary: Unable to build Tobago without all-modules profile Key: TOBAGO-1507 URL: https://issues.apache.org/jira/browse/TOBAGO-1507 Project: MyFaces Tobago Issue Type: Bug Reporter: Dennis Kieselhorst Assignee: Dennis Kieselhorst Priority: Minor Reported by G. Ann Campbell on the mailinglist: http://myfaces.10567.n7.nabble.com/Tobago-problems-building-td120745.html Sources jar is required by sandbox so this should be build not only in all-modules profile -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (TOBAGO-1505) NPE while rendering Session Secret
[ https://issues.apache.org/jira/browse/TOBAGO-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-1505. Resolution: Fixed > NPE while rendering Session Secret > -- > > Key: TOBAGO-1505 > URL: https://issues.apache.org/jira/browse/TOBAGO-1505 > Project: MyFaces Tobago > Issue Type: New Feature >Reporter: Udo Schnurpfeil >Assignee: Dennis Kieselhorst > Fix For: 3.0.0-alpha-1, 2.0.9 > > > Can be checked for null. > Its no problem, for security reasons. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-4011) Old namespaces in tld-files
[ https://issues.apache.org/jira/browse/MYFACES-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733420#comment-14733420 ] Dennis Kieselhorst commented on MYFACES-4011: - I agree that this is an Eclipse issue. Thanks for the related link, I commented on that issue. > Old namespaces in tld-files > --- > > Key: MYFACES-4011 > URL: https://issues.apache.org/jira/browse/MYFACES-4011 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 2.2.8 > Environment: Eclipse >Reporter: Kristian Jörg >Assignee: Dennis Kieselhorst > Fix For: 2.2.9 > > Attachments: MYFACES_4011.patch > > > Myfaces 2.2.8 does not support the new namespaces in TLD files i.e > xmlns:f="http://xmlns.jcp.org/jsf/core"; > xmlns:h="http://xmlns.jcp.org/jsf/html"; > xmlns:jl="http://xmlns.jcp.org/jsf/composite/jsflive"; > In Eclipse, which autoloads namespace definitions from JAR files, I get > "Can't find facelet tag library for uri http://xmlns.jcp.org/jsf/core";. The > TLD files that are contained in Myfaces 2.2.8 corresponds to JSF 2.1, and > does not include f:viewAction. > I've seen that the code for viewAction is there in the 2.2.8 impl jars. The > problem is that the TLD file does not list it so I can't use it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-4011) Old namespaces in tld-files
[ https://issues.apache.org/jira/browse/MYFACES-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730466#comment-14730466 ] Dennis Kieselhorst commented on MYFACES-4011: - Ok I've commited the change, please try the latest snapshot: https://repository.apache.org/content/groups/snapshots/org/apache/myfaces/core/myfaces-impl/2.2.9-SNAPSHOT/myfaces-impl-2.2.9-20150904.074527-95.jar > Old namespaces in tld-files > --- > > Key: MYFACES-4011 > URL: https://issues.apache.org/jira/browse/MYFACES-4011 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 2.2.8 > Environment: Eclipse >Reporter: Kristian Jörg > Fix For: 2.2.9 > > Attachments: MYFACES_4011.patch > > > Myfaces 2.2.8 does not support the new namespaces in TLD files i.e > xmlns:f="http://xmlns.jcp.org/jsf/core"; > xmlns:h="http://xmlns.jcp.org/jsf/html"; > xmlns:jl="http://xmlns.jcp.org/jsf/composite/jsflive"; > In Eclipse, which autoloads namespace definitions from JAR files, I get > "Can't find facelet tag library for uri http://xmlns.jcp.org/jsf/core";. The > TLD files that are contained in Myfaces 2.2.8 corresponds to JSF 2.1, and > does not include f:viewAction. > I've seen that the code for viewAction is there in the 2.2.8 impl jars. The > problem is that the TLD file does not list it so I can't use it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-4011) Old namespaces in tld-files
[ https://issues.apache.org/jira/browse/MYFACES-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726892#comment-14726892 ] Dennis Kieselhorst commented on MYFACES-4011: - Please take a look at META-INF/schema/myfaces_facelets_core_2_1.xsd of myfaces-impl.jar - viewAction is part of this. In addition I've attached a patch that generates a myfaces_facelets_core_2_2.xsd with the new namespace. I've not commited it yet because I'm not sure if it's really needed. MyFaces is handling the new namespace http://xmlns.jcp.org/jsf/ correctly, the old http://java.sun.com/jsf is treated as alias. > Old namespaces in tld-files > --- > > Key: MYFACES-4011 > URL: https://issues.apache.org/jira/browse/MYFACES-4011 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 2.2.8 > Environment: Eclipse >Reporter: Kristian Jörg > Attachments: MYFACES_4011.patch > > > Myfaces 2.2.8 does not support the new namespaces in TLD files i.e > xmlns:f="http://xmlns.jcp.org/jsf/core"; > xmlns:h="http://xmlns.jcp.org/jsf/html"; > xmlns:jl="http://xmlns.jcp.org/jsf/composite/jsflive"; > In Eclipse, which autoloads namespace definitions from JAR files, I get > "Can't find facelet tag library for uri http://xmlns.jcp.org/jsf/core";. The > TLD files that are contained in Myfaces 2.2.8 corresponds to JSF 2.1, and > does not include f:viewAction. > I've seen that the code for viewAction is there in the 2.2.8 impl jars. The > problem is that the TLD file does not list it so I can't use it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-4011) Old namespaces in tld-files
[ https://issues.apache.org/jira/browse/MYFACES-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726866#comment-14726866 ] Dennis Kieselhorst commented on MYFACES-4011: - I agree that we should fix this as soon as possible, but in my view it's not a Blocker. > Old namespaces in tld-files > --- > > Key: MYFACES-4011 > URL: https://issues.apache.org/jira/browse/MYFACES-4011 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 2.2.8 > Environment: Eclipse >Reporter: Kristian Jörg >Priority: Blocker > > Myfaces 2.2.8 does not support the new namespaces in TLD files i.e > xmlns:f="http://xmlns.jcp.org/jsf/core"; > xmlns:h="http://xmlns.jcp.org/jsf/html"; > xmlns:jl="http://xmlns.jcp.org/jsf/composite/jsflive"; > In Eclipse, which autoloads namespace definitions from JAR files, I get > "Can't find facelet tag library for uri http://xmlns.jcp.org/jsf/core";. The > TLD files that are contained in Myfaces 2.2.8 corresponds to JSF 2.1, and > does not include f:viewAction. > I've seen that the code for viewAction is there in the 2.2.8 impl jars. The > problem is that the TLD file does not list it so I can't use it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MYFACES-4002) Regression? - References to external entities not working with WebXmlParser
[
https://issues.apache.org/jira/browse/MYFACES-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14723197#comment-14723197
]
Dennis Kieselhorst commented on MYFACES-4002:
-
The file Jetty couldn't find was /example/demo/webxml/context-params.xml
(stated with absolute location). Actually the WEB-INF is missing to resolve the
path in filesystem.
> Regression? - References to external entities not working with WebXmlParser
> ---
>
> Key: MYFACES-4002
> URL: https://issues.apache.org/jira/browse/MYFACES-4002
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.4
> Environment: Myfaces 2.2.4, Tomcat 8.0.23, JDK 1.8_20, Windows 7 64bit
>Reporter: Thomas Timbul
> Attachments: patch1.txt
>
>
> I've searched JIRA and there are a few issues related to WebXmlParser, but
> this seems almost like a recurrence of MYFACES-1754.
> My web.xml is split into multiple files, each declared as an XML entity
> relative to the web.xml file itself:
> {code:xml}
>
> {code}
> (As a side note I used to use
> {{jndi:/localhost/WEB-INF/webxml/context-params.xml}}, but for some reason
> Tomcat 8 claims that jndi is an invalid protocol).
> Using resource relative system identifiers Tomcat is now happy and the
> context starts correctly. However, during its initialization MyFaces
> re-parses the web.xml descriptor and resolves the entities incorrectly,
> leading to failure with the message:
> {code}
> 2015-06-17 15:48:13.853 [localhost-startStop-1] ERROR
> o.a.m.s.w.webxml.WebXmlParser - Unable to parse web.xml
> java.lang.IllegalArgumentException: The resource path
> [file:///WEB-INF/webxml/context-params.xml] is not valid
> {code}
> The solution is to remove the file:// prefix before passing to the external
> context to resolve, as in this patch:
> {code}
> Index: org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
> ===
> --- WebXmlParser.java (revision ???)
> +++ WebXmlParser.java (working copy)
> @@ -138,6 +138,9 @@
>
> private InputSource createContextInputSource(String publicId, String
> systemId)
> {
> +if(systemId.startsWith("file:")) {
> +systemId = systemId.substring(7); // remove file://
> +}
> InputStream inStream = _context.getResourceAsStream(systemId);
> if (inStream == null)
> {
> {code}
> Those three lines of code are based on other work by the MyFaces team
> (org.apache.myfaces.config.impl.FacesConfigEntityResolver) and even if it
> weren't is made available free of charge and free from license restrictions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MYFACES-4002) Regression? - References to external entities not working with WebXmlParser
[
https://issues.apache.org/jira/browse/MYFACES-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718339#comment-14718339
]
Dennis Kieselhorst commented on MYFACES-4002:
-
As far as I can see there were no significant changes in WebXmlParser. I tried
it with latest 2.0.x release and the same error occurred. So I think it's more
a change of dependencies (e.g. XML parser) or environment (servlet container).
I also tried your example with Jetty and Jetty itself was not even able to
parse the file:
{noformat}
java.io.FileNotFoundException
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.(FileInputStream.java:146)
at java.io.FileInputStream.(FileInputStream.java:101)
at
sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
at
sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:619)
at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.startEntity(XMLEntityManager.java:1297)
at
com.sun.org.apache.xerces.internal.impl.XMLEntityManager.startEntity(XMLEntityManager.java:1234)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanEntityReference(XMLDocumentFragmentScannerImpl.java:1908)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3067)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
at
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
at
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
at
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
at
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
at
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:648)
at
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:332)
at org.eclipse.jetty.xml.XmlParser.parse(XmlParser.java:252)
{noformat}
So a hack in MyFaces would just fix a particular setup but not the whole issue.
As I'm also not aware of possible side effects I will not apply your patch but
leaving this issue open for a while to allow comments from other team members.
> Regression? - References to external entities not working with WebXmlParser
> ---
>
> Key: MYFACES-4002
> URL: https://issues.apache.org/jira/browse/MYFACES-4002
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.4
> Environment: Myfaces 2.2.4, Tomcat 8.0.23, JDK 1.8_20, Windows 7 64bit
>Reporter: Thomas Timbul
> Attachments: patch1.txt
>
>
> I've searched JIRA and there are a few issues related to WebXmlParser, but
> this seems almost like a recurrence of MYFACES-1754.
> My web.xml is split into multiple files, each declared as an XML entity
> relative to the web.xml file itself:
> {code:xml}
>
> {code}
> (As a side note I used to use
> {{jndi:/localhost/WEB-INF/webxml/context-params.xml}}, but for some reason
> Tomcat 8 claims that jndi is an invalid protocol).
> Using resource relative system identifiers Tomcat is now happy and the
> context starts correctly. However, during its initialization MyFaces
> re-parses the web.xml descriptor and resolves the entities incorrectly,
> leading to failure with the message:
> {code}
> 2015-06-17 15:48:13.853 [localhost-startStop-1] ERROR
> o.a.m.s.w.webxml.WebXmlParser - Unable to parse web.xml
> java.lang.IllegalArgumentException: The resource path
> [file:///WEB-INF/webxml/context-params.xml] is not valid
> {code}
> The solution is to remove the file:// prefix before passing to the external
> context to resolve, as in this patch:
> {code}
> Index: org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
> ===
> --- WebXmlParser.java (revision ???)
> +++ WebXmlParser.java (working copy)
> @@ -138,6 +138,9 @@
>
> private InputSource createContextInputSource(String publicId, String
> systemId)
> {
> +if(systemId.startsWith("file:")) {
> +systemId = systemId.substring(7); // remove file://
[jira] [Commented] (MYFACES-4002) Regression? - References to external entities not working with WebXmlParser
[
https://issues.apache.org/jira/browse/MYFACES-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706420#comment-14706420
]
Dennis Kieselhorst commented on MYFACES-4002:
-
Could you please attach an example of a web.xml with this !ENTITY reference?
Btw servlet API 3.0 supports web-fragment. Which version are you using?
> Regression? - References to external entities not working with WebXmlParser
> ---
>
> Key: MYFACES-4002
> URL: https://issues.apache.org/jira/browse/MYFACES-4002
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.2.4
> Environment: Myfaces 2.2.4, Tomcat 8.0.23, JDK 1.8_20, Windows 7 64bit
>Reporter: Thomas Timbul
> Attachments: patch1.txt
>
>
> I've searched JIRA and there are a few issues related to WebXmlParser, but
> this seems almost like a recurrence of MYFACES-1754.
> My web.xml is split into multiple files, each declared as an XML entity
> relative to the web.xml file itself:
> {code:xml}
>
> {code}
> (As a side note I used to use
> {{jndi:/localhost/WEB-INF/webxml/context-params.xml}}, but for some reason
> Tomcat 8 claims that jndi is an invalid protocol).
> Using resource relative system identifiers Tomcat is now happy and the
> context starts correctly. However, during its initialization MyFaces
> re-parses the web.xml descriptor and resolves the entities incorrectly,
> leading to failure with the message:
> {code}
> 2015-06-17 15:48:13.853 [localhost-startStop-1] ERROR
> o.a.m.s.w.webxml.WebXmlParser - Unable to parse web.xml
> java.lang.IllegalArgumentException: The resource path
> [file:///WEB-INF/webxml/context-params.xml] is not valid
> {code}
> The solution is to remove the file:// prefix before passing to the external
> context to resolve, as in this patch:
> {code}
> Index: org/apache/myfaces/shared_impl/webapp/webxml/WebXmlParser.java
> ===
> --- WebXmlParser.java (revision ???)
> +++ WebXmlParser.java (working copy)
> @@ -138,6 +138,9 @@
>
> private InputSource createContextInputSource(String publicId, String
> systemId)
> {
> +if(systemId.startsWith("file:")) {
> +systemId = systemId.substring(7); // remove file://
> +}
> InputStream inStream = _context.getResourceAsStream(systemId);
> if (inStream == null)
> {
> {code}
> Those three lines of code are based on other work by the MyFaces team
> (org.apache.myfaces.config.impl.FacesConfigEntityResolver) and even if it
> weren't is made available free of charge and free from license restrictions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (TOBAGO-335) and Double object in backing bean
[
https://issues.apache.org/jira/browse/TOBAGO-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved TOBAGO-335.
---
Resolution: Won't Fix
This is not a Tobago specific issue.
> and Double object in backing bean
> -
>
> Key: TOBAGO-335
> URL: https://issues.apache.org/jira/browse/TOBAGO-335
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.0.10
>Reporter: Guido Dubois
>
> If you need to clear an input field, the easiest way is to use an object type
> like String, Date or Double. So you can set it simply to null and the field
> will be cleared. But in case of Double there will be a problem with
> .
> In RI there is the same problem. See issue
> https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=286 for more
> details.
> This workaround helps:
>
>
>
> ...
> private Number f1;
> private Double f1double;
> ...
> public Number getF1() {
> return f1double;
> }
> public void setF1(Number f1) {
> this.f1double = f1.doubleValue();
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (TOBAGO-270) APT option values passed to the APT compiler are wrong: -Akey=value => -Akey=value=null
[
https://issues.apache.org/jira/browse/TOBAGO-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Kieselhorst resolved TOBAGO-270.
---
Resolution: Not A Problem
This is not causing any issues in Tobago.
> APT option values passed to the APT compiler are wrong: -Akey=value =>
> -Akey=value=null
> ---
>
> Key: TOBAGO-270
> URL: https://issues.apache.org/jira/browse/TOBAGO-270
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
>Affects Versions: 1.0.9
>Reporter: Thierry Monney
>Assignee: Dennis Kieselhorst
>
> When APT options are specified, the plugin does not split the supplied
> options as quiet=true (as one would expect it). Instead, the annotation
> processor's environment gets an option of the type quiet=true=null, where
> quiet=true is the actual key and null is the actual value.
> For example, -Aquiet=true ends up as -Aquiet=true=null. The same
> happens whether -A is explicit or not.
> The workaround is to manually parse the key in the annotation processor, e.g.,
> String value = null;
> Set keys = env.getOptions().keySet();
> for (String key : keys) {
> if (key.startsWith(optionName)) {
> int index = key.indexOf('=');
> if (index > 0) {
> value = key.substring(index + 1, key.length());
> }
> break;
> }
> }
> I am not sure whether this is a bug in the Maven plugin, in Plexus command
> line lib or even in APT itself. Currently I haven't too much time to
> seriously dig into it, but I will try to narrow things down a little and give
> more precisions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TOBAGO-128) Using an image in a menu tag creates the image below the menu text
[
https://issues.apache.org/jira/browse/TOBAGO-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704522#comment-14704522
]
Dennis Kieselhorst commented on TOBAGO-128:
---
The issue still exists, just the tags in the example code need to be changed to
tc:menu/ tc:menubar. I don't need icons on top level either but why not fixing
it?
> Using an image in a menu tag creates the image below the menu text
> --
>
> Key: TOBAGO-128
> URL: https://issues.apache.org/jira/browse/TOBAGO-128
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Themes
>Affects Versions: 1.0.8
> Environment: Windows XP, Tomcat 5.5, Speyside Theme (others not
> tested)
>Reporter: Carsten Dimmek
>Priority: Trivial
> Attachments: menu.gif, menu_err.jpg
>
>
> If you user the image attribute in the menu component, the image is created
> below the text.
> Example Code:
>
> label="#{msg.menuUserInfo}" />
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (TOBAGO-251) JSR 276: Design-Time Metadata
[ https://issues.apache.org/jira/browse/TOBAGO-251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Kieselhorst resolved TOBAGO-251. --- Resolution: Won't Fix https://jcp.org/en/jsr/detail?id=276 Closing this as status of the JSR is dormant. > JSR 276: Design-Time Metadata > - > > Key: TOBAGO-251 > URL: https://issues.apache.org/jira/browse/TOBAGO-251 > Project: MyFaces Tobago > Issue Type: Improvement >Reporter: Bernd Bohmann >Priority: Minor > > https://jsf-metadata-spec-public.dev.java.net/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
