[jira] [Created] (MYFACES-3857) Unbalanced pushComponentToEL/popComponentFromEL in processUpdates

2014-02-16 Thread James G (JIRA)
James G created MYFACES-3857:


 Summary: Unbalanced pushComponentToEL/popComponentFromEL in 
processUpdates
 Key: MYFACES-3857
 URL: https://issues.apache.org/jira/browse/MYFACES-3857
 Project: MyFaces Core
  Issue Type: Bug
  Components: JSR-314
Affects Versions: 2.1.14
 Environment: Linux, Tomcat 7
Reporter: James G


I discovered this through some complicated use of composite components but the 
issue is that during process updates if a component is not rendered 
(rendered=false) then it is pushed on the component stack but never popped.  
This bug has existed since version 2.1.2.
The affected method is 
javax.faces.component.UIComponentBase.processUpdates(FacesContext)

The code is
...
pushComponentToEL(context, this);
if (_isPhaseExecutable(context))
{
...
popComponentFromEL(context);
}
...




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (MYFACES-3854) oam-compress-spaces remove carriage return / line feed in CDATA sections

2014-02-14 Thread James G (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901484#comment-13901484
 ] 

James G commented on MYFACES-3854:
--

My suggestion would be: not remove any spaces inside the CDATA sections.  This 
will preserve any intentional spacing and CDATA sections are fairly rare in jsf.

 oam-compress-spaces remove carriage return / line feed in CDATA sections
 

 Key: MYFACES-3854
 URL: https://issues.apache.org/jira/browse/MYFACES-3854
 Project: MyFaces Core
  Issue Type: Bug
  Components: JSR-314
Affects Versions: 2.1.14
 Environment: Linux, tomcat 7
Reporter: James G

 When the oam-compress-spaces option removes spaces in a CDATA section it 
 can cause problems with the generated code.  For example, I sometimes do:
 script type=text/javascript
 //![CDATA[
 someJavascript();
 //]]
 /script
 If there happens to be a space after //![CDATA[, then it comes out:
 script type=text/javascript
 //![CDATA[ someJavascript();
 //]]/script
 so someJavascript() is not called by the browser.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Created] (MYFACES-3854) oam-compress-spaces don't remove spaces in CDATA sections

2014-02-13 Thread James G (JIRA)
James G created MYFACES-3854:


 Summary: oam-compress-spaces don't remove spaces in CDATA sections
 Key: MYFACES-3854
 URL: https://issues.apache.org/jira/browse/MYFACES-3854
 Project: MyFaces Core
  Issue Type: Bug
  Components: JSR-314
Affects Versions: 2.1.14
 Environment: Linux, tomcat 7
Reporter: James G


When the oam-compress-spaces option removes spaces in a CDATA section it can 
cause problems with the generated code.  For example, I sometimes do:
script type=text/javascript
//![CDATA[
someJavascript();
//]]



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Created] (MYFACES-3769) Support method invoking on parent composite components

2013-08-30 Thread James G (JIRA)
James G created MYFACES-3769:


 Summary: Support method invoking on parent composite components
 Key: MYFACES-3769
 URL: https://issues.apache.org/jira/browse/MYFACES-3769
 Project: MyFaces Core
  Issue Type: Improvement
Affects Versions: 2.1.12
 Environment: tomcat 7.0.41, jboss el 2.2, linux
Reporter: James G


You are able to access properties of a parent composite component while in a 
child composite component using the el syntax #{cc.parent.attrs.propName} but 
method invoking does not work.  e.g. action=#{cc.parent.attrs.saveAction}.  
It can make sense to specify a method in the parent cc that child cc's would 
like to invoke.  I think this is a relatively easy change to the regular 
expressions in the CompositeComponentELUtils class to support one or more 
.parent within method expressions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (MYFACES-3206) ui:repeat loses varStatus during save/restore state

2011-07-05 Thread James G (JIRA)
ui:repeat loses varStatus during save/restore state
---

 Key: MYFACES-3206
 URL: https://issues.apache.org/jira/browse/MYFACES-3206
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.0.7
 Environment: MyFaces 2.0.7, Richfaces 4.0, Tomcat 6
Reporter: James G


If you use a ui:repeat with the varStatus set then the varStatus is lost during 
an ajax call.
for example:
h:panelGroup id=myPanel
  ui:repeat value=#{repeatOver} 
   id=repeatID
 var=v
   varStatus=vStatus
h:outputText value=vStatus.index /
  /ui:repeat
/h:panelGroup

If you invoke an ajax call which renders myPanel then the vStatus variable is 
now null.
If you look at org.apache.myfaces.view.facelets.component.UIRepeat the 
restoreState and saveState methods save _var but not _varStatus.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (MYFACES-3164) jsf.js:javascript error this.Lang is not defined

2011-06-01 Thread James G (JIRA)
jsf.js:javascript error this.Lang is not defined


 Key: MYFACES-3164
 URL: https://issues.apache.org/jira/browse/MYFACES-3164
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 2.0.6
 Environment: Myfaces 2.0.6, Richfaces 4.0.Final, Tomcat 6
Reporter: James G
Priority: Minor


javascript error this.Lang is not defined.
See _BaseRequest.js line 204.
I think it's supposed to be this._Lang

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (MYFACES-3162) AJAX Broken when State Caching Mechanics turned off

2011-05-31 Thread James G (JIRA)
AJAX Broken when State Caching Mechanics turned off
---

 Key: MYFACES-3162
 URL: https://issues.apache.org/jira/browse/MYFACES-3162
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 2.0.6
 Environment: MyFaces 2.0.6, RichFaces 4.0.Final, Tomcat 6
Reporter: James G


When the web configuration param 
org.apache.myfaces.HANDLE_STATE_CACHING_MECHANICS is set to false, after the 
first ajax call, all further ajax calls fail.  The failure occurs with a 
ViewExpiredException on the next ajax call.  The reason is that the sequence 
number part of the view state is being lost during the first ajax call.  (See 
HtmlResponseStateManager.getViewState() where baseState is lost when 
isHandlingStateCachingMechanics(facesContext) returns false.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (MYFACES-3131) jsf.js:tables not rendering after ajax call in internet explorer 6

2011-05-09 Thread James G (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13030880#comment-13030880
 ] 

James G commented on MYFACES-3131:
--

Thanks for fixing this!!

 jsf.js:tables not rendering after ajax call in internet explorer 6
 --

 Key: MYFACES-3131
 URL: https://issues.apache.org/jira/browse/MYFACES-3131
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.0.5
 Environment: Tomcat 6 / Myfaces 2.0.5 and Richfaces 4.0.0.Final
 Internet Explorer 6 as client
Reporter: James G
 Fix For: 2.0.6-SNAPSHOT, 2.1.0-SNAPSHOT


 objects that start with table disappear when they are selected for render 
 during an ajax call.
 I debugged the problem and found it occurs in the _outerHTMLNonCompliant 
 function.  When tagName is table, _buildTableNodes is called (it really 
 shouldn't be called in this case).
 In _buildTableNodes, dummyPlaceHolder.innerHTML is set to 
 tabletableSTUFF/table/table.
 ie6 changes this to tabletbody/tbodytableSTUFF/table/table so 
 evalNodes is set to the empty tbody and thus the table sent back from the 
 server is lost.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (MYFACES-3131) tables not rendering after ajax call in internet explorer 6

2011-05-06 Thread James G (JIRA)
tables not rendering after ajax call in internet explorer 6
---

 Key: MYFACES-3131
 URL: https://issues.apache.org/jira/browse/MYFACES-3131
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.0.5
 Environment: Tomcat 6 / Myfaces 2.0.5 and Richfaces 4.0.0.Final
Internet Explorer 6 as client
Reporter: James G


objects that start with table disappear when they are selected for render 
during an ajax call.
I debugged the problem and found it occurs in the _outerHTMLNonCompliant 
function.  When tagName is table, _buildTableNodes is called (it really 
shouldn't be called in this case).
In _buildTableNodes, dummyPlaceHolder.innerHTML is set to 
tabletableSTUFF/table/table.
ie6 changes this to tabletbody/tbodytableSTUFF/table/table so 
evalNodes is set to the empty tbody and thus the table sent back from the 
server is lost.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira