[jira] [Commented] (MYFACES-3459) RegexValidator does not provide label and pattern for first usage of RegexValidator.NOT_MATCHED
[
https://issues.apache.org/jira/browse/MYFACES-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13217052#comment-13217052
]
Keith Wong commented on MYFACES-3459:
-
Will the translation be accepted?
RegexValidator does not provide label and pattern for first usage of
RegexValidator.NOT_MATCHED
---
Key: MYFACES-3459
URL: https://issues.apache.org/jira/browse/MYFACES-3459
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.1.5
Environment: myfaces trunk
Reporter: Martin Kočí
Assignee: Martin Kočí
Priority: Trivial
Attachments: MYFACES-3459.patch, myfaces-1244836.patch
RegexValidator uses javax.faces.validator.RegexValidator.NOT_MATCHED 2x:
javax.faces.validator.RegexValidator.NOT_MATCHED= the passed value is not a
String, or when the pattern does not match the passed value.
the first usage for if (value instanceof String) check does not provide
args for {0} {1} in message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3438) jsf.js: error handling output improvement
[ https://issues.apache.org/jira/browse/MYFACES-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193946#comment-13193946 ] Keith Wong commented on MYFACES-3438: - Will the translation be accepted? jsf.js: error handling output improvement - Key: MYFACES-3438 URL: https://issues.apache.org/jira/browse/MYFACES-3438 Project: MyFaces Core Issue Type: Improvement Affects Versions: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT Reporter: Werner Punz Assignee: Werner Punz Priority: Minor Fix For: 2.0.12-SNAPSHOT, 2.1.6-SNAPSHOT Attachments: myfaces-1229093.patch While we already have improved the error reporting a lot. We still have room for improvement. For instance the error alert could need some room for improvement, we should also report the faulty http codes in case of a http error etc... Also we should discuss whether we really should use the alert if there is a console present. (would make more sense to push error reports into the console on newer browsers if present) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3385) Entered values for input fields conatined in a Composite Component are lost, if the CC is used in a datatable
[
https://issues.apache.org/jira/browse/MYFACES-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146744#comment-13146744
]
Keith Wong commented on MYFACES-3385:
-
I want to make a note that this issue also affects the components that using
facets to store input components such as p:cellEditor of PrimeFaces. For
example,
p:dataTable var=customer value=#{customers}
p:column headerText=First Name
p:cellEditor
f:facet name=output
h:outputText value=#{customer.firstName}/
/f:facet
f:facet name=input
p:inputText value=#{customer.firstName}/
/f:facet
/p:cellEditor
/p:column
p:column headerText=Options
p:rowEditor/
/p:column
/p:dataTable
In this case, the first row is always be overwritten by the last row whatever
which row is editing. See
http://forum.primefaces.org/viewtopic.php?f=3t=15349 for further discussion.
Entered values for input fields conatined in a Composite Component are lost,
if the CC is used in a datatable
-
Key: MYFACES-3385
URL: https://issues.apache.org/jira/browse/MYFACES-3385
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 2.1.2
Reporter: Michael Dietrich
Assignee: Leonardo Uribe
Priority: Critical
Fix For: 2.0.10, 2.1.4
Attachments: MYFACES-3385-1.patch, MyFacesCCUIData212Test.war
Assume, a Composite Component contains input fields, i.e any subclass of
EditableValueHolder (e.g. inputText, inputTextarea, ..). If this CC is than
used in a subclass of UIData, e.g. a dataTable, the values entered in the CCs
input fields get lost (despite for the last row in the Model of the UIData
object).
This seems to be related to the fact how the method
saveDescendantComponentStates(..) of the UIData class checks, if a
component has childs, whos state must be saved, before changing the rowIndex.
The mentioned method only checks child.getChildCount() 0, but
getChildCount() is 0 for a CC. I assume it would be necessary to check the
FacetCount for a CC instead.
The attached WAR file can help to reproduce the issue with a simple example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3358) Flash created in ExceptionHandler not work
[
https://issues.apache.org/jira/browse/MYFACES-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13146753#comment-13146753
]
Keith Wong commented on MYFACES-3358:
-
I do agree that it is not clear in the spec that how the lifecycle of a flash
would be. But I think this case should work in the mojarra implementation.
After investigation, I found that the following changes in
org.apache.myfaces.lifecycle.LifecycleImpl could handle the flash in this case:
@Override
public void render(FacesContext facesContext) throws FacesException
{
//try
//{
// if the response is complete we should not be invoking the phase
listeners
if (isResponseComplete(facesContext, renderExecutor.getPhase(),
true))
{
facesContext.setCurrentPhaseId(renderExecutor.getPhase());
Flash flash = facesContext.getExternalContext().getFlash();
flash.doPrePhaseActions(facesContext);
flash.doPostPhaseActions(facesContext);
return;
}
...
Flash created in ExceptionHandler not work
--
Key: MYFACES-3358
URL: https://issues.apache.org/jira/browse/MYFACES-3358
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.1.3
Environment: WebSphere 8.0
Reporter: Keith Wong
Assignee: Leonardo Uribe
I have a custom ExceptionHandler for handling ViewExpiredException as
occurred in session timeout or application restart. I have to tell the user
in the redirected page the reason for being redirected. Here is the handler:
public void handle() throws FacesException {
for (IteratorExceptionQueuedEvent
i=getUnhandledExceptionQueuedEvents().iterator(); i.hasNext(); ) {
ExceptionQueuedEventContext context =
i.next().getContext();
Throwable t = context.getException();
if (t instanceof ViewExpiredException) {
FacesContext ctx =
FacesContext.getCurrentInstance();
ViewExpiredException vee =
(ViewExpiredException)t;
try {
ctx.addMessage(null, new
FacesMessage(FacesMessage.SEVERITY_ERROR, vee.getClass().getName(),
vee.getMessage()));
Flash flash =
ctx.getExternalContext().getFlash();
flash.put(expiredViewId,
vee.getViewId());
flash.setKeepMessages(true);
ctx.getApplication().getNavigationHandler().handleNavigation(ctx, null,
/login?faces-redirect=true);
ctx.renderResponse();
}
finally {
i.remove();
}
}
}
super.handle();
}
In the login.xhtml, it has #{flash.expiredViewId} and f:messages but both
are empty when displayed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3361) jsf.js: code restructuration for size and speed improvlements
[ https://issues.apache.org/jira/browse/MYFACES-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140871#comment-13140871 ] Keith Wong commented on MYFACES-3361: - It seems Messages_zh_HK.js is missing in the change set #1190363 and #1190364. jsf.js: code restructuration for size and speed improvlements - Key: MYFACES-3361 URL: https://issues.apache.org/jira/browse/MYFACES-3361 Project: MyFaces Core Issue Type: Improvement Affects Versions: 2.0.10-SNAPSHOT, 2.1.4-SNAPSHOT Reporter: Werner Punz Assignee: Werner Punz Fix For: 2.0.10, 2.1.4 Attachments: Adding_modular_jsf_js_support_.patch h2. Currently we have one big jsf.js file with all code in * *core* which implements all of the spec * *i18n* which implements the language messages for currently 7 languages * *experimental* which implements features targetted for jsf 2.2 onwards * *quirksmode* code which supports non standard compliant browsers The idea is to still keep one big file, but also provide several files which partially can be mixed to achieve the functionality needed h2. We are going to allow * one big file which resembles our current jsf.js * a base file which resembles the core + quirksmode * a modern browser file which resembles the core only without quirksmode code * a separate i18n file for the i18n messages * a legacy file for quirksmode browsers * an experimental file with all non standard features combined In the end the plan is to allow the users to mix those feature sets to reduce the import size while still retaining all the existing functionality. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
