[jira] Created: (MYFACES-1710) Improve performance by using Trove fast collections (as optional)
Improve performance by using Trove fast collections (as optional) - Key: MYFACES-1710 URL: https://issues.apache.org/jira/browse/MYFACES-1710 Project: MyFaces Core Issue Type: Improvement Components: General Affects Versions: 1.2.0, 1.2.1-SNAPSHOT Environment: all Reporter: Mikhail Grushinskiy Fix For: 1.2.1-SNAPSHOT Improve performance by using Trove (Trove4J) fast collections (as optional) http://trove4j.sourceforge.net/ Trove4J can be made optional like this: http://www.onjava.com/pub/a/onjava/2002/06/12/trove.html?page=2 I believe it is not that difficult to implement and results would be easy to compare... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-674) ConcurrentModificationException in ScheduleModel.load on access to 'days' TreeMap
ConcurrentModificationException in ScheduleModel.load on access to 'days'
TreeMap
-
Key: TOMAHAWK-674
URL: http://issues.apache.org/jira/browse/TOMAHAWK-674
Project: MyFaces Tomahawk
Issue Type: Bug
Components: Schedule
Environment: all
Reporter: Mikhail Grushinskiy
Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT, 1.1.3
ConcurrentModificationException in ScheduleModel.load on access to 'days'
TreeMap
AbstractSchedule model days TreeMap throws ConcurrentModificationException when
accessed from two requests at same time.
Caused by: java.util.ConcurrentModificationException
at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1031)
at java.util.TreeMap$KeyIterator.next(TreeMap.java:1058)
at com.jsfapp.web.faces.bean.ScheduleModel.load(ScheduleModel.java:204)
at com.jsfapp.web.faces.bean.ScheduleModel.setMonth(ScheduleModel.java:174)
at
org.apache.myfaces.custom.schedule.model.AbstractScheduleModel.setSelectedDate(AbstractScheduleModel.java:118)
at
org.apache.myfaces.custom.schedule.model.AbstractScheduleModel.refresh(AbstractScheduleModel.java:410)
Consider using this:
public static K,V SortedMapK,V synchronizedSortedMap(SortedMapK,V m)
Returns a synchronized (thread-safe) sorted map backed by the specified
sorted map. In order to guarantee serial access, it is critical that all access
to the backing sorted map is accomplished through the returned sorted map (or
its views).
It is imperative that the user manually synchronize on the returned sorted
map when iterating over any of its collection views, or the collections views
of any of its subMap, headMap or tailMap views.
SortedMap m = Collections.synchronizedSortedMap(new HashSortedMap());
...
Set s = m.keySet(); // Needn't be in synchronized block
...
synchronized(m) { // Synchronizing on m, not s!
Iterator i = s.iterator(); // Must be in synchronized block
while (i.hasNext())
foo(i.next());
}
or:
SortedMap m = Collections.synchronizedSortedMap(new HashSortedMap());
SortedMap m2 = m.subMap(foo, bar);
...
Set s2 = m2.keySet(); // Needn't be in synchronized block
...
synchronized(m) { // Synchronizing on m, not m2 or s2!
Iterator i = s.iterator(); // Must be in synchronized block
while (i.hasNext())
foo(i.next());
}
--MG
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-637) forceId on tomahawk components causes waring when running under facelets
forceId on tomahawk components causes waring when running under facelets Key: TOMAHAWK-637 URL: http://issues.apache.org/jira/browse/TOMAHAWK-637 Project: MyFaces Tomahawk Issue Type: Bug Components: ForceId Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Ex: t:div Property 'forceId' is not on type: org.apache.myfaces.custom.div.Div tomahawk.taglib.xml is in place --MG -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-638) Tomahawk Schedule style class attributes are ignored under facelets. (Ex: dayClass, entryClass, etc)
Tomahawk Schedule style class attributes are ignored under facelets. (Ex: dayClass, entryClass, etc) Key: TOMAHAWK-638 URL: http://issues.apache.org/jira/browse/TOMAHAWK-638 Project: MyFaces Tomahawk Issue Type: Bug Components: Schedule Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Tomahawk Schedule style class attributes are ignored under facelets. (Ex: dayClass, entryClass, etc) The following are warnings from facelets Property 'headerClass' is not on type: org.apache.myfaces.custom.schedule.HtmlSchedule Property 'dayClass' is not on type: org.apache.myfaces.custom.schedule.HtmlSchedule facelets 1.1.11 --MG -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-619) Add timeZone, firstDayOfWeek, minimalDaysInFirstWeek attributes to schedule component similar to java.util.Calendar
Add timeZone, firstDayOfWeek, minimalDaysInFirstWeek attributes to schedule component similar to java.util.Calendar --- Key: TOMAHAWK-619 URL: http://issues.apache.org/jira/browse/TOMAHAWK-619 Project: MyFaces Tomahawk Issue Type: Improvement Environment: All Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Add timeZone, firstDayOfWeek, minimalDaysInFirstWeek attributes to schedule component similar to java.util.Calendar. Currently there is no way to serve clients with schedule in different timezones and different preferences (as of starting week with Sunday vs Monday). I propose to add these 3 attributes ( timeZone, firstDayOfWeek, minimalDaysInFirstWeek) as in java.util.Calendar. --MG -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-614) Schedule for January is missing January 1, 2006
[ http://issues.apache.org/jira/browse/TOMAHAWK-614?page=comments#action_12430148 ] Mikhail Grushinskiy commented on TOMAHAWK-614: -- If I select January 1, 2006 as current date on weekly view it gives me week starting with January 2nd, which is clearly a bug. Schedule for January is missing January 1, 2006 --- Key: TOMAHAWK-614 URL: http://issues.apache.org/jira/browse/TOMAHAWK-614 Project: MyFaces Tomahawk Issue Type: Bug Components: Schedule Environment: all Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Attachments: AbstractScheduleModel.java.patch, AbstractScheduleModel.java.patch Schedule for January is missing January 1, 2006. Somehow January 1, 2006 is not appearing on January 2006 schedule (basically whole week ending with it is missing) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-614) Schedule for January is missing January 1, 2006
[
http://issues.apache.org/jira/browse/TOMAHAWK-614?page=comments#action_12430154
]
Mikhail Grushinskiy commented on TOMAHAWK-614:
--
Here sample code to fix it.
This is not a patch yet. Trick is in setting
calendar.setFirstDayOfWeek(Calendar.MONDAY);
calendar.setMinimalDaysInFirstWeek(1);
for every calendar used in a code. TimeZone has to be consistent and
configurable everywhere too.
I think getCalendar() should be moved into base abstract class for a
ScheduleModel and
AbstractScheduleModel should have gettter/setter for timeZone and
all places for schedule instead of doing GregorialCalendar.getInstance() we
should make a call
to model.getCalendar(). See code below
/**
* @return Calendar with settings
*/
public Calendar {
String userTimeZone = getTimeZone();
TimeZone tz = TimeZone.getTimeZone(userTimeZone);
Calendar calendar = GregorianCalendar.getInstance();
calendar.setTimeZone(tz);
calendar.setFirstDayOfWeek(Calendar.MONDAY);
calendar.setMinimalDaysInFirstWeek(1);
return calendar;
}
import java.util.Calendar;
import java.util.GregorianCalendar;
import java.util.TimeZone;
import java.io.Serializable;
import java.util.Collection;
import java.util.Date;
import java.util.Iterator;
import org.apache.myfaces.custom.schedule.model.SimpleScheduleModel;
import org.apache.myfaces.custom.schedule.model.ScheduleDay;
import org.apache.myfaces.custom.schedule.model.ScheduleEntry;
public class ScheduleModel extends SimpleScheduleModel implements
Serializable {
public static final String VER_ID=$Id$;
/**
* serialVersionUID
*/
private static final long serialVersionUID =
-7391783268115864166L;
private String timeZone = null;
public String getTimeZone() {
return timeZone;
}
public void setTimeZone(String timeZone) {
this.timeZone = timeZone;
}
/**
* @return Calendar with settings
*/
public Calendar getCalendar() {
String userTimeZone = getTimeZone();
TimeZone tz = TimeZone.getTimeZone(userTimeZone);
Calendar calendar = GregorianCalendar.getInstance();
calendar.setTimeZone(tz);
calendar.setFirstDayOfWeek(Calendar.MONDAY);
calendar.setMinimalDaysInFirstWeek(1);
return calendar;
}
/**
* p
* navigate to the specified week
* /p
*
* @param date
*the date to navigate to
*/
protected void setWeek(Date date) {
if (date == null) {
return;
}
clear();
Calendar cal = getCalendar();
cal.setTime(date);
// go back to the monday of this week
cal.set(Calendar.DAY_OF_WEEK, Calendar.MONDAY);
ScheduleDay firstDay = null;
ScheduleDay lastDay = null;
for (int i = 0; i 7; i++) {
ScheduleDay addedDay = add(cal.getTime());
if (firstDay == null) {
firstDay = addedDay;
}
lastDay = addedDay;
cal.add(Calendar.DATE, 1);
}
load(firstDay.getDayStart(), lastDay.getDayEnd());
}
/*
* (non-Javadoc)
*
* @see
org.apache.myfaces.custom.schedule.model.AbstractScheduleModel#setWorkWe
ek(java.util.Date)
*/
@Override
protected void setWorkWeek(Date date) {
if (date == null) {
return;
}
clear();
Calendar cal = getCalendar();
cal.setTime(date);
// go back to the monday of this week
cal.set(Calendar.DAY_OF_WEEK, Calendar.MONDAY);
ScheduleDay firstDay = null;
ScheduleDay lastDay = null;
for (int i = 0; i 5; i++) {
ScheduleDay addedDay = add(cal.getTime());
if (firstDay == null) {
firstDay = addedDay;
}
lastDay = addedDay;
cal.add(Calendar.DATE, 1);
}
load(firstDay.getDayStart(), lastDay.getDayEnd());
}
private void load(Date startDate, Date endDate) {
Collection entries = loadEntries(startDate, endDate);
for (Iterator entryIterator = entries.iterator();
entryIterator
.hasNext();) {
ScheduleEntry entry = (ScheduleEntry)
entryIterator.next();
[jira] Updated: (TOMAHAWK-614) Schedule for January is missing January 1, 2006
[ http://issues.apache.org/jira/browse/TOMAHAWK-614?page=all ] Mikhail Grushinskiy updated TOMAHAWK-614: - Status: Patch Available (was: Open) Schedule for January is missing January 1, 2006 --- Key: TOMAHAWK-614 URL: http://issues.apache.org/jira/browse/TOMAHAWK-614 Project: MyFaces Tomahawk Issue Type: Bug Components: Schedule Environment: all Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Attachments: AbstractScheduleModel.java.patch, AbstractScheduleModel.java.patch Schedule for January is missing January 1, 2006. Somehow January 1, 2006 is not appearing on January 2006 schedule (basically whole week ending with it is missing) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-614) Schedule for January is missing January 1, 2006
[ http://issues.apache.org/jira/browse/TOMAHAWK-614?page=all ] Mikhail Grushinskiy updated TOMAHAWK-614: - Status: Patch Available (was: Open) Schedule for January is missing January 1, 2006 --- Key: TOMAHAWK-614 URL: http://issues.apache.org/jira/browse/TOMAHAWK-614 Project: MyFaces Tomahawk Issue Type: Bug Components: Schedule Environment: all Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Attachments: AbstractScheduleModel.java.patch, AbstractScheduleModel.java.patch Schedule for January is missing January 1, 2006. Somehow January 1, 2006 is not appearing on January 2006 schedule (basically whole week ending with it is missing) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-614) Schedule for January is missing January 1, 2006
[ http://issues.apache.org/jira/browse/TOMAHAWK-614?page=all ] Mikhail Grushinskiy updated TOMAHAWK-614: - Status: Open (was: Patch Available) Schedule for January is missing January 1, 2006 --- Key: TOMAHAWK-614 URL: http://issues.apache.org/jira/browse/TOMAHAWK-614 Project: MyFaces Tomahawk Issue Type: Bug Components: Schedule Environment: all Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Attachments: AbstractScheduleModel.java.patch, AbstractScheduleModel.java.patch Schedule for January is missing January 1, 2006. Somehow January 1, 2006 is not appearing on January 2006 schedule (basically whole week ending with it is missing) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-621) Tomahawk DayRenderer move inner classes out make more methods protected vs private
Tomahawk DayRenderer move inner classes out make more methods protected vs private -- Key: TOMAHAWK-621 URL: http://issues.apache.org/jira/browse/TOMAHAWK-621 Project: MyFaces Tomahawk Issue Type: Improvement Components: Schedule Environment: all Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Tomahawk DayRenderer move inner classes out make more methods protected vs private It is not easy to extend this class. Many private methods and inner classes lead to code replication in subclass. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-614) Schedule for January is missing January 1, 2006
Schedule for January is missing January 1, 2006 --- Key: TOMAHAWK-614 URL: http://issues.apache.org/jira/browse/TOMAHAWK-614 Project: MyFaces Tomahawk Issue Type: Bug Components: Schedule Environment: all Reporter: Mikhail Grushinskiy Priority: Minor Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Schedule for January is missing January 1, 2006. Somehow January 1, 2006 is not appearing on January 2006 schedule (basically whole week ending with it is missing) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-599) Allow displaying week starting from Sunday (on weekly and monthly views)
Allow displaying week starting from Sunday (on weekly and monthly views) Key: TOMAHAWK-599 URL: http://issues.apache.org/jira/browse/TOMAHAWK-599 Project: MyFaces Tomahawk Issue Type: Improvement Components: Schedule Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Environment: All Reporter: Mikhail Grushinskiy Allow displaying week starting from Sunday (on weekly and monthly views). Maybe a new attribute to a tag is needed. --MG -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-601) t:column width and style attributes are ignored within t:panelGrid
t:column width and style attributes are ignored within t:panelGrid -- Key: TOMAHAWK-601 URL: http://issues.apache.org/jira/browse/TOMAHAWK-601 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT Environment: all Reporter: Mikhail Grushinskiy t:column width and style attribute are ignored within t:panelGrid -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-470) Add ability to set initial state of all details as expanded for master/detail table
[ http://issues.apache.org/jira/browse/TOMAHAWK-470?page=comments#action_12422530 ] Mikhail Grushinskiy commented on TOMAHAWK-470: -- Any ideas how this can be achieved? Thanks, --MG Add ability to set initial state of all details as expanded for master/detail table --- Key: TOMAHAWK-470 URL: http://issues.apache.org/jira/browse/TOMAHAWK-470 Project: MyFaces Tomahawk Issue Type: Improvement Components: Extended Datatable Affects Versions: 1.1.3-SNAPSHOT, 1.1.2, 1.1.4-SNAPSHOT Environment: all Reporter: Mikhail Grushinskiy Priority: Minor Add ability to set initial state of all details as expanded for master/detail table Currently it is not possible to have master/detail table with all details expanded initially. Please, add additional attribute to dataTable tag which would allow all details expanded on first load of the page. Thanks, --MG -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-470) Add ability to set initial state of all details as expanded for master/detail table
Add ability to set initial state of all details as expanded for master/detail table Key: TOMAHAWK-470 URL: http://issues.apache.org/jira/browse/TOMAHAWK-470 Project: MyFaces Tomahawk Type: Improvement Components: Extended Datatable Versions: 1.1.3-SNAPSHOT, 1.1.2, 1.1.4-SNAPSHOT Environment: all Reporter: Mikhail Grushinskiy Priority: Minor Add ability to set initial state of all details as expanded for master/detail table Currently it is not possible to have master/detail table with all details expanded initially. Please, add additional attribute to dataTable tag which would allow all details expanded on first load of the page. Thanks, --MG -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MYFACES-1299) f:facet name=header/ doesn't allow multiple h:outputText inside
f:facet name=header/ doesn't allow multiple h:outputText inside - Key: MYFACES-1299 URL: http://issues.apache.org/jira/browse/MYFACES-1299 Project: MyFaces Core Type: Bug Versions: 1.1.3-SNAPSHOT Reporter: Mikhail Grushinskiy Fix For: 1.1.3-SNAPSHOT f:facet name=header/ doesn't allow multiple t:outputText inside multiple t:outputText inside f:facet name=header cause exception [java] WARN SL: javax.servlet.ServletException: facet 'header' already has a child associated. current associated component id: eventDetailsForm:productInfoView:_idJsp5 class:org.apache.myfaces.component.html.ext.HtmlOutputText [java] at javax.faces.webapp.FacesServlet.service(FacesServlet.java:152) [java] at com.webapp.framework.web.faces.ExtFacesServlet.service(ExtFacesServlet.java:31) [java] at weblogic.servlet.internal.StubSecurityHelper$ServletServiceAction.run(StubSecurityHelper.java:214) [java] at weblogic.servlet.internal.StubSecurityHelper.invokeServlet(StubSecurityHelper.java:120) [java] at weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:272) [java] at weblogic.servlet.internal.TailFilter.doFilter(TailFilter.java:26) [java] at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) [java] at leh.efw.shared.filter.LoggingFilter.doFilter(LoggingFilter.java:113) [java] at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) [java] at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:144) [java] at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1299) f:facet name=header/ doesn't allow multiple h:outputText inside
[ http://issues.apache.org/jira/browse/MYFACES-1299?page=comments#action_12378164 ] Mikhail Grushinskiy commented on MYFACES-1299: -- I have core 1.1.3 and impl 1.1.3 both from May 1st build (I think it was release cadidate for coming Monday) and tomahawk 1.1.3 from May 5th build snapshot f:facet name=header/ doesn't allow multiple h:outputText inside - Key: MYFACES-1299 URL: http://issues.apache.org/jira/browse/MYFACES-1299 Project: MyFaces Core Type: Bug Versions: 1.1.3-SNAPSHOT Reporter: Mikhail Grushinskiy Fix For: 1.1.3-SNAPSHOT f:facet name=header/ doesn't allow multiple t:outputText inside multiple t:outputText inside f:facet name=header cause exception [java] WARN SL: javax.servlet.ServletException: facet 'header' already has a child associated. current associated component id: eventDetailsForm:productInfoView:_idJsp5 class:org.apache.myfaces.component.html.ext.HtmlOutputText [java] at javax.faces.webapp.FacesServlet.service(FacesServlet.java:152) [java] at com.webapp.framework.web.faces.ExtFacesServlet.service(ExtFacesServlet.java:31) [java] at weblogic.servlet.internal.StubSecurityHelper$ServletServiceAction.run(StubSecurityHelper.java:214) [java] at weblogic.servlet.internal.StubSecurityHelper.invokeServlet(StubSecurityHelper.java:120) [java] at weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:272) [java] at weblogic.servlet.internal.TailFilter.doFilter(TailFilter.java:26) [java] at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) [java] at leh.efw.shared.filter.LoggingFilter.doFilter(LoggingFilter.java:113) [java] at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) [java] at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:144) [java] at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-388) Add expandAll/collapseAll or toggleAll details for master detail dataTable (detailToggler)
[
http://issues.apache.org/jira/browse/TOMAHAWK-388?page=comments#action_12378188
]
Mikhail Grushinskiy commented on TOMAHAWK-388:
--
I've done some more testing against May 1st build of myfaces core/impl 1.1.3
and May 5th build of tomahawk 1.1.3 with this patch and it works fine.
Add expandAll/collapseAll or toggleAll details for master detail dataTable
(detailToggler)
--
Key: TOMAHAWK-388
URL: http://issues.apache.org/jira/browse/TOMAHAWK-388
Project: MyFaces Tomahawk
Type: Improvement
Components: Extended Datatable
Versions: 1.1.2-SNAPSHOT
Environment: All
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 1.1.2-SNAPSHOT
Attachments: HtmlDataTable-TOMAHAWK-388.java.patch
Add expandAll/collapseAll or toggleAll details for master detail tomahawk
dataTable (detailToggler). It seems it can be achieved pretty easily.
In tomahawk package org.apache.myfaces.component.html.ext HtmlDataTable
the following methods could be added for that
public void expandAllDetails()
{
int rowCount = getRowCount();
_expandedNodes.clear();
for (int row = 0; row rowCount; row++)
{
_expandedNodes.add(new Integer(row));
}
}
public void collapseAllDetails()
{
_expandedNodes.clear();
}
In tomahawk.tld
attribute
namevarDetailToggler/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
description
This variable has the boolean property currentdetailExpanded
which is true if the current detail row is expanded and the action methods
toggleDetail which expand/collapse the current detail row;
expandAllDetails - expands all detail rows;
collapseAllDetails - collapses all detail rows
/description
/attribute
Also it would be nice to have an attribute to allow initial state to be all
expanded, something like allExpandInit=true
Thanks a lot,
--MG
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-388) Add expandAll/collapseAll or toggleAll details for master detail dataTable (detailToggler)
[
http://issues.apache.org/jira/browse/TOMAHAWK-388?page=comments#action_12377629
]
Mikhail Grushinskiy commented on TOMAHAWK-388:
--
In TLD only documentation change
In tomahawk.tld
attribute
namevarDetailToggler/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
description
This variable has the boolean property currentdetailExpanded
which is true if the current detail row is expanded,
boolean property expandedEmpty which is true if all details are
collapsed, and the action methods
toggleDetail which expand/collapse the current detail row;
expandAllDetails - expands all detail rows;
collapseAllDetails - collapses all detail rows
/description
/attribute
--MG
Add expandAll/collapseAll or toggleAll details for master detail dataTable
(detailToggler)
--
Key: TOMAHAWK-388
URL: http://issues.apache.org/jira/browse/TOMAHAWK-388
Project: MyFaces Tomahawk
Type: Improvement
Components: Extended Datatable
Versions: 1.1.2-SNAPSHOT
Environment: All
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 1.1.2-SNAPSHOT
Attachments: HtmlDataTable-TOMAHAWK-388.java.patch
Add expandAll/collapseAll or toggleAll details for master detail tomahawk
dataTable (detailToggler). It seems it can be achieved pretty easily.
In tomahawk package org.apache.myfaces.component.html.ext HtmlDataTable
the following methods could be added for that
public void expandAllDetails()
{
int rowCount = getRowCount();
_expandedNodes.clear();
for (int row = 0; row rowCount; row++)
{
_expandedNodes.add(new Integer(row));
}
}
public void collapseAllDetails()
{
_expandedNodes.clear();
}
In tomahawk.tld
attribute
namevarDetailToggler/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
description
This variable has the boolean property currentdetailExpanded
which is true if the current detail row is expanded and the action methods
toggleDetail which expand/collapse the current detail row;
expandAllDetails - expands all detail rows;
collapseAllDetails - collapses all detail rows
/description
/attribute
Also it would be nice to have an attribute to allow initial state to be all
expanded, something like allExpandInit=true
Thanks a lot,
--MG
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-407) Tomahawk org.apache.myfaces.component.html.ext.HtmlDataTable.findComponent bug (numeric format exception at line 143)
Tomahawk org.apache.myfaces.component.html.ext.HtmlDataTable.findComponent bug (numeric format exception at line 143) - Key: TOMAHAWK-407 URL: http://issues.apache.org/jira/browse/TOMAHAWK-407 Project: MyFaces Tomahawk Type: Bug Versions: 1.1.3-SNAPSHOT Environment: any Reporter: Mikhail Grushinskiy When using forceIdIndexFormula which generates id as astring I'm receiving the following exception. It happens if I have f:convertNumber/ on same form. It should allow to use non numeric indexes too in case of forceIdIndexFormula. I had to use this formula to compensate for missing generated Ids in master/detail table to combine master and detail IDs into single index value. java.lang.NumberFormatException: For input string: 895o2397 at java.lang.NumberFormatException.forInputString(NumberFormatException.jav a:48) at java.lang.Integer.parseInt(Integer.java:456) at java.lang.Integer.valueOf(Integer.java:553) at org.apache.myfaces.component.html.ext.HtmlDataTable.findComponent(HtmlDa taTable.java:143) at javax.faces.component.UIComponentBase.findComponent(UIComponentBase.java :426) at org.apache.myfaces.component.html.ext.HtmlDataTable.findComponent(HtmlDa taTable.java:152) at javax.faces.component.UIComponentBase.findComponent(UIComponentBase.java :426) at javax.faces.component.UIComponentBase.findComponent(UIComponentBase.java :426) at javax.faces.component.UIComponentBase.findComponent(UIComponentBase.java :426) at org.apache.myfaces.renderkit.html.ext.HtmlMessageRenderer.findInputLabel (HtmlMessageRenderer.java:158) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-388) Add expandAll/collapseAll or toggleAll details for master detail dataTable (detailToggler)
[ http://issues.apache.org/jira/browse/TOMAHAWK-388?page=all ]
Mikhail Grushinskiy updated TOMAHAWK-388:
-
Status: Patch Available (was: Open)
Add expandAll/collapseAll or toggleAll details for master detail dataTable
(detailToggler)
--
Key: TOMAHAWK-388
URL: http://issues.apache.org/jira/browse/TOMAHAWK-388
Project: MyFaces Tomahawk
Type: Improvement
Components: Extended Datatable
Versions: 1.1.2-SNAPSHOT
Environment: All
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 1.1.2-SNAPSHOT
Add expandAll/collapseAll or toggleAll details for master detail tomahawk
dataTable (detailToggler). It seems it can be achieved pretty easily.
In tomahawk package org.apache.myfaces.component.html.ext HtmlDataTable
the following methods could be added for that
public void expandAllDetails()
{
int rowCount = getRowCount();
_expandedNodes.clear();
for (int row = 0; row rowCount; row++)
{
_expandedNodes.add(new Integer(row));
}
}
public void collapseAllDetails()
{
_expandedNodes.clear();
}
In tomahawk.tld
attribute
namevarDetailToggler/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
description
This variable has the boolean property currentdetailExpanded
which is true if the current detail row is expanded and the action methods
toggleDetail which expand/collapse the current detail row;
expandAllDetails - expands all detail rows;
collapseAllDetails - collapses all detail rows
/description
/attribute
Also it would be nice to have an attribute to allow initial state to be all
expanded, something like allExpandInit=true
Thanks a lot,
--MG
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-403) CLONE -Add expandAll/collapseAll or toggleAll details for master detail dataTable (detailToggler)
CLONE -Add expandAll/collapseAll or toggleAll details for master detail
dataTable (detailToggler)
-
Key: TOMAHAWK-403
URL: http://issues.apache.org/jira/browse/TOMAHAWK-403
Project: MyFaces Tomahawk
Type: Improvement
Components: Extended Datatable
Versions: 1.1.2-SNAPSHOT
Environment: All
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 1.1.2-SNAPSHOT
Add expandAll/collapseAll or toggleAll details for master detail tomahawk
dataTable (detailToggler). It seems it can be achieved pretty easily.
In tomahawk package org.apache.myfaces.component.html.ext HtmlDataTable
the following methods could be added for that
public void expandAllDetails()
{
int rowCount = getRowCount();
_expandedNodes.clear();
for (int row = 0; row rowCount; row++)
{
_expandedNodes.add(new Integer(row));
}
}
public void collapseAllDetails()
{
_expandedNodes.clear();
}
In tomahawk.tld
attribute
namevarDetailToggler/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
description
This variable has the boolean property currentdetailExpanded
which is true if the current detail row is expanded and the action methods
toggleDetail which expand/collapse the current detail row;
expandAllDetails - expands all detail rows;
collapseAllDetails - collapses all detail rows
/description
/attribute
Also it would be nice to have an attribute to allow initial state to be all
expanded, something like allExpandInit=true
Thanks a lot,
--MG
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-388) Add expandAll/collapseAll or toggleAll details for master detail dataTable (detailToggler)
[
http://issues.apache.org/jira/browse/TOMAHAWK-388?page=comments#action_12377180
]
Mikhail Grushinskiy commented on TOMAHAWK-388:
--
I've attached a patch. Please, include it into tomahawk 1.1.3
Add expandAll/collapseAll or toggleAll details for master detail dataTable
(detailToggler)
--
Key: TOMAHAWK-388
URL: http://issues.apache.org/jira/browse/TOMAHAWK-388
Project: MyFaces Tomahawk
Type: Improvement
Components: Extended Datatable
Versions: 1.1.2-SNAPSHOT
Environment: All
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 1.1.2-SNAPSHOT
Attachments: HtmlDataTable-TOMAHAWK-388.java.patch
Add expandAll/collapseAll or toggleAll details for master detail tomahawk
dataTable (detailToggler). It seems it can be achieved pretty easily.
In tomahawk package org.apache.myfaces.component.html.ext HtmlDataTable
the following methods could be added for that
public void expandAllDetails()
{
int rowCount = getRowCount();
_expandedNodes.clear();
for (int row = 0; row rowCount; row++)
{
_expandedNodes.add(new Integer(row));
}
}
public void collapseAllDetails()
{
_expandedNodes.clear();
}
In tomahawk.tld
attribute
namevarDetailToggler/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
description
This variable has the boolean property currentdetailExpanded
which is true if the current detail row is expanded and the action methods
toggleDetail which expand/collapse the current detail row;
expandAllDetails - expands all detail rows;
collapseAllDetails - collapses all detail rows
/description
/attribute
Also it would be nice to have an attribute to allow initial state to be all
expanded, something like allExpandInit=true
Thanks a lot,
--MG
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-388) Add expandAll/collapseAll or toggleAll details for master detail dataTable (detailToggler)
Add expandAll/collapseAll or toggleAll details for master detail dataTable
(detailToggler)
--
Key: TOMAHAWK-388
URL: http://issues.apache.org/jira/browse/TOMAHAWK-388
Project: MyFaces Tomahawk
Type: Improvement
Components: Extended Datatable
Versions: 1.1.2-SNAPSHOT
Environment: All
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 1.1.2-SNAPSHOT
Add expandAll/collapseAll or toggleAll details for master detail tomahawk
dataTable (detailToggler). It seems it can be achieved pretty easily.
In tomahawk package org.apache.myfaces.component.html.ext HtmlDataTable
the following methods could be added for that
public void expandAllDetails()
{
int rowCount = getRowCount();
_expandedNodes.clear();
for (int row = 0; row rowCount; row++)
{
_expandedNodes.add(new Integer(row));
}
}
public void collapseAllDetails()
{
_expandedNodes.clear();
}
In tomahawk.tld
attribute
namevarDetailToggler/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
description
This variable has the boolean property currentdetailExpanded
which is true if the current detail row is expanded and the action methods
toggleDetail which expand/collapse the current detail row;
expandAllDetails - expands all detail rows;
collapseAllDetails - collapses all detail rows
/description
/attribute
Also it would be nice to have an attribute to allow initial state to be all
expanded, something like allExpandInit=true
Thanks a lot,
--MG
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-388) Add expandAll/collapseAll or toggleAll details for master detail dataTable (detailToggler)
[
http://issues.apache.org/jira/browse/TOMAHAWK-388?page=comments#action_12376301
]
Mikhail Grushinskiy commented on TOMAHAWK-388:
--
for allExpandInit
a new variable can be added in tomahawk package
org.apache.myfaces.component.html.ext HtmlDataTable
private Boolean _allExpandInit = null;
with getter and setter
in
tomahawk.tld
attribute
nameallExpandInit/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
typejava.lang.String/type
descriptionIf true, all detail rows will be initially expanded
(applicable only for master/detail table)./description
/attribute
and somewhere (might be processDetails() ?)
if (_allExpandInit) {
expandAllDetails();
...
_allExpandInit = false; // ? so it happens only once
}
Add expandAll/collapseAll or toggleAll details for master detail dataTable
(detailToggler)
--
Key: TOMAHAWK-388
URL: http://issues.apache.org/jira/browse/TOMAHAWK-388
Project: MyFaces Tomahawk
Type: Improvement
Components: Extended Datatable
Versions: 1.1.2-SNAPSHOT
Environment: All
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 1.1.2-SNAPSHOT
Add expandAll/collapseAll or toggleAll details for master detail tomahawk
dataTable (detailToggler). It seems it can be achieved pretty easily.
In tomahawk package org.apache.myfaces.component.html.ext HtmlDataTable
the following methods could be added for that
public void expandAllDetails()
{
int rowCount = getRowCount();
_expandedNodes.clear();
for (int row = 0; row rowCount; row++)
{
_expandedNodes.add(new Integer(row));
}
}
public void collapseAllDetails()
{
_expandedNodes.clear();
}
In tomahawk.tld
attribute
namevarDetailToggler/name
requiredfalse/required
rtexprvaluefalse/rtexprvalue
description
This variable has the boolean property currentdetailExpanded
which is true if the current detail row is expanded and the action methods
toggleDetail which expand/collapse the current detail row;
expandAllDetails - expands all detail rows;
collapseAllDetails - collapses all detail rows
/description
/attribute
Also it would be nice to have an attribute to allow initial state to be all
expanded, something like allExpandInit=true
Thanks a lot,
--MG
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
