[jira] Created: (TOMAHAWK-1033) Add triggers to start periodcialUpdate
Add triggers to start periodcialUpdate -- Key: TOMAHAWK-1033 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1033 Project: MyFaces Tomahawk Issue Type: New Feature Components: PPRPanelGroup Affects Versions: 1.1.7-SNAPSHOT Reporter: Stefan Schuster Fix For: 1.1.7-SNAPSHOT Feature proposal: periodicalTriggers to allow starting the periodcalUpdate on a trigger As it's not possible to put periodical updating pprPanelGroups into partialTriggered pprPanelGroups I thought it would be a good idea to add the attribute periodicalTriggers. The implementation in the attached patch introduces such an attribute. It basically works like the partialTriggers but when triggered it calls the startPeriodicalUpdate() method from the ppr.js file. If no periodicalTrigger is given the startPeriodicalUpdate is called as before in dojo.addOnLoad. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-1033) Add triggers to start periodcialUpdate
[ https://issues.apache.org/jira/browse/TOMAHAWK-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Schuster updated TOMAHAWK-1033: -- Status: Patch Available (was: Open) Add triggers to start periodcialUpdate -- Key: TOMAHAWK-1033 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1033 Project: MyFaces Tomahawk Issue Type: New Feature Components: PPRPanelGroup Affects Versions: 1.1.7-SNAPSHOT Reporter: Stefan Schuster Fix For: 1.1.7-SNAPSHOT Feature proposal: periodicalTriggers to allow starting the periodcalUpdate on a trigger As it's not possible to put periodical updating pprPanelGroups into partialTriggered pprPanelGroups I thought it would be a good idea to add the attribute periodicalTriggers. The implementation in the attached patch introduces such an attribute. It basically works like the partialTriggers but when triggered it calls the startPeriodicalUpdate() method from the ppr.js file. If no periodicalTrigger is given the startPeriodicalUpdate is called as before in dojo.addOnLoad. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-936) TableSuggestAjax aborts page load in IE
TableSuggestAjax aborts page load in IE --- Key: TOMAHAWK-936 URL: https://issues.apache.org/jira/browse/TOMAHAWK-936 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Fix For: 1.1.5-SNAPSHOT Every use of the tableSuggestComponent in a page aborts the page load in IE with an error message (even in the sandbox example pages). This happens due to a bug that the javascript gets rendered before the DIV it works with gets closed. The attached patch moves the DIV-close to the correct position. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-936) TableSuggestAjax aborts page load in IE
[ https://issues.apache.org/jira/browse/TOMAHAWK-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Schuster updated TOMAHAWK-936: - Status: Patch Available (was: Open) TableSuggestAjax aborts page load in IE --- Key: TOMAHAWK-936 URL: https://issues.apache.org/jira/browse/TOMAHAWK-936 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Fix For: 1.1.5-SNAPSHOT Attachments: TableSuggestAjax_IEPatch.patch Every use of the tableSuggestComponent in a page aborts the page load in IE with an error message (even in the sandbox example pages). This happens due to a bug that the javascript gets rendered before the DIV it works with gets closed. The attached patch moves the DIV-close to the correct position. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-928) DojoUtils.getAttributeMap fails for subclassed Dojo Components
[ https://issues.apache.org/jira/browse/TOMAHAWK-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479623 ] Stefan Schuster commented on TOMAHAWK-928: -- Well that sounds reasonable. I'm not sure about the protected argument, but the performance aspect convinced me. Therefore I implemented your suggestion and added an enhanced patch. So now it works like before, but inherited members will be found too in the 3rd and 4th attempt. Stefan DojoUtils.getAttributeMap fails for subclassed Dojo Components -- Key: TOMAHAWK-928 URL: https://issues.apache.org/jira/browse/TOMAHAWK-928 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Assigned To: Werner Punz Fix For: 1.1.5-SNAPSHOT Attachments: DojoUtils.patch, DojoUtilsV2.patch When using DojoUtils.renderWidgetInitializationCode() with a String Array as arguments parameter introspection get's used to find the getters for the given Strings. When subclassing a dojo based widget this mechanisms fails with a NoSuchMethodException. The introspection happens in DojoUtils.getAttributeMap() and uses Class.getDeclaredMethod() instead of Class.getMethod() which won't find the inherited getters. Changing this makes the mechanism working with subclassed components too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-928) DojoUtils.getAttributeMap fails for subclassed Dojo Components
[ https://issues.apache.org/jira/browse/TOMAHAWK-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479712 ] Stefan Schuster commented on TOMAHAWK-928: -- In my opinion this looks good and finally solves the performance issues while covering both, is and get getters. Werner? DojoUtils.getAttributeMap fails for subclassed Dojo Components -- Key: TOMAHAWK-928 URL: https://issues.apache.org/jira/browse/TOMAHAWK-928 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Assigned To: Werner Punz Fix For: 1.1.5-SNAPSHOT Attachments: DojoUtils.patch, DojoUtilsV2.patch When using DojoUtils.renderWidgetInitializationCode() with a String Array as arguments parameter introspection get's used to find the getters for the given Strings. When subclassing a dojo based widget this mechanisms fails with a NoSuchMethodException. The introspection happens in DojoUtils.getAttributeMap() and uses Class.getDeclaredMethod() instead of Class.getMethod() which won't find the inherited getters. Changing this makes the mechanism working with subclassed components too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-910) inputSugestAjax onchange JavaScript error
inputSugestAjax onchange JavaScript error - Key: TOMAHAWK-910 URL: https://issues.apache.org/jira/browse/TOMAHAWK-910 Project: MyFaces Tomahawk Issue Type: Bug Components: InputSuggestAjax Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Priority: Minor Fix For: 1.1.5-SNAPSHOT The JavaScript for the dojo inputSuggestAjax component always tries to call onchange event if no event handler is set for it. This causes javaScript errors. The patch checks if onchange is available and call only if it's available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-910) inputSugestAjax onchange JavaScript error
[ https://issues.apache.org/jira/browse/TOMAHAWK-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Schuster updated TOMAHAWK-910: - Status: Patch Available (was: Open) inputSugestAjax onchange JavaScript error - Key: TOMAHAWK-910 URL: https://issues.apache.org/jira/browse/TOMAHAWK-910 Project: MyFaces Tomahawk Issue Type: Bug Components: InputSuggestAjax Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Priority: Minor Fix For: 1.1.5-SNAPSHOT Attachments: inputSuggestAjax.patch The JavaScript for the dojo inputSuggestAjax component always tries to call onchange event if no event handler is set for it. This causes javaScript errors. The patch checks if onchange is available and call only if it's available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOMAHAWK-258) sandbox inputSuggestAjax ignores onkeydown event
[ https://issues.apache.org/jira/browse/TOMAHAWK-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475353 ] Stefan Schuster commented on TOMAHAWK-258: -- This is actually based on the same issues I experienced with the new tableSuggestAjax component. As the input field gets created by a dojo standard component it does not know or care about the MyFaces attributes. As an improvement to the current situation I've applied the same technique on the inputSuggestAjax as I've done it for tableSuggestAjax (TOMAHAWK-898). The input field will be generated by the HtmlTextRendererBase and then be injected into the dojo component. This delegates all the standard attribute rendering back to the Base, and attributes like disabled or the javascript event handler work. To do the input field injection it was necessary to create a subclass of the original dojo ComboBox component which was used previously. The derived component gets the clientId of the inputField and will inject it into the component. sandbox inputSuggestAjax ignores onkeydown event Key: TOMAHAWK-258 URL: https://issues.apache.org/jira/browse/TOMAHAWK-258 Project: MyFaces Tomahawk Issue Type: Bug Components: InputSuggestAjax Affects Versions: 1.1.2-SNAPSHOT Reporter: Juergen Melzer Assigned To: Gerald Müllan I created a field like: s:inputSuggestAjax suggestedItemsMethod=#{editUser.getUserNames} id=stellvertreterUserID value=#{editUser.activeSubstitute} onkeydown=alert('Hallo') onclick=alert('Hallo')/ But no javascript event are generated... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-258) sandbox inputSuggestAjax ignores onkeydown event
[ https://issues.apache.org/jira/browse/TOMAHAWK-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Schuster updated TOMAHAWK-258: - Status: Patch Available (was: Open) sandbox inputSuggestAjax ignores onkeydown event Key: TOMAHAWK-258 URL: https://issues.apache.org/jira/browse/TOMAHAWK-258 Project: MyFaces Tomahawk Issue Type: Bug Components: InputSuggestAjax Affects Versions: 1.1.2-SNAPSHOT Reporter: Juergen Melzer Assigned To: Gerald Müllan Attachments: InputSuggestAjax.patch I created a field like: s:inputSuggestAjax suggestedItemsMethod=#{editUser.getUserNames} id=stellvertreterUserID value=#{editUser.activeSubstitute} onkeydown=alert('Hallo') onclick=alert('Hallo')/ But no javascript event are generated... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-898) New tableSuggestAjax is ignoring multiple attribtues
New tableSuggestAjax is ignoring multiple attribtues Key: TOMAHAWK-898 URL: https://issues.apache.org/jira/browse/TOMAHAWK-898 Project: MyFaces Tomahawk Issue Type: Bug Components: New Component Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Fix For: 1.1.5-SNAPSHOT The new version of the tableSuggestAjax changed the input field to be generated by dojo instead of the being rendered by the standard HtmlTextRendererBase. This caused multiple lost attributes like disabled or all the javascript handlers. The attached patch solves this by going one step back. The input field will be generated by the HtmlTextRendererBase again and then be injected into the dojo component. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-898) New tableSuggestAjax is ignoring multiple attribtues
[ https://issues.apache.org/jira/browse/TOMAHAWK-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Schuster updated TOMAHAWK-898: - Status: Patch Available (was: Open) New tableSuggestAjax is ignoring multiple attribtues Key: TOMAHAWK-898 URL: https://issues.apache.org/jira/browse/TOMAHAWK-898 Project: MyFaces Tomahawk Issue Type: Bug Components: New Component Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Fix For: 1.1.5-SNAPSHOT Attachments: tableSuggestAjax.patch The new version of the tableSuggestAjax changed the input field to be generated by dojo instead of the being rendered by the standard HtmlTextRendererBase. This caused multiple lost attributes like disabled or all the javascript handlers. The attached patch solves this by going one step back. The input field will be generated by the HtmlTextRendererBase again and then be injected into the dojo component. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-886) DojoInitializer doesn't render correctly after restoreState
DojoInitializer doesn't render correctly after restoreState --- Key: TOMAHAWK-886 URL: https://issues.apache.org/jira/browse/TOMAHAWK-886 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Priority: Critical Fix For: 1.1.5-SNAPSHOT Every given paramter in the dojoInitializer only gets rendered out on the first request into the djConfig in the header. On every following request the parameters are ignored. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-886) DojoInitializer doesn't render correctly after restoreState
[ https://issues.apache.org/jira/browse/TOMAHAWK-886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Schuster updated TOMAHAWK-886: - Status: Patch Available (was: Open) DojoInitializer doesn't render correctly after restoreState --- Key: TOMAHAWK-886 URL: https://issues.apache.org/jira/browse/TOMAHAWK-886 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Priority: Critical Fix For: 1.1.5-SNAPSHOT Every given paramter in the dojoInitializer only gets rendered out on the first request into the djConfig in the header. On every following request the parameters are ignored. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (TOMAHAWK-884) TableSuggestAjax JavaScript based on Dojo
TableSuggestAjax JavaScript based on Dojo - Key: TOMAHAWK-884 URL: https://issues.apache.org/jira/browse/TOMAHAWK-884 Project: MyFaces Tomahawk Issue Type: Improvement Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster Fix For: 1.1.5-SNAPSHOT Currently the TableSuggestAjax JavaScript basis is not based on dojo and therefore completly different from eg. the InputSuggestAjax component. Ideally the TableSuggestAjax should be based on the Dojo ComboBox component too (like the InputSuggestAjax) to benefit from the efforts dojo already put into this component and to unifiy the look and feel of the Input and TableSuggest Ajax component. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TOMAHAWK-870) Sandbox dojolayouts.FloatingPaneTag iconSrc error
[ https://issues.apache.org/jira/browse/TOMAHAWK-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Schuster updated TOMAHAWK-870: - Status: Patch Available (was: Open) Sandbox dojolayouts.FloatingPaneTag iconSrc error - Key: TOMAHAWK-870 URL: https://issues.apache.org/jira/browse/TOMAHAWK-870 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster The implementation of the iconSrc property in the FloatingPaneTag is defective. The property never gets set correctly in the FloatingPaneBase which causes that the property is missing in the dojo widget initialization. The reason for seems to be, that the iconSrc property is implemented in different upper/lower case combinations throughout the file. The bottom line is that the TAG_PARAM_iconSrc used in setProperties() doesn't match the property name in the FloatingPaneBase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-870) Sandbox dojolayouts.FloatingPaneTag iconSrc error
Sandbox dojolayouts.FloatingPaneTag iconSrc error - Key: TOMAHAWK-870 URL: https://issues.apache.org/jira/browse/TOMAHAWK-870 Project: MyFaces Tomahawk Issue Type: Bug Affects Versions: 1.1.5-SNAPSHOT Reporter: Stefan Schuster The implementation of the iconSrc property in the FloatingPaneTag is defective. The property never gets set correctly in the FloatingPaneBase which causes that the property is missing in the dojo widget initialization. The reason for seems to be, that the iconSrc property is implemented in different upper/lower case combinations throughout the file. The bottom line is that the TAG_PARAM_iconSrc used in setProperties() doesn't match the property name in the FloatingPaneBase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira