[GitHub] [myfaces] volosied commented on pull request #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier

2023-01-30 Thread via GitHub 


volosied commented on PR #504:
URL: https://github.com/apache/myfaces/pull/504#issuecomment-1409727137

   GREEN GREEN GREEN!     Never been so happy to see a "BUILD SUCCESSFUL". 
   
   Still need do some more testing and refactor the changes a bit, but I think 
I've fixed this without causing any regressions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [myfaces] volosied commented on pull request #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier

2023-01-27 Thread via GitHub 


volosied commented on PR #504:
URL: https://github.com/apache/myfaces/pull/504#issuecomment-1407295681

   ```
   Error:  Failures: 
   Error:FlowMyFacesRequestTestCase.testFlow1_10:940 expected: but 
was:
   Error:FlowMyFacesRequestTestCase.testFlow1_10_1:1028 expected: 
but was:
   Error:FlowMyFacesRequestTestCase.testFlow1_10_2:1116 expected: 
but was:
   Error:FlowMyFacesRequestTestCase.testFlow1_8:684 expected: but 
was:
   ```
   
   Made a update and it's down to 4 failures now. However, I don't really like 
this approach, but I don't see much we can do. We follow the spec (mostly), but 
I think Mojarra just made more updates made to address edge cases and the spec 
was never updated.
   
   Basically, when should a flow be entered so that flowScope is active? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [myfaces] volosied commented on pull request #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier

2023-01-26 Thread via GitHub 


volosied commented on PR #504:
URL: https://github.com/apache/myfaces/pull/504#issuecomment-1405997332

   This code addresses the issue found in the TCK, but it fails in our tests. 
You can find the failures in the build log, for example: 
   ```
   Error:  Tests run: 5, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 
2.055 s <<< FAILURE! - in 
org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase
   Error:  
org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase.testFlow1_1  
Time elapsed: 0.369 s  <<< FAILURE!
   java.lang.AssertionError: 
   expected null, but was:<
 /flow1_1.xhtml
 content
 /flow1/content.xhtml
   >
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotNull(Assert.java:756)
at org.junit.Assert.assertNull(Assert.java:738)
at org.junit.Assert.assertNull(Assert.java:748)
at 
org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase.testFlow1_1(FlowMyFacesCDIRequestTestCase.java:72)
   ```
   
   
https://github.com/apache/myfaces/blob/93a47f3c78716f0ff3c01227ee1cd5972aeb965b/impl/src/test/java/org/apache/myfaces/application/flow/FlowMyFacesCDIRequestTestCase.java#L59-L72


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org