[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1429970835 I can keep the new logging code as is, but undo my LOG_WEB_CONTEXT_PARAMS changes. Although, "auto" doesn't seem to make much sense since now it only applies to dev mode (true / false is enough IMO, default true), and I still would like to have fine logging simply for support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1429987506 I think I'm following you now. So here's the new behavior for these _info_ message: auto - logs in dev mode only (not prod) (fine messages still logged in prod when trace is specified) true - logs in production and dev mode (fine not needed, due to info messages) false - no logging in either (fine messages still logged in prod when trace is specified) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1430297468 @tandraschko Let me know what you think of the new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #520: MYFACES-4561 Change Context Parameter Logging
volosied commented on PR #520: URL: https://github.com/apache/myfaces/pull/520#issuecomment-1433182916 I agree. What about `always, dev-only, never`as the three options? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
