[GitHub] [myfaces] werpu commented on pull request #426: https://issues.apache.org/jira/browse/MYFACES-4040:
werpu commented on PR #426: URL: https://github.com/apache/myfaces/pull/426#issuecomment-1359621968 works with all the latest fixes in 2.3! I will merge now this backend pull request, given it is uncritical. Will also port this tomorrow to 3.0! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #426: https://issues.apache.org/jira/browse/MYFACES-4040:
werpu commented on PR #426: URL: https://github.com/apache/myfaces/pull/426#issuecomment-1359579959 I found a better way. A small code reorg into existing structures, allows me to get a cleaner cut between legacy browser support and modern browsers. Basically I just reorganized smaller parts of the code into the already existing shim layer. I am now able to sync more or less with minor code changes between the branches. This already is merged, I will reissue the fix for 4040 later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #426: https://issues.apache.org/jira/browse/MYFACES-4040:
werpu commented on PR #426: URL: https://github.com/apache/myfaces/pull/426#issuecomment-1348739068 I have started an informal vote on the mailing list to get a general community opinion about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #426: https://issues.apache.org/jira/browse/MYFACES-4040:
werpu commented on PR #426: URL: https://github.com/apache/myfaces/pull/426#issuecomment-1348704930 @pnicolucci yes a vote is a good idea, I will start one right away. If the vote goes no, or not enough people vote, I will revert the change immediately. Thanks for the feedback, did not think of starting a vote on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #426: https://issues.apache.org/jira/browse/MYFACES-4040:
werpu commented on PR #426: URL: https://github.com/apache/myfaces/pull/426#issuecomment-1348535177 Ok I will merge the code then into 2.3, thanks for the update. Also @pnicolucci I have merged the jsf.js 2.3-next codebase back into 2.3, this however means we cut browser support for browsers below IE9. If there are any objections to this - I know you guys have a ton of customers, so a change in a stable branch might be too much, I will revert this change. The codebase is more or less the same but it has dropped a ton of ie6 and 7 and even older browser code, and introduced a construct in a fixed head replace (there was a tck issue this has fixed) which relies on a dom construct which ie9+ only support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #426: https://issues.apache.org/jira/browse/MYFACES-4040:
werpu commented on PR #426: URL: https://github.com/apache/myfaces/pull/426#issuecomment-1346546585 Tests have passed... I will leave it up to you whether you want to take it in, but given we have synchronized our myfaces jsf.js codebases now back from next into the original codebase, I highly can recommend to take this also in and cosider this bug fixed for all of 2.3+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #426: https://issues.apache.org/jira/browse/MYFACES-4040:
werpu commented on PR #426: URL: https://github.com/apache/myfaces/pull/426#issuecomment-1346500645 Checking why the build is failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #426: https://issues.apache.org/jira/browse/MYFACES-4040:
werpu commented on PR #426: URL: https://github.com/apache/myfaces/pull/426#issuecomment-1346498926 Just a short explanation. This is not a full backport of the entire next javascript rendering infrastructure, just a small fix which shifts the parameters around just like the other fixes do, but within the code of 2.3.x: Example: ```html Click here If you check the params are now passe dunder the params attribute. and so is the javax.faces.behavior.event (which is a request parameter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
