Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-26 Thread via GitHub


volosied merged PR #708:
URL: https://github.com/apache/myfaces/pull/708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub


volosied commented on PR #708:
URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075478696

   Might just be something with my system then. Thanks for checking!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub


melloware commented on PR #708:
URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075476511

   OK your branch is also all passing for me locally?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub


melloware commented on PR #708:
URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075471785

   let me try your branch now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub


melloware commented on PR #708:
URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075470451

   OK I did a git pull of the 4.1 branch and everything is passing for me with 
`mvn clean install`.  
   
   logs below
   
   ```
   [INFO] ---
   [INFO]  T E S T S
   [INFO] ---
   [INFO] Running 
org.apache.myfaces.core.extensions.quarkus.showcase.QuarkusMyFacesShowcaseTest
   Using org.apache.myfaces.webapp.MyFacesContainerInitializer
   MyFaces Core Bean Validation support disabled
   MyFaces Core CDI support enabled
   Running on PrimeFaces 12.0.0
   UT026005: Adding programmatic server endpoint class 
org.apache.myfaces.push.EndpointImpl for path /jakarta.faces.push/{channel}
   Scanning for context init parameters not defined. It is not necessary to 
define them all into your web.xml, they are just provided here for informative 
purposes. To disable this messages set 
org.apache.myfaces.LOG_WEB_CONTEXT_PARAMS config param to 'false'
   Init context parameter found 'jakarta.faces.PROJECT_STAGE' set to 
'Development'
   No context init parameter 'jakarta.faces.RESOURCE_EXCLUDES' found, using 
default value '.class .jsp .jspx .properties .xhtml .groovy'.
   No context init parameter 'jakarta.faces.STATE_SAVING_METHOD' found, using 
default value 'server'.
   No context init parameter 'jakarta.faces.FULL_STATE_SAVING_VIEW_IDS' found.
   No context init parameter 'jakarta.faces.PARTIAL_STATE_SAVING' found, using 
default value 'true (false with 1.2 webapps)'.
   No context init parameter 'jakarta.faces.SERIALIZE_SERVER_STATE' found, 
using default value 'false'.
   No context init parameter 'jakarta.faces.DEFAULT_SUFFIX' found, using 
default value '.xhtml'.
   No context init parameter 'jakarta.faces.FACELETS_SUFFIX' found, using 
default value '.xhtml'.
   No context init parameter 'jakarta.faces.FACELETS_VIEW_MAPPINGS' found.
   No context init parameter 'jakarta.faces.FACELETS_BUFFER_SIZE' found, using 
default value '1024'.
   No context init parameter 'jakarta.faces.FACELETS_DECORATORS' found.
   No context init parameter 'jakarta.faces.FACELETS_LIBRARIES' found.
   No context init parameter 'jakarta.faces.FACELETS_REFRESH_PERIOD' found, 
using default value '0, -1 in Production'.
   No context init parameter 'jakarta.faces.FACELETS_SKIP_COMMENTS' found.
   No context init parameter 'jakarta.faces.VALIDATE_EMPTY_FIELDS' found, using 
default value 'auto'.
   Init context parameter found 
'jakarta.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL' set to 'true'
   No context init parameter 
'org.apache.myfaces.CLEAR_INPUT_WHEN_SUBMITTED_VALUE_IS_NULL_OR_EMPTY' found, 
using default value 'true'.
   No context init parameter 
'jakarta.faces.ALWAYS_PERFORM_VALIDATION_WHEN_REQUIRED_IS_TRUE' found, using 
default value 'false'.
   No context init parameter 
'jakarta.faces.VIEWROOT_PHASE_LISTENER_QUEUES_EXCEPTIONS' found, using default 
value 'false'.
   No context init parameter 
'jakarta.faces.DATETIMECONVERTER_DEFAULT_TIMEZONE_IS_SYSTEM_TIMEZONE' found, 
using default value 'false'.
   No context init parameter 
'org.apache.myfaces.ENUM_CONVERTER_ALLOW_STRING_PASSTROUGH' found, using 
default value 'false'.
   No context init parameter 'jakarta.faces.CLIENT_WINDOW_MODE' found, using 
default value 'none'.
   No context init parameter 'jakarta.faces.NUMBER_OF_CLIENT_WINDOWS' found, 
using default value '10'.
   No context init parameter 
'jakarta.faces.validator.DISABLE_DEFAULT_BEAN_VALIDATOR' found, using default 
value 'true'.
   No context init parameter 
'jakarta.faces.validator.ENABLE_VALIDATE_WHOLE_BEAN' found, using default value 
'false'.
   No context init parameter 'jakarta.faces.CONFIG_FILES' found.
   No context init parameter 'jakarta.faces.LIFECYCLE_ID' found.
   No context init parameter 'jakarta.faces.DISABLE_FACESSERVLET_TO_XHTML' 
found.
   No context init parameter 'org.apache.myfaces.USE_LAMBDA_METAFACTORY' found, 
using default value 'false'.
   No context init parameter 'org.apache.myfaces.USE_ENCRYPTION' found, using 
default value 'true'.
   No context init parameter 'org.apache.myfaces.SECRET' found.
   No context init parameter 'org.apache.myfaces.ALGORITHM' found, using 
default value 'AES'.
   No context init parameter 'org.apache.myfaces.SECRET.CACHE' found.
   No context init parameter 'org.apache.myfaces.ALGORITHM.IV' found.
   No context init parameter 'org.apache.myfaces.ALGORITHM.PARAMETERS' found, 
using default value 'ECB/PKCS5Padding'.
   No context init parameter 'org.apache.myfaces.SERIAL_FACTORY' found.
   No context init parameter 'org.apache.myfaces.COMPRESS_STATE_IN_CLIENT' 
found, using default value 'false'.
   No context init parameter 'org.apache.myfaces.MAC_ALGORITHM' found, using 
default value 'HmacSHA256'.
   No context init parameter 'org.apache.myfaces.MAC_SECRET' found.
   No context init parameter 'org.apache.myfaces.MAC_SECRET.CACHE' 

Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub


melloware commented on PR #708:
URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075459835

   yep let me look. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] MYFACES-4662 + Spec 1760 [myfaces]

2024-04-24 Thread via GitHub


volosied commented on PR #708:
URL: https://github.com/apache/myfaces/pull/708#issuecomment-2075445624

   @melloware  I'm hitting this in the quarkus tests? Not sure why -- it 
doesn't look related to my changes? Can you test / investigate this PR?
   
   ```
   
---
   Test set: 
org.apache.myfaces.core.extensions.quarkus.showcase.QuarkusMyFacesShowcaseTest
   
---
   Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.128 s <<< 
FAILURE! - in 
org.apache.myfaces.core.extensions.quarkus.showcase.QuarkusMyFacesShowcaseTest
   
org.apache.myfaces.core.extensions.quarkus.showcase.QuarkusMyFacesShowcaseTest  
Time elapsed: 2.128 s  <<< ERROR!
   java.lang.RuntimeException: 
   java.lang.RuntimeException: io.quarkus.builder.BuildException: Build 
failure: Build failed due to errors
[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate 
threw an exception: jakarta.enterprise.inject.spi.DeploymentException: 
jakarta.enterprise.inject.UnsatisfiedResolutionException: Unsatisfied 
dependency for type PushContext and qualifiers [@Default]
- java member: 
org.apache.myfaces.core.extensions.quarkus.showcase.view.SocketView#helloChannel
- declared on CLASS bean [types=[java.io.Serializable, 
org.apache.myfaces.core.extensions.quarkus.showcase.view.SocketView, 
java.lang.Object], qualifiers=[@Default, @Any, @Named("socketView")], 
target=org.apache.myfaces.core.extensions.quarkus.showcase.view.SocketView]
at 
io.quarkus.arc.processor.BeanDeployment.processErrors(BeanDeployment.java:1435)
at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:310)
at 
io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:155)
at 
io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:469)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at 
io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:864)
at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
at 
org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
at 
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
at java.base/java.lang.Thread.run(Thread.java:833)
at org.jboss.threads.JBossThread.run(JBossThread.java:501)
   Caused by: jakarta.enterprise.inject.UnsatisfiedResolutionException: 
Unsatisfied dependency for type PushContext and qualifiers [@Default]
- java member: 
org.apache.myfaces.core.extensions.quarkus.showcase.view.SocketView#helloChannel
- declared on CLASS bean [types=[java.io.Serializable, 
org.apache.myfaces.core.extensions.quarkus.showcase.view.SocketView, 
java.lang.Object], qualifiers=[@Default, @Any, @Named("socketView")], 
target=org.apache.myfaces.core.extensions.quarkus.showcase.view.SocketView]
at io.quarkus.arc.processor.Beans.resolveInjectionPoint(Beans.java:477)
at io.quarkus.arc.processor.BeanInfo.init(BeanInfo.java:624)
at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:298)
... 13 more
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org