henningn commented on code in PR #4405:
URL: https://github.com/apache/myfaces-tobago/pull/4405#discussion_r1378639445
##
tobago-example/tobago-example-demo/package.json:
##
@@ -21,12 +21,11 @@
"css-prefix_xxx": "postcss --config postcss.config.js --replace
src/main/webapp/css/demo.css",
"css-minify": "cleancss -O1 specialComments:0 --format breakWith=lf
--source-map --source-map-inline-sources --output
src/main/webapp/css/demo.min.css src/main/webapp/css/demo.css",
"css-copy-prism": "ncp node_modules/prismjs/themes/prism.css
src/main/webapp/css/prism.css",
-"fa": "npm-run-all fa-mkdir --parallel fa-css fa-fonts",
-"fa-mkdir": "mkdir -p src/main/webapp/css src/main/webapp/fonts",
-"fa-css": "ncp node_modules/font-awesome/css/ src/main/webapp/css
--filter='.*(css|font-awesome\\.).*$'",
-"fa-fonts": "ncp node_modules/font-awesome/fonts src/main/webapp/fonts
--filter='.*(fonts|fontawesome-webfont.woff.*)$'",
+"fa": "npm-run-all --parallel fa-css fa-fonts",
+"fa-css": "ncp node_modules/font-awesome/css/ src/main/webapp/css
--filter='.*(font-awesome\\.).*$'",
+"fa-fonts": "ncp node_modules/font-awesome/fonts src/main/webapp/fonts
--filter='.*(fontawesome-webfont.woff.*)$'",
"jasmine": "npm-run-all --parallel jasmine-cp-js jasmine-cp-css",
-"jasmine-cp-js": "ncp node_modules/jasmine-core/lib/jasmine-core
src/main/webapp/js
--filter='.*(jasmine-core|/boot..js|/jasmine-html.js|/jasmine.js)$'",
Review Comment:
jasmine JS files are no longer copied
##
tobago-example/tobago-example-demo/package.json:
##
@@ -21,12 +21,11 @@
"css-prefix_xxx": "postcss --config postcss.config.js --replace
src/main/webapp/css/demo.css",
"css-minify": "cleancss -O1 specialComments:0 --format breakWith=lf
--source-map --source-map-inline-sources --output
src/main/webapp/css/demo.min.css src/main/webapp/css/demo.css",
"css-copy-prism": "ncp node_modules/prismjs/themes/prism.css
src/main/webapp/css/prism.css",
-"fa": "npm-run-all fa-mkdir --parallel fa-css fa-fonts",
-"fa-mkdir": "mkdir -p src/main/webapp/css src/main/webapp/fonts",
-"fa-css": "ncp node_modules/font-awesome/css/ src/main/webapp/css
--filter='.*(css|font-awesome\\.).*$'",
Review Comment:
fontawesome CSS is no longer copied
##
tobago-example/tobago-example-demo/package.json:
##
@@ -21,12 +21,11 @@
"css-prefix_xxx": "postcss --config postcss.config.js --replace
src/main/webapp/css/demo.css",
"css-minify": "cleancss -O1 specialComments:0 --format breakWith=lf
--source-map --source-map-inline-sources --output
src/main/webapp/css/demo.min.css src/main/webapp/css/demo.css",
"css-copy-prism": "ncp node_modules/prismjs/themes/prism.css
src/main/webapp/css/prism.css",
-"fa": "npm-run-all fa-mkdir --parallel fa-css fa-fonts",
-"fa-mkdir": "mkdir -p src/main/webapp/css src/main/webapp/fonts",
-"fa-css": "ncp node_modules/font-awesome/css/ src/main/webapp/css
--filter='.*(css|font-awesome\\.).*$'",
-"fa-fonts": "ncp node_modules/font-awesome/fonts src/main/webapp/fonts
--filter='.*(fonts|fontawesome-webfont.woff.*)$'",
Review Comment:
fontawesome Fonts are no longer copied to the font directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
