Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1792016552 Give it a shot, we can merge it, from my side it works! (tested it with my it test suite) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu commented on PR #637: URL: https://github.com/apache/myfaces/pull/637#issuecomment-1792015711 Build broken for branch: java.lang.NullPointerException at aQute.bnd.header.OSGiHeader.quote(OSGiHeader.java:153) at aQute.bnd.header.Attrs.append(Attrs.java:424) at aQute.bnd.header.Attrs.append(Attrs.java:404) at aQute.bnd.header.Parameters.append(Parameters.java:175) at aQute.bnd.header.Parameters.toString(Parameters.java:164) at aQute.bnd.osgi.Analyzer.calcManifest(Analyzer.java:789) at aQute.bnd.osgi.Builder.build(Builder.java:104) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu opened a new pull request, #638: URL: https://github.com/apache/myfaces/pull/638 Fix for MyFaces 4606, checkboxes and radio buttons are not appended automatically if unchecked! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu opened a new pull request, #637: URL: https://github.com/apache/myfaces/pull/637 Fix for MyFaces 4606, checkboxes and radio buttons are not appended automatically if unchecked! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
volosied commented on PR #630: URL: https://github.com/apache/myfaces/pull/630#issuecomment-1766546891 Haven't run the the full tck yet, but the one test that failed is now passing. I should have all the results by tomorrow. I think the changes should be fine. Can you get a PR for the older JS code base and I can port it all the other affected branches? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu commented on PR #630: URL: https://github.com/apache/myfaces/pull/630#issuecomment-1765739544 does it fix the issue for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
volosied commented on PR #630: URL: https://github.com/apache/myfaces/pull/630#issuecomment-1762520466 Running tests. Will report later. Thanks for getting this PR up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu commented on PR #630: URL: https://github.com/apache/myfaces/pull/630#issuecomment-1762127783 I will leave this pull request open for a few days and merge on monday! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]
werpu opened a new pull request, #630: URL: https://github.com/apache/myfaces/pull/630 Fix for MyFaces 4606, checkboxes and radio buttons are not appended automatically if unchecked! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
