Re: [Trinidad] proposed API change on ChangeManager

2010-04-08 Thread Matthias Wessendorf 
looks OK

+1

On Wed, Apr 7, 2010 at 11:29 PM, Gabrielle Crawford
gabrielle.crawf...@oracle.com wrote:
 adding Trinidad to the subject

 Yuan Gao wrote:

 hi,

 For JIRA 1761 (https://issues.apache.org/jira/browse/TRINIDAD-1761), we
 propose to add this API to the ChangeManager interface:
  /**
   * Replace an AttributeComponentChange if it's present.
   *
   * @param facesContext
   * @param uiComponent
   * @param attributeComponentChange
   * @return the old change instance
   */
  public AttributeComponentChange
 replaceAttributeChangeIfPresent(FacesContext facesContext,
    UIComponent uiComponent,
    AttributeComponentChange attributeComponentChange);


 Let me know what do you think about it.

 Thanks,
 -Yuan






-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

[Trinidad] proposed API change on ChangeManager

2010-04-07 Thread Gabrielle Crawford 

adding Trinidad to the subject

Yuan Gao wrote:

hi,

For JIRA 1761 (https://issues.apache.org/jira/browse/TRINIDAD-1761), 
we propose to add this API to the ChangeManager interface:

  /**
   * Replace an AttributeComponentChange if it's present.
   *
   * @param facesContext
   * @param uiComponent
   * @param attributeComponentChange
   * @return the old change instance
   */
  public AttributeComponentChange 
replaceAttributeChangeIfPresent(FacesContext facesContext,

UIComponent uiComponent,
AttributeComponentChange attributeComponentChange);


Let me know what do you think about it.

Thanks,
-Yuan