Re: [core] do not check for duplicate ids when saving view on production stage
Sounds great. But with regard to your third point, what about keeping it more general? Maybe we later want to extend it to something we don't want to check in production that has nothing to do with IDs whatsoever? Maybe org.apache.myfaces.DISABLE_PRODUCTION_CHECKS or org.apache.myfaces.DISABLE_PRODUCTION_INSPECTIONS or org.apache.myfaces.DISABLE_INSPECTIONS_IN_PRODUCTION (default=false) would fit. However, I am usually not very good with names, so maybe we will find something better! Regards, Jakob 2011/5/19, Martin Koci martin.kocicak.k...@gmail.com: org.apache.myfaces.CHECK_ID_IN_PRODUCTION (default true) and when false: 1) skip duplicate id check 2) skip id validity check (in UIComponent.setId) 3) ... (something we found later) ... WDYT? Jakob Korherr píše v So 14. 05. 2011 v 12:26 +0200: +1 for a MyFaces specific parameter. Regards, Jakob 2011/5/11 Martin Koci martin.kocicak.k...@gmail.com: +1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/11 Leonardo Uribe lu4...@gmail.com Hi Checking the state saving algorithm I have seen that every time StateManager.saveView is called, it checks for duplicate ids, scanning the whole component tree. The documentation of StateManager.saveView says this: ...This method must also enforce the rule that, for components with non-null ids, all components that are descendants of the same nearest NamingContainer must have unique identifiers. Yes, that's right, but a possible optimization could be do not do it if project stage is production, or maybe just add a param that disable that stuff. Does that sounds good? Any objections? regards, Leonardo Uribe -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [core] do not check for duplicate ids when saving view on production stage
On Fri, May 20, 2011 at 2:40 AM, Jakob Korherr jakob.korh...@gmail.com wrote: Sounds great. But with regard to your third point, what about keeping it more general? Maybe we later want to extend it to something we don't want to check in production that has nothing to do with IDs whatsoever? Maybe org.apache.myfaces.DISABLE_PRODUCTION_CHECKS or org.apache.myfaces.DISABLE_PRODUCTION_INSPECTIONS or org.apache.myfaces.DISABLE_INSPECTIONS_IN_PRODUCTION org.apache.myfaces.OPTIMIZE_PRODUCTION? Or... org.apache.myfaces.OPTIMIZE_PROJECT_STAGES = e.g. SystemTest,Production Matt (default=false) would fit. However, I am usually not very good with names, so maybe we will find something better! Regards, Jakob 2011/5/19, Martin Koci martin.kocicak.k...@gmail.com: org.apache.myfaces.CHECK_ID_IN_PRODUCTION (default true) and when false: 1) skip duplicate id check 2) skip id validity check (in UIComponent.setId) 3) ... (something we found later) ... WDYT? Jakob Korherr píše v So 14. 05. 2011 v 12:26 +0200: +1 for a MyFaces specific parameter. Regards, Jakob 2011/5/11 Martin Koci martin.kocicak.k...@gmail.com: +1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/11 Leonardo Uribe lu4...@gmail.com Hi Checking the state saving algorithm I have seen that every time StateManager.saveView is called, it checks for duplicate ids, scanning the whole component tree. The documentation of StateManager.saveView says this: ...This method must also enforce the rule that, for components with non-null ids, all components that are descendants of the same nearest NamingContainer must have unique identifiers. Yes, that's right, but a possible optimization could be do not do it if project stage is production, or maybe just add a param that disable that stuff. Does that sounds good? Any objections? regards, Leonardo Uribe -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [core] do not check for duplicate ids when saving view on production stage
The point of the options is to customize your behavior from the standard expected configuration. I think you are better off keeping things as specific as possible rather than generalizing. If someone has a special reason why they need to turn on duplicate id warnings (like in this case), that doesn't mean they want to turn on any other warnings. On Fri, May 20, 2011 at 3:40 AM, Jakob Korherr jakob.korh...@gmail.com wrote: Sounds great. But with regard to your third point, what about keeping it more general? Maybe we later want to extend it to something we don't want to check in production that has nothing to do with IDs whatsoever? Maybe org.apache.myfaces.DISABLE_PRODUCTION_CHECKS or org.apache.myfaces.DISABLE_PRODUCTION_INSPECTIONS or org.apache.myfaces.DISABLE_INSPECTIONS_IN_PRODUCTION (default=false) would fit. However, I am usually not very good with names, so maybe we will find something better! Regards, Jakob 2011/5/19, Martin Koci martin.kocicak.k...@gmail.com: org.apache.myfaces.CHECK_ID_IN_PRODUCTION (default true) and when false: 1) skip duplicate id check 2) skip id validity check (in UIComponent.setId) 3) ... (something we found later) ... WDYT? Jakob Korherr píše v So 14. 05. 2011 v 12:26 +0200: +1 for a MyFaces specific parameter. Regards, Jakob 2011/5/11 Martin Koci martin.kocicak.k...@gmail.com: +1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/11 Leonardo Uribe lu4...@gmail.com Hi Checking the state saving algorithm I have seen that every time StateManager.saveView is called, it checks for duplicate ids, scanning the whole component tree. The documentation of StateManager.saveView says this: ...This method must also enforce the rule that, for components with non-null ids, all components that are descendants of the same nearest NamingContainer must have unique identifiers. Yes, that's right, but a possible optimization could be do not do it if project stage is production, or maybe just add a param that disable that stuff. Does that sounds good? Any objections? regards, Leonardo Uribe -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [core] do not check for duplicate ids when saving view on production stage
org.apache.myfaces.CHECK_ID_IN_PRODUCTION (default true) and when false: 1) skip duplicate id check 2) skip id validity check (in UIComponent.setId) 3) ... (something we found later) ... WDYT? Jakob Korherr píše v So 14. 05. 2011 v 12:26 +0200: +1 for a MyFaces specific parameter. Regards, Jakob 2011/5/11 Martin Koci martin.kocicak.k...@gmail.com: +1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/11 Leonardo Uribe lu4...@gmail.com Hi Checking the state saving algorithm I have seen that every time StateManager.saveView is called, it checks for duplicate ids, scanning the whole component tree. The documentation of StateManager.saveView says this: ...This method must also enforce the rule that, for components with non-null ids, all components that are descendants of the same nearest NamingContainer must have unique identifiers. Yes, that's right, but a possible optimization could be do not do it if project stage is production, or maybe just add a param that disable that stuff. Does that sounds good? Any objections? regards, Leonardo Uribe
Re: [core] do not check for duplicate ids when saving view on production stage
+1 for a MyFaces specific parameter. Regards, Jakob 2011/5/11 Martin Koci martin.kocicak.k...@gmail.com: +1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/11 Leonardo Uribe lu4...@gmail.com Hi Checking the state saving algorithm I have seen that every time StateManager.saveView is called, it checks for duplicate ids, scanning the whole component tree. The documentation of StateManager.saveView says this: ...This method must also enforce the rule that, for components with non-null ids, all components that are descendants of the same nearest NamingContainer must have unique identifiers. Yes, that's right, but a possible optimization could be do not do it if project stage is production, or maybe just add a param that disable that stuff. Does that sounds good? Any objections? regards, Leonardo Uribe -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [core] do not check for duplicate ids when saving view on production stage
+1 for specific parameter (in one project I build view dynamically from DB and want this ids check) Gerhard Petracek píše v St 11. 05. 2011 v 07:52 +0200: hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/11 Leonardo Uribe lu4...@gmail.com Hi Checking the state saving algorithm I have seen that every time StateManager.saveView is called, it checks for duplicate ids, scanning the whole component tree. The documentation of StateManager.saveView says this: ...This method must also enforce the rule that, for components with non-null ids, all components that are descendants of the same nearest NamingContainer must have unique identifiers. Yes, that's right, but a possible optimization could be do not do it if project stage is production, or maybe just add a param that disable that stuff. Does that sounds good? Any objections? regards, Leonardo Uribe
[core] do not check for duplicate ids when saving view on production stage
Hi Checking the state saving algorithm I have seen that every time StateManager.saveView is called, it checks for duplicate ids, scanning the whole component tree. The documentation of StateManager.saveView says this: ...This method must also enforce the rule that, for components with non-null ids, all components that are descendants of the same nearest NamingContainer must have unique identifiers. Yes, that's right, but a possible optimization could be do not do it if project stage is production, or maybe just add a param that disable that stuff. Does that sounds good? Any objections? regards, Leonardo Uribe
Re: [core] do not check for duplicate ids when saving view on production stage
hi, i would combine it - +1 for a myfaces specific parameter which gets evaluated in case of project-stage production. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/11 Leonardo Uribe lu4...@gmail.com Hi Checking the state saving algorithm I have seen that every time StateManager.saveView is called, it checks for duplicate ids, scanning the whole component tree. The documentation of StateManager.saveView says this: ...This method must also enforce the rule that, for components with non-null ids, all components that are descendants of the same nearest NamingContainer must have unique identifiers. Yes, that's right, but a possible optimization could be do not do it if project stage is production, or maybe just add a param that disable that stuff. Does that sounds good? Any objections? regards, Leonardo Uribe
