[jira] [Comment Edited] (MYFACES-4584) faces.js /ts improvements post 4.0
[ https://issues.apache.org/jira/browse/MYFACES-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697975#comment-17697975 ] Werner Punz edited comment on MYFACES-4584 at 3/8/23 3:54 PM: -- I would have most of my fixes for the codebase ready, which version do we aim for? I also could clean up the handling of, the internal Config datastructures as additional benefit down to an associative array, which should speed things up slightly but also makes internal debugging easier (less abstractions in the config) If it is ok we could merge for 4.0.1, otherwise a later version! The apis have not changed this is mostly smaller code improvements and code refactoring to get some indirection layers out. was (Author: werpu): I would have most of my fixes for the codebase ready, which version do we aim for? I also could clean up the handling of, the internal Config datastructures as additional benefit down to an associative array, which should speed things up slightly but also makes internal debugging easier (less abstractions in the config) If it is ok we could merge for 4.0.1, otherwise a later version! The apis have not changed this is mostly smaller code improvements. > faces.js /ts improvements post 4.0 > -- > > Key: MYFACES-4584 > URL: https://issues.apache.org/jira/browse/MYFACES-4584 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > Several ideas on how to go forward, a 4.0.1 branch is already opened on the > separate github project > a) JSF_TS github > elimination of streams in favor or arrays, introduction of a shim if needed > reintroduction of partial page submit as myfaces.pps=true option > > Both tasks are already done and working on the github jsf_ts side! > > b) Project organisation > The Question is on how we go forward -> Given that the codebase is not only > used by MyFaces but also Tobago even for their 2.3 code we cannot roll the > codebase entirely into myfaces as is but on the other hand we will get > bugfixes from the myfaces side in, which might become lost. > As a quick fix, I will write a small script which diffs the codebase with the > npm dir to see if there are any local codechanges (the npm dir pulls the > version in which is linked) so that a deviation is quickly shown. This is > more a private thing, but can be hooked in as node task (we already have a > small set of build helpers)! > So running this script before updating into the latest codebase shows if > there are some deviations between the node version and the sources. > In the long run we might have to roll the jsf_ts codebase into myfaces one > way or the other. Not sure yet how, given that I soon wont be able to commit > full time anymore (but given that 99% of the work on the js_ts side is done > anyway), good question! > > > > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4584) faces.js /ts improvements post 4.0
[ https://issues.apache.org/jira/browse/MYFACES-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696912#comment-17696912 ] Werner Punz edited comment on MYFACES-4584 at 3/6/23 12:47 PM: --- The same reason primefaces uses its own... it had problems with the default implementations, when I did the reimplementation they took it in and things started to work for them. It might not be needed anymore given we now have the same implementation on both ends, but Tobago still supports 2.3 so it still makes sense there. In the end this is Tobagos decision not mine! I never influenced them to do it, just told them that I was working on a reimplementation! But I was happy they did because their unit tests gave my code an additional testing layer and they provided several tests on things which crawled up for them! So it was a win win for both! Whether they are going to drop the included codebase for the 4.0 version is up to them, their project :) was (Author: werpu): The same reason primefaces uses its own... it had problems with the default implementations, when I did the reimplementation they took it in and things started to work for them. It might not be needed anymore given we now have the same implementation on both ends, but Tobago still supports 2.3 so it still makes sense there. In the end this is Tobagos decision not mine! I never influenced them to do it, just told them that I was working on a reimplementation! > faces.js /ts improvements post 4.0 > -- > > Key: MYFACES-4584 > URL: https://issues.apache.org/jira/browse/MYFACES-4584 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > Several ideas on how to go forward, a 4.0.1 branch is already opened on the > separate github project > a) JSF_TS github > elimination of streams in favor or arrays, introduction of a shim if needed > reintroduction of partial page submit as myfaces.pps=true option > > Both tasks are already done and working on the github jsf_ts side! > > b) Project organisation > The Question is on how we go forward -> Given that the codebase is not only > used by MyFaces but also Tobago even for their 2.3 code we cannot roll the > codebase entirely into myfaces as is but on the other hand we will get > bugfixes from the myfaces side in, which might become lost. > As a quick fix, I will write a small script which diffs the codebase with the > npm dir to see if there are any local codechanges (the npm dir pulls the > version in which is linked) so that a deviation is quickly shown. This is > more a private thing, but can be hooked in as node task (we already have a > small set of build helpers)! > So running this script before updating into the latest codebase shows if > there are some deviations between the node version and the sources. > In the long run we might have to roll the jsf_ts codebase into myfaces one > way or the other. Not sure yet how, given that I soon wont be able to commit > full time anymore (but given that 99% of the work on the js_ts side is done > anyway), good question! > > > > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4584) faces.js /ts improvements post 4.0
[ https://issues.apache.org/jira/browse/MYFACES-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696912#comment-17696912 ] Werner Punz edited comment on MYFACES-4584 at 3/6/23 12:17 PM: --- The same reason primefaces uses its own... it had problems with the default implementations, when I did the reimplementation they took it in and things started to work for them. It might not be needed anymore given we now have the same implementation on both ends, but Tobago still supports 2.3 so it still makes sense there. In the end this is Tobagos decision not mine! I never influenced them to do it, just told them that I was working on a reimplementation! was (Author: werpu): The same reason primefaces uses its own... it had problems with the default implementations, when I did the reimplementation they took it in. It might not be needed anymore given we now have the same implementation on both ends, but Tobago still supports 2.3 so it still makes sense there. > faces.js /ts improvements post 4.0 > -- > > Key: MYFACES-4584 > URL: https://issues.apache.org/jira/browse/MYFACES-4584 > Project: MyFaces Core > Issue Type: Improvement >Reporter: Werner Punz >Assignee: Werner Punz >Priority: Major > > Several ideas on how to go forward, a 4.0.1 branch is already opened on the > separate github project > a) JSF_TS github > elimination of streams in favor or arrays, introduction of a shim if needed > reintroduction of partial page submit as myfaces.pps=true option > > Both tasks are already done and working on the github jsf_ts side! > > b) Project organisation > The Question is on how we go forward -> Given that the codebase is not only > used by MyFaces but also Tobago even for their 2.3 code we cannot roll the > codebase entirely into myfaces as is but on the other hand we will get > bugfixes from the myfaces side in, which might become lost. > As a quick fix, I will write a small script which diffs the codebase with the > npm dir to see if there are any local codechanges (the npm dir pulls the > version in which is linked) so that a deviation is quickly shown. This is > more a private thing, but can be hooked in as node task (we already have a > small set of build helpers)! > So running this script before updating into the latest codebase shows if > there are some deviations between the node version and the sources. > In the long run we might have to roll the jsf_ts codebase into myfaces one > way or the other. Not sure yet how, given that I soon wont be able to commit > full time anymore (but given that 99% of the work on the js_ts side is done > anyway), good question! > > > > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
