[jira] [Comment Edited] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782455#comment-17782455 ] Werner Punz edited comment on MYFACES-4636 at 11/3/23 8:18 AM: --- Looks ok to me, the test reconfirms the result anyway, I wonder why the +colon was added, probably a misunderstanding of the mechanism, but we will see! This might not only affect 2.3 but also the other branches, this needs to be reconfirmed! Thanks for fixing this [~tandraschko] was (Author: werpu): Looks ok to me, the test reconfirms the result anyway, I wonder why the +colon was added, probably a misunderstanding of the mechanism, but we will see! Thanks for fixing this [~tandraschko] > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Fix For: 4.0.2, 2.3-next-M9, 4.1.0, 5.0.0 > > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781339#comment-17781339 ] Werner Punz edited comment on MYFACES-4636 at 10/31/23 12:52 PM: - This seems to be an issue in the java renderer, the analysis is correct, the chain function is wrongly constructed! a comma is missing after testJs! Afair when I did the 4.0 javascripts I noticed that the spec passing the params has changed slightly, i adapted the code, you now can and should pass params maps via params: instead of just passing the map! I left the way how we did it in the past open, but it seems there was a slight mistake in the changes in the java renderer adapting to the spec conform api! was (Author: werpu): This seems to be an issue in the java renderer, the analysis is correct, the chain function is wrongly constructed! a comma is missing after testJs! > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781339#comment-17781339 ] Werner Punz edited comment on MYFACES-4636 at 10/31/23 12:50 PM: - This seems to be an issue in the java renderer, the analysis is correct, the chain function is wrongly constructed! a comma is missing after testJs! was (Author: werpu): This seems to be an issue in the java renderer, the analysis is correct, the chain function is wrongly constructed! > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MYFACES-4636) Using f:param + f:ajax onvent results in an error
[ https://issues.apache.org/jira/browse/MYFACES-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781339#comment-17781339 ] Werner Punz edited comment on MYFACES-4636 at 10/31/23 12:49 PM: - This seems to be an issue in the java renderer, the analysis is correct, the chain function is wrongly constructed! was (Author: werpu): This seems to be an issue in the java renderer, this is not syntatically correct, onevent wants a function. There seems to be something going wrong with the params rendering onEvent: testJsParams is definitely wrong here! > Using f:param + f:ajax onvent results in an error > - > > Key: MYFACES-4636 > URL: https://issues.apache.org/jira/browse/MYFACES-4636 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3-next-M8 >Reporter: Vitaly Sidorov >Priority: Major > Attachments: sample.zip > > > *Steps to reproduce:* > - create xhtml with f:param and f:ajax onevent like this: > > {code:html} > > > > > execute="@this" > onevent="testJs"> > > > > > // function testJs(data) { > if (data.status === 'success') { > alert("Success click") > } > } > //]]> > > {code} > > - click on "Click me" > - get an error in the console: "{color:#FF}Uncaught SyntaxError: > Unexpected token ':' (at index.xhtml:9:868){color}" > *The reason:* > Generated page code by M7 build: > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJs,'var1':'NEW > VALUE'})}); return false; > {code} > Generated page code by M8 build with *bad JS* (look at {*}testJsparams{*}): > {code:javascript} > jsf.util.chain(this, > event,function(event){myfaces.ab(this,event,'click','j_id_i','',{'onevent':testJsparams:{'var1':'NEW > VALUE'}})}); return false; > {code} > *I've attached an archive with an example.* -- This message was sent by Atlassian Jira (v8.20.10#820010)