[jira] [Commented] (MYFACES-3800) HtmlLinkRendererBase encodes url using encodeResourceURL instead encodeActionURL

[Leonardo Uribe (JIRA)]

[ 
https://issues.apache.org/jira/browse/MYFACES-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797157#comment-13797157
 ] 

Leonardo Uribe commented on MYFACES-3800:
-

That part is dictated by JSF spec, and it is not possible to change it. I think 
there is no need to call encodeActionURL from that point (or no strong reason 
has been given to do such change) I'll close this issue as invalid.

 HtmlLinkRendererBase encodes url using encodeResourceURL instead 
 encodeActionURL
 

 Key: MYFACES-3800
 URL: https://issues.apache.org/jira/browse/MYFACES-3800
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 2.1.12
Reporter: Jan Dosoudil
Priority: Minor

 Link to resource is IMHO less frequent then to an action. (I don't think 
 there is frequent purpose for resource linking) 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Commented] (MYFACES-3800) HtmlLinkRendererBase encodes url using encodeResourceURL instead encodeActionURL

[Jan Dosoudil (JIRA)]

[ 
https://issues.apache.org/jira/browse/MYFACES-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789219#comment-13789219
 ] 

Jan Dosoudil commented on MYFACES-3800:
---

Here is simple patch.
{code}
Index: 
shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
===
--- 
shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
 (revision 1529776)
+++ 
shared/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
 (working copy)
@@ -980,7 +980,7 @@
 {
 href += anchorString;
 }
-href = facesContext.getExternalContext().encodeResourceURL(href);  
  //TODO: or encodeActionURL ?
+href = facesContext.getExternalContext().encodeActionURL(href);
 
 //write anchor
 writer.startElement(HTML.ANCHOR_ELEM, output);

{code}

 HtmlLinkRendererBase encodes url using encodeResourceURL instead 
 encodeActionURL
 

 Key: MYFACES-3800
 URL: https://issues.apache.org/jira/browse/MYFACES-3800
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 2.1.12
Reporter: Jan Dosoudil
Priority: Minor

 Link to resource is IMHO less frequent then to an action. (I don't think 
 there is frequent purpose for resource linking) 



--
This message was sent by Atlassian JIRA
(v6.1#6144)