[jira] [Commented] (MYFACES-3902) jsf.js: error handling output improvement
[
https://issues.apache.org/jira/browse/MYFACES-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14055959#comment-14055959
]
Krashan Brahmanjara commented on MYFACES-3902:
--
We test software in Development mode and this alert never occurs - only log to
console occurs.
So we move if(jsf.getProjectStage() === Development) { test before console
test and now alert is visible in Development mode. This is more useful for
developers.
jsf.js: error handling output improvement
-
Key: MYFACES-3902
URL: https://issues.apache.org/jira/browse/MYFACES-3902
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.2.3
Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4
Firefox =18
Reporter: Krashan Brahmanjara
Fix For: 2.0.22, 2.1.16, 2.2.4
Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors
- Icefaces js has exceptions without message and description a message is
directly a 'e' object. So an error 'invalid property' is printed to console
- development mode is ignored by this catch block, in reverse order checking
too because jsf.ajax.getProjectStage() is not initialized
Workaround - because development mode is recognized we can only show an alert
{noformat}
} catch (e) {
/*
if(window.console window.console.error) {
//not sure if we
//should use our standard
//error mechanisms here
//because in the head appendix
//method only a console
//error would be raised as well
if (e.message) {
window.console.error(e.message);
} else {
if (e.description) {
window.console.error(e.description);
} else {
window.console.error(e);
}
}
}
if(jsf.ajax.getProjectStage() === Development) {
*/
if (e.message) {
alert(Error in evaluated javascript:+
(e.message));
} else {
if (e.description) {
alert(Error in evaluated
javascript:+ (e.description));
} else {
alert(Error in evaluated
javascript:+ (e));
}
}
/*
}
*/
} finally {
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (MYFACES-3902) jsf.js: error handling output improvement
[
https://issues.apache.org/jira/browse/MYFACES-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14055999#comment-14055999
]
Werner Punz commented on MYFACES-3902:
--
I double checked the code, this is not in consistency with the way the rest of
the system handles errors, in the rest of the system we have alerts only with a
config way to override the alerts. I will change this accordingly. I will open
another issue later today regarding fixing this.
jsf.js: error handling output improvement
-
Key: MYFACES-3902
URL: https://issues.apache.org/jira/browse/MYFACES-3902
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.2.3
Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4
Firefox =18
Reporter: Krashan Brahmanjara
Fix For: 2.0.22, 2.1.16, 2.2.4
Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors
- Icefaces js has exceptions without message and description a message is
directly a 'e' object. So an error 'invalid property' is printed to console
- development mode is ignored by this catch block, in reverse order checking
too because jsf.ajax.getProjectStage() is not initialized
Workaround - because development mode is recognized we can only show an alert
{noformat}
} catch (e) {
/*
if(window.console window.console.error) {
//not sure if we
//should use our standard
//error mechanisms here
//because in the head appendix
//method only a console
//error would be raised as well
if (e.message) {
window.console.error(e.message);
} else {
if (e.description) {
window.console.error(e.description);
} else {
window.console.error(e);
}
}
}
if(jsf.ajax.getProjectStage() === Development) {
*/
if (e.message) {
alert(Error in evaluated javascript:+
(e.message));
} else {
if (e.description) {
alert(Error in evaluated
javascript:+ (e.description));
} else {
alert(Error in evaluated
javascript:+ (e));
}
}
/*
}
*/
} finally {
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (MYFACES-3902) jsf.js: error handling output improvement
[
https://issues.apache.org/jira/browse/MYFACES-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056139#comment-14056139
]
Werner Punz commented on MYFACES-3902:
--
Ok I opened another improvement/defect
https://issues.apache.org/jira/browse/MYFACES-3906 for this exact issue, that
we are in accordance with the rest of the error handling.
jsf.js: error handling output improvement
-
Key: MYFACES-3902
URL: https://issues.apache.org/jira/browse/MYFACES-3902
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.2.3
Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4
Firefox =18
Reporter: Krashan Brahmanjara
Fix For: 2.0.22, 2.1.16, 2.2.4
Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors
- Icefaces js has exceptions without message and description a message is
directly a 'e' object. So an error 'invalid property' is printed to console
- development mode is ignored by this catch block, in reverse order checking
too because jsf.ajax.getProjectStage() is not initialized
Workaround - because development mode is recognized we can only show an alert
{noformat}
} catch (e) {
/*
if(window.console window.console.error) {
//not sure if we
//should use our standard
//error mechanisms here
//because in the head appendix
//method only a console
//error would be raised as well
if (e.message) {
window.console.error(e.message);
} else {
if (e.description) {
window.console.error(e.description);
} else {
window.console.error(e);
}
}
}
if(jsf.ajax.getProjectStage() === Development) {
*/
if (e.message) {
alert(Error in evaluated javascript:+
(e.message));
} else {
if (e.description) {
alert(Error in evaluated
javascript:+ (e.description));
} else {
alert(Error in evaluated
javascript:+ (e));
}
}
/*
}
*/
} finally {
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (MYFACES-3902) jsf.js: error handling output improvement
[
https://issues.apache.org/jira/browse/MYFACES-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047496#comment-14047496
]
Krashan Brahmanjara commented on MYFACES-3902:
--
You probably forget about 'if; order.
Test if(jsf.getProjectStage() === Development) { should be executed first.
jsf.js: error handling output improvement
-
Key: MYFACES-3902
URL: https://issues.apache.org/jira/browse/MYFACES-3902
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.2.3
Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4
Firefox =18
Reporter: Krashan Brahmanjara
Fix For: 2.0.22, 2.1.16, 2.2.4
Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors
- Icefaces js has exceptions without message and description a message is
directly a 'e' object. So an error 'invalid property' is printed to console
- development mode is ignored by this catch block, in reverse order checking
too because jsf.ajax.getProjectStage() is not initialized
Workaround - because development mode is recognized we can only show an alert
{noformat}
} catch (e) {
/*
if(window.console window.console.error) {
//not sure if we
//should use our standard
//error mechanisms here
//because in the head appendix
//method only a console
//error would be raised as well
if (e.message) {
window.console.error(e.message);
} else {
if (e.description) {
window.console.error(e.description);
} else {
window.console.error(e);
}
}
}
if(jsf.ajax.getProjectStage() === Development) {
*/
if (e.message) {
alert(Error in evaluated javascript:+
(e.message));
} else {
if (e.description) {
alert(Error in evaluated
javascript:+ (e.description));
} else {
alert(Error in evaluated
javascript:+ (e));
}
}
/*
}
*/
} finally {
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (MYFACES-3902) jsf.js: error handling output improvement
[
https://issues.apache.org/jira/browse/MYFACES-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14047503#comment-14047503
]
Werner Punz commented on MYFACES-3902:
--
No the order is intentitional, the console.error if possible is a non blocking
operation which does not disturb the users, i always log a javascript error if
a console log is present, if not then we go into a blocking alert operation.
The alert is a blocking operation and disturbs the users heavily, hence I only
alert on Development mode.
jsf.js: error handling output improvement
-
Key: MYFACES-3902
URL: https://issues.apache.org/jira/browse/MYFACES-3902
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.2.3
Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4
Firefox =18
Reporter: Krashan Brahmanjara
Fix For: 2.0.22, 2.1.16, 2.2.4
Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors
- Icefaces js has exceptions without message and description a message is
directly a 'e' object. So an error 'invalid property' is printed to console
- development mode is ignored by this catch block, in reverse order checking
too because jsf.ajax.getProjectStage() is not initialized
Workaround - because development mode is recognized we can only show an alert
{noformat}
} catch (e) {
/*
if(window.console window.console.error) {
//not sure if we
//should use our standard
//error mechanisms here
//because in the head appendix
//method only a console
//error would be raised as well
if (e.message) {
window.console.error(e.message);
} else {
if (e.description) {
window.console.error(e.description);
} else {
window.console.error(e);
}
}
}
if(jsf.ajax.getProjectStage() === Development) {
*/
if (e.message) {
alert(Error in evaluated javascript:+
(e.message));
} else {
if (e.description) {
alert(Error in evaluated
javascript:+ (e.description));
} else {
alert(Error in evaluated
javascript:+ (e));
}
}
/*
}
*/
} finally {
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (MYFACES-3902) jsf.js: error handling output improvement
[
https://issues.apache.org/jira/browse/MYFACES-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040516#comment-14040516
]
Werner Punz commented on MYFACES-3902:
--
Thanks for reporting the issue, I will work on it sometime this week, as my
time permits.
jsf.js: error handling output improvement
-
Key: MYFACES-3902
URL: https://issues.apache.org/jira/browse/MYFACES-3902
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.2.3
Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4
Firefox =18
Reporter: Krashan Brahmanjara
Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors
- Icefaces js has exceptions without message and description a message is
directly a 'e' object. So an error 'invalid property' is printed to console
- development mode is ignored by this catch block, in reverse order checking
too because jsf.ajax.getProjectStage() is not initialized
Workaround - because development mode is recognized we can only show an alert
{noformat}
} catch (e) {
/*
if(window.console window.console.error) {
//not sure if we
//should use our standard
//error mechanisms here
//because in the head appendix
//method only a console
//error would be raised as well
if (e.message) {
window.console.error(e.message);
} else {
if (e.description) {
window.console.error(e.description);
} else {
window.console.error(e);
}
}
}
if(jsf.ajax.getProjectStage() === Development) {
*/
if (e.message) {
alert(Error in evaluated javascript:+
(e.message));
} else {
if (e.description) {
alert(Error in evaluated
javascript:+ (e.description));
} else {
alert(Error in evaluated
javascript:+ (e));
}
}
/*
}
*/
} finally {
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (MYFACES-3902) jsf.js: error handling output improvement
[
https://issues.apache.org/jira/browse/MYFACES-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040562#comment-14040562
]
Werner Punz commented on MYFACES-3902:
--
There were actually two problems a) we have to have a fallback for a pure e
object as parameter, secondly there was a wrong call to getProjectStage both
will be fixed asap
jsf.js: error handling output improvement
-
Key: MYFACES-3902
URL: https://issues.apache.org/jira/browse/MYFACES-3902
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.2.3
Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4
Firefox =18
Reporter: Krashan Brahmanjara
Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors
- Icefaces js has exceptions without message and description a message is
directly a 'e' object. So an error 'invalid property' is printed to console
- development mode is ignored by this catch block, in reverse order checking
too because jsf.ajax.getProjectStage() is not initialized
Workaround - because development mode is recognized we can only show an alert
{noformat}
} catch (e) {
/*
if(window.console window.console.error) {
//not sure if we
//should use our standard
//error mechanisms here
//because in the head appendix
//method only a console
//error would be raised as well
if (e.message) {
window.console.error(e.message);
} else {
if (e.description) {
window.console.error(e.description);
} else {
window.console.error(e);
}
}
}
if(jsf.ajax.getProjectStage() === Development) {
*/
if (e.message) {
alert(Error in evaluated javascript:+
(e.message));
} else {
if (e.description) {
alert(Error in evaluated
javascript:+ (e.description));
} else {
alert(Error in evaluated
javascript:+ (e));
}
}
/*
}
*/
} finally {
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (MYFACES-3902) jsf.js: error handling output improvement
[
https://issues.apache.org/jira/browse/MYFACES-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040577#comment-14040577
]
Werner Punz commented on MYFACES-3902:
--
Fixed
jsf.js: error handling output improvement
-
Key: MYFACES-3902
URL: https://issues.apache.org/jira/browse/MYFACES-3902
Project: MyFaces Core
Issue Type: Bug
Components: General
Affects Versions: 2.2.3
Environment: Snapshot code 2.2.3 from trunk + Icefaces 4/Primefaces 4
Firefox =18
Reporter: Krashan Brahmanjara
Fix For: 2.0.22-SNAPSHOT, 2.1.16-SNAPSHOT, 2.2.4-SNAPSHOT
Myfaces core do not show real javascipt errors.
In _Dom.js there is a catch block in rows 192-203.
Unofortunately I see two errors
- Icefaces js has exceptions without message and description a message is
directly a 'e' object. So an error 'invalid property' is printed to console
- development mode is ignored by this catch block, in reverse order checking
too because jsf.ajax.getProjectStage() is not initialized
Workaround - because development mode is recognized we can only show an alert
{noformat}
} catch (e) {
/*
if(window.console window.console.error) {
//not sure if we
//should use our standard
//error mechanisms here
//because in the head appendix
//method only a console
//error would be raised as well
if (e.message) {
window.console.error(e.message);
} else {
if (e.description) {
window.console.error(e.description);
} else {
window.console.error(e);
}
}
}
if(jsf.ajax.getProjectStage() === Development) {
*/
if (e.message) {
alert(Error in evaluated javascript:+
(e.message));
} else {
if (e.description) {
alert(Error in evaluated
javascript:+ (e.description));
} else {
alert(Error in evaluated
javascript:+ (e));
}
}
/*
}
*/
} finally {
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
