[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435880#comment-16435880 ] Thomas Andraschko commented on MYFACES-4160: Dont think that its fixed. Could you create a issue and fix it? :P > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz >Priority: Major > Fix For: 2.3.0 > > Attachments: test1.xhtml > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[
https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435820#comment-16435820
]
Mark Struberg commented on MYFACES-4160:
Folks, I also get the following issue when starting up MyFaces with plain
tomcat and OWB:
{noformat}
An error occured while initializing MyFaces: It's not allowed to call
getBeans(Type, Annotation...) before AfterBeanDiscovery
java.lang.IllegalStateException: It's not allowed to call getBeans(Type,
Annotation...) before AfterBeanDiscovery
at
org.apache.webbeans.container.InjectableBeanManager.checkAfterBeanDiscoveryProcessed(InjectableBeanManager.java:423)
at
org.apache.webbeans.container.InjectableBeanManager.getBeans(InjectableBeanManager.java:129)
at org.apache.myfaces.cdi.util.CDIUtils.lookup(CDIUtils.java:45)
at
org.apache.myfaces.flow.cdi.DefaultCDIFacesFlowProvider.getAnnotatedFlows(DefaultCDIFacesFlowProvider.java:52)
at
org.apache.myfaces.flow.impl.AnnotatedFlowConfigurator.configureAnnotatedFlows(AnnotatedFlowConfigurator.java:42)
at
org.apache.myfaces.config.FacesConfigurator.configureFlowHandler(FacesConfigurator.java:1672)
at
org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:614)
at
org.apache.myfaces.webapp.AbstractFacesInitializer.buildConfiguration(AbstractFacesInitializer.java:416)
at
org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:74)
at
org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces(AbstractFacesInitializer.java:172)
at
org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:121)
{noformat}
Should this be fixed with this commit or is this another issue which we need to
address?
> ViewState not written for Ajax request
> --
>
> Key: MYFACES-4160
> URL: https://issues.apache.org/jira/browse/MYFACES-4160
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 2.3.0-beta
>Reporter: Thomas Andraschko
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3.0
>
> Attachments: test1.xhtml
>
>
> If you run the application from MYFACES-4156 via mvn jetty:run, the
> viewStateId isn't rendered again after the first ajax request.
> Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it
> skips.
> [~lu4242] Could you please check that?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292407#comment-16292407 ] Werner Punz commented on MYFACES-4160: -- I have revisited this bug again because Thomas has reported also a firefox warning of getElementById called with an empty string. The cause of this warning is not in the javascripts but in the way the h:selectOneRadio is resolved: Becomes staticValue1 Now if you check the label field, an empty string is passed as for and Firefox then complains probably due to some internal code the getElementById with empty string warning. There is no way to fix this in the javascripts, the selectOneRadio renderer must be fixed for this. I dont know if we need another bug report for that. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > Attachments: test1.xhtml > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276893#comment-16276893 ] Eduardo Breijo commented on MYFACES-4160: - I have retested both cases reported by Thomas and me, and both are working now. Thanks Werner for fix in it! :) > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > Attachments: test1.xhtml > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275748#comment-16275748 ] Werner Punz commented on MYFACES-4160: -- Fixed second issue which crawled up under 4169 as well. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > Attachments: test1.xhtml > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275740#comment-16275740 ] Werner Punz commented on MYFACES-4160: -- Fixed and committed. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > Attachments: test1.xhtml > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275725#comment-16275725 ] Werner Punz commented on MYFACES-4160: -- Sorry to respond so late, I was rather sick for three weeks. I have now almost fully recovered. I will recheck your testcase to see if the issue is reproducable. If not then it might have been fixed with my november fixes. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > Attachments: test1.xhtml > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246573#comment-16246573 ] Thomas Andraschko commented on MYFACES-4160: [~werpu] Found the exact problem! 1. requests posts: "javax.faces.ViewState=" 2. requests posts: "j_id__v_0:javax.faces.ViewState=..." seems like for the second request restore view fails. also firefox logs: Empty string passed to getElementById(). Just run the sample attached in 4169 > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246167#comment-16246167 ] Thomas Andraschko commented on MYFACES-4160: [~werpu] Not sure but i faced a similar issue now. I'm currently trying to fix + test the new selectOneRadio feature (https://issues.apache.org/jira/browse/MYFACES-4169) but it fails on the second ajax request. The issue is the following: RestoreViewExecutor on line 266 skips the further lifefcycle as the restored viewRoot doesn't have any metadata. Could you have a look at that sample? Maybe there is still somewrong with the viewstate id - looks like it stays the same for all ajax requests. I will attach the bean + xhtml in the linked issue (4169) > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198455#comment-16198455 ] Werner Punz commented on MYFACES-4160: -- Ok I found another issue, Fixed now. The login the error case and the logout now works as expected. I guess 4156 and 4160 are now fixed. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1619#comment-1619 ] Werner Punz commented on MYFACES-4160: -- The example from MYFACES-4156 looks fine now. My testing has shown that both forms get a new viewstate upon submission. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196588#comment-16196588 ] Thomas Andraschko commented on MYFACES-4160: Thanks werner! So my example app is also working now? > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196313#comment-16196313 ] Werner Punz commented on MYFACES-4160: -- Ok got in contact with one of the EG guys and it seems the spec again is wrong here. I have sent some info forward to the Mojarra devs and will fopr now go forward with my propose solution which seems to be correct, lets wait for the reaction on Mojarras side on this matter. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196287#comment-16196287 ] Werner Punz commented on MYFACES-4160: -- Ok again the spec seems at fault here, partially my fault, I should have followed the 790 thread more thoroughly instead of just checking the proposed solutions from time to time. I will implement the in my opinion correct solution for now and will get in contact with some of the EG guys. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196266#comment-16196266 ] Werner Punz commented on MYFACES-4160: -- Ok I rechecked the docs, and I think the spec was not properly updated. I know there was a long thread discussing the solution and I personally think the correct solution was to update the issuing form and all forms ander a view root. *f the javax.faces.ViewState element could not be found, throw an error. If the ID of the javax.faces.ViewState element has a prefix, where is the currently configured UINamingContainer.getSeparatorChar() and is the return from UIViewRoot.getContainerClientId() on the view from whence this state originated, then remember it as namespace prefix. This is needed during encoding of the set of post data arguments.* Which implemented word by word simply causes some viewstates under a naming container to be not updated again. Again I state, all forms under one given viewroot must be updated, otherwise you will simply get old stale broken viewstates. If the stated viewroot element cannot be found then we do not have multiple viewroots, so the update root then is the body in a html environment. As it is Is stated in the jsdocs, which was carried over from the old spec with the broken issuer, render target pattern. The problem I have is, the old java.net issue thread https://java.net/jira/browse/JAVASERVERFACES_SPEC_PUBLIC-790 is gone because oracle has pulled it due to the shutdown of java.net. Does anyone know where the JSF issues have been moved? I need to dig up the thread. In the meanwhile I will implement the solution which is correct in my opinion we will see if the TCK will fail or not. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196220#comment-16196220 ] Werner Punz commented on MYFACES-4160: -- In 2.2 there was no id flag in update, the id flag is new, it basically says, update all elements under this viewroot. Now if there is a viewstate update in there, then all viewstated forms which are prefixed with the id flag must be updated with the new viewstate. If no id flag is set, simply all forms are updated. http://arjan-tijms.omnifaces.org/p/jsf-23.html Still digging through the various sections of the spec, I have clearly one last bug in my code here (I also need to update the issuing form). But still trying to figure out whether the changes parts id is wrong here. In any case I probably simply can dump it if the viewroot element itself is not found in the tree. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196217#comment-16196217 ] Thomas Andraschko commented on MYFACES-4160: Also, AFAIR, in PrimeFaces we completly ignore the id attribute of partial-response. Not sure if it's correct but PF is working without in a normal servlet container + it's working fine in portlets. We just dynamically prepend the paramater namespace to the dynamic post params like "javax.faces.partial.render" > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196210#comment-16196210 ] Thomas Andraschko commented on MYFACES-4160: Hmm, how did it work in 2.2? I'm also not sure if we talk about the same "namespacing". I talk about this one: https://issues.apache.org/jira/browse/MYFACES-4053 > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196209#comment-16196209 ] Werner Punz commented on MYFACES-4160: -- Ah yes the second problem, intiially both viewstate elements were prefixed perfectly fine, but upon replacement the cdata block does not have a viewstate in, which also is fine, but then the comes along and the viewstate element cannot be added to the first form anymore since the form id is not prefixed with j_id__v_0 So I guess there are some bugs regarding the viewroot name handling. Either leave out the j_id__v_0 for the partial response block so that all forms are picked up or put the prefix into all elements under this viewroot. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196201#comment-16196201 ] Werner Punz commented on MYFACES-4160: -- While trying 4156 I found another issue in the rendered markup: First at initial page load the page was basically perfectly rendered, once I tried to hit the login button following response came Now this is problematic a) the response is prefixed wich puts the code into naming mode which means only the elements with the prefix j_id__v_0 will be updated... which then means the viewstate update will only update form2 not form1, because of the prefix and hence you again run into viewstate sync issues: there seems to be the first form being omitted from the viewroot id. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196191#comment-16196191 ] Thomas Andraschko commented on MYFACES-4160: +1 to commit it if the sample app in https://issues.apache.org/jira/browse/MYFACES-4156 is working fine (you just need to download + do mvn clean package jetty:run) Which JSF - CDI example do you mean? But +1 for a new issue, seems like a real error. Also not sure if we can correctly test the namespaced paramter case as this is only used in portlets. Not sure if any portlet container is using MyFaces. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196164#comment-16196164 ] Werner Punz commented on MYFACES-4160: -- I would be ready to commit however. before committing it I would like to check the the code in the JSF - CDI example app. However I cannot get it up and running, there are several issues. a) The code references websockets, but the pom.xml does not have a websocket reference - thats easy to fix. b) Whenever I dump the war into Tomcat I get a CDI error: nfig.annotation.Tomcat7AnnotationLifecycleProvider 08-Oct-2017 17:09:45.158 SCHWERWIEGEND [main] org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces An error occured while initializing MyFaces: It's not allowed to call getBeans(Type, Annotation...) before AfterBeanDiscovery java.lang.IllegalStateException: It's not allowed to call getBeans(Type, Annotation...) before AfterBeanDiscovery at org.apache.webbeans.container.InjectableBeanManager.checkAfterBeanDiscoveryProcessed(InjectableBeanManager.java:402) at org.apache.webbeans.container.InjectableBeanManager.getBeans(InjectableBeanManager.java:121) at org.apache.myfaces.cdi.util.CDIUtils.lookup(CDIUtils.java:51) at org.apache.myfaces.flow.cdi.DefaultCDIFacesFlowProvider.getAnnotatedFlows(DefaultCDIFacesFlowProvider.java:52) at org.apache.myfaces.flow.impl.AnnotatedFlowConfigurator.configureAnnotatedFlows(AnnotatedFlowConfigurator.java:42) at org.apache.myfaces.config.FacesConfigurator.configureFlowHandler(FacesConfigurator.java:1700) at org.apache.myfaces.config.FacesConfigurator.configure(FacesConfigurator.java:614) at org.apache.myfaces.webapp.AbstractFacesInitializer.buildConfiguration(AbstractFacesInitializer.java:452) at org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:74) This must be fixed on the codeside. Shall I open a Jira issue for that one? So there is no real way to test this stuff atm. I ran my usual integration tests (which I host on github sort of as a workspace for myself) which I use for development. but a final test on my side is still pending. Shall I push the code anyway and someone with a working running config wants to test it? The changes do not break anything, my about 15 or so tests I have on the code pass perfectly, but I would love to see the new behavior to be tested (aka the namespaced changes). > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192541#comment-16192541 ] Thomas Andraschko commented on MYFACES-4160: cool! :) > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192522#comment-16192522 ] Werner Punz commented on MYFACES-4160: -- Just wanted to give a status update, I have implemented basically the new response behavior but I need to write some tests first before dropping the code into the myfaces codebase. The entire viewstate handling has become tighter, it is just basically determine the viewroot if an updates id is given and then update all forms under this viewRoot as usual with the given artifact (clientWindowId, Viewstate etc...) So all this special handling regarding issuing element, rendered fragment, our special handling for non portlet multiform environments all gone. This is good news because I was really unhappy with this part due to the fixes and workarounds it had, caused by the broken jsf 2.0-2.2 spec in this area. (God knows I reported the spec bug for JSF 2.0) Expect the code if all goes well (I need to recheck the spec if I have covered all, for now I was using the Tijms weblog to get a quick grasp) late weekend, monday. Once this is implemented I will start the discussion on the mailing list on how we proceed with the reimplementation, for now I have two options use Typescript, a language which I am very familiar with due to my daywork, also we could use the Kotlin -> Javascript crosscompiler which I need to evaluate. I do not want to go to pure javascript again, it has so many advantages to use a better language. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188185#comment-16188185 ] Werner Punz commented on MYFACES-4160: -- Hi I have started to work on it, now that the extscript 1.0.6 vote is out. Expect a few days for resolving the bug, since I only can work on it mostly in my sparetime. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185522#comment-16185522 ] Werner Punz commented on MYFACES-4160: -- Re portlets, this config entry is a helper to fix the broken viewstate handling of jsf 2.0-2.2, since it now is fixed in 2.3 it will go away. I will take over the issue, but I wont be able to do it before next week. And yes, if we baseline for IE9 we can move a lot of the query stuff to domNode.querySelectorAll. As I said about 40-50% of the existing code simply is there to bypass and fix bugs of by now dead browsers, so after the release we are going to clean this all up one way or the other. As I said My preference would be: a) Typescript, that can be discussed - it is just that I prefer it over plain javascript because then we can move Ecmascript levels and module systems on the fly and the syntax is way cleaner and nicer, the maven integration should not pose to much of a problem - but that needs to be discussed b) Promises to handle the entire ajax cycle in a sanmer manner, more or less like jquery allows it and other frameworks. c) A thin query layer over document.querySelectorAll to get rid of the domutils class, ideally would be jquery because this delivers in some areas where plain dom lacks, like outerHTML, a promise layer over ajax, some fixes for browser incompatibilities etc... but that is out of the question, we cannot bundle such a lib or require such a lib. Primefaces has an easier stand here, because it is a third party lib not a core lib. And then the code should become clean and maintainable without all the legacy junk. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184880#comment-16184880 ] Thomas Andraschko commented on MYFACES-4160: Hmm, i'm really not sure about Typescript if it isn't easy. I think we can do a good implementation also without typescript but lets discuss this for 2.4. In PrimeFaces jQuery is used, yep. But i think the DOM manipulation is not sooo hard for the ajax engine because we only need to support newer browsers and not IE6 or 7 anymore. Not sure about the AJAX request/response-handling, i'm jQuery user since almost many years. I would be great great if you could take care of it. I checked the base ~2 hours today and it's really hard to understand. Also i'm not sure if AjaxResponse or AjaxResponseJSF22 is the correct one. We really need to delete one of both and do a cleanup. Not sure why this worked in MF2.2 - Maybe AjaxResponseJSF22 was used? Do we need to support porlets? We have there some JS configs to update all forms or not. Porlets have some namespacing for the clientIds - which is currently also not implemented on the server side. So not sure if we should care of it. See: https://github.com/ngriffin7a/primefaces/blob/master/src/main/resources/META-INF/resources/primefaces/core/core.ajax.js#L369 https://github.com/primefaces/primefaces/blob/master/src/main/java/org/primefaces/context/PrimePartialResponseWriter.java#L267 > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184259#comment-16184259 ] Werner Punz commented on MYFACES-4160: -- Just checked the primefaces code one of the reasons is, it utilizes jquery which does the heavy lifiting in the browser compatibility dom and Ajax area. That back then was out of the question for me because the sources needed to be self contained, I did not have the luxury of being able to bundle jquery. I would say about 40% of the old code is dealing with browser incompatbilities which were serious back then, have in mind when the code was developed, the main platforms were ie6 and to some degree also still blackberry on the mobile sector. But yes, the code needs a serious overhaul, I agree. It is now almost 10 years old and things have moved on big time. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183934#comment-16183934 ] Werner Punz commented on MYFACES-4160: -- Well you can remove parts of it out of the box... There is an internal switch to my knowledge which switches between xhr indirections, IE7 and older uses the old xhr mechanism, and newer browser switch to the standardized xhr object - there is no browser anymore which uses a non standardized xhr system, since IE6 is absolutely dead by now. I think I have the same switch also for the domUtils, but I need to check this first. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183778#comment-16183778 ] Thomas Andraschko commented on MYFACES-4160: Sounds good werner! Websockets are AFAICS already implemented by Leo. I will check the issue today and also remove the duplicate AjaxResponse. I will also check if we can easily remove sound of the codebase, which will result in a smaller javascript for the client. For 2.4, we should really reimplement it. In PrimeFaces we have the same functionality as in the JSF API and the source is really small and clean compared to the myfaces one: https://github.com/primefaces/primefaces/blob/master/src/main/resources/META-INF/resources/primefaces/core/core.ajax.js (NOTE: we even have some more features) I'm not sure if we should Typescript for the reimplementation as i'm not sure if we can easily integrate it in our maven builds (1-2 years ago there were no good plugins available). I don't think we should require that a MF developer should install gulp+nodejs+ > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko >Assignee: Werner Punz > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183744#comment-16183744 ] Werner Punz commented on MYFACES-4160: -- Hi I am a little bit bound by other things this week, (one of them is to get out another ext-scripting release), I will to get back to you sometime next week. I think AjaxResponse22 is not really workable code, I need to check it. In any way, the viewstate handling has been altered for jsf 2.3, we need to fix this in our code, there was no fix without breaking existing code. In the long run we should replace the existing javascripts since it is rather old. There is a load of code in there which is obsolete: Also we need to add Websockets, which is also part of the JSF 2.3 js part. (I need to look into that) a) We use our own class system based in prototype b) We support stone old browsers, we should ramp it up to IE9 as baseline I guess, I wonder if anyone still uses any IE below that in a corporate environment? c) We might rewrite the code in Typescript for maintainability reasons, this would allow us to ramp up the Ecmascript level dynamically and also to switch module systems on the fly (aka with ES6 a standardized module system was finally introduced) I have started to work on it on a github project this summer... but I never publicly announced it since the entire thing is not in a representable state yet. What I would propose is following: a) Fix the old codebase for JSF 2.3 b) Lets reimplement the stuff in Typescript with a bunch of helpers from modern libs and drop really old browser support along the way. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4160) ViewState not written for Ajax request
[ https://issues.apache.org/jira/browse/MYFACES-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183102#comment-16183102 ] Thomas Andraschko commented on MYFACES-4160: Checked that case again and i remember now that the forms were always rendered without viewstate id and was applied via JS. Now looking why it doesn't work - Somehow we also have 2 AjaxResponse.js. > ViewState not written for Ajax request > -- > > Key: MYFACES-4160 > URL: https://issues.apache.org/jira/browse/MYFACES-4160 > Project: MyFaces Core > Issue Type: Bug >Affects Versions: 2.3.0-beta >Reporter: Thomas Andraschko > Fix For: 2.3.0 > > > If you run the application from MYFACES-4156 via mvn jetty:run, the > viewStateId isn't rendered again after the first ajax request. > Seems like FaceletViewDeclerationLanguage line 1910 should handle that but it > skips. > [~lu4242] Could you please check that? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
