[jira] [Commented] (MYFACES-4166) Make FACES_SERVLET_ADDED_ATTRIBUTE key public
[ https://issues.apache.org/jira/browse/MYFACES-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218905#comment-16218905 ] Eduardo Breijo commented on MYFACES-4166: - I didn't know they were in maintenance, sorry about that. I reverted all the changes except for JSF 2.3. > Make FACES_SERVLET_ADDED_ATTRIBUTE key public > - > > Key: MYFACES-4166 > URL: https://issues.apache.org/jira/browse/MYFACES-4166 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.3.0-beta >Reporter: Eduardo Breijo >Assignee: Eduardo Breijo >Priority: Minor > Fix For: 2.3.0 > > Attachments: MYFACES-4166.patch > > > It seems that MyFacesContainerInitializer.FACES_SERVLET_ADDED_ATTRIBUTE key > is also used on AbstractFacesInitializer. > It would be nice if we can make the field public so we remove duplicates. > I will provide a patch. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4166) Make FACES_SERVLET_ADDED_ATTRIBUTE key public
[ https://issues.apache.org/jira/browse/MYFACES-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218736#comment-16218736 ] Thomas Andraschko commented on MYFACES-4166: Why for older versions? They are in maintenance, there is no reason to add it there. > Make FACES_SERVLET_ADDED_ATTRIBUTE key public > - > > Key: MYFACES-4166 > URL: https://issues.apache.org/jira/browse/MYFACES-4166 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.0.24, 2.1.18, 2.2.12, 2.3.0-beta >Reporter: Eduardo Breijo >Assignee: Eduardo Breijo >Priority: Minor > Fix For: 2.0.25, 2.1.19, 2.2.13, 2.3.0 > > Attachments: MYFACES-4166.patch > > > It seems that MyFacesContainerInitializer.FACES_SERVLET_ADDED_ATTRIBUTE key > is also used on AbstractFacesInitializer. > It would be nice if we can make the field public so we remove duplicates. > I will provide a patch. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MYFACES-4166) Make FACES_SERVLET_ADDED_ATTRIBUTE key public
[ https://issues.apache.org/jira/browse/MYFACES-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217903#comment-16217903 ] Eduardo Breijo commented on MYFACES-4166: - If no objections, I'm going to commit this patch. > Make FACES_SERVLET_ADDED_ATTRIBUTE key public > - > > Key: MYFACES-4166 > URL: https://issues.apache.org/jira/browse/MYFACES-4166 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.3.0-beta >Reporter: Eduardo Breijo >Assignee: Eduardo Breijo >Priority: Minor > Attachments: MYFACES-4166.patch > > > It seems that MyFacesContainerInitializer.FACES_SERVLET_ADDED_ATTRIBUTE key > is also used on AbstractFacesInitializer. > It would be nice if we can make the field public so we remove duplicates. > I will provide a patch. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
