[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267785#comment-17267785 ] Milan Siebenbürger commented on MYFACES-4375: - Thanks (y) > ResourceLoaderUtils - connection not close for FileURLConnection > > > Key: MYFACES-4375 > URL: https://issues.apache.org/jira/browse/MYFACES-4375 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Milan Siebenbürger >Assignee: Thomas Andraschko >Priority: Critical > Fix For: 2.3-next-M5, 3.0.0, 4.0.0-RC1, 2.3.8 > > > Hello, > we are facing problem with non-closed connection in ResourceLoaderUtils. > Since this change (pull request> https://github.com/apache/myfaces/pull/90) > in method ResourceLoaderUtils.getResourceLastModification(URL url) is > connection opened, but it is never closed (assuming it is not instance of > JarURLConnection, which is closed correctly). > If URLConnection is FileURLConnection (our case), it is not closed, and > afterwards file is locked in file system and can't be accessed (for deleting, > etc)... > Method ResourceLoaderUtils.getResourceLastModification is called at > ResourceImpl:316. > > Do you have any solution or workaround for this case, or could it be fixed > somehow (ie same as JarURLConnection)? > Thanks > Milan Siebenbürger > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267783#comment-17267783 ] Thomas Andraschko commented on MYFACES-4375: We may release something next month, but not sure yet > ResourceLoaderUtils - connection not close for FileURLConnection > > > Key: MYFACES-4375 > URL: https://issues.apache.org/jira/browse/MYFACES-4375 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Milan Siebenbürger >Assignee: Thomas Andraschko >Priority: Critical > Fix For: 2.3-next-M5, 3.0.0, 4.0.0-RC1, 2.3.8 > > > Hello, > we are facing problem with non-closed connection in ResourceLoaderUtils. > Since this change (pull request> https://github.com/apache/myfaces/pull/90) > in method ResourceLoaderUtils.getResourceLastModification(URL url) is > connection opened, but it is never closed (assuming it is not instance of > JarURLConnection, which is closed correctly). > If URLConnection is FileURLConnection (our case), it is not closed, and > afterwards file is locked in file system and can't be accessed (for deleting, > etc)... > Method ResourceLoaderUtils.getResourceLastModification is called at > ResourceImpl:316. > > Do you have any solution or workaround for this case, or could it be fixed > somehow (ie same as JarURLConnection)? > Thanks > Milan Siebenbürger > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267769#comment-17267769 ] Milan Siebenbürger commented on MYFACES-4375: - Confirming, everything is working fine, thank you Thomas :) Any info about date of 2.3-next-M5 release? Milan > ResourceLoaderUtils - connection not close for FileURLConnection > > > Key: MYFACES-4375 > URL: https://issues.apache.org/jira/browse/MYFACES-4375 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Milan Siebenbürger >Assignee: Thomas Andraschko >Priority: Critical > Fix For: 2.3-next-M5, 3.0.0, 4.0.0-RC1, 2.3.8 > > > Hello, > we are facing problem with non-closed connection in ResourceLoaderUtils. > Since this change (pull request> https://github.com/apache/myfaces/pull/90) > in method ResourceLoaderUtils.getResourceLastModification(URL url) is > connection opened, but it is never closed (assuming it is not instance of > JarURLConnection, which is closed correctly). > If URLConnection is FileURLConnection (our case), it is not closed, and > afterwards file is locked in file system and can't be accessed (for deleting, > etc)... > Method ResourceLoaderUtils.getResourceLastModification is called at > ResourceImpl:316. > > Do you have any solution or workaround for this case, or could it be fixed > somehow (ie same as JarURLConnection)? > Thanks > Milan Siebenbürger > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MYFACES-4375) ResourceLoaderUtils - connection not close for FileURLConnection
[ https://issues.apache.org/jira/browse/MYFACES-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267272#comment-17267272 ] Thomas Andraschko commented on MYFACES-4375: It seems that the underlying IS is closed https://github.com/apache/myfaces/blob/8bb2ddf9f0dce365f4082a03d3d3272710854e11/impl/src/main/java/org/apache/myfaces/resource/ResourceLoaderUtils.java#L101 isnt that enough? > ResourceLoaderUtils - connection not close for FileURLConnection > > > Key: MYFACES-4375 > URL: https://issues.apache.org/jira/browse/MYFACES-4375 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 3.0.0-RC1, 2.3-next-M3, 2.3-next-M4, 3.0.0, 4.0.0-RC1 >Reporter: Milan Siebenbürger >Priority: Critical > > Hello, > we are facing problem with non-closed connection in ResourceLoaderUtils. > Since this change (pull request> https://github.com/apache/myfaces/pull/90) > in method ResourceLoaderUtils.getResourceLastModification(URL url) is > connection opened, but it is never closed (assuming it is not instance of > JarURLConnection, which is closed correctly). > If URLConnection is FileURLConnection (our case), it is not closed, and > afterwards file is locked in file system and can't be accessed (for deleting, > etc)... > Method ResourceLoaderUtils.getResourceLastModification is called at > ResourceImpl:316. > > Do you have any solution or workaround for this case, or could it be fixed > somehow (ie same as JarURLConnection)? > Thanks > Milan Siebenbürger > -- This message was sent by Atlassian Jira (v8.3.4#803005)
