[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638650#comment-17638650
]
Werner Punz commented on MYFACES-4498:
--
Fixed for master, 2.3-Next, and the js pull request
Downside of this fix, the cutoff point now is IE9 as lowest supported browser
for the old codebase.
If anyone objects to this, I can work on another solution!
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Fix For: 2.3-next-M8, 4.0.0-RC3
>
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638547#comment-17638547
]
Werner Punz commented on MYFACES-4498:
--
Have started to fix it on the old codebase. Will take a while because I have to
make an integration test on the old codebase
(the new one is covered by unit tests in this area, I do not have unit tests on
the old one)
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17638327#comment-17638327
]
Werner Punz commented on MYFACES-4498:
--
Fixed now properly for our new codebase, will add the fix as well for the old
codebase tomorrow.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637841#comment-17637841
]
Werner Punz commented on MYFACES-4498:
--
Added a unit test for a more complex case as well
{code:xml}
{code:java}
{code}
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637838#comment-17637838
]
Werner Punz commented on MYFACES-4498:
--
Found the second issue.
The way we handle the head replace simply was false... we basically left the
head intact and only evaluated the scripts.
The correct fix is to replace all elements on dom level. (I still do the
deferred eval though, but with sticky scripts!)
This is an issue which has spilled over from the old codebase.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637817#comment-17637817
]
Werner Punz commented on MYFACES-4498:
--
Error is reproducible with following unit test
```typescript
it("head replacement must work
(https://issues.apache.org/jira/browse/MYFACES-4498 and TCK Issue 4345IT)",
function(done) {
DQ.byId("cmd_complex_resource2").click();
this.respond(XmlResponses.HEAD_REPLACE);
let headHTML = document.head.innerHTML;
//failing now, no elements in the html head after respond!!!
expect(headHTML.indexOf("href=\"../../../xhrCore/fixtures/addedViewHead2.css\"")).not.eq(-1);
expect(DQ$("head
link[rel='stylesheet'][href='../../../xhrCore/fixtures/addedViewHead2.css']").length).to.eq(1);
expect(headHTML.indexOf("../../../xhrCore/fixtures/addedViewHead3.js")).not.eq(-1);
})
static HEAD_REPLACE = `
`
```
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637706#comment-17637706
]
Werner Punz commented on MYFACES-4498:
--
The link style change is a bug in our codebase... will be fixed
The script disappearing already documented above.
I will fix it for the new codebase first where I can set dedicated unit tests
for this case and then fix it
for our old codebase if requested/needed.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17637704#comment-17637704
]
Werner Punz commented on MYFACES-4498:
--
Taking over this now, should the fix also go into 2.3 Next?
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635675#comment-17635675
]
Werner Punz commented on MYFACES-4498:
--
Yes.. I was too vague, I meant did you run the TCK against the new codebase, I
just was wondering, because the TCK is using HTMLUnit and by my testing and
knowledge it should not work against the new codebase.
And yes the new codebase has exactly the same behavior it removes the script
elements after a short eval period.
Again a mild bug, more a deviation from what is expected.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635592#comment-17635592
]
Volodymyr Siedlecki commented on MYFACES-4498:
--
If I recall, I saw the same behavior on both the older and newer codebases.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Assignee: Werner Punz
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635150#comment-17635150
]
Werner Punz commented on MYFACES-4498:
--
Yes please assign it to me. The script tags in fact are appended but then
removed, this is the standard way on how you evaluate them.
(call to eval are basically forbidden, an eval is done by swiftly appending a
script tag and then remove it)
I probably have to remove the removal for the head update case.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635070#comment-17635070
]
Volodymyr Siedlecki commented on MYFACES-4498:
--
[~werpu] is Can I assign this to you?
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MYFACES-4498) TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
[
https://issues.apache.org/jira/browse/MYFACES-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17633937#comment-17633937
]
Volodymyr Siedlecki commented on MYFACES-4498:
--
I've attached the Mojarra app from the TCK.
> TCK: Issue 4345 : Head Element Not Updated As Expected via Ajax Call
>
>
> Key: MYFACES-4498
> URL: https://issues.apache.org/jira/browse/MYFACES-4498
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC2
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: test-faces22-ajax.war
>
>
> Test Code:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/main/webapp/issue4345result.xhtml]
>
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/faces22/ajax/src/test/java/ee/jakarta/tck/faces/test/servlet30/ajax/Issue4345IT.java#L47]
> This test was created for ensure HTML is only escaped twice ([Issue
> 4345|https://github.com/eclipse-ee4j/mojarra/issues/4345). However, MyFaces
> is encountering two problems with this test.
> Firstly, here is the Ajax response and the updated HTML:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> {code}
> The HTML is then set as :
> {code:java}
> http://www.w3.org/1999/xhtml;>
>
> @import
> url('/test-faces22-ajax/jakarta.faces.resource/issue4345.css.xhtml?firstParam=1&secondParam=2');
>
>
>
> {code}
> 1) We change from a link (type/css ) to a style tag that imports the URL?
> Should that occur? The JavaScript in issue4345result.xhtml specifically
> looks for a link element.
> 2) The script tags *are not appended* to the head element, but I do see
> network requests for them. Additionally, the scripts do run (confirmed by the
> console: "issue4345.js loaded." ).
> This fails on both the RC2 scripts and the new TypeScript code.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
