[jira] [Commented] (PORTLETBRIDGE-203) Proposal for 3.0 IMPL: Preserve and restore JSF2 FacesContext attributes in BridgeRequestScope
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13016463#comment-13016463 ] Michael Freedman commented on PORTLETBRIDGE-203: I have found that the 329/301 bridge methodology of caching the UIViewRoot and releasing the FacesContext at the end of the action and then getting the render to use the cached UIViewRoot in a new FacesContext will not work consistently in JSF 3.0. Each release of Mojarra or Myfaces I get changes the issue I ran into -- yes first it was just the need to carry some of the FacesContext attributes forward -- but now there are issues with attributes stored on the UiViewRoot itself that have been released underneath these references in the prior facesContext.release. So I think the bridge is going to have to change to explicitly save and restore the view across the action/render -- at which point we won't need to preserve/restore the JSF2 FacesContext attrs anymore. Proposal for 3.0 IMPL: Preserve and restore JSF2 FacesContext attributes in BridgeRequestScope -- Key: PORTLETBRIDGE-203 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-203 Project: MyFaces Portlet Bridge Issue Type: New Feature Components: General Affects Versions: 3.0.0 Reporter: Neil Griffin Assignee: Michael Freedman The JSF 2.0 API introduced a getAttributes() method on FacesContext: http://javaserverfaces.java.net/nonav/docs/2.0/javadocs/javax/faces/context/FacesContext.html#getAttributes() These values need to be preserved in the BridgeRequestScope. For more information on implementation details, search for BRIDGE_REQ_SCOPE_ATTR_FACES_CONTEXT_ATTRIBUTES in the following Java class: http://svn.portletfaces.org/svn/portletfaces/bridge/portletfaces-bridge-impl/trunk/src/main/java/org/portletfaces/bridge/scope/BridgeRequestScopeImpl.java -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PORTLETBRIDGE-203) Proposal for 3.0 IMPL: Preserve and restore JSF2 FacesContext attributes in BridgeRequestScope
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13012588#comment-13012588 ] Michael Freedman commented on PORTLETBRIDGE-203: We will have to discuss/debate this one. Turns out there are some Faces internal FacesContext attributes that can't be preserved across FacesContext releases and there are others that must. In addition we need to discuss/understand to what degree application developers are using this scope and expect/require that it last until the entire action/render occurs. Basically -- this scope is a mess for the bridge as its normal behavior is to release the FacesContext at the end of the action and start a new one in render. I really want to avoid having to support a similar include/exclude mechanism as the request scope for any new scope. Proposal for 3.0 IMPL: Preserve and restore JSF2 FacesContext attributes in BridgeRequestScope -- Key: PORTLETBRIDGE-203 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-203 Project: MyFaces Portlet Bridge Issue Type: New Feature Components: General Affects Versions: 3.0.0 Reporter: Neil Griffin Assignee: Michael Freedman The JSF 2.0 API introduced a getAttributes() method on FacesContext: http://javaserverfaces.java.net/nonav/docs/2.0/javadocs/javax/faces/context/FacesContext.html#getAttributes() These values need to be preserved in the BridgeRequestScope. For more information on implementation details, search for BRIDGE_REQ_SCOPE_ATTR_FACES_CONTEXT_ATTRIBUTES in the following Java class: http://svn.portletfaces.org/svn/portletfaces/bridge/portletfaces-bridge-impl/trunk/src/main/java/org/portletfaces/bridge/scope/BridgeRequestScopeImpl.java -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PORTLETBRIDGE-203) Proposal for 3.0 IMPL: Preserve and restore JSF2 FacesContext attributes in BridgeRequestScope
[
https://issues.apache.org/jira/browse/PORTLETBRIDGE-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13012597#comment-13012597
]
Neil Griffin commented on PORTLETBRIDGE-203:
Not sure about application developers, but there's a bunch of stuff that
Mojarra is placing in this scope:
18:20:47,625 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[com.sun.faces.renderKitImplForRequest]
value=[com.sun.faces.renderkit.RenderKitFactoryImpl@2c29c8]
18:20:47,626 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[com.sun.faces.context.StateContext_KEY]
value=[com.sun.faces.context.StateContext@6b3c55]
18:20:47,627 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[com.sun.faces.context.FacesContextImpl_POST_BACK] value=[true]
18:20:47,627 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[RequestFlashManager] value=[previousRequestSequenceNumber: 3
nextRequestSequenceNumber: 1]
18:20:47,628 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[SavedResponseCompleteFlagValue] value=[false]
18:20:47,629 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[javax.faces.component.AjaxBehaviors]
value=[com.sun.faces.component.behavior.AjaxBehaviors@462601]
18:20:47,630 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[com.sun.faces.facelets.FACELET_CONTEXT]
value=[com.sun.faces.facelets.impl.DefaultFaceletContext@6938ed]
18:20:47,631 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[com.sun.faces.INVOCATION_PATH] value=[/*]
18:20:47,633 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute
name=[com.sun.faces.application.ApplicationImpl.IS_PROCESSING_LISTENERS]
value=[{class javax.faces.event.PostAddToViewEvent=false, class
javax.faces.event.PreValidateEvent=false, class
javax.faces.event.PostConstructViewMapEvent=false, class
javax.faces.event.PostValidateEvent=false}]
18:20:47,634 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[com.sun.faces.FACES_VIEW_STATE] value=[... MORE STUFF ...]
18:20:47,635 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[com.sun.faces.logicalViewMap] value=[8077633702120430112]
18:20:47,645 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[facelets.Encoding] value=[UTF-8]
18:20:47,646 TRACE [BridgeRequestScopeImpl:243] Restoring FacesContext
attribute name=[javax.faces.SEPARATOR_CHAR] value=[:]
Proposal for 3.0 IMPL: Preserve and restore JSF2 FacesContext attributes in
BridgeRequestScope
--
Key: PORTLETBRIDGE-203
URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-203
Project: MyFaces Portlet Bridge
Issue Type: New Feature
Components: General
Affects Versions: 3.0.0
Reporter: Neil Griffin
Assignee: Michael Freedman
The JSF 2.0 API introduced a getAttributes() method on FacesContext:
http://javaserverfaces.java.net/nonav/docs/2.0/javadocs/javax/faces/context/FacesContext.html#getAttributes()
These values need to be preserved in the BridgeRequestScope. For more
information on implementation details, search for
BRIDGE_REQ_SCOPE_ATTR_FACES_CONTEXT_ATTRIBUTES in the following Java class:
http://svn.portletfaces.org/svn/portletfaces/bridge/portletfaces-bridge-impl/trunk/src/main/java/org/portletfaces/bridge/scope/BridgeRequestScopeImpl.java
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
