[jira] [Commented] (TOBAGO-950) tc:link still occupies some space, when rendered is set to false
[ https://issues.apache.org/jira/browse/TOBAGO-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193743#comment-13193743 ] Dom W. commented on TOBAGO-950: --- This issue prevails in the recent 1.0.38 version (and Firefox 9.0.1). Could anyone please have a look at it? When looking at the generated HTML source code, I can see that there are tr-tags created for the hidden tc:links: trtd style=width: 283px; class=tobago-gridLayout-cell-tddiv style=width: 283px; class=tobago-gridLayout-default tobago-gridLayout-first-column/div/td/tr Happy to hear about any comments ... tc:link still occupies some space, when rendered is set to false -- Key: TOBAGO-950 URL: https://issues.apache.org/jira/browse/TOBAGO-950 Project: MyFaces Tobago Issue Type: Bug Affects Versions: 1.0.31 Environment: Firefox 3.6.12, Ubuntu 10.04 64bit Reporter: Dom W. Priority: Minor Attachments: tc-link-rendered.png Even though the rendered attribute is set to false, the tc:link is not fully hidden, i.e. it still uses up some space (a few pixels) . This creates additional empty space, which gets more and more apparent, the more hidden links you have. Example code: tc:panel f:facet name=layout tc:gridLayout rows=fixed;fixed;fixed;fixed;fixed;fixed;fixed;*/ /f:facet tc:label value=tc:link rendered/ tc:link label=Test 1 rendered=false / tc:link label=Test 2 rendered=false / tc:link label=Test 3 rendered=false / tc:link label=Test 4 rendered=true / tc:link label=Test 5 rendered=false / tc:link label=Test 6 rendered=false / tc:link label=Test 7 rendered=true / tc:link label=Test 8 rendered=true / /tc:panel Expected result: There should be as much space between the tc:label and the first visible tc:link, and also between tc:link 4 and 7, as there is between tc:link 7 and 8. Actual result: There is a big gap between the tc:label and the first visible tc:link, and also between tc:link 4 and 7. Please also see the attached image. Greetings, dom -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOBAGO-950) tc:link still occupies some space, when rendered is set to false
[
https://issues.apache.org/jira/browse/TOBAGO-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12936033#action_12936033
]
Dom W. commented on TOBAGO-950:
---
Thanks for your reply.
Here is the full view, including your corrections. The result remains the same
as initially reported:
f:view
tc:page label=TOBAGO 950 width=500px height=600px
tc:sheet var=myVar value=#{myController.myList}
state=#{myController.sheetState}
tc:column
tc:panel
f:facet name=layout
tc:gridLayout
rows=fixed;fixed;fixed;fixed;fixed;fixed;fixed;fixed;fixed;* /
/f:facet
tc:label value=tc:link rendered /
tc:link label=Test 1 rendered=false /
tc:link label=Test 2 rendered=false /
tc:link label=Test 3 rendered=false /
tc:link label=Test 4 rendered=true /
tc:link label=Test 5 rendered=false /
tc:link label=Test 6 rendered=false /
tc:link label=Test 7 rendered=true /
tc:link label=Test 8 rendered=true /
tc:cell /
/tc:panel
/tc:column
/tc:sheet
/tc:page
/f:view
tc:link still occupies some space, when rendered is set to false
--
Key: TOBAGO-950
URL: https://issues.apache.org/jira/browse/TOBAGO-950
Project: MyFaces Tobago
Issue Type: Bug
Affects Versions: 1.0.31
Environment: Firefox 3.6.12, Ubuntu 10.04 64bit
Reporter: Dom W.
Priority: Minor
Attachments: tc-link-rendered.png
Even though the rendered attribute is set to false, the tc:link is not
fully hidden, i.e. it still uses up some space (a few pixels) . This creates
additional empty space, which gets more and more apparent, the more hidden
links you have.
Example code:
tc:panel
f:facet name=layout
tc:gridLayout
rows=fixed;fixed;fixed;fixed;fixed;fixed;fixed;*/
/f:facet
tc:label value=tc:link rendered/
tc:link label=Test 1 rendered=false /
tc:link label=Test 2 rendered=false /
tc:link label=Test 3 rendered=false /
tc:link label=Test 4 rendered=true /
tc:link label=Test 5 rendered=false /
tc:link label=Test 6 rendered=false /
tc:link label=Test 7 rendered=true /
tc:link label=Test 8 rendered=true /
/tc:panel
Expected result:
There should be as much space between the tc:label and the first visible
tc:link, and also between tc:link 4 and 7, as there is between tc:link 7 and
8.
Actual result:
There is a big gap between the tc:label and the first visible tc:link, and
also between tc:link 4 and 7.
Please also see the attached image.
Greetings, dom
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TOBAGO-950) tc:link still occupies some space, when rendered is set to false
[ https://issues.apache.org/jira/browse/TOBAGO-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935913#action_12935913 ] Udo Schnurpfeil commented on TOBAGO-950: The numbers of item in the rows attribute should be the same like the number of ui-components inside the layout area. In the example there are 8 item (7xfixed + 1x*) but 9 ui-components. You should fix it e.g. like this: f:view tc:page label=TOBAGO 950 width=500px height=600px f:facet name=layout tc:gridLayout rows=fixed;fixed;fixed;fixed;fixed;fixed;fixed;fixed;fixed;*/ /f:facet tc:label value=tc:link rendered/ tc:link label=Test 1 rendered=false/ tc:link label=Test 2 rendered=false/ tc:link label=Test 3 rendered=false/ tc:link label=Test 4 rendered=true/ tc:link label=Test 5 rendered=false/ tc:link label=Test 6 rendered=false/ tc:link label=Test 7 rendered=true/ tc:link label=Test 8 rendered=true/ tc:cell/ /tc:page /f:view On the other side, I can't reproduce your result unfortunately. The reason may be other components on your page that are not in the example. Which theme you are using? Please fix the rows definition and (if suitable) add a tc:cell and let me know your result (with the whole page) if there are still any problems. tc:link still occupies some space, when rendered is set to false -- Key: TOBAGO-950 URL: https://issues.apache.org/jira/browse/TOBAGO-950 Project: MyFaces Tobago Issue Type: Bug Affects Versions: 1.0.31 Environment: Firefox 3.6.12, Ubuntu 10.04 64bit Reporter: Dom W. Priority: Minor Attachments: tc-link-rendered.png Even though the rendered attribute is set to false, the tc:link is not fully hidden, i.e. it still uses up some space (a few pixels) . This creates additional empty space, which gets more and more apparent, the more hidden links you have. Example code: tc:panel f:facet name=layout tc:gridLayout rows=fixed;fixed;fixed;fixed;fixed;fixed;fixed;*/ /f:facet tc:label value=tc:link rendered/ tc:link label=Test 1 rendered=false / tc:link label=Test 2 rendered=false / tc:link label=Test 3 rendered=false / tc:link label=Test 4 rendered=true / tc:link label=Test 5 rendered=false / tc:link label=Test 6 rendered=false / tc:link label=Test 7 rendered=true / tc:link label=Test 8 rendered=true / /tc:panel Expected result: There should be as much space between the tc:label and the first visible tc:link, and also between tc:link 4 and 7, as there is between tc:link 7 and 8. Actual result: There is a big gap between the tc:label and the first visible tc:link, and also between tc:link 4 and 7. Please also see the attached image. Greetings, dom -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
