[jira] [Commented] (TRINIDAD-2026) memory leak in skinstyleprovider
[ https://issues.apache.org/jira/browse/TRINIDAD-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020357#comment-13020357 ] Jeanne Waldman commented on TRINIDAD-2026: -- We voted via email and the consensus is: org.apache.myfaces.trinidad.skin.MAX_SKINS_CACHED memory leak in skinstyleprovider Key: TRINIDAD-2026 URL: https://issues.apache.org/jira/browse/TRINIDAD-2026 Project: MyFaces Trinidad Issue Type: Improvement Reporter: Jeanne Waldman Attachments: LRUCache.patch There is no limit to the size of the providers cache in SkinStyleProvider.java. Every time we ask for a new skin, we add to the provider cache. A skin has StyleSheetDocument and StyleSheetDocument has StyleSheetNodes. If we remove a skin from the cache, we will need to clear out its _document, which in turn will clear out the StyleSheetNodes. StyleSheetNodes are the parsed representation of the skin css file. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2026) memory leak in skinstyleprovider
[ https://issues.apache.org/jira/browse/TRINIDAD-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019444#comment-13019444 ] Jeanne Waldman commented on TRINIDAD-2026: -- initial patch. Need to discuss the (1) default size and (2) the web.xml parameter name. Let's say one skin takes 1M of SkinStyleProvider. What should the default size (number of skins in the LRUCache) be? memory leak in skinstyleprovider Key: TRINIDAD-2026 URL: https://issues.apache.org/jira/browse/TRINIDAD-2026 Project: MyFaces Trinidad Issue Type: Improvement Reporter: Jeanne Waldman Attachments: LRUCache.patch There is no limit to the size of the providers cache in SkinStyleProvider.java. Every time we ask for a new skin, we add to the provider cache. A skin has StyleSheetDocument and StyleSheetDocument has StyleSheetNodes. If we remove a skin from the cache, we will need to clear out its _document, which in turn will clear out the StyleSheetNodes. StyleSheetNodes are the parsed representation of the skin css file. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2026) memory leak in skinstyleprovider
[ https://issues.apache.org/jira/browse/TRINIDAD-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019448#comment-13019448 ] Jeanne Waldman commented on TRINIDAD-2026: -- This patch does not clear out _document off the Skin. SkinFactory#_FACTORIES is holding on to StyleSheetNodes. We register all skins with the SkinFactory. Once a skin has been requested by the user, we parse the stylesheet and store the stylesheetnodes with the skin. This is TRINIDAD-2087 memory leak in skinstyleprovider Key: TRINIDAD-2026 URL: https://issues.apache.org/jira/browse/TRINIDAD-2026 Project: MyFaces Trinidad Issue Type: Improvement Reporter: Jeanne Waldman Attachments: LRUCache.patch There is no limit to the size of the providers cache in SkinStyleProvider.java. Every time we ask for a new skin, we add to the provider cache. A skin has StyleSheetDocument and StyleSheetDocument has StyleSheetNodes. If we remove a skin from the cache, we will need to clear out its _document, which in turn will clear out the StyleSheetNodes. StyleSheetNodes are the parsed representation of the skin css file. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2026) memory leak in skinstyleprovider
[ https://issues.apache.org/jira/browse/TRINIDAD-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019526#comment-13019526 ] Jeanne Waldman commented on TRINIDAD-2026: -- I discussed this with our performance expert, and we decided to limit it to around 20M. A complex skin for many components (like adf faces's skins) will take about 1M per skin, so the default size will be 20. This leaves the decision for what should the web.xml parameter be called? ideas: org.apache.myfaces.trinidad.skin.NUMBER_OF_SKINS_CACHE_SIZE org.apache.myfaces.trinidad.skin.SKIN_STYLE_PROVIDER_CACHE_SIZE org.apache.myfaces.trinidad.skin.SKIN_STYLE_PROVIDER_LRU_CACHE_SIZE in the patch it is org.apache.myfaces.trinidad.skin.SKIN_STYLE_PROVIDER_CACHE_SIZE memory leak in skinstyleprovider Key: TRINIDAD-2026 URL: https://issues.apache.org/jira/browse/TRINIDAD-2026 Project: MyFaces Trinidad Issue Type: Improvement Reporter: Jeanne Waldman Attachments: LRUCache.patch There is no limit to the size of the providers cache in SkinStyleProvider.java. Every time we ask for a new skin, we add to the provider cache. A skin has StyleSheetDocument and StyleSheetDocument has StyleSheetNodes. If we remove a skin from the cache, we will need to clear out its _document, which in turn will clear out the StyleSheetNodes. StyleSheetNodes are the parsed representation of the skin css file. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2026) memory leak in skinstyleprovider
[ https://issues.apache.org/jira/browse/TRINIDAD-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019544#comment-13019544 ] Scott O'Bryan commented on TRINIDAD-2026: - I like SKIN_STYLE_PROVIDER_CACHE_SIZE memory leak in skinstyleprovider Key: TRINIDAD-2026 URL: https://issues.apache.org/jira/browse/TRINIDAD-2026 Project: MyFaces Trinidad Issue Type: Improvement Reporter: Jeanne Waldman Attachments: LRUCache.patch There is no limit to the size of the providers cache in SkinStyleProvider.java. Every time we ask for a new skin, we add to the provider cache. A skin has StyleSheetDocument and StyleSheetDocument has StyleSheetNodes. If we remove a skin from the cache, we will need to clear out its _document, which in turn will clear out the StyleSheetNodes. StyleSheetNodes are the parsed representation of the skin css file. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2026) memory leak in skinstyleprovider
[ https://issues.apache.org/jira/browse/TRINIDAD-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019566#comment-13019566 ] Prakash Udupa commented on TRINIDAD-2026: - I like what Blake proposed in his review email: 'org.apache.myfaces.trinidad.skin.MAX_CACHED_SKINS'. memory leak in skinstyleprovider Key: TRINIDAD-2026 URL: https://issues.apache.org/jira/browse/TRINIDAD-2026 Project: MyFaces Trinidad Issue Type: Improvement Reporter: Jeanne Waldman Attachments: LRUCache.patch There is no limit to the size of the providers cache in SkinStyleProvider.java. Every time we ask for a new skin, we add to the provider cache. A skin has StyleSheetDocument and StyleSheetDocument has StyleSheetNodes. If we remove a skin from the cache, we will need to clear out its _document, which in turn will clear out the StyleSheetNodes. StyleSheetNodes are the parsed representation of the skin css file. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
