[jira] Commented: (MYFACES-1561) Validators, Converters are not recognized
[ https://issues.apache.org/jira/browse/MYFACES-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484751 ] Christoph Ebner commented on MYFACES-1561: -- I created the patch for UIComponentClassicTagBase now as martin suggested . i realized, that while reverting the code-formatters changes, i must have also undone the changes i made manually. anyhow, the new patch (V2) should definitely work! regards, christoph > Validators, Converters are not recognized > - > > Key: MYFACES-1561 > URL: https://issues.apache.org/jira/browse/MYFACES-1561 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-252 >Affects Versions: 1.2.0-SNAPSHOT > Environment: Tomcat 6.0.10 >Reporter: Cagatay Civici > Assigned To: Christoph Ebner > Attachments: ConverterTag.java, ConverterTag.patch, > UIComponentClassicTagBase.java, UIComponentClassicTagBase.patch, > UIComponentClassicTagBase_V2.patch > > > For a component like; > > > > > Both validators and converters specified for the input text are ignored. > UIInput getValidators.length returns 0 and getConverter is always null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1561) Validators, Converters are not recognized
[ https://issues.apache.org/jira/browse/MYFACES-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484733 ] Martin Marinschek commented on MYFACES-1561: Hi Christoph, you should make sure that you don't create patches which are splattered with formatting changes - remember your changes first, than do an svn-revert, then do the changes on a clean file from the repository. @Dennis: I think the difference is this line: UIComponentClassicTagBase componentTag = UIComponentClassicTagBase.getParentUIComponentClassicTagBase(pageContext); regards, Martin > Validators, Converters are not recognized > - > > Key: MYFACES-1561 > URL: https://issues.apache.org/jira/browse/MYFACES-1561 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-252 >Affects Versions: 1.2.0-SNAPSHOT > Environment: Tomcat 6.0.10 >Reporter: Cagatay Civici > Assigned To: Christoph Ebner > Attachments: ConverterTag.java, ConverterTag.patch, > UIComponentClassicTagBase.java, UIComponentClassicTagBase.patch > > > For a component like; > > > > > Both validators and converters specified for the input text are ignored. > UIInput getValidators.length returns 0 and getConverter is always null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1561) Validators, Converters are not recognized
[ https://issues.apache.org/jira/browse/MYFACES-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484648 ] Dennis Byrne commented on MYFACES-1561: --- Hi Christoph, I appreciate your interest here but can you please look at the patch files? It looks like a formatter was run on them and not much else. The UIComponentClassicTagBase patch does have one null check in it. Please advise > Validators, Converters are not recognized > - > > Key: MYFACES-1561 > URL: https://issues.apache.org/jira/browse/MYFACES-1561 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-252 >Affects Versions: 1.2.0-SNAPSHOT > Environment: Tomcat 6.0.10 >Reporter: Cagatay Civici > Assigned To: Christoph Ebner > Attachments: ConverterTag.java, ConverterTag.patch, > UIComponentClassicTagBase.java, UIComponentClassicTagBase.patch > > > For a component like; > > > > > Both validators and converters specified for the input text are ignored. > UIInput getValidators.length returns 0 and getConverter is always null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1561) Validators, Converters are not recognized
[ https://issues.apache.org/jira/browse/MYFACES-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484606 ] Christoph Ebner commented on MYFACES-1561: -- Sorry, yes they were fixes. I added them as patches now. > Validators, Converters are not recognized > - > > Key: MYFACES-1561 > URL: https://issues.apache.org/jira/browse/MYFACES-1561 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-252 >Affects Versions: 1.2.0-SNAPSHOT > Environment: Tomcat 6.0.10 >Reporter: Cagatay Civici > Assigned To: Christoph Ebner > Attachments: ConverterTag.java, ConverterTag.patch, > UIComponentClassicTagBase.java, UIComponentClassicTagBase.patch > > > For a component like; > > > > > Both validators and converters specified for the input text are ignored. > UIInput getValidators.length returns 0 and getConverter is always null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-1561) Validators, Converters are not recognized
[ https://issues.apache.org/jira/browse/MYFACES-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484271 ] Dennis Byrne commented on MYFACES-1561: --- Christoph, are the two attached files fixes? If so, please do us a favor and submit this in subversion patch form. Thanks. > Validators, Converters are not recognized > - > > Key: MYFACES-1561 > URL: https://issues.apache.org/jira/browse/MYFACES-1561 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-252 >Affects Versions: 1.2.0-SNAPSHOT > Environment: Tomcat 6.0.10 >Reporter: Cagatay Civici > Assigned To: Christoph Ebner > Attachments: ConverterTag.java, UIComponentClassicTagBase.java > > > For a component like; > > > > > Both validators and converters specified for the input text are ignored. > UIInput getValidators.length returns 0 and getConverter is always null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.